- Nov 19, 2022
-
-
Nikita Hovratov authored
Resolves: #98763 Releases: main Change-Id: I1e254429777594b5035c24d46f7ca5cb5ea3a219 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76697 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98760 Releases: main Change-Id: Ib497b35c6201d2859cfb4865f641fa4b60d1fcc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76696 Tested-by:
-
Nikita Hovratov authored
Resolves: #98758 Releases: main Change-Id: I777732e76c1182d6453aea52221054cc31d0f833 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76694 Tested-by:
-
Nikita Hovratov authored
Resolves: #98759 Releases: main Change-Id: I907e7f2d4958901205f6d9af517979aa61c5b9bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76695 Tested-by:
-
- Nov 18, 2022
-
-
Benjamin Kott authored
To increase the reusability of the multi-record-selecton, we are removing the limitation to table elements. This enables us to use it in more places in the backend. Resolves: #99129 Releases: main Change-Id: I961263c34c0a60b117c711cc94b55c51d73a3081 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76664 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Klee authored
The FAL-related Extbase models are documented in the "TYPO3 Explained" documentation, and they are the recommended way to use FAL in an Extbase context. So the following classes are not marked as `@internal` anymore in order to not send mixed signals to extension developers: - TYPO3\CMS\Extbase\Domain\Model\File - TYPO3\CMS\Extbase\Domain\Model\FileReference - TYPO3\CMS\Extbase\Domain\Model\Folder There is no point in forcing extension authors to re-implement those classes (and duplicating the code from the Core) when the Core implementation is stable now and has proven to work fine. Some history for what has happened: Those classes started out marked as experimental (when they were indeed still experimental). Then, in a cleanup bulk change in 3888dae8f3f71c3f5e1db1c00bcbfe7d0d8fed2e5966e6533c9353b6d7485f32, the classes were converted to use the `@internal` annotation, even though at least the three FAL Extbase models should have been made public API instead by that time. This is where the usage of the FAL models is documented in "TYPO3 Explained": https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Fal/UsingFal/Frontend.html Resolves: #99126 Releases: main, 11.5 Change-Id: I2935fdb989569c7fc4088975af0ba1e5206df6d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76670 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Christian Kuhn authored
Remove a series of property and param annotations specified by signatures already. Resolves: #99124 Releases: main Change-Id: I18d3aa2d798c71a96ccd8c47f71c276172091401 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76668 Tested-by:
-
- Nov 17, 2022
-
-
linawolf authored
Resolves: #99083 Releases: main Change-Id: I8e84db2ca9afdb2dc335fc3b89902f015aec2f87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76596 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
linawolf authored
Changelog entries can be linked even if the file is renamed or moved. In the future this enables us to get rid of different link syntax and only use the most well known :ref:`deprecation-12345` syntax. Resolves: #96329 Releases: main Change-Id: I3c1c6c48e3a2d381974752f1c837a04e59036ffd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76667 Tested-by:
-
Torben Hansen authored
Note, that the combination of shouldBeCalled and shouldNotBeCalled for the `quoteIdentifier` function in `QueryBuilderTest` has been replaced with the `never` expectation only, since the tests only test, if the star placeholder is not quoted. Also 2 new mock classes have been introduced to cover the tests in `AbstractRestrictionContainerTest`, where the mock object must implement 2 interfaces, which is not mockable. Resolves: #98792 Resolves: #98793 Resolves: #98794 Resolves: #98795 Resolves: #98796 Resolves: #98797 Resolves: #98798 Resolves: #98799 Resolves: #98800 Resolves: #98801 Resolves: #98802 Resolves: #98803 Resolves: #98804 Releases: main Change-Id: I691c69f201e39cd8d6d580cbbb86fad4cb032c64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76666 Tested-by:
-
Tomas Norre Mikkelsen authored
With PHP 8.1 the CommandUtility::getCommand() results in an error: Typed static property TYPO3\CMS\Core\Utility\CommandUtility::$paths must not be accessed before initialization This patch is to prevent this from happening Resolves: #98950 Releases: main Change-Id: I9fa88c65f25eebb7d2b2f989b875cb7bd85e60f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76551 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Ingo Fabbri authored
With `fallbackType` set to strict, only translated content is rendered. In AbstractMenuContentObject->sectionIndex content is fetched and overlayed. Once there is an element untranslated, the record overlay will return a $row = `null`. To mitigate, move all left over access to $row inside the guarded if-block. Resolves: #98043 Releases: main, 11.5 Change-Id: If4baf0fb88292cb8c6814539cf7efa610ae850f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75318 Tested-by:
-
Oliver Klee authored
Resolves: #99111 Releases: main Change-Id: I16550b5d6ed40a9abe13db5ff247297898a3890a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76657 Tested-by:
-
Oliver Klee authored
Passing no action name is a perfectly fine use case as this allows to conveniently redirect from a controller action to any page. Making this explicit in the type annotations allows extension authors to use this pattern without type checkers like PHPStan creating a warnings about this. Resolves: #99110 Releases: main, 11.5 Change-Id: I12cded81cbe20f7f2f626cf71ab92532d9037ee9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76654 Tested-by:
-
Christian Kuhn authored
When the Site construct has been added to TYPO3 in v9, the setup together with PseudoSites was pretty complex. This has been simplified meanwhile and the resolved site is usually added to the backend request as attribute. Except in cases where GET / POST param "id" is misused. This is the case in filelist module. The patch changes the backend related SiteResolver middleware to *always* add a site attribute to the request, backend controllers can now rely on it to be set, even if its just a NullSite. Resolves: #99121 Related: #86153 Releases: main Change-Id: I63ea9ed1b5bca5db298f7a3bf000fcb4f777f627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76665 Tested-by:
-
Christian Kuhn authored
There are a couple of places in the core care that parse a TypoScript a-like syntax. The patch switches them to the new TypoScript parser by adding a factory class that is able to parse single string snippets. Resolves: #99114 Related: #97816 Releases: main Change-Id: I2292e90bbdd7ea16ad48b4b7811f9935f4a51196 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76659 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Benjamin Kott authored
Reduce color overwrites and streamline active styling for table rows. Resolves: #99117 Releases: main Change-Id: Ia6d0ac6415346ac049e176d0f3a3c30d0bf9b7a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76661 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Matthias Vogel authored
Releases: main, 11.5 Resolves: #99115 Change-Id: I7860824c5377896f94f2ee34b281bf69bae251a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76658 Reviewed-by:
-
Oliver Klee authored
Extbase controllers that call a never-returning method do not need a return statement after that call in order to avoid calling the rest of the action method. The new annotations ensure that PHPStan becomes aware of this control flow. Resolves: #99109 Releases: main, 11.5 Change-Id: I9b9d308440966c71051fe993abd31f23b13c82e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76652 Tested-by:
-
Christian Kuhn authored
getPagesTSconfigWorksWithoutInitializedBackendUser() does nothing insanely useful and is more a burden than a helper when the implementation of the test subject is changed. Resolves: #99112 Releases: main Change-Id: I7377c17283fcfe641bb46356fd5cd1e91b92552d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76656 Tested-by:
-
Andreas Fernandez authored
In TYPO3 v8, a "rebounce" protection was added to deny overscrolling the document on iOS devices (aka "rubber band effect"). This caused an issue in #98348 where the shortcut menu opened to the wrong side and the rubber band fix got partially reverted, breaking modals where the content is intended to be scrollable. Also, the scaffold is "broken" on Apple devices as `100vh` is treated as "100vh if the address bar is shrunk", leading to a larger and thus scrollable scaffold when using `overscroll-behavior: none` [1], which would've been the preferred solution to solve the scrolling issue. The solution for the scrollable scaffold are dynamic viewport units [2], but those are not supported in all browsers, yet, and also revert `overscroll-behavior` (tested with iPadOS 16.1). To have the original issue fixed somehow, a workaround now adds the CSS class `with-overflow` to the `body` tag to all iframes rendered in modals. [1] https://caniuse.com/css-overscroll-behavior [2] https://caniuse.com/viewport-unit-variants Resolves: #98710 Related: #98348 Releases: main Change-Id: I13159cb1894aa76f81a91b8b80863a9dcfbc1970 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76236 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
Stefan Bürk authored
RootlineUtility uses a multi-staged cacheing logic. This contains the use of a dedicated rootline-cache, but also two static class internal caches. Static property caches are a horrable nightmare when it comes to keep proper clean state between test executions, beside it's a not really needed state on a non-static class. This change aims to replace the static property caches in RootlineUtility with the core runtime cache. Thus making the static properties obsolete, but keeping it until testing-framework can deal with the absence of the static properties. Remove them! `RootlineUtility::purgeCaches()` calls are replaced now with core runtime cache flush calls using tags to avoid flushing other unrelated runtime cache entries. This makes this method obsolete. This method was declared @internal, eliminate it! Additionally, default `$rootlineField` merging with the `$GLOBALS['TYPO3_CONF_VARS']['FE']['addRootLineFields']` is moved from RootlineUtility constructor to the only method using it, namely `getRecordArray`. In the same we changed it from static to non-static, as there is no need anymore for having it static. "typo3/testing-framework" has been made aware of these changes and deals with absent of these properties and method, but keep doing the guarding steps if they are still exists. See: https://github.com/TYPO3/testing-framework/pull/423 > composer u typo3/testing-framework Resolves: #99100 Releases: main Change-Id: I5fdcabd1c3727f020abc7d8bdbcf1f0276b715a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76637 Tested-by:
-
- Nov 16, 2022
-
-
Benni Mack authored
This change updates some comments for better understanding TYPO3-internal system languages vs. locales, and makes the class strict. Also the type annotations are more specific now, and an additional type check has been introduced. Resolves: #99108 Releases: main Change-Id: I9ea61bed9770c9b5a13bd7cdbb1da8e889905dca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76644 Tested-by:
-
Stefan Bürk authored
Implementing class internal caches has been done in the past, which however came with a lot of headaches. Mainly in tests it's a epic quest to properly clear the state between test runs, but it's not a good design at all. Some work has been already done to make static class `\TYPO3\CMS\Core\FormProtection\FormProtectionFactory` injectable through the DI container, which moved some parts from static to the instance part. This allows us to transform methods from static to non-static. This change injects the runtime cache, if the class is instanciated through the DI. Thus the internal static property cache for instances is removed. Tests are adjusted. TestCases testing deprecated method are moved to the UnitDeprecated to avoid failing tests. Resolves: #99098 Related: #98696 Related: #98627 Releases: main Change-Id: Ib92bb9f73f3b1bbb4995ef01c53ca973588528bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76634 Tested-by:
-
Andreas Fernandez authored
The file backend.js contained some basic preparations for the backend context that are partially not required anymore. The remaining settings are converted to a global assignment set in BackendController. The `window.name` property is now hard-coded to be `typo3-backend` for use with the EXT:adminpanel, which requires some changes in acceptance tests as `window.name` had an empty value before. `window.opener` is nulled, otherwise, this might cause issues with inter-frame communication if the backend was e.g. opened via a link in an email. With the remaining assigned being migrated, backend.js serves no purpose anymore and is dropped now. Resolves: #99101 Releases: main Change-Id: I1b92184c1e5063f7a494c62060adfb5b67a2878e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76607 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99106 Releases: main, 11.5 Change-Id: Iabddf0b2f1c98db6e3e07f26162257f696d6fd9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76642 Tested-by:
-
Torben Hansen authored
Note, that the argument usage in callback return functions had to be adjusted. Also, mocking of the `quote` function for sqlite tests had to be adapted to match the actual amount of consecutive calls. Resolves: #98805 Releases: main Change-Id: I95e4fb1941292cff7dcf6f4616c2eb768e17c43d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76641 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99107 Releases: main, 11.5 Change-Id: If5e9d1acf81bf2913405e18cc38f2a7ad5ee62cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76643 Reviewed-by:
-
Andreas Fernandez authored
Multi-step wizards may contain a lot of different steps (e.g. in localization or form management) and accidentally closing the wizard by clicking the backdrop may lead to frustration. To prevent this issue, the backdrop of such wizards is now static. Resolves: #99102 Releases: main Change-Id: I7e7adf6a8e30cc067fbadd73016cf01ec9bdf4d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76639 Tested-by:
-
Benjamin Kott authored
The module menu button bar now can display dropdowns. This enables new interface interactions, like switching the current view from list to tiles or group actions like clipboard and thumbnail visibility. It will help declutter views and help the user to see more information at a glance. Each dropdown consists of different items ranging from headlines to items links that can display the current status. The button will automaticly change the icon representation to the icon of the the first active radio icon in the dropdown. It is now implemented in the File List module to switch between Thumbnails and enable Actions like Clipboard Resolves: #99093 Releases: main Change-Id: I8c0498716d82c16e5b15bbe117fccd772d13a655 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76602 Tested-by:
-
Andreas Fernandez authored
The Modal API is now able to render a static backdrop to avoid closing the modal when clicking it which may come in handy in case closing the modal would result in a negative user experience, e.g. in the image cropper. The new boolean configuration option `staticBackdrop` controls whether a static backdrop should be rendered or not, defaulting to `false`. The trigger class "t3js-modal-trigger" also supports the new option by setting corresponding data attribute. Resolves: #99092 Releases: main Change-Id: I0e1c7753944b41d5266aa6232d1fa838752f95b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76605 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Stefan Bürk authored
Some changelog files containing invalid Sphinx syntax, thus adding warnings during documentation build. This change adjusts some changelog files to avoid these warnings. * use correct link target syntax * ensure correct usage of code blocks Resolves: #99099 Releases: main Change-Id: Ib883ed6cb94bad98f5eb0d893d008728a3e1dc2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76636 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
- Nov 15, 2022
-
-
Oliver Hader authored
* actually use `array_filter` internally * allow using `array_filter` modes `ARRAY_FILTER_USE_KEY` and `ARRAY_FILTER_USE_BOTH` Resolves: #99071 Releases: main, 11.5 Change-Id: I1b95ae0a7551250125a9eeabbd0ee7e66e25a6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76571 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Christian Kuhn authored
We will soon have additional TypoScript TreeBuilder classes, for instance one related to TsConfig. Rename the Frontend TypoScript related TreeBuilder to SysTemplateTreeBuilder to improve namings. Resolves: #99096 Related: #97816 Releases: main Change-Id: I32dbd8aae87614d0a2a7d6aaa21e0f71059242a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76611 Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
Chris Müller authored
Resolves: #99085 Releases: main, 11.5 Change-Id: Ie3b337b93f43fb2c41d76427f29d793b57e9232b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76598 Tested-by:
-
Chris Müller authored
Resolves: #99037 Releases: main, 11.5 Change-Id: I86cf8b64c198d1707dc3c5f385c6ee19ffa5960c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76581 Tested-by:
-
Christian Kuhn authored
Minor class modification to make the code more dense, more strict and reduce duplication. Resolves: #99094 Releases: main Change-Id: Iac3e7926dd16351ae0e0e7c45dfd099aa2eb61b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76608 Reviewed-by:
-
Christian Kuhn authored
Create a functional test form the rather heavily mocking unit test, and streamline. Resolves: #98773 Releases: main Change-Id: I9f2275394a2f644e8e707dc3218868dbbea63e06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76609 Tested-by:
-
Christian Kuhn authored
The default configuration of new typoscript cache has been accidently added twice: In ext:frontend ext_localconf.php and in DefaultConfiguration.php. Remove the one from ext:frontend. Resolves: #99095 Related: #97816 Releases: main Change-Id: I94eff13d894b9e22bc61b61fb29546dcfd695d96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76610 Tested-by:
-
Benjamin Kott authored
The context menu JavaScript API was adapted to also support opening the menu through the "contextmenu" event type (right click) only. Configuration for the context menu was streamlined and now reflects its purpose. The trigger can now be set to "click" or "contextmenu". Before: class="t3js-contextmenutrigger" data-table="pages" data-uid="10" data-context="tree" After: data-contextmenu-trigger="click" data-contextmenu-table="pages" data-contextmenu-uid="10" data-contextmenu-context="tree" New options: data-contextmenu-trigger: click: Opens the contextmenu click and contextmenu contextmenu: Opens the contextmenu only on contextmenu Examples: <a href="#" data-contextmenu-trigger="click" data-contextmenu-table="pages" data-contextmenu-uid="10" > Click and Contextmenu </a> <a href="#" data-contextmenu-trigger="contextmenu" data-contextmenu-table="pages" data-contextmenu-uid="10" > Contextmenu only </a> Legacy configuration with `.t3js-contextmenutrigger` is still supported to avoid migration issues, but is now considered deprecated and will be removed with TYPO3 v13. Resolves: #99084 Releases: main Change-Id: I1a8429b2964f0372b3162994f49f4c1141dffc86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76595 Tested-by:
-
