- Jul 25, 2024
-
-
Christian Kuhn authored
FluidTemplateContentObject has some magic to adapt the given request *if* the request is an extbase request already. This code is relatively obviously obsolete: Only extbase bootstrap creates extbase requests (and actually, the code *below* the lines changed by this patch in FluidTemplateContentObject, those will see a separate deprecation or removal patch, soon). So, when FluidTemplateContentObject is called for whatever reason with an extbase request, it has been created by a proper extbase bootstrap call, wich created a "correct" extbase request already. There is no need to tamper with this in FluidTemplateContentObject again. Note this wasn't the case with earlier TYPO3 versions where extbase requests were created within StandaloneView, a misuse we got rid off in v12. The patch removes these extbase request manipulations from FluidTemplateContentObject. Resolves: #104473 Related: #104472 Related: #104471 Related: #98377 Releases: main Change-Id: Id4fc202f140fe270e35259251ed052752c2c6ed0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85348 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
RenderingContext is *the* state object in fluid. Fluid was always bound to extbase. There was quite some magic between the two: For instance, when extbase calls action "myDetailAction" on "ListController", fluid looks for template "List/MyDetail.html". Fluid derived this from the old extbase request - A request implementation that existed before PSR-7 handling has been introduced to the core. With TYPO3 v11, the extbase request has been turned into a decorator of the PSR-7 object, and fluid has been changed to deal with a standard PSR-7 request. But lots of the fluid related magic tailored to the extbase request remained. Some blockers to relax this have been removed already, most notably the extbase ControllerContext vanished, and the StandaloneView no longer creates an extbase request in its constructor. We can now go a step further: The RenderingContext creates new requests when setControllerAction() and setControllerName(), even cross-triggered when setRequest() is called. This is insane: A rendering engine must never manipulate request itself, but must expect a proper request to hand over by the application. $controllerName and $controllerAction are still important within fluid - it still derives the template files from it if no direct template file is given. But there is no reason to also change the request. All this functionality is bound to the extbase request only. Extbase bootstrap *does* create a proper extbase request already. It can just be hand over as is. setControllerAction() and setControllerName() can be called by extbase abstract ActionController to init fluid properly, reading the values from extbase request itself. Magic within RenderingContext is no longer needed. Resolves: #104471 Related: #96183 Related: #98377 Releases: main Change-Id: I2090230cc37870c0f2a7107ca2af6370ab786175 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85346 Reviewed-by:
-
Markus Klein authored
* ext:form is FE an extbase plugin and operates with an extbase request created by extbase bootstrap (or by FluidTemplateContentObject, but that's a different story). * ConfirmationFinisher has option 'contentElementUid', which - when set - creates a ContentObjectRenderer to render specific content elements. * ContentObjectRenderer then often renders this content element using FluidTemplateContentObject. Various code within Fluid rendering then applies magic to create new requests, *if* an extbase request is given. This can lead to broken template resolving when rendering in FluidTemplateContentObject. This entire thing is quite messy. We're taking measures to resolve the underlying flaws in v13. To fix the situation in v12, the idea is like that: When ConfirmationFinisher calls ContentObjectRenderer and hands over its request, it should "free" that request from its own extbase context to not trigger pollution by code that does things if an extbase request is given. Note this was not an issue in v11 since only v12 started handing over the extbase request to ContentObjectRenderer, in v11 it was indirectly pulled from $GLOBALS['TYPO3_REQUEST'] within ContentObjectRenderer, which is the "original" request before it is turned into an extbase request by extbase plugin bootstrap. Resolves: #104462 Related: #100623 Related: #104472 Related: #104471 Related: #104473 Releases: main, 12.4 Change-Id: Id53bc9f159dc2575a8bedb63cd7e7a039864f92b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85336 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Anja Leichsenring authored
The was a wrong accumulation in place that made the checker report success while the output clearly stated exceptionCodeChecker found issues. Accumulation and final status report were fixed to properly report the checker failing in this case. Resolves: #104474 Releases: main Change-Id: I6c620a3509685797e2baf7f20da96f270c833455 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85350 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Christian Kuhn authored
phpstan can be very memory hungry. Option --verbose adds a line about 'peak memory' usage to the output. Add this to get a better feeling of the memory usage. Resolves: #104475 Releases: main, 12.4, 11.5 Change-Id: I3fdaf7ddee7e003e7a8e75a508dd69161c804c8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85351 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Jul 24, 2024
-
-
Martin Adler authored
This patch seeks to further eliminate the usage of 'GU:makeInstance' for stateless services in the styleguide's 'TcaDataGenerator'. Resolves: #104458 Releases: main Change-Id: Ib227afffe40ccdf16b00adb1d357554226322637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85328 Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Jasmina Ließmann authored
This patch standardizes the appearance of the cards in the "Reports overview" view with those from the "About" module and the "Admin Tools" area. Since this was the last occurrence where a card was used directly as a link, the corresponding CSS settings are also removed. Resolves: #104465 Releases: main Change-Id: I17800d9125d5f59053e82022d7d2d90eb6b75b98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85340 Tested-by:
-
Jasmina Ließmann authored
The new markup for examples, previously introduced on the Avatar component page, has been rolled out to all example pages within the "Styleguide" backend module. The component pages, as well as the styles pages, are expanded to include more application examples and color scheme examples. In this context the CodeViewHelper has been split into three individual ViewHelpers to make functionalities clearer. Resolves: #104464 Related: #104371 Releases: main Change-Id: I581e60b06eb0e9494895917495c3214fc014d0b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85285 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
$request is hand around already. There is no reason to assign it to $this. Resolves: #104467 Releases: main Change-Id: I27ab48eaafaec3f78f98ff627034f19a8ad33fb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85342 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Georg Ringer authored
Resolves: #99197 Releases: main, 12.4 Change-Id: I9ac78c5a7ef29f0390dbe7d5dd0004472382eea8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76827 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Jasmina Ließmann authored
This patch ensures that all detail action views in the "Reports" backend module use a unique h1. In addition, the detail action view content now takes up the entire content width. Resolves: #104466 Releases: main Change-Id: I460c7c59af296785f32d5e9c4e6f5ec58e690a2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85341 Tested-by:
-
Jasmina Ließmann authored
The report table contains broken links that exist in the system depending on the configuration. The information about these broken links can be varied and the previous view already provided essential information. With this patch the view has been expanded and the UX has been improved. Information about the link text, (location) path in the page tree and the record field that contains the broken link have been moved to a modal so that the table only contains the relevant information and further information can be viewed in the modal. The new modal is divided into an area with information about the link properties and an area with extensive information about the record itself. Furthermore a column has been added to the table that shows the language of the record that contains the broken link. Previously, the record icon was simply the standard icon of the table, now the actual record type is taken into account as the icon. A sorting function has also been added to the table with which the columns can be sorted alphabetically in ascending/descending order. Resolves: #104323 Releases: main Change-Id: Id7279080c8f851c1b8cb7d45f4e0116fa6a1fc49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85088 Tested-by:
-
Hannes Lau authored
TYPO3 v12 added a new ViewInterface to ext:core that allows implementing *any* view as long as it sticks to this interface. This interface has been put into use for all backend modules, combined with a factory that allows to set custom stuff per module. Extbase however has not been touched: Extbase is still tailored towards ext:fluid and Fluid standalone. The patch changes this by adapting the Extbase related views towards ext:core ViewInterface. This allows implementing "own" views not depending on Fluid standalone. The patch has to hop through quite some loops to allow this: ext:core FluidViewAdapter is a class implemented in v12 that is a facade between core views and Fluid. Unfortunatly, extbase uses some "specialities" like "renderPartial()" from Fluid, which ext:core ViewInterface does not implement. We can not get rid of those within extbase any time soon. As such, FluidViewAdapter now implements all the nasty details that Fluid provides: FluidViewAdapter is now the main class between extbase and Fluid views - it implements both the Fluid view interface, plus ext:core ViewInterface. FluidViewAdapter in itself is rather simple: It only holds the Fluid view instance. Historically, many further operations were possible on Fluid view classes, those were only wrappers around RenderingContext, though. To keep backwards compatibility, FluidViewAdapter now re-implements all these methods, but deprecates them. In addition to ext:core ViewInterface, FluidViewAdapter will continue to implement getRenderingContext(), setRenderingContext() (probably), renderSection() and renderPartial(). All other methods that are wrappers around details of RenderingContext are marked @deprecatded. Systems that need to work with details of Fluid, now need to test for an instance of FluidViewAdapter to manipulate setRenderingContext if needed. This strategy will allow us to phase out ext:fluid StandaloneView and ext:fluid TemplateView with further patches, which will further simplify the layer towards Fluid standalone. Within Extabse, the main view interface is now ext:core ViewInterface, which free's the dependency to Fluid. JsonView is now the primary example for a view that has no relation to Fluid anymore. TYPO3 v14 can continue with hardening various type hints related to views, those have been marked accordingly. Note the handling related to ServerRequestInterface will see some additional patches in this area as well. Resolves: #101559 Related: #96730 Related: #104463 Releases: main Change-Id: I4be3e6be191b8bce599523a1055fc6136a86a879 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329 Tested-by:
Hannes Lau <office@hanneslau.de> Reviewed-by:
-
- Jul 23, 2024
-
-
Lina Wolf authored
So that they can be properly linked in api.typo3.org and IDEs. Releases: main, 12.4 Resolves: #104439 Change-Id: Id01abd68ec8f8238a70aa900a17fd33917ffd67e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85309 Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
-
Christian Kuhn authored
> composer req typo3fluid/fluid:^2.14.0 > composer req -d typo3/sysext/adminpanel --no-update typo3fluid/fluid:^2.14.0 > composer req -d typo3/sysext/core --no-update typo3fluid/fluid:^2.14.0 > composer req -d typo3/sysext/fluid --no-update typo3fluid/fluid:^2.14.0 > composer req -d typo3/sysext/redirects --no-update typo3fluid/fluid:^2.14.0 Notable changes: * Obsoletes VH overrideArgument() by allowing registerArgument() to override existing arguments without throwing an exception. * Fully b/w compatible changes to ViewInterface * New soft-deprecations in AbstractTemplateView Resolves: #104463 Releases: main Change-Id: I844bc31dc0ffa96ea337fcc207544b9cc45f4694 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85338 Tested-by:
-
Georg Ringer authored
Provide a new type of static routes `assets` to expose assets shipped by extensions. Resolves: #101472 Releases: main Change-Id: I46d5b8af795b1037c6a3e2554454df6a6e7174ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85268 Reviewed-by:
-
- Jul 22, 2024
-
-
Oliver Bartsch authored
In case content elements exist in the database, having a CType for which no TCA exists, e.g. because an extension providing this CType has been deactivated, no more UndefinedSchemaException, is thrown. This allows an editor to properly handle the situation as before. Note: Such elements are displayed with an "INVALID VALUE ("INVALID_CTYPE")" badge. Resolves: #104448 Releases: main Change-Id: I94cd9c42040274536730b020ae29bf9ff13bb3f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85322 Tested-by:
-
- Jul 21, 2024
-
-
Christian Kuhn authored
Fluid standalone AbstractTemplateView has method getTemplatePaths() which is just a wrapper around the same operation on RenderingContext. This method has been marked as deprecated in Fluid standalone 2.14, and will be removed in Fluid standalone v4. The patch avoids some last usages. Note this is a pre-patch to a bigger patch that will change view handling in extbase, which will come with proper deprecation notes. Resolves: #104446 Releases: main Change-Id: I495ceac71cd998550fb930b45d8f34513e7cce3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85318 Tested-by:
-
Christian Kuhn authored
There is some ancient when a DI method is called 'injectSettings': DI ignores this. There is a single use for Fluid views in extbase, which calls injectSettings if it exists manually. However no Fluid view ever implemented this method. It is removed. Also, the DI magic to not call 'injectSettings' is removed, injectSettings can now be used as casual inject* method. This is considered a bugfix (for main only): It is unexpected and undocumented this handling exists. Resolves: #104445 Releases: main Change-Id: I6eb527bea048dd856f618b4caadb7e17d4ce6ad3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85317 Reviewed-by:
-
- Jul 20, 2024
-
-
Christian Kuhn authored
Method registerTagAttribute() has been soft-deprecated with Fluid 2.12. The patch removed usages and documents details. Resolves: #104443 Related: #103560 Related: #104412 Releases: main Change-Id: Id1c0f6d801a2a4898afca6a24e541ee1b2a9a694 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85310 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Stephan Großberndt authored
The usages of `PasswordViewHelper` now render `required="required"` instead of `required="true"`. ViewHelpers that do not register "required" as an argument (e.g. `PasswordViewHelper`) pass any value since Fluid v2.12.0 (see https://github.com/TYPO3/Fluid/pull/859). ViewHelpers that register "required" as an argument (e.g. `TextfieldViewHelper`) interpret the specified value as a bool and if true always render `required="required"` and omit the attribute if false. Resolves: #104441 Related: #104436 Releases: main Change-Id: Id3bef65e36a488ab35ac367b1722e05bfa1ba106 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85311 Tested-by:
-
- Jul 19, 2024
-
-
Oliver Bartsch authored
Resolves: #104425 Releases: main Change-Id: I76dea6700d5d51a1283e6c13f84ff97dbb0bd386 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85287 Reviewed-by:
-
Garvin Hicking authored
An example colorPalette picker is utilized for the new field `tx_styleguide_elements_basic.color_palpreset`. By default all defined colors available to palettes are used as a fallback, so every colorpicker will receive these palettes now. `color_palpreset` has a limited palette to showcase both fallback and specific choice of colors. A custom page.tsconfig is added, independent from the Site Set file, to apply this to the backend. Resolves: #103994 Related: #101843 Related: #98294 Releases: main Change-Id: I18c06ddcd7938ea0b0088e3ee3b56e02a26ed3f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84521 Tested-by:
-
Sandra Erbel authored
Missing definition provided and wording corrected. Releases: main, 12.4 Resolves: #104429 Change-Id: I59bca54826557e7633ce837c73df6d38cda24742 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85294 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Stephan Großberndt authored
With Fluid v2.12.0 using `additionalAttributes` became obsolete in `TagBasedViewhelper` (see https://github.com/TYPO3/Fluid/pull/859). Resolves: #104436 Releases: main Change-Id: Iae48db75658bdb8b48da636c7145257629577460 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85304 Reviewed-by:
-
Stephan Großberndt authored
Disables spell checking in the changePassword form of EXT:felogin See issue #98492 for details. Resolves: #104437 Related: #98492 Related: #98504 Releases: main, 12.4 Change-Id: I4ec8056867ac55b00a542c1527f028c234a064c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85305 Tested-by:
-
Stephan Großberndt authored
Resolves: #104438 Releases: main, 12.4 Change-Id: I4ef127561e45d72c03beb9db08a2a081aa59ddca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85306 Tested-by:
-
Stephan Großberndt authored
This patch corrects the optional last step of the initial setup process "Create default backend user groups" if EXT:dashboard is not installed. This may be the case for a composer based installation. Instead of silently failing the step due to the missing column "be_groups.availableWidgets" this permission is not written to the database. Resolves: #104434 Releases: main Change-Id: I20216cb9032a36ad36a862289ba98082249b0a26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85300 Reviewed-by:
-
Stefan Bürk authored
Resolves: #104435 Releases: main, 12.4, 11.5 Change-Id: I5ff37f97f0d0a71420839c4d2b1bf8bde70afa7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85303 Tested-by:
-
Christian Kuhn authored
Tag based ViewHelpers no longer need to call registerUniversalTagAttributes() since Fluid 2.12. Add a 'deprecation.rst' related to this raise. Resolves: #104412 Related: #103560 Releases: main Change-Id: I5f038f047330406ef82e3df202ad67e1ed058e17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85276 Tested-by:
-
Oliver Bartsch authored
To prevent using the renderType for checking whether a column of SelectRelationFieldType is a single reference, we set the maxitems option to 1. This allows to keep existing functionality unmodified. Resolves: #104424 Releases: main Change-Id: I1190f6957e7351c79e23f2a313b3f4775ee130d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85286 Tested-by:
-
Stefan Bürk authored
This change adds the predefined GitLab CI/CD variable `CI_JOB_ID` value to the suffix, used for containerized network and container names, with the goal to increase uniqueness in CI runs. Additionally, the value is now displayed in execution and the container cleanup notes at least the network name further information source to investage unusually container shutdowns. [1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html Resolves: #103928 Releases: main, 12.4, 11.5 Change-Id: I6cf8dddefd2b45ed6f5c8cca8aa5521319cc8c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84417 Tested-by:
-
Oliver Hader authored
Fixes an array key warning in $backendUser->groupData['webmounts']. Resolves: #104430 Releases: main, 12.4, 11.5 Change-Id: I077c59c67067f6221288ca4a73589dcc9c69bd07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85296 Reviewed-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Martin Adler authored
'RecordData' is already a stateless service and partially injected using DI. The remaining cases could easily be refactored to eliminate these 'makeInstance' calls. Resolves: #104426 Releases: main Change-Id: I938259f22cc13839662fa903d6e9f7be72f1c558 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85289 Reviewed-by:
-
Garvin Hicking authored
The Changelog mistakenly referred to "PageRenderer::loadJavaScriptModules" (even though the example code itself was right). To avoid confusion of the method not being static, the notation is also changed from "::" to "->" to indicate a non-static class member method. Resolves: #104428 Releases: main, 12.4 Change-Id: I82827590ea2c852522b487986ff95159204b5b70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85290 Tested-by:
-
- Jul 18, 2024
-
-
Oliver Bartsch authored
All fields, defined in the sub schema should be added to the Record object, especially the record type value. Resolves: #104418 Releases: main Change-Id: I49c13fac0ee8c09cae31dcc733e2451135af2187 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85284 Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
$required defaults to 'false' and does not need to be set explicitly when there are no further non-default arguments. Resolves: #104411 Releases: main Change-Id: If8884ccce95481f0f239cace13fa24c60215ca5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85275 Reviewed-by:
-
Oliver Bartsch authored
This also removed a duplicated check for the element's type. Resolves: #104354 Releases: main Change-Id: Ied1cb75ad556efee5a942cb89c6a65f9a8290c19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85218 Reviewed-by:
-
Oliver Bartsch authored
TextPreviewRenderer and TextpicPreviewRenderer extend the StandardContentPreviewRenderer while not implementing any custom functionality and are therefore now removed. Resolves: #104417 Releases: main Change-Id: Ia99c3751405f038dbdc57b531650d7657e4a83fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85283 Reviewed-by:
-
Markus Klein authored
Referencing xmlns namespaces in Fluid using https://typo3.org/ns/... does not work. Fluid only searches for http://typo3.org/ns/. While this is not critical for the default "f" namespace, the core should serve as a good example. Resolves: #104416 Releases: main, 12.4 Change-Id: I698347c3cb6a2b89fd9b3de9dd24e5dabf373be0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85281 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
