- Jul 04, 2023
-
-
Andreas Nedbal authored
The hint when changing a slug previously was a combination of utility classes and with color changes in a recent Bootstrap version, it became barely readable. Resolves: #101222 Releases: main, 12.4 Change-Id: I594c995f23c99d81b0d5e2d619e63f811c36576a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79694 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Annett Jähnichen <mcmietz@web.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Manuel Glauser authored
Rendering image '<source>' elements using the IMAGE content object (layoutKey 'picture') no longer have the document root path prepended in the 'srcset' attribute. Resolves: #100867 Related: #95379 Releases: main, 12.4 Change-Id: Id49b0f9a41dd9760e25fc17386cae805f66083e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79030 Tested-by:
Ben Robinson <robinson2.ben@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Elias Häußler authored
The `PageErrorHandlerInterface` is often implemented in case a custom error handler is used in site configuration. Static code analysis may complain about missing iterable types in implementations. Thus, we now provide the iterable types to ease the implementation effort in TYPO3 projects. Resolves: #100004 Releases: main, 12.4 Change-Id: I9734ce09c091f6d0e6f68d19019e8d77d1ffc685 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77915 Reviewed-by:
Susanne Moog <look@susi.dev> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Tim Horstmann authored
Additionally switch $nextActive to boolean Resolves: #100995 Releases: main, 12.4 Change-Id: I0e41835f42753595480afb16182c446991157ec2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79258 Tested-by:
-
Daniel Siepmann authored
Some checks might return a message why images can't be generated. Those checks didn't return success which prevents processing by JavaScript, leading to endless "Loading" state within UI. All responses now properly return success = true in order to be processed by JavaScript. Resolves: #100893 Releases: main, 12.4 Change-Id: I720893a0b01a26a7b77bdcb16c02295eed3ae595 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79063 Tested-by:
-
Stefan Bürk authored
With #89091 pages with slugs containing trailing slash have been enabled to be resolved when requested with trailing slash in the request uri and have been a logical follow-up of #86055. In between an issue with language fallback chain have been found, which allowed that a valid translated page could be resolved with the default language slug even and reported as #88715 and #96010. These issues have been solved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75101 which partly broke the original implemented behaviour for pages with trailing slash slugs requested without a trailing slash. This change now ensures pages are resolved containing a trailing slash in their "slug" like "/my-page/subpage/" if requested without the trailing slash like "https://domain.tld/my-page/subpage". Additionally, tests are added to cover this case along with other possible cases. This should detect future regressions. The docblock return annotation for `PageRouter::matchRequest()` is changed to the correct returned value, removing ignore pattern for the phpstan baseline instead of increasing the counter. Note: This change ensures that a page can be resolved in any constellation with trailing slash in record slug/not in record slug and requested with trailing slash/not requested slug. In both cases, already working and the now fixed variant are serving both potential duplicate content - if no correct cannonical url is provided. Tackling the duplicate issue should be done in a dedicated change for both cases. Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100990 Related: #96010 Related: #88715 Related: #89091 Related: #86055 Releases: main, 12.4, 11.5 Change-Id: I9f26c4500e2f812e8727b4b565570fcc579bf3e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79249 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Torben Hansen authored
With #100255 it has been ensured, that the translate ViewHelper uses the site language locale. For backend context, the locale is resolved from `$GLOBALS['BE_USER']->user['lang']`. In case of the backend login or password reset form , the evaluated preferred browser language is however not set to the global `BE_USER` object, when no user is logged in. As a result, some labels in the fluid views are always rendered in the default language. This change sets the preferred browser language to the `BE_USER` object in the backend login controller and the reset password controller, when no backend user is logged in, so label translation is now consistent again. Resolves: #101166 Related: #100255 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: If3ba886c4e8be19990c45cc48c7001a128535f25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79524 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Georg Ringer authored
The deleted records should be sorted by the timestamp descending instead of by the uid ascending because in most cases one of the recently deleted records should be restored. In addition, a comparison is fixed as a drive-by change to have compatible types. Resolves: #100252 Releases: main, 12.4 Change-Id: I67ce8134ea498782b476381716559e92f9867059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78211 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Stefan Bürk authored
Creating redirects for `SysFolder` and `Spacer` on slug changes does not make sense as they are not reachable in the frontend. Updating child pages if they start with the orignal slug however is a wanted behaviour following the normal page type behaviour. Resolves: #99624 Releases: main, 12.4 Change-Id: I8c93c9ceb858c0e0c0eda32ae8f6c58af652b7e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79623 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Alexander Schnitzler authored
ObjectAccess::getGettablePropertyNames() has quite the history by now. It used to be quite simple, an is_callable() check for getters/hassers and issers of objects. That didn't account for methods with mandatory method arguments which was fixed by using reflection. Because runtime reflection is slow, the usage of cached reflection (ClassSchema) had been introduced. But, during that change, symfony/property-access had also been introduces, which contradicts the idea of performance gain because: - symfony/property-access also uses uncached reflection - symfony/property-access actually calls the accessors under test As both is undesirable, the usage of symfony/property-access has been removed again. Releases: main, 12.4, 11.5 Resolves: #101176 Change-Id: I2bc796ebeaf2f1357fd3154b711910c6f553f4e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79514 Reviewed-by:
-
Oliver Bartsch authored
The markup is adjusted to make the "parallel execution" checkbox in the scheduler module edit view working again. Additionally, the checkbox is only displayed for recuring tasks, because it's always set to FALSE for tasks with single execution. Resolves: #101146 Releases: main, 12.4 Change-Id: I0bc595683565ab099ca2a78f7a0aaf1480255a8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79621 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Guillaume Germain authored
Use array chunked query combined with direct value list to retrieve full data set in `DataMapProcessor` methods `fetchTranslationValues` and `fetchDependentElements`. Resolves: #99326 Releases: main, 12.4, 11.5 Change-Id: Iaf220014cd991002450779197169c5c32a3c7dbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77005 Tested-by:
-
Benni Mack authored
Historically, TYPO3 Core has had a custom page doktype "recycler" which was used as a "manual trash bin" so editors could park / move records to that location instead of deleting them. However, the concept of the actual "recycler" (where the GUI is in the system extension recycler) is to actually use the "soft-delete" feature and restore / undelete records based on the GUI. There is a huge advantage, as the records are kept on the actual Page ID instead of a custom recycler. In order to avoid confusion, the manual logic of pages.doktype=255 as a recycler to have editors move content manually in there, is removed. The TCA is adapted, and the constant PageRepository::DOKTYPE_RECYCLER is removed as well. People who want to use a recycler, can use the recycler system extension. An upgrade wizard moves pages of type "doktype 255" to a regular Backend User Section with a prefix "[RECYCLER] " in the page title. Resolves: #101137 Releases: main Change-Id: Ibd8a6bb788eeada0110390ca2cca411c61961c3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79472 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Nikita Hovratov authored
Since the swap to LinkResult, the ATagParams and some more attributes are cached independent of different configuration. This is now fixed by adding the following configuration options to the md5 hash: - TMENUITEM: ATagParams - TMENUITEM: additionalParams - TMENU: addParams - TMENU: target Note: Doing this weakens the usefulness of the runtime cache again (especially for old-school TypoScript based menus). Another option would be to add the attributes after the LinkResult generation (how it was done before), but this would bypass possible Event manipulation. Resolves: #100319 Related: #96486 Releases: main, 12.4 Change-Id: I8a0346b5b932f071f9498ddccd7ecceca39deed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79575 Tested-by:
Garvin Hicking <garvinh+typo3@gmail.com> Tested-by:
-
- Jul 03, 2023
-
-
Benni Mack authored
When a link href is empty or invalid, TYPO3 now does not crash anymore. Resolves: #100958 Releases: main, 12.4 Change-Id: I768d43b72a3abd55af06cd9750ac8a400bc41d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79462 Tested-by:
-
Benni Mack authored
This change also adds some basic tests for MediaViewHelper Resolves: #100929 Resolves: #99122 Releases: main, 12.4 Change-Id: Ie5d086efe605845f70f55e647c4edb87d03eba6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79615 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Benni Mack authored
This way, it works in CLI mode as well. Resolves: #100745 Releases: main, 12.4 Change-Id: Idc00323c012bd3c7f6816b6431ed91c44da50605 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79002 Tested-by:
-
Oliver Bartsch authored
Since #97330, a form engine elements label might not be represented by a <label> tag, but by using a <legend> tag. This patch now ensures that those elements are also correctly considered within form engine validation. Resolves: #101221 Related: #97330 Releases: main, 12.4 Change-Id: Iac4ef9b198bd7a7b8c75e53b83e45117be348c98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79619 Tested-by:
-
Oliver Bartsch authored
Resolves: #101194 Releases: main, 12.4, 11.5 Change-Id: I431e0af6b35d85aed0a3834c16b9f75c2923bfaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79620 Tested-by:
-
Andreas Fernandez authored
This change updates ckeditor5 to version 38.1. See [1] for detailed information. Executed commands: npm i --save \ @ckeditor/ckeditor5-alignment@^38.1.0 \ @ckeditor/ckeditor5-autoformat@^38.1.0 \ @ckeditor/ckeditor5-basic-styles@^38.1.0 \ @ckeditor/ckeditor5-block-quote@^38.1.0 \ @ckeditor/ckeditor5-clipboard@^38.1.0 \ @ckeditor/ckeditor5-code-block@^38.1.0 \ @ckeditor/ckeditor5-core@^38.1.0 \ @ckeditor/ckeditor5-dev-utils@^38.0.4 \ @ckeditor/ckeditor5-editor-classic@^38.1.0 \ @ckeditor/ckeditor5-engine@^38.1.0 \ @ckeditor/ckeditor5-essentials@^38.1.0 \ @ckeditor/ckeditor5-find-and-replace@^38.1.0 \ @ckeditor/ckeditor5-heading@^38.1.0 \ @ckeditor/ckeditor5-horizontal-line@^38.1.0 \ @ckeditor/ckeditor5-html-support@^38.1.0 \ @ckeditor/ckeditor5-indent@^38.1.0 \ @ckeditor/ckeditor5-link@^38.1.0 \ @ckeditor/ckeditor5-list@^38.1.0 \ @ckeditor/ckeditor5-paragraph@^38.1.0 \ @ckeditor/ckeditor5-paste-from-office@^38.1.0 \ @ckeditor/ckeditor5-remove-format@^38.1.0 \ @ckeditor/ckeditor5-source-editing@^38.1.0 \ @ckeditor/ckeditor5-special-characters@^38.1.0 \ @ckeditor/ckeditor5-style@^38.1.0 \ @ckeditor/ckeditor5-table@^38.1.0 \ @ckeditor/ckeditor5-theme-lark@^38.1.0 \ @ckeditor/ckeditor5-ui@^38.1.0 \ @ckeditor/ckeditor5-undo@^38.1.0 \ @ckeditor/ckeditor5-utils@^38.1.0 \ @ckeditor/ckeditor5-word-count@^38.1.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v38.1.0 Resolves: #101223 Releases: main, 12.4 Change-Id: I5653cc0fb217dfa9bb2301c5a985aca953fc4d87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79617 Reviewed-by: -
Andreas Fernandez authored
With the dismissal of jQuery and jQuery UI from the image manipulation component, the event handling for the trigger button ("Open Editor") got borked as the event state toggling previously done via `.off(...).on(...)` was replaced with using a `signal` as documented at [1]. The `AbortController` instance is only built when the modal has been fully shown, way after the event handling took place, breaking the module's global state. To solve this issue we removed the `AbortController` and its usages again. Also, `initializeTrigger()` now uses event delegation to register the event handler on the trigger buttons. As a drive-by fixes, the `active` state of the ratio buttons is now properly toggled, and the ratio title field is correctly updated by comparing with the scoped `ratioTitleWindow.HTMLElement` prototype. [1] https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#add_an_abortable_listener Resolves: #101150 Resolves: #101199 Related: #100948 Releases: main, 12.4 Change-Id: I021c74bb67976468ebdc5226263c6441796bd65b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79555 Reviewed-by:Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
Resolves: #100538 Releases: main, 12.4, 11.5 Change-Id: Ia0e37a39ed566938a9b9f947ad21949a9ab3b0bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79612 Tested-by:
-
Thomas Hohn authored
Removed the following public methods: * \TYPO3\CMS\Core\Site\Entity\SiteLanguage->getTwoLetterIsoCode * \TYPO3\CMS\Core\Site\Entity\SiteLanguage->getDirection Resolves: #101112 Related: #100963 Related: #99905 Related: #99908 Releases: main Change-Id: I15374e397a3fd3ebb2bede2d02d2f835104bcb0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79451 Tested-by:
-
Benni Mack authored
This change prevents a PHP warning in ContentObjectRenderer when working with "max" and "begin". Resolves: #100857 Releases: main, 12.4, 11.5 Change-Id: I1af115deecc537efdc41125daa119630d6449044 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79587 Tested-by:
-
Andreas Nedbal authored
This change in the Rollup configuration caused the window namespace to disappear, breaking the JS call in the process. Resolves: #101202 Releases: main, 12.4 Change-Id: Ie216d7d91502436b68c6404b0c81268ce0f5672e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79616 Tested-by:
-
Benni Mack authored
When editing in FormEngine the popup now has a larger size, corresponding to up-to-date displays and devices. Resolves: #99383 Releases: main, 12.4 Change-Id: I0638d42b0b4018aba1093cca5f816e91bf86e471 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79588 Tested-by:
-
Christoph Lehmann authored
Its todo is solved. This also introduces constructor property promotion. Resolves: #101213 Releases: main Change-Id: I929bd9584e9f83c92919973a2769b0cccd55d9b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79574 Reviewed-by:
-
Benni Mack authored
The site language's configuration setting "hreflang" was deprecated with #99908, however, it still serves a valid purpose. If working with EXT:seo and the <link rel="alternate"> tags, it is still valid and possible to set a specific "hreflang" attribute. Example setups: * You have "German (Germany)" (which is using de-DE as locale) and "German (Austria)" (which is using de-AT as locale). here you want to set "de" as generic fallback in the "de-DE" locale when using hreflang attributes. * You want to explicitly set "x-default" for a specific language, which is clearly not a valid language key. This change does the following: * It re-adds the hreflang property to be managed by the UI, however it is empty by default and will fallback to the $locale->getName(). * It is not used within the <html lang="..."> attribute anymore as this was a mis-use in the first place (and now properly using just the language key, see https://www.w3.org/International/questions/qa-html-language-declarations.en.html#attributes * The method "SiteLanguage->getHrefLang()" is not deprecated anymore. * The RST is adapted accordingly Still, the relevant information is: The site language configuration option "hreflang" is not relevant anymore for regular websites without rendering hreflang tags, but is now customizable, and has a proper fallback. Resolves: #101160 Resolves: #95798 Related: #99908 Releases: main, 12.4 Change-Id: Ifc5b5b10ba46b4da4abd5c504d4d69f240f2fd02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79488 Tested-by:
-
Torben Hansen authored
This change moves the section about "Access restrictions on the felogin plugin" to the user manual, since the section is not an example, but an important notice for users of the plugin. The part about having two plugins on one page has been removed, since this will lead to other problems as noted in the "Known problems" chapter. Additionally, a short notice about the "Hide at login" problem has been added to the "Known problems" chapter. Resolves: #100632 Releases: main, 12.4, 11.5 Signed-off-by:
-
Susanne Moog authored
As LC_NUMERIC is not set via Locales::setLocale because conflicts on float calculation may occur, we have to manually set LC_NUMERIC in places where we need the locale aware numeric functionality. In the core this is only formatSize - which missed the LC_NUMERIC handling since the switch to SiteConfiguration. With this patch, the handling is reintroduced by using the locale set by setLocale for LC_MONETARY to temporarily set LC_NUMERIC in formatSize. Resolves: #101211 Releases: main, 12.4 Change-Id: Id694f04fb07fb421644fa87c415d786ca11bcfaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79592 Tested-by:
-
Markus Klein authored
All PHP code is adjusted to use proper spelling "referrer". Existing Fluid variables or config options are not touched. Resolves: #101216 Releases: main, 12.4, 11.5 Change-Id: I8d18b1f269c921d01bcd1b5c3b7017527d92e72d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79580 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Andreas Fernandez authored
If a console command throws an exception that isn't caught, the exit code evaluates to "0" (aka successful) because the exit codes usually are the exception timestamp and UNIX doesn't support exit codes > 255. The issue is now solved by checking the exit code in `CommandApplication` and setting an upper bound of 255. Resolves: #101220 Releases: main, 12.4 Change-Id: I722125aa678fe24accb7ebf9732e571ff54abb73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79585 Tested-by:
-
Tymoteusz Motylewski authored
Include Matomo, Google, Hubspot. Resolves: #101180 Releases: main, 12.4, 11.5 Change-Id: I15ba4d4ec84e5abfb22e5f83d02535e06e2de40f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79529 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Stefan Bürk authored
This change raises `styleguide` to include the change with the correct version constraints in the `ext_emconf.php`. Resolves: #101218 Releases: main Change-Id: Id9488a09de930441b31dba08ded2bfbe67a1a92b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79584 Reviewed-by:
-
- Jul 02, 2023
-
-
Torben Hansen authored
This change removes a useless test, which only tests PHP native `htmlspecialchars()` and `htmlspecialchars_decode()` functionality. The test did previously test `GU:htmlspecialchars_decode()`, which has replaced by PHP native `htmlspecialchars_decode()` in #54777. Resolves: #101215 Related: #54777 Releases: main, 12.4 Signed-off-by:
-
- Jul 01, 2023
-
-
Christian Kuhn authored
A new patch level requires to regenerate baseline. > composer req --dev phpstan/phpstan:^1.10.22 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101214 Releases: main, 12.4, 11.5 Change-Id: I762846574afa26b6b4bc0ae122b07be3dde99c73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79576 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Jun 30, 2023
-
-
Nikita Hovratov authored
The previous logic for checking whether a value for a specific doktype already exists falsely assumed the value should be an array. This is now fixed by using the null coalescing assignment, which is available since PHP 7.4. Resolves: #101196 Related: #94498 Releases: main, 12.4, 11.5 Change-Id: Iab1dba7987d336b08bfb4f398b16666d591daada Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79564 Tested-by:
-
Stephan Großberndt authored
Instead of breaking the execution with a TypeError if an array to be flattened by ArrayUtility::flatten() has integer keys, this change allows the method to handle this case correctly. Resolves: #101208 Related: #97202 Releases: main, 12.4 Change-Id: I05d47da80e088f024536fe15f5f2c2802c22a921 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79569 Reviewed-by:
-
Christian Kuhn authored
Class SchemaMigrator has an unused property $schema. Removing this property makes it more obvious this service is stateless. Resolves: #101207 Releases: main, 12.4 Change-Id: Icb6fced983129a508152ed79f7511b1b219c23db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79565 Tested-by:
-
Stephan Großberndt authored
Replace the Fluid if condition for the onSubmit value in the login template of EXT:fe_login with the else part. The onSubmit value in the login template of EXT:fe_login was ported from the pibase'd version but never set in Extbase'd version and thus in Fluid. Resolves: #101178 Releases: main, 12.4 Change-Id: Ic80a65c80841292c4b6ee2251d8e148d51b56e9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79518 Tested-by:
-
