[TASK] Change sorting of records in recycler module

The deleted records should be sorted by the timestamp descending instead
of by the uid ascending because in most cases one of the recently
deleted records should be restored.

In addition, a comparison is fixed as a drive-by change to have
compatible types.

Resolves: #100252
Releases: main, 12.4
Change-Id: I67ce8134ea498782b476381716559e92f9867059
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78211


Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>

typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php

@@ -223,19 +223,23 @@ class DeletedRecords
             if ($maxResults) {
                 $queryBuilder->setMaxResults($maxResults);
             }
-            $recordsToCheck = $queryBuilder->select('*')
+            $queryBuilder = $queryBuilder->select('*')
                 ->from($table)
                 ->andWhere(
                     $queryBuilder->expr()->eq(
                         $deletedField,
                         $queryBuilder->createNamedParameter(1, Connection::PARAM_INT)
                     )
-                )
-                ->orderBy('uid')
-                ->executeQuery()
-                ->fetchAllAssociative();
-
-            if ($recordsToCheck !== false) {
+                );
+            if ($GLOBALS['TCA'][$table]['ctrl']['tstamp'] ?? false) {
+                $queryBuilder = $queryBuilder
+                    ->orderBy($GLOBALS['TCA'][$table]['ctrl']['tstamp'], 'desc')
+                    ->addOrderBy('uid');
+            } else {
+                $queryBuilder = $queryBuilder->orderBy('uid');
+            }
+            $recordsToCheck = $queryBuilder->executeQuery()->fetchAllAssociative();
+            if ($recordsToCheck !== []) {
                 $this->checkRecordAccess($table, $recordsToCheck);
             }
         }