- Nov 14, 2022
-
-
Benni Mack authored
BackendUtility::getPossibleWorkspaceVersionIdsOfLiveRecordIds() is added to check for workspace versions within FormEngine foreign_field logic to first fetch a list of all records that have a versioned record within the workspace, and only apply BackendUtility::workspaceOL() for these cases. Without the patch, each live record triggers a database query to resolve a possible workspace overlay. With the patch, one query is done to see which records have workspace overlays, only those are queried for overlays. This reduces the number of performed queries a lot, since typically only a small number of records are overlaid. This only affects editing records in a workspace. Resolves: #99007 Releases: main, 11.5 Change-Id: Ia7c47e5de0082ca0ff2c68b30d9ff1bc5312981b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76446 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benjamin Kott authored
The custom element typo3-backend-column-selector-button is a valid HTML and should be used as such. There is no need to nest buttons/links inside the element to add CSS styling. We are adding keyboard events to react on the "Enter" and "Space" keys to mimic the behavior of a button and setting defaults for the role and tabindex to make it keyboard accessible. CSS classes are now directly set to the element itself. Resolves: #99080 Releases: main Change-Id: I71dfa68174255a5d445af5fadbf1924b54a6b687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76593 Tested-by:
-
Daniel Ziegenberg authored
Resolves: #99082 Related: #99038 Releases: main Change-Id: Icefd1b4ac8a2ae4cefee51ac9cecfd24e4f989a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76597 Tested-by:
-
Christian Kuhn authored
TSconfig plays an important role in the Backend: It configures rendering and behavior details in the Backend and can be set on pages, be_users and be_groups field, leading to UserTsConfig and PageTsConfig. Frontend users and Frontend groups have this as well on database level, together with an API in class FrontendUserAuthentication. This was probably added in the old days to allow a similar thing as Backend TSconfig for Frontend users as well. It is however unused by the core and there seems to be only a very limited number of extensions that ever used this. Developers think of "TSconfig" as Backend specific things, and that's how it should be. To reduce confusion, the patch deprecates the TSconfig database fields in fe_groups and fe_users table along with the PHP API. Resolves: #99075 Releases: main Change-Id: I599670bf5e87eee4aa5e1ba353da1e7dc9351702 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76578 Tested-by:
-
Christian Kuhn authored
> composer u typo3/testing-framework Resolves: #99078 Releases: main Change-Id: I937487add61afc30509c898004b55a62d6cb80c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76592 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
marcus@schwemer.de authored
Adds a submodule to the beuser module, which provides an overview over all filemounts and allows them to modify, hide, delete and add those. Resolves: #99038 Releases: main Change-Id: I2769ad34562c0428226da4abe1ab79077fc52475 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76547 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Nov 13, 2022
-
-
Stefan Bürk authored
NoopEventDispatcher was originally a text fixture class to help during testing. This class has been made available to extension developers with #99070. However, #98808 has been mergend without prior rebasing and having wrong namespace for this class in a test class. This change now uses the correct namespace to ensure tests are working again. Resolves: #99076 Related: #99070 Related: #98808 Releases: main Change-Id: Ibe28b8e56b18c6899e3a1935e97e6df9e68803d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76582 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Torben Hansen authored
Resolves: #98808 Releases: main Change-Id: I24bbb0b74a238e2488fd60c67d502bba7fa3079c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76579 Reviewed-by:
-
Benni Mack authored
The latest Doctrine DBAL 3.5 is similar to Doctrine DBAL 4, which is what we want to use in the future. Used command(s): > composer req "doctrine/dbal":"^3.5.1" \ --no-update -d typo3/sysext/core > composer req "doctrine/dbal":"^3.5.1" \ --no-update -d typo3/sysext/install > composer req "doctrine/dbal":"^3.5.1" \ --no-update -d typo3/sysext/redirects > composer req "doctrine/dbal":"^3.5.1" Resolves: #99072 Releases: main Change-Id: I62eaa0cd0c759ecc58c40d3b12dd751fd1b47bc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76564 Tested-by: -
Torben Hansen authored
Resolves: #98806 Releases: main Change-Id: I9e87fd549f0fbc29fc392cc73944d92fbc83ddb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76580 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98754 Releases: main Change-Id: I5b11bea380acbce339e37bff4efc117cbeef769e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76575 Tested-by:
-
Nikita Hovratov authored
Resolves: #98752 Releases: main Change-Id: I8b5229ca9d2eb86072ae21a775d9368133cbba54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76573 Tested-by:
-
Nikita Hovratov authored
Resolves: #98751 Releases: main Change-Id: I5e127bebb5fdab914c535c7f16f1ff85ce1d9778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76572 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98753 Releases: main Change-Id: Ibd1b655f8d7563165683e4d8307c9445ac9d3398 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76574 Tested-by:
-
Nikita Hovratov authored
Resolves: #98755 Resolves: #98756 Releases: main Change-Id: If8484ba37f25cceb7a2d35dfc22717d95c122716 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76576 Tested-by:
-
- Nov 12, 2022
-
-
Oliver Klee authored
With the class moved out of the `Tests` namespace into the general `EventDispatcher` namespace, extensions can now also use this class for their tests. Also add unit tests for the moved class. Resolves: #99070 Releases: main, 11.5 Change-Id: I69b94f50f68dcacfe036e8eb489ba6b82fbb585a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76569 Tested-by:
-
Torben Hansen authored
Resolves: #98809 Resolves: #98810 Resolves: #98811 Resolves: #98812 Releases: main Change-Id: I043c797873be9df1ce1356fd4c3425bc0018673a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76567 Tested-by:
-
Andreas Fernandez authored
This patch updates `moment-timezone`, having a fixed vulnerability, along with the related `moment` library. In the same run, dev depencendies are updated as well. Executed commands: npm install --save \ moment@^2.29.4 \ moment-timezone@^0.5.38 npm audit fix npm run build Resolves: #99061 Releases: main, 11.5, 10.4 Change-Id: I36376bad194aa63dda0146c8bc0f481b932dc89d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76556 Tested-by:Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Andreas Fernandez authored
This patch simplifies some JavaScript-side validations in FormEngine. Most notably, parsing dates and times is now handled by moment.js (which will be replaced by luxon in the future), allowing us to remove decades-old mambo-jambo code nobody can reverse-engineer nowadays. In the same run, `ltrim()` and the unused `btrim()` methods are removed in favor of modern JavaScript functions. Previously, it was possible to supply the invalid date "13-13-2016" which was magically fixed to "13-01-2017". However, this was only possible by setting the value and triggering the `change` event via JavaScript and NOT by using the backend as a sane user. The behavior introduced with this patch is now streamlined to behave like using the datepicker or entering the field in the input field. Resolves: #99058 Releases: main Change-Id: I98af867ee3bda91222d21bcee1bc1f4c92e41d7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76544 Tested-by:
Roman Büchler <info@buechler.pro> Tested-by:
-
linawolf authored
Solves https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-ViewHelper/issues/50 Occurences of `:ts:` are adressed in https://forge.typo3.org/issues/99068 Resolves: #99069 Releases: main, 11.5 Change-Id: I49a42ba29017081d338bec815e3b2c5f14bf7a68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76566 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
linawolf authored
Replace `:ts:` with ``:typoscript:` in ViewHelper class comments. `:ts` does not render properly, see for example https://docs.typo3.org/other/typo3/view-helper-reference/main/en-us/typo3/fluid/latest/CObject.html Resolves: #99068 Releases: main, 11.5 Change-Id: Idfac843859a5e9054e6e48f29b19616b2b956dac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76562 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98750 Releases: main Change-Id: I3d57299abd943eca8f2e12a3ad56461e7339c28f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76563 Tested-by:
-
- Nov 11, 2022
-
-
Torben Hansen authored
Resolves: #98813 Resolves: #98814 Resolves: #98815 Resolves: #98816 Resolves: #98817 Resolves: #98818 Resolves: #98819 Resolves: #98820 Resolves: #98821 Resolves: #98972 Releases: main Change-Id: I03e1a5854e13fe935c1bb40111d3d5b9cc5c33fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76559 Tested-by:
-
Andreas Fernandez authored
In mid-2020, the library `web-animate` was added as a polyfill due to missing support of the Web Animations API (WAAPI). Now, in late 2022, all major browsers support WAAPI [1], and therefore the library became obsolete. Executed command: npm remove web-animate [1] https://caniuse.com/web-animation Resolves: #99063 Related: #91072 Releases: main Change-Id: Id1098b58a686bbd4ac1f6062e6750fa2115c576c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76560 Tested-by: -
Andreas Fernandez authored
The date-time-picker component now checks properly if the backend user's language could not get fetched from its UC by checking loose for a falsy value. Resolves: #99067 Releases: main, 11.5 Change-Id: I3ba104afde2321480099e96beff6ab77ecb126a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76561 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Stefan Bürk authored
Long time back auto-created redirects were created on page "0", which has been changed meanwhile to create them using the pageId of the changed page as `pid`. With this change, auto-created redirects now use the siteConfigs rootPageId as `pid`. This acts as a preparation for following features and site based redirects editing capabilities. Resolves: #99044 Related: #91776 Releases: main Change-Id: I9ebacd268999d6a5bdf765dc14ebac5f11777514 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76521 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Chris Müller authored
The Service Configuration for the dependency container is now also checked in `config/system/services.yaml` or `config/system/services.php`. Note that this only works in Composer-based installations where the project root is outside the document root. Resolves: #98912 Resolves: #98316 Releases: main Change-Id: Id60b3614a59a28f38aafb372389002fc13b2d3ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76449 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Christian Kuhn authored
To further reduce usages of old TypoScriptParser, the "resolve '=<' reference operator" logic in ContentObjectRenderer is streamlined and avoids using the TypoScriptParser->getVal() helper method. Resolves: #99060 Related: #97816 Releases: main Change-Id: Ibf131238b5350e77b7fac6f1006d8da54925213d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76552 Tested-by:
-
Torben Hansen authored
Resolves: #98822 Releases: main Change-Id: I3e94df477f21600fdd0cb0eeb4ae1c9932d2bc34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76541 Tested-by:
-
- Nov 10, 2022
-
-
Bastien Lutz authored
New helper methods are added to allow to do the reverse of flattenPlain() in ArrayUtility, that is ArrayUtility::unflatten(). In order to unflatten correctly, an explode function which respects escaping characters was introduced to StringUtility. Releases: main Resolves: #99054 Change-Id: If153f04c7371b6dbae173472077cdcb1b18152b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76546 Tested-by:
-
Oliver Hader authored
Empty (in terms of PHP empty()) string values are shown as blank strings in the info section of the admin panel. For instance "0" is incorrectly shown as "". Resolves: #99052 Releases: main, 11.5 Change-Id: Ic330fb1874edca8b3e640e9c5793192616583ec0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76543 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Achim Fritz authored
EXT:redirects DataHandler hook to flush the redirects cache in case a redirect is modified does now also work for new redirect records by removing parts of the early return, which relied on records having a numeric uid while new records' uid is the known "NEW.*" string. Resolves: #99042 Releases: main, 11.5 Change-Id: I3624ceecaefd00c0ffce88fd656dc5d81a5b77de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76536 Tested-by:
-
Chris Müller authored
The TypoScript "cssInline" property is only available on PAGE level, not as a property on CONFIG. Resolves: #99057 Related: #99050 Releases: main Change-Id: Ic302d6ea79aba3cb32813f001f9d2dc57daabbaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76548 Tested-by:
-
Christian Kuhn authored
This is not about TypoScript constants/settings that are accessed using {$myConstant} in TypoScript setup. This is about the TypoScript setup "constants" top-level-object: It is used in TypoScript "parseFunc" and allows referencing string literals by name in "parseFunc" strings, which are substituted by using ###theName###, when property "constants = 1" is set in "parseFunc". This feature dates back to Kasper's "Initial revision" and is obsolete ever since: The feature exists next to well-known TypoScript constants, existing usages can be easily substituted. The confusion with TypoScript "constants" alone justifies a deprecation of this detail. The patch deprecates both the TypoScript setup "constants" top-level-object, plus the "constants" property in "parseFunc". Resolves: #99040 Releases: main Change-Id: I91546067db8a7eb72661087780e39f320db2cbeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76532 Tested-by: -
Benni Mack authored
When using site configuration with settings, they previously were accessible via $site->getConfiguration()['settings']. A site now also contains the settings in a better way to read them via $site->getSettings() where a SiteSettings object is resolved, which contains all defined settings. Settings can be defined in a settings.yaml within the site configuration folder, which are then read and populated along with the site configuration. The new SiteSettings Read API allows to access the settings via a flat array or a full array. Resolves: #99048 Releases: main Change-Id: I07f1244d0ed45fe09d0f39dfdd52e8523a05b730 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76520 Tested-by:
-
Christian Kuhn authored
Plugins can instruct the Frontend to add CSS using the property "plugin.tx_myPlugin._CSS_DEFAULT_STYLE". This often kicks in as soon as an extension is loaded if this TypoScript is added by the extension as default TypoScript. Doing this has a drawback though: If the Frontend renders no HTML but something else - for instance json, this default CSS can destroy the output. In these cases, or when a Frontend integration does not want to have the default styles applied, property "config.removeDefaultCss" can be used to avoid loading these plugin styles. While "_CSS_DEFAULT_STYLE" is still widely used - for instance by ext:fluid_styled_content and lots of TER extensions, the sister property "_CSS_PAGE_STYLE" is much less well known: It has the same characteristics as "_CSS_DEFAULT_STYLE", but is meant to be used by integrators to add additional styles on plugin level. It's inclusion in Frontend can be suppressed using "config.removePageCss". However, there are more elegant ways to include CSS to the Frontend, typically using the PAGE object properties "includeCSS" or "cssInline". The documenation of property "_CSS_PAGE_STYLE" is also misleading since it states the styles are only applied when such a plugin is actively used on a page. But this is not true. The patch deprecates "_CSS_PAGE_STYLE" together with its toggle-off property "config.removePageCss". Resolves: #99050 Releases: main Change-Id: I9863d552f7c068a053fb5d32973b46e7b9fa9219 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76542 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Andreas Nedbal authored
One of the main use cases of replacing files is updating the content of a referenced file with new revisions or changed content. The local filename of the replacing file in most cases is not as relevant so by default opting to keeping the filename makes sense for the end user. Resolves: #96442 Releases: main Change-Id: I9fbdc7229884b48433447eb1b9616623c3a09e33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76533 Tested-by:
-
Andreas Fernandez authored
The TYPO3 backend search (aka "Live Search") has a `\TYPO3\CMS\Backend\Search\LiveSearch\DatabaseRecordProvider` that searches all records in database tables that have `searchFields` configured. In some individual cases it may not be desired to search in a certain table, therefore a new event `BeforeSearchInDatabaseRecordProviderEvent` is introduced to add tables to a deny list. The event is directly used by TYPO3 to exclude the "pages" table. Resolves: #99033 Releases: main Change-Id: I956085d02576dae60ae6ffb011c9c3a695e08d4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76522 Tested-by:
-
Bastien Lutz authored
Site Settings were introduced with TYPO3 v10. In contrast to the rest of the site configuration, site settings are sane defaults for TypoScript constants, and consist of simple key value logic. In order to separate settings, make them accessible and editable in the TYPO3 Backend, and distinguish between the functionality between required site configuration and optional settings, the "settings" part of the settings are moved to a separate "settings.yaml" file in the site configuration folder, which will later-on be editable by the TYPO3 Backend with the new Settings API introduced in a separate patch. Resolves: #99047 Releases: main Change-Id: Idbcb33ccf1c0d8a728b80ad4c242b56ff2d69afd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491 Tested-by:
-
Oliver Klee authored
This update makes a warning more specific. Run commands: > composer req --dev phpstan/phpstan:^1.9.2 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99045 Releases: main, 11.5 Change-Id: I4c5af9d69e0e5b8f4b0d78efd4caa4ed79aed795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76538 Tested-by:
-
