- Jan 17, 2023
-
-
Christian Kuhn authored
Resolves: #99582 Releases: main, 11.5 Change-Id: Ib7a0f546f025eed37bac6b494f29865494841787 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77429 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Torben Hansen authored
The web components for the following TCA types had a wrong closing tag: * `\TYPO3\CMS\Backend\Form\Element\ColorElement` * `\TYPO3\CMS\Backend\Form\Element\FolderElement` * `\TYPO3\CMS\Backend\Form\Element\TextElement` Resolves: #99581 Releases: main Change-Id: I9c98d2ff82eef9f5fcf205ef6527f99ffcbf99d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77427 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Georg Ringer authored
Set the argument `muted` if autoplay is enabled for vimeo and local videos - just as done for YouTube videos in #96320 Resolves: #99301 Resolves: #99461 Related: #96320 Releases: main, 11.5 Change-Id: I81848a724dc736b49c4c98c4c2f59627be169f8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77288 Tested-by:
-
Benjamin Kott authored
CKEditor4 had several ways of defining toolbars - Basic, Advanced, Toolbar Groups, and Toolbar References. All these cases are now covered in the migration and updated to the CKEditor5 format. There can only be one `toolbar` or a `toolbarGroups` definition. The preference is `toolbarGroups` since we assume it only exists on an incomplete migration. Instead of mapping groups to new definitions, we are now resolving each main and subgroup to the CKEditor4 defaults. Each item is migrated to the CKEditor5 equivalent if one exists. CKEditor5 allows buttons to appear multiple times in a configuration. The migration now ensures that buttons exist once. Duplicates are removed during the migration to reproduce the behavior of CKEditor4. Resolves: #99556 Releases: main Change-Id: Ib403f377895cc0f8020b7f0070a969088a9eec28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77358 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Anja Leichsenring authored
Resolves: #99564 Releases: main Change-Id: I64b1adaec854a565b73e60455dc731b9d6d5053f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77404 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Oliver Klee authored
The new version finds some more potential problems. > composer req --dev phpstan/phpstan:^1.9.12 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99573 Releases: main, 11.5 Change-Id: Ieee3a5881a854946cb180965e4f182b27ea05aaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77419 Reviewed-by:
-
Christoph Lehmann authored
This introduces less but bigger queries. Queries are also chunked to avoid hitting platform/driver placeholder limit, if `doctrine/dbal` transform eventually unsupported named query params to positional ones. Releases: main Resolves: #99555 Change-Id: I7af6060781ddaeabae34f2c4544046e3ab926b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77392 Tested-by:
-
Benni Mack authored
LanguageService can also be used for overriding labels via TypoScript. For this reason, TranslationService from EXT:form can be slimmed down similar to how Extbase's TranslationUtility was migrated in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77399 Because TranslationService does not have an input for alternative language keys, the dependency functionality from LanguageService can be used. Resolves: #99566 Releases: main Change-Id: I76536087d2210bbd4d47fc9119abd86af3348a9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77412 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Resolves: #99572 Releases: main, 11.5 Change-Id: I65fe76b733b6b0fce9ebb7dd54759ae673ab1755 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77417 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
To simplify working with the UpgradeWizardService, the patch cleans up the following: * Extract database related tasks into an own service * Fetch UpgradeWizardService via container Resolves: #99570 Releases: main Change-Id: Ia18aa19cea8743890a4e85629b7e720ee73a7220 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77416 Reviewed-by:
-
Christian Kuhn authored
Just another sanitation in lowlevel QueryGenerator. Resolves: #99568 Related: #98536 Releases: main, 11.5 Change-Id: Id7d8aa9856e7e148964bff0ef66e7c7b69bd6aaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77413 Reviewed-by:
-
Benni Mack authored
The functionality to handle TypoScript overrides for Labels is now moved from Extbase LocalizationUtility to LanguageService. All tests now use proper XLF files and also real TypoScript values, in order to make the tests easier to understand. Instead of magic $LOCALLANG and $LOCALLANG_UNSET properties, LocalizationUtility now keeps the actual LanguageService objects in its storage. The LanguageService->overrideLabels() method should be used with care, as other instances of the object might not have the overrides stored. Resolves: #99559 Releases: main Change-Id: I3e83695baebec545b5e6c5d8504df95950a543cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77399 Tested-by:
-
Jasmina Ließmann authored
The submodule "TSconfig page" is to be streamlined. Therefore some options in the function menu have been removed. We will continue to work on this module. Resolves: #99565 Releases: main Change-Id: I2ca41d9a029f0f26878137228a9d84a96179b132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77406 Reviewed-by:
-
Jasmina Ließmann authored
Move PageTsConfig tree rendering from a PHP method to Fluid as a cleanup of the controller. Resolves: #99562 Releases: main Change-Id: I31afce9a9f74a1e728b97a2a2bb324b9005be7d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77398 Tested-by:
-
Georg Ringer authored
Relax the usage of the attribute approved added with #97729 by allowed translations without the approved attribute Resolves: #99265 Related: #97729 Releases: main Change-Id: I7802b597c746d885e458f13d351ce0c2a9be6034 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77032 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benni Mack authored
Resolves: #99561 Releases: main Change-Id: I3f8a5e4d89c31f28703e91cbd02840ecfc7df9a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77403 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Jan 16, 2023
-
-
Sybille Peters authored
Checking for duplicate slugs in DataHandler will now make sure that no two fields with the same slug exist, where one of them has a language of -1. Existing records are not migrated. This could be done in a followup patch or with a community extension. When new records are created or changed which have a field of type "slug", a unique handling ensures that no records exists with the same slug (depending on the additional settings "unique", "uniqueInSite" and "uniqueInPid"). The language is considered as well: Records with the same slug can exist if the language differs. But language -1 was not considered previously. Since -1 means all language, no other record with the same slug should exist in ANY language if a record with language -1 exists. Resolves: #99529 Releases: main, 11.5 Change-Id: I919c3a3954df02cd55c701c480f6c1a8c87d84d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77383 Tested-by:
-
Benni Mack authored
PageRepository->getExtURL() is a pretty upgly public helper method that has a depedency to $GLOBALS['TYPO3_REQUEST']. It is used only once. The patch moves the method body to the consuming class and deprecates it. Resolves: #99558 Releases: main Change-Id: I7c1e8d6b1a454950de6fa7469d13fbab81ee2962 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77330 Reviewed-by:
-
Oliver Bartsch authored
The file mount identifier, introduced in #97922 might be invalid, e.g. in case the upgrade wizard was not executed yet. To prevent an undefined array key warning, the identifier is now properly checked, like already done in the StoragePermissionsAspect. Resolves: #99560 Related: #97922 Releases: main Change-Id: Iba75d2a6792a5e619a5ea51d9664e511c8ad46ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77400 Tested-by:
-
Oliver Bartsch authored
Resolves: #99557 Releases: main Change-Id: Idf145a98aa3fd386ff9906a4ee9cf5f0593fe8a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77397 Tested-by:
-
Torben Hansen authored
The `redirectMode=referer` configuration allows to process a redirect after a successful login to an evaluated referer value. For the legacy version of the felogin plugin, the referer value has been evaluated using the GET/POST parameter `referer` and the `HTTP_REFERER` as fallback. The extbase version of the felogin plugin currently only evaluates the GET/POST parameter `referer`. This patch adds the missing `HTTP_REFERER` fallback evaluation of the referer. Resolves: #91844 Releases: main, 11.5 Signed-off-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Georg Ringer authored
As the selection "explain" only works for Mysql, it should also only be displayed then. Resolves: #99512 Releases: main, 11.5 Change-Id: I93ddf86d1f63ef124feb2b72e86f32d8260ad99f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77324 Reviewed-by:
-
linawolf authored
Resolves: #99542 Releases: main, 11.5 Change-Id: Ifa05cc27825bc4c89dd9b08f66c03505270fd815 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77388 Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Benni Mack authored
Avoid heavy mocking in tests by utilizing Functionals incl. PackageManager and Caching Framework. Resolves: #99553 Releases: main Change-Id: Ie569e87c0710a50ce09cc60f3d9a1773d39d4b4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77391 Tested-by:
-
Elias Häußler authored
When authenticating and fetching user records, appropriate methods normally pass around either the full database record or `false` in case the user does not exist or could not be authenticated. The expected types are now added to all relevant methods in authentication services. Resolves: #99544 Releases: main, 11.5 Change-Id: Ib45440a39e64b5ac5a1f1c4799e2f59cb13526bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77385 Tested-by:
-
Benni Mack authored
PageRenderer has some speciality but also code duplication from LanguageService and can be simplified this way, avoid additional parsing states. This way, LanguageService can be used more instead of handling language dependencies manually as before. Resolves: #99540 Releases: main Change-Id: I4416b349351ee629012bee8ad518c20b9efd7ed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77378 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Georg Ringer authored
The text about the time restriction inside the logging module can be removed because: - if no time filter is used, it takes place in the UI by giving the information that the search starts 1970 - if the filter is used, the information can be found inside the filter, just like for all other filter options Resolves: #99539 Releases: main Change-Id: Iccdf83f5a607b0260baa44603fef0b80c57fcec4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77382 Reviewed-by:
-
Christian Kuhn authored
The patch comes with a couple of changes for the TypoScript IncludeTree construct: * Identifiers are now unique within a tree. This is needed especially in the Backend TypoScript -> Included Template files rendering: Before, showing content of single segments did not work due to duplicate identifiers. * getIdentifier() is hardened to throw an exception if not initialized: This detail is only needed for non-cache analysis purposes and identifiers don't exist when getting trees from cache in Frontend. * To allow file includes relative to a parent file include, they now have a "path" property that is properly hand over to child includes. Relative child includes now work with include_static sys_template includes as well. * RootInclude now has an identifier as well to seed child includes which include the parent identifier in their hash. * Identifier hashes and cache identifiers are built with fast xxh3 hash in favor of sha1() and json_encode() is used in favor of serialize() when hashing structures, if possible. * Identifier hashes are created in the setter instead of calling hash() in the caller. * [end] and [global] lines are now parts of the previous condition segment and don't create one-line segments anymore. * Tests are adapted to be a bit less noisy on properties we're not interested in by using another custom comparator. Change-Id: I9c03edfcf29e2887c0ef70ce1692582524333bdf Resolves: #99537 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77369 Reviewed-by:
-
- Jan 14, 2023
-
-
Torben Hansen authored
Use strict properties in all test classes and additionally remove one superfluous class doc header. Resolves: #99543 Releases: main Signed-off-by:
-
- Jan 13, 2023
-
-
Stefan Bürk authored
ext:redirects provides the feature to eventually update subpage slugs and automatically create redirects for changed pages. To accomplish that, a combination of two DataHandler hooks are used along with a centralized service. The service is used before the page slug change is persistent to the database. Hook execution for subpage changes are disabled, to contain all changes in one correlation for eventually reverting. With #99188 the auto-create chain has been streamlined to prepare for further changes. However, added functional tests do not reflect the real procedure properly. Because of that it has been overlooked that the direct slug change which triggers is handled by the hook works with old record, thus creating invalid page slug updates and redirects for the children pages. This change now properly combine the update data with the current record data instead of retrieving not-yet updated data from the database. Corresponding functional tests are adopted to update the records after calling the hook implementation, which reflects real procedure order. Resolves: #99506 Related: #99188 Releases: main Change-Id: Ib2fac341483b863ee20c228dfb6c8a06ea1978f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77318 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Philipp Kitzberger authored
When pressing the save+preview button for a non-page record the local PageTS is not being ignored anymore and leads the user to the right page in the frontend. Resolves: #96667 Releases: main, 11.5 Change-Id: Ibb3e9a549ca59bfd3a71649e2970d1d534c2c0e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73193 Tested-by:
Lorenz Ulrich <lorenz.ulrich@visol.ch> Tested-by:
Rémy DANIEL <dogawaf@no-log.org> Reviewed-by:
-
Benni Mack authored
Because FormProtectionFactory now uses proper injection, this hack is not needed anymore. Resolves: #99532 Related: #98696 Releases: main Change-Id: Id743944586511352228f6187815b70561593f1a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77374 Reviewed-by:
-
Benni Mack authored
Before TYPO3 v4.0, TYPO3 had inconsistencies in its language keys, such as "ja" (= Japan) instead of "jp" (= Japanese), which was still available. However, the mapping was only used for detecting the language from the user agent, for the backend login screen, and not used since various versions. TYPO3 since at least 6.0 only delivers the correct language keys and the "old" language keys can now safely be removed, thus they are deprecated. The getter method Locales->getIsoMapping() is marked as deprecated. Resolves: #99531 Releases: main Change-Id: Ie86237fd0ac4bad460960f31e3bd3971d021de16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77373 Tested-by:
-
Georg Ringer authored
Tool Use the correct structure to be able to modify the setting `requireApprovedLocalizations` also via the UI of the Install Tool. Resolves: #99317 Releases: main Change-Id: Ifda4e47ebcf8a7cb0aaa9509ca32271a529f36bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77363 Tested-by:
-
- Jan 12, 2023
-
-
Robert Kärner authored
The path to the calling file in CompositeExpression::add and ::addMultiple is now normalized to forward slashes to work with Windows paths. Resolves: #99509 Releases: main Change-Id: Ib00a541ee08343d9483b1474590dcd80f819723a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77321 Reviewed-by:
-
Chris Müller authored
The docblocks in the LanguageService class are used for an automatically generated API documentation in TYPO3 Explained. The formatting of some code blocks can be improved. Resolves: #99528 Related: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/2590 Releases: main Change-Id: Idfb29d45f6c452e7f2a51ef81df63378b4e0b247 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77367 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Christian Kuhn authored
The "pass_content" flag for TCA type="none" is a potential security risk and should be removed. A bug in the implementation did not surface the security risk until now, but instead of fixing the bug, we deprecate this toggle entirely since the toggle had no effect for a long time anyways. Resolves: #99523 Related: #99522 Releases: main Change-Id: I911f8f69bf49a21280d661d63de5aaf508bcef2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77359 Reviewed-by:
-
Christian Kuhn authored
Brings a series of rather minor fixes. > composer u typo3/cms-styleguide Resolves: #99525 Releases: main Change-Id: I8832baccaf98d5b1c4e97a1d922b5a2b712e6a05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77365 Tested-by:
-
Christian Kuhn authored
TCA "type=none" with "pass_content=false" (styleguide elements basic none_2) or without pass_content at all (styleguide elements basic none_4) double encodes the value. Testable using styleguide with some DB value like "l<u>i</u>p", which needs to be manually put into DB since none fields do not persist data using the backend. Note pass_content=true is documented to not hsc() the value at all, which is not true since TYPO3 v7, a htmlspecialchars() is still applied. Not encoding HTML is a potential security risk, so the patch now only fixes the "pass_content=false" and "not set" scenario to no longer double encode, and another patch will remove the pass_content option in v12 entirely with a TCA migration and deprecation note stating the option did not work since 2017 anyways. Resolves: #99522 Releases: main, 11.5 Change-Id: Ic19ad991d0f17925d5f56fb34126a7cf8f6e6aab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77355 Reviewed-by:
-
Christian Kuhn authored
With more and more refactoring of the backend controllers and improving controller/view separation, usages of old BackendUtility menu rendering helper methods are shrinking. The patch refactors a last usage of BackendUtility::getFuncMenu() and deprecates the method. Resolves: #99519 Releases: main Change-Id: Ibeb8db7a5b6835200f9e80c776ac606103b11e1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77331 Reviewed-by:
-
