- Sep 09, 2024
-
-
Hannes Lau authored
By allowing `en` as language key and not falling back to `default` automatically, integrators can get back an edge case to use a different language in default XLF files and provide an english translation in `en.locallang.xlf` files by registering English as another language. This is not the suggested way but has worked in 11.5 and is a valid use case if clients use a different language as basis for e.g. translation agencies. Resolves: #104468 Releases: main, 12.4 Change-Id: Id35c7fd1e3a6b50d2b19eaa418fa4a2ba8c46024 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85447 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benjamin Kott authored
The new panel treelist styling is context aware and adapts to light and dark color schemes. This patch also restores the visibility of treelines in Pagetree overview and Localization overview. Resolves: #104845 Releases: main Change-Id: I82785daec2de46e259eca757206e502798922069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85914 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
If settings definitions are configured to use the type `stringlist`, it is expected that `SiteSettings->get('setting.key')` returns the array of strings, but failed for namespaced keys (separated by at least one dot) because of array-flattening. Array-flattening does only provide access to concrete array values, as `ArrayUtility::flattenPlain` transform a settings tree like ``` [ 'foo' => [ 'bar' => ['a', 'b'], ], ], ``` …into a flat list like: ``` [ 'foo.bar.0' => 'a', 'foo.bar.1' => 'b', ] ``` That means the key `foo.bar` is considered as not existent. To provide access to actively defined settings key, a new settings map is composed from the list of active setting definition keys. For compatibility reasons the old array flattening is still used for: a) undefined settings b) access to sub-values (as it worked before) Releases: main Resolves: #104858 Change-Id: Id3304d4673f778ef8a78381dd317816c0e8f1a13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85924 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Simon Praetorius authored
The constructor of Fluid's `TemplatePath` class allowed both a package name and a configuration array (containing `templateRootPaths`, `layoutRootPaths`, `partialRootPaths` and a `format`). It also tried to set defaults for TYPO3, without the base `TemplatePaths` class being part of TYPO3. To streamline Fluid's API and to untangle Fluid's configuration from TYPO3, both constructor variants have been soft-deprecated with Fluid v2.15 and will log deprecation notices with Fluid v4. In preparation of the switch to Fluid v4, all usages of the constructor are removed from the core. A lot of this work has already been done in previous patches. The remaining usages are related to the `FluidEmail` class, which unfortunately uses Fluid's `TemplatePaths` class as API. In all cases, the default mailer configuration is extended, which is part of the system configuration: from DefaultConfiguration.php: ``` 'MAIL' => [ // Mail configurations to tune how \TYPO3\CMS\Core\Mail\ classes will send their mails. //… 'format' => 'both', 'layoutRootPaths' => [ 0 => 'EXT:core/Resources/Private/Layouts/', 10 => 'EXT:backend/Resources/Private/Layouts/', ], 'partialRootPaths' => [ 0 => 'EXT:core/Resources/Private/Partials/', 10 => 'EXT:backend/Resources/Private/Partials/', ], 'templateRootPaths' => [ 0 => 'EXT:core/Resources/Private/Templates/Email/', 10 => 'EXT:backend/Resources/Private/Templates/Email/', ], ``` `format` is already problematic, because `both` is not a valid value to Fluid. So that value is *not* set in this patch because `FluidEmail` overwrites the value internally anyways once `txt`, `html` or `both` are rendered for an email. The three path arrays are set by using the appropriate setter methods of the `TemplatePaths` object and thus avoiding the deprecated constructor. Merges with additional paths are performed in the same way they were before. Due to slightly different implementations, changes to tests are necessary. The new implementation preserves numeric array keys, while the old implementation didn't. However, the order of the templates stays the same and overriding by key is still possible. Resolves: #104823 Releases: main Change-Id: Iee9e08e3320657bfffa4c069da94efcf0f9ebd2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85832 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Oliver Bartsch authored
The method is unused in core and also is considered bad API, e.g. because of a couple of method arguments are unused, while other have been added over time to change behaviour. Resolves: #104662 Releases: main Change-Id: Ibe9057dcd7d86995c8bb664cb47be4f3ea043b03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85680 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Mathias Brodala authored
Resolves: #104643 Releases: main, 12.4 Change-Id: I32a5a46e9cee321673afe760f18578f35af49f4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85659 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Simon Praetorius authored
In preparation for changes on `AssetRenderer`, most of the unit tests are converted to functional tests. The test cases are preserved, but duplicated to cover both the new functional and the old unit tests. Resolves: #104854 Releases: main Change-Id: I3ab5bad81d7554061ca4d2ef61946e8282dc8f85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85921 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Simon Praetorius <simon@praetorius.me>
-
Benjamin Kott authored
The new panel element styling is context aware and adapts to light and dark color schemes. The markup was streamlined, workarounds dropped and now features improved focus and hover styles. Resolves: #104818 Resolves: #104798 Releases: main Change-Id: I9cf2b1c203b8a38c0c0675ff26a08131b0277923 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85725 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Benjamin Franzke authored
The set language files introduced in #104831 are now auto-loaded from labels.xlf within the sets folder, if the file is provided and the set configuration does not reference an explicit labels xlf file. TYPO3 documentation is adapted to understand this change via: https://github.com/TYPO3-Documentation/render-guides/pull/737 Releases: main Resolves: #104840 Related: #104831 Change-Id: If00ae72da97b65768d925de48f7850e80bc44b3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85907 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com>
-
- Sep 07, 2024
-
-
Lina Wolf authored
These directives are currently causing errors in opening rst files in PHP storm. Also it is best practice to only use explicit code blocks or literalincludes. Resolves: #104848 Releases: main, 12.4 Change-Id: I1271b6e4f5e032a1f0d5835e141334e263b30169 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85916 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Sep 06, 2024
-
-
Thomas Hohn authored
`LogDataTrait::formatLogDetailsStatic()` simple used `vsprintf()` in case that the string contains any `%` characters and throws either a `\ValueError` or `\ArgumentCountError` depending if no value exists or the count does not match. It is not reliable and implement additional lexing here to avoid the exception by not calling `vsprintf()` upfront. This change calls `vsprintf()` and handles the mentioned exceptions and use the fallback handling in case exception has been thrown as a simplefied approach. Tests are added to cover legacy, mixed and new log format option along with static and instanced method calls. Note that a minor inline PHP DocBlock annotation has been added in `LogDataTrait` to mitigate detection issues of PHPStan, which allows now to remove baseline ignore patterns in the same run. Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #103711 Releases: main, 12.4 Change-Id: I7b23eccdc944d2cb068f584b01b52835aca938e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84004 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Ayke Halder authored
Resolves: #104847 Releases: main Change-Id: I018f359886bb98962646ab542da5cabb6851af43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85915 Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Lina Wolf authored
These directives are currently causing errors in opening rst files in PHP storm. Also it is best practice to only use explicit code blocks or literalincludes. Resolves: #104849 Releases: main Change-Id: I42aebb26e9398229159f91d8a100f277aa4837e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85918 Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
Oliver Bartsch authored
This extracts most of the content types from the main tt_content file to dedicated configuration files in the TCA/Overrides/ directory. This allows a better handling and also paves the ways for a component based registration in the future. Resolves: #104838 Releases: main Change-Id: I1b1446a506aaa0774d70fdcdfdbcf466eff9a580 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85898 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Franz Holzinger authored
Resolves: #104841 Related: #87889 Releases: main Change-Id: I799ea6adfdd26e01d7f0ba97be3c57840e5cb365 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85908 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com>
-
Simon Schaufelberger authored
Resolves: #104843 Releases: main Change-Id: I38d9dd2bb2562af43866c57f10b245960a6670d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85911 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Simon Praetorius <simon@praetorius.me>
-
Helmut Hummel authored
The code for the web installer and the cli installer is only partly aligned and shared, thus may easily diverge, leading to different installation results. The code to create system settings is now put into SetupService and is used for both installation methods, so that the cli install now also uses FactoryConfiguration.php. Additionally, the following cleanups are performed to prepare further cleanup of the installation process: * The cli setup does not set insecure trustedHostPattern any more. * Silent config and template file changes are removed from setup, as conceptually these do nothing on newly created config and template files. * New exceptions are created for config file generation instead of misusing a FAL-related exception. * Absolute paths are made relative to project path before being passed to exception. Resolves: #102403 Releases: main, 12.4 Change-Id: I069e9e9f4136bba56d630eaf09f676b6c5ea7904 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81793 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com>
-
Benjamin Franzke authored
The set label and setting labels and descriptions are now translatable. That means the `label:` and `description:` keys may be ommited and and will be read from a labels-file by convention: * set label: `label` * settings label: `settings.{settings-key}` * settings description: `settings.description.{settings-key}` The labels file is referenced centrally via the sets config.yaml file. Note that the settings labels have not been consumed yet, implementation will follow in #104794. TYPO3 documentation hass been adapted to understand this change via: https://github.com/TYPO3-Documentation/render-guides/pull/734 Resolves: #104831 Related: #104794 Releases: main Change-Id: I9b0f01891db2d7b0c2db63efcd7cb5408439bd24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85869 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benni Mack <benni@typo3.org>
-
- Sep 05, 2024
-
-
Benni Mack authored
A new PSR-14 Event "AfterRawPageRowPreparedEvent" is added to allow to filter out, or remove or re-sort items / children for the page tree in the TYPO3 Backend. This is typically the case for e.g. sorting subpages within a page by e.g. the creation date (news as pages). Resolves: #104832 Releases: main Change-Id: Id9597897e06bba94957e50cbcfee69d4c2bb960c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85864 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org>
-
Xavier Perseguers authored
Resolves: #104834 Releases: main, 12.4 Change-Id: I0ec9d31b36e6fe885f020be895b5f6483c12d2b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85900 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
The "script" typeicon definition is removed since no such CType exists. Resolves: #104830 Releases: main Change-Id: I6d733a3d87a916e616407bd9f7681ebf8bd03184 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85897 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Philipp Kuhlmay authored
The WidgetRegistration.rst had a wrong indentation inside the example. Resolves: #104829 Releases: main Change-Id: Ia4e4e02bba65d036363dfea3fb391c16b1fd1749 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85896 Tested-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Oliver Bartsch authored
The extbase data and column mapping is now properly using the TCA schema API. While streamlining the code some divergences regarding relation handling have been observed (e.g. use of "maxitems" and "renderType" options). Those will be tackled separately, since streamlining this might be breaking. Resolves: #104808 Releases: main Change-Id: I5aedf761372a4c14da76619a85f931a411b1dcb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85811 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
Nikita Hovratov authored
This change adds system fields - as defined in the ctrl section - of tt_content to the showitem field list automatically. This is either done based on palettes that already exist or adding the fields individually to the corresponding tabs. Tabs that are therefore added automatically are: * General tab at the beginning * Language tab including language fields * Access tab including hidden+access fields * Description tab including descriptionColumn In case the showitem of such type defines the "Extended" tab, it is added at the end. We do this for tt_content because we want a unified way of how FormEngine renders the fields. Resolves: #104814 Releases: main Change-Id: I69965fbc74ae2192151ad2617c1a88cf1eb2a987 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85859 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Chris Müller authored
The given migration examples were not really practical, as an integrator does not return an array, but use either the API for adding a new content element/plugin, or manipulate the TCA array directly via `Configuration/TCA/Overrides/tt_content.php` for adding `saveAndClose` or `defaultValues`. To ease the work for integrators when migrating to the new options, the examples have been improved. Additionally, captions for the files have been added to ease grasping the context of the examples. Resolves: #104806 Related: #102834 Releases: main Change-Id: Idc840c611751be79dec475d372c9a2f29d23f32f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85860 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Simon Praetorius authored
`fillFromConfigurationArray()` has been deprecated with Fluid v2.15. Instead, we use the new ViewFactory to create a Fluid view. Resolves: #104822 Releases: main Change-Id: I6b034452b27c8c66f72880f1608285053fcf6bf7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85861 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Simon Praetorius <simon@praetorius.me>
-
- Sep 04, 2024
-
-
Garvin Hicking authored
This is an effort to document the steps that were made in issue #104786 to allow developers and probably integrators to migrate affected ViewHelpers easier. The goal is to lower unneeded fears of possibly complex migrations, because the steps can actually be performed mostly even with search+replace. Resolves: #104824 Related: #104799 Related: #104789 Related: #104786 Releases: main Change-Id: I06bd649c2ff9a4a84c31dfec9d9bcc7c6f2b81f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85893 Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Markus Klein authored
Add more typehints and introduce helper methods to make the code more readable. Resolves: #104800 Releases: main Change-Id: I32c9e4a612f59df1f507f1f09b89fa9df772ea21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85854 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Till Hörner authored
A new CLI command `typo3 upgrade:mark:undone` has been introduced that allows to mark a previously executed upgrade wizard as undone so it can be run again. This makes the existing functionality from the install tool also available on CLI. Resolves: #104655 Releases: main Change-Id: I0d4601e3e81b447793586ddfc31e10bd40a87e64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85672 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Simon Praetorius authored
With Fluid v4, renderStatic() and the associated traits are deprecated. ViewHelpers should use render() as their primary rendering method from now on. [1] Consequently we switch all ViewHelpers in the Core from renderStatic() to render(). This has been done in this patch. The following steps have been performed: 1. Use custom rector rule to perform changes (Patchset 1) > git clone git@github.com:s2b/fluid-rector.git > cd fluid-rector/ > composer install > vendor/bin/rector process ../typo3/ 2. Apply cgl fixes (Patchset 2) > Build/Scripts/runTests.sh -s cglGit 3. Manually migrate phpstan annotations (Patchset 3, partially reverted in Patchset 5) If `$arguments` is annotated in the ViewHelper class, that annotation is removed (either right in Patchset 3 or later in Patchset 5). 4. Manually migrate ViewHelpers that are not covered by rector rule (Patchset 4) [1] https://github.com/TYPO3/Fluid/commit/97aa45a6ed0fa3959cfa7d790077a4a5a9cef53f Resolves: #10478...
-
serbelanalog authored
This patch shows an example for the frontend login how to get a redirect when an unauthorized visitor tries to access a restricted page. In this case, a 403 ErrorHandler can perform a redirect with special parameters, that a properly configured felogin plugin can utilize to redirect back to. Resolves: #104694 Related: #101252 Releases: main, 12.4, 11.5 Change-Id: Ia2c6723621304b8b3de366590c1be905572b00d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85817 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Lina Wolf authored
This fixes the rendering warnings due to duplicate anchors and provides more structure in general. Also utilize API docs referencing for FQCNs. Resolves: #104712 Releases: main, 12.4, 11.5 Change-Id: I4e088dacec80a44d7c6e24ebb07582cbe84f72a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85742 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Torben Hansen authored
When TYPO3 is configured to create links to access protected pages using `typolinkLinkAccessRestrictedPages = NONE` (which is default), a 403 response is returned, if the current frontend request does not fulfill configured access permissions. This change introduces a new Site errorHandler, which can be used to handle 403 responses for access restricted pages and which redirects the user to a configured page and adds a configurable GET parameter (`return_url` or `redirect_url`) containing the original URL. The configurable GET parameter can be used by 3rd party extensions to redirect the user back to the original URL after a successful login. The TYPO3 extensions ext:felogin and ext:oidc both support the configurable redirect parameter introduced in the new Site errorHandler feature. Resolves: #101252 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I06d8e384c5519975efdc8803c98c0a92a56a7653 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81945 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Mathias Brodala authored
With #100307 the authentication system got streamlined and prepared to pass the request and added on dispatched PSR-14 events. To mitigate breaking change nullable method parameter signature has been used along with keeping the fallback handling retrieving the global request or creating a valid request from globales within the `EmailLoginNotification` event listener. The code has been additionally adjusted for issues #100128 and #99864 in case of MFA authentication but missed to pass the request correctly to the added intermediate method. This change passes the request down to the event dispatching method which contains the application type request argument. To mitigate issues in systems using xclasses or test setups the fallback handling in `EmailLoginNotification` is modified to set the BE application type in case a request is created from globals. Both solution parts ensures to have a proper application type set and that `f:translate` viewhelper can be used in system mail templates. Resolves: #104809 Related: #100128 Related: #99864 Related: #100307 Releases: main, 12.4 Change-Id: Ib23a035bfed38c7dc03db111e42f6e98b12e3a4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85862 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de>
-
Garvin Hicking authored
The module "EditModule" was removed with #87498, but the documentation reference remained. Instead of using this module as an example, instead "CacheModule" is referenced, since it addresses similar demonstration purposes. Backports are needed for proper documentation rendering. Resolves: #104802 Related: #87498 Releases: main, 12.4, 11.5 Change-Id: Iab25eec9aec9765f1c71f439c00ca34975d7e8a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85858 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benni Mack <benni@typo3.org>
-
Stefan Bürk authored
This change raises the phpstan package to ensure a stable check across version which is required due to changed detection behavior (bugfixes). Used command(s): > composer require --dev "phpstan/phpstan":"^1.12.1" > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #104813 Releases: main, 12.4 Change-Id: Ia196033a9340d3ce87691eec1da67d6169312962 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85865 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
Adds missing search level selection to the search bar in the link browser for records. Resolves: #104683 Releases: main, 12.4 Change-Id: I71faf22a336b688e1d6f048c76a35bf0e117dc3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85715 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com>
-
- Sep 03, 2024
-
-
Simon Praetorius authored
This release contains important pre-patches for the upgrade to Fluid v4 in the next step. Apart from soft deprecations of code that will log deprecation level errors with Fluid v4, it backports a feature from Fluid v4 to Fluid v2 to deliver a smoother migration path from Fluid v2 to v4 in 3rd party code. The necessary changes to TYPO3's ViewHelpers will be applied in a follow-up patch. Similarly to the previous update to 2.14.0, this patch adds RST files that describe both new features and deprecations that were introduced in this version. Noteworthy changes: * The functionality of `CompileWithContentArgumentAndRenderStatic` has been integrated into `AbstractViewHelper` and can thus be used with non-static ViewHelpers from now on. * `renderStatic()` and both associated traits `CompileWithContentArgumentAndRenderStatic` and `CompileWithRenderStatic` are deprecated * Methods deprecated with the introduction of the ViewFactoryInterface in #104773 have been deprecated in Fluid as well * `true`, `false` and `null` can no longer be used as variable names, as these will become proper language keywords in Fluid v4 Executed composer commands: > composer req typo3fluid/fluid > composer req -d typo3/sysext/adminpanel --no-update typo3fluid/fluid > composer req -d typo3/sysext/core --no-update typo3fluid/fluid > composer req -d typo3/sysext/fluid --no-update typo3fluid/fluid > composer req -d typo3/sysext/redirects --no-update typo3fluid/fluid Resolves: #104789 Related: #104463 Related: #104773 Releases: main Change-Id: I32a465e327cf84975c45e86580c54d060d688cd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85837 Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
- Sep 02, 2024
-
-
Garvin Hicking authored
With #103034 EXT:styleguide received a dependency on EXT:seo. This could lead to a situation for classic installations (non-composer mode) where via `PackageStates.php` the loading order was changed in a way that loaded EXT:dashboard before EXT:seo. This would lead to widgets defined in EXT:seo not getting displayed in the dashboard, because the registration would be performed too late. The easy fix for this is to adjust the file `ext_emconf.php` of EXT:seo to provide a 'suggest' key for EXT:dashboard. The expected PackageStates default in the functional tests are adapted to match that proper order. In case EXT:seo is enabled, this 'suggest' entry ensures that EXT:dashboard is loaded before EXT:seo, so that everything else falls into place. Please note that for composer installations this suggestion was already provided. For classic installations, [1] states: For non-Composer installation ("Classic Mode") the `ext_emconf.php` file is the source of truth for required dependencies and the loading order of active extensions. NOTE: To fix a possible ordering problem in existing installations, rebuilding `PackageStates.php` is needed. This can be done by enabling and disabling EXT:dashboard for example, through the Extension Manager. [1] https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.4/Important-95647-ComposerInstallationsAndExtensionUsage.html Resolves: #104717 Related: #103034 Related: #95647 Releases: main, 12.4 Change-Id: I13547b0ecf6bcb60abf2e3674d273413fb6f9a6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85750 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Oliver Hader authored
Prior to this change, empty sources to be assigned to an existing Content-Security-Policy directive have been ignored. Resolves: #104727 Releases: main, 12.4 Change-Id: I788c32a1772d929b2b974058b0afb746d936718c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85812 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Chris Müller <typo3@brotkrueml.dev>
-