- Apr 22, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. * adjusts invocations of top.TYPO3.InfoWindow.showItem * adjusts low-level inline `onchange` and `onclick` events Both JavaScript modules `TYPO3/CMS/Backend/GlobalEventHandler` and `TYPO3/CMS/Backend/ActionDispatcher` are required to actually handle these new triggers and correpsonding events - that's why they are loaded in `ModuleTemplate` and deprecated `DocumentTemplate`. Resolves: #91117 Releases: master Change-Id: Ie7012445d09c3aee253548cb3057c8e9e4b86809 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Apr 21, 2020
-
-
Daniel Siepmann authored
Resolves: #91155 Releases: master Change-Id: I8e26f7d9bb0c22dcb00cadc704cf8c61ffaf8c0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64293 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Christian Eßl authored
The fluidbased page layout refactoring done in #90882 missed two spots, where the no longer existing function getBackendLayout() is called on a GridObject. Resolves: #91162 Related: #90882 Releases: master Change-Id: I7d381fe35a02c4f1464f9c4bb9fc31b27ef02b1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64297 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
Change-Id: Ia7d214d29ca5fd958fd9c8169b2d76578cbeb511 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64292 Reviewed-by:
-
Benni Mack authored
Change-Id: I8f9c86cfb5a9785e6884ebd643127cac91bbbd67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64271 Tested-by:
-
Claus Due authored
Skip creation of the PageLayoutContext in PageLayoutController if the user has no access to the page, or if the ID parameter was malformed. Releases: master Resolves: #91147 Change-Id: Idd73aa7ba5e6b3a2b41429b1887ad8f9d1db45ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64259 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
In order to stabilize this API, all APIs are marked as internal in order to allow changes once Fluid-based page module is stable enough to remove the info in further patch-level releases. Resolves: #91153 Releases: master Change-Id: I26737e5ab89947fdcd7a0bf99c30310fce3b0a3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64268 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Apr 20, 2020
-
-
Oliver Bartsch authored
The check if a user is allowed to paste content from the clipboard now evaluates the content modify and content edit permissions instead of the page edit permission. This is done in both PageLayoutView and the fluid based page module. Resolves: #90961 Releases: master, 9.5 Change-Id: I65a29a9a6cf4ae4e73af28d1319d0b730fd5f5bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64105 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Benni Mack authored
Due to the fact that backend user objects have not been initialized properly in PSR-15 middlewares defining the current in-memory state for workspaces falls back to the users' default workspace. Basically `BackendUserAuthentication::groupData['workspace_perms']` was not initialized which results in the mentioned behavior for non-admin users. `fetchGroupData` was split up into public `initializeGroupData` to be used internally only and protected `enrichGroupData`. Resolves: #90954 Releases: master, 9.5 Change-Id: I75ad15ac600ca489b9951199482e97bcb54d1778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64264 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Benni Mack authored
Due to the replacment of DocumentTemplate with ModuleTemplate the rendering is now different. In order to overcome this, a new flag enableDocHeader is added. see https://review.typo3.org/c/Packages/TYPO3.CMS/+/63290 Resolves: #90834 Releases: master Change-Id: Ifb278f7dff1c9b1e18b09f7587dbe33caff13732 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64261 Reviewed-by:
-
Claus Due authored
Provide the correct UID for the "edit record" link which edits the default language page record when page module is in "Languages" mode and the edit icon in top of default language's column is clicked. Releases: master Resolves: #91146 Change-Id: I17c415efdcbf80737d05982ec90a4ac62ce5abea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64258 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Benni Mack authored
This patch prevents throwing and spamming the logs with 500 server errors. Resolves: #91145 Releases: master, 9.5 Change-Id: I9385a9c0a2a665cedb1340cc8397740b0bd6255e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64084 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Claus Due authored
Implements a PSR-14 event dispatched after LocalizationController has built the manifest of columns and column numbers, allowing third parties to change this manifest without XCLASS'ing LocalizationController. Releases: master Resolves: #90945 Change-Id: I5a7929512c498329841c51ceceba7b0d4c156594 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64071 Tested-by:
-
Claus Due authored
Refactoring with the goal of: * Restoring entity-like nature of BackendLayout * Decreasing coupling between components of the page module processing and rendering. Implements a PageLayoutContext to hold all context-related objects and methods and passes the context to objects instead of passing the BackendLayout. Reduces number of methods on DrawingConfiguration so the configuration object only holds output- and behavior-related options and does not hold things like permission checks. Releases: master Resolves: #90882 Change-Id: I09f1d97a53a76ea96d6cbc18bb5549127b5a1a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64002 Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * extracts inline JavaScript from controllers & templates * GlobalEventHandler is extended to deal with custom scenarios that acutally would trigger a browser navigate events (e.g. changing a select drop-down leads to a document refresh) * ActionDispatcher is introduced to listen and delegate events to global TYPO3 modules in `top` window scope Resolves: #91015 Releases: master Change-Id: I67bf70bba1890c0ef966a08d96823ad91b1d4167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64130 Tested-by:
-
Xavier Perseguers authored
Resolves: #91130 Related: #82990 Releases: master, 9.5 Change-Id: I8337f8d24fff67ac2c8f05f16de642f46e86cfd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64250 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- Apr 19, 2020
-
-
Oliver Hader authored
Module TYPO3/CMS/Core/DocumentService provides native JavaScript functions to detect DOM ready-state returning a Promise<Document>. `$(document).ready(() => {...});` can be replaced by `documentService.ready().then(() => {...});` Resolves: #91122 Releases: master Change-Id: Id812f786430f1ced6265493dd0bae472b8144588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64241 Tested-by: -
Andreas Fernandez authored
When the MultiStepWizard is used with additional click events bound to the next or prev button, those event got stacked as the buttons don't change per step. To fix this issue, all click events are removed after switching a step and the original click event to switch the step is bound again. Furthermore the 'savePath' for duplication of a form is now correctly set if there is only one folder available and therefore no select element present in the modal. Resolves: #91094 Releases: master Change-Id: Ic95d2222441c8e1e8cf9fb46e5e7437d4e4ed85e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64214 Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
- Apr 18, 2020
-
-
Oliver Hader authored
Superfluous inline events have been removed or replaced with native HTML functionality (location.href -> anchor). Resolves: #91110 Releases: master Change-Id: I594fe2df3c71234de096e437b5662867469ffbb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64229 Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Christian Eßl authored
Resolves: #91103 Releases: master Change-Id: If342b9bf69574b54d598e342c3bb2773dba582cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64224 Reviewed-by:
-
Oliver Hader authored
Using HTML form elements without actually making use of typical consumers (input, textarea, select, ...) seems to be superfluous. Resolves: #91101 Releases: master Change-Id: I37a6647f162a8b1f3f8394ad04458830abca0e26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64222 Tested-by:
-
Benni Mack authored
YAML configuration set in a site configuration under the main key "settings:" are now available as TypoScript constants in templates and as constants in page TSconfig. This feature is a replacement for the former page TSconfig functionality "TSFE.constants", which has been removed. A former replacement approach had to be reverted in v10.1. Resolves: #91080 Resolves: #91081 Releases: master Change-Id: Ia5cd4e94049a359a23418c1fdb122a0d5f8c7311 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64128 Tested-by:
-
- Apr 17, 2020
-
-
Andreas Fernandez authored
Resolves: #91099 Releases: master, 9.5 Change-Id: I08ea8ecfc7096a21b0ffddee0b4e3976363fffd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64219 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Benni Mack authored
In order to build a stronger Permission Handling system and a stronger API for TCA resolving in TYPO3 v11, several methods and public properties have been marked as "internal". These continue to be working as is for TYPO3 v10 LTS, but are now marked as internal - most of the code has been coming from PHP4 where no visibility restrictions have been available back then. Resolves: #91095 Releases: master Change-Id: Ibb47739a0cdec5eae19fafa2e376eeb609aa6c53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64162 Tested-by:
-
Andreas Fernandez authored
The page module now doesn't try to update the flag icon of a dragged record if the page module is not in "language" mode as the required information is not available. Resolves: #91096 Related: #90693 Releases: master Change-Id: I1c796a6f4b00761f3310335cf45256d75a7e3bc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64218 Tested-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/backend/Classes bin/rector process --set=php53 typo3/sysext/backend/Tests Releases: master Resolves: #91064 Change-Id: I9e91882ab233b0e34bc991fd348fceba197a91ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64187 Tested-by: -
Tymoteusz Motylewski authored
Do not calculate permissions for every page, as we're limiting the pages through SQL query constraints. Fetch sys_language_uid and l10n_parent from db as they are required for isInWebMount to prevent it from fetching row from db again. Pass full row to isInWebMount in calcPerms instead of just uid. isInWebMount has logic to handle translated records. Resolves: #91037 Related: #90105 Releases: 9.5, master Change-Id: I56dbaf3daa15aa8b6f0fc5e09b212aa34203a0b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64175 Tested-by:
-
- Apr 16, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` events. * extracts inline JavaScript from templates * introduces `TYPO3/CMS/Backend/GlobalEventHandler` module * adjusts PHP type-hints to their correct & actual values Resolves: #91052 Releases: master Change-Id: If92391bd48f89df57fbb0ed6f8b0936da0e1a49d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191 Tested-by:
-
Andreas Fernandez authored
Resolves: #91057 Related: #91008 Releases: master Change-Id: I448a7b2364996f55c98dfe92c3c566acdf3df3e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64196 Tested-by:
-
- Apr 15, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * allows `Modal` confirmation to emit `ModalResponseEvent` * extracts inline JavaScript from controllers & templates * introduces `BroadcastChannel` in `nav_frame` (folder tree) * uses plain links (`<a href="..."`) where applicable * updates folder tree when navigating in browser history Resolves: #91016 Releases: master Change-Id: Ied6a626e09df07bd1a240b9b6b4250cd6fff4c8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154 Tested-by:
-
Benni Mack authored
Due to the deprecation of "switchable controller actions", list_type items can now be grouped in FormEngine - as well as all other "select" fields defined in TCA. A new TCA option in TCA type=select is added, called "itemGroups". In addition, all "items" now have four parts (fourth being optional) 0 => label 1 => value 2 => icon 3 => groupID where the group belongs to an item group (defined explicitly) or taken from a --div-- element, which then turns into an optgroup. In order then to avoid the "itemProcFunc" of tt_content.list_type which is used to sort items, a "sortOrders" option is added to sort items (within a group, if grouping is enabled) by label or value. When registering a new plugin, the groupId can be added as well as an additional parameter, which falls back to the "default" group. A new method ExtensionManagementUtility::addTcaSelectItemGroup() allows to add item groups via API. When registering extbase Plugins or pibase plugins, it is possible to add a registered "group ID" to make use of this feature. Resolves: #91008 Resolves: #82352 Releases: master Change-Id: I8ad215b5cbc16f332e7c129d762fc020ade5ceeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63889 Tested-by:
-
Benni Mack authored
TYPO3's PHP-CS-Fixer configuration is adapted to move towards the PSR-12 standard by unifying the new statement and adding proper braces argument methods and arguments. Resolves: #91026 Releases: master Change-Id: If5eb945e18fb4a2330e3c9eeaf90134126638079 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64163 Tested-by:
-
Andreas Fernandez authored
Resolves: #90941 Releases: master Change-Id: If205ab5308c0f1bb7e935a53bebee41e7b9e2fd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64061 Tested-by:
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- Apr 14, 2020
-
-
Andreas Fernandez authored
The start up option "First module in menu" is a misleading in some ways. The select box e.g. has "dashboard" as first selectable option, but in such cases the "help_AboutAbout" module is loaded instead, for example. This is due the fact the first module is determined via querying the DOM for the first element matching the selector `.t3js-modulemenu-action[data-link]`. The behavior is now changed to load the first module as listed in the previously mentioned select box. Resolves: #91028 Releases: master Change-Id: I669a9b146f76f2513c51ff5f48128a1ea8b0c0a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64164 Tested-by:
-
Andreas Fernandez authored
To improve the user experience, the search filter in the "New Content Element" wizard is automatically focussed when the modal appears. Resolves: #91014 Releases: master Change-Id: I3e0f18bd454955af63cd797138de7b2118d9d2ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64129 Tested-by:
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by: -
Benni Mack authored
DataHandler does not set "-1" for versioned records in workspaces anymore, thus making it a lot easier to find the real PID for a versioned record without always having to fetch the live version for it. This is ground-breaking, as this opens the door for a lot of improvements when accessing versions via overlays. An upgrade wizard will migrate all pid=-1 records to their equivalent pids, and discard all already published / archived versions. Resolves: #89555 Releases: master Change-Id: I31c32451827c1f94764bb0ba22ad8207c8b3d4fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
- Apr 13, 2020
-
-
Benni Mack authored
Due to wrong prefixes of TCA type=slug fields for custom records e.g. in ext:news, a new configuration `prefix` is introduced. A `userFunc` can be assigned to the new field which then allows to provide a custom base url based on e.g. the correct detail page. The default behaviour, which is used for pages, is still applied, when no custom base url is given. Resolves: #89573 Releases: master Change-Id: I529ff26ddeba200b56f0c23aca55daa187c3f40d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62270 Tested-by:
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
