- Aug 10, 2023
-
-
Tomasz Woldański authored
This implements a rather unexpected detail when combining reference "=<" and copy "<" operator from old TypoScript parser. Copy operator: lib.source1 = TEXT lib.source1.value = source1Value lib.source2.otherValue = source2OtherValue tt_content.target < lib.source1 tt_content.target < lib.source2 Result: tt_content.target = TEXT tt_content.target.otherValue = source2OtherValue The tt_content.target existing value from lib.source1 is kept, but children are reset - lib.source1.value is not within tt_content.target anymore. Now reference first, then copy: lib.source1 = TEXT lib.source1.value = source1Value lib.source2.otherValue = source2OtherValue tt_content.target =< lib.source1 tt_content.target < lib.source2 Old parser after resolving reference in FE: tt_content.target = TEXT tt_content.target.value = source1Value tt_content.target.otherValue = source2OtherValue New parser after resolving reference in FE: tt_content.target = TEXT tt_content.target.otherValue = source2OtherValue The old parser keeps existing references when the copy operator does not reset the value to something else. The patch adapts the new parser to behave identical and refactors the AST copy method to better documented, more easy and eventually also quicker code. Resolves: #100115 Releases: main, 12.4 Change-Id: Ia03cefd6e550833bdc9120a179881d04bf70d117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80509 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Andreas Fernandez authored
This patch removes jQuery from the `@typo3/scheduler/scheduler` module in favor of native APIs. Extra fields are now hidden via the `hidden` attribute and not via CSS styling anymore. Resolves: #101619 Releases: main, 12.4 Change-Id: Ida87f82cde264785c8cd5b0d3619304bc6dfadfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80478 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benjamin Franzke authored
Also raise the fixed linters to error level in order to not introduce similar errors again. The linter @typescript-eslint/no-explicit-any is disabled for now, in order for errors to be visible at first glance. Resolves: #101645 Releases: main, 12.4 Change-Id: I48229f148298ac13acd6d12deb55d606a3c7ef59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80504 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Benjamin Franzke authored
Missing declarations caused some method calls and assignments to not be type checked, as all members of the (top.|window.)TYPO3 object were declared to `any`. This actually revealed some invalid API usage. which is fixed as a drive-by. (No real bugs were found, as type checking in the APIs caught/ignored such cases) Resolves: #101644 Releases: main, 12.4 Change-Id: I2e188e53a02d9e0ae875084cadc28600c7a59aa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80502 Reviewed-by:
-
Andreas Fernandez authored
Executed commands: npm install --save bootstrap@^5.3.1 npm run build Resolves: #101629 Releases: main, 12.4 Change-Id: Idcb9f78543e945e0e948a19bb2574827b15806b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80493 Tested-by:
-
- Aug 09, 2023
-
-
Ernesto Baschny authored
In case you add a new TCA field of type "slug" in the pages table but without a config "eval", you get an exception in the backend. Resolves: #101640 Related: #93640 Releases: main, 12.4, 11.5 Change-Id: Ia9fc65707c581c288101eb9d54957aa9d025b98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80497 Tested-by:
-
Oliver Klee authored
Fix a case where the name of the testcase did not follow the name of the tested class. Resolves: #101631 Releases: main, 12.4 Change-Id: Ic5225f692c8610b18769bbceb5acdb427ef4c5d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80477 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Aug 08, 2023
-
-
Oliver Klee authored
This change fixes places where the code violates the contract. Also, the change will avoid type errors when the `GeneralUtility` array functions are switched to native type declarations. All of these changes fix places where the acceptance test break with the GU array methods using native type declarations. Resolves: #101616 Related: #101453 Releases: main, 12.4 Change-Id: I6f86f7a371d50b20a34275ebc771604d407917bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80476 Tested-by:
-
Stephan Bauer authored
Releases: main, 12.4, 11.5 Resolves: #101620 Change-Id: I18563030fd382331a1389c500f313e28383901d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80475 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow current best practices. This changes tackles the classes where we can mock an interface instead of an abstract class, allowing us to use `createMock` instead of `getMockForAbstractClass`. Resolves: #101609 Related: #101601 Releases: main, 12.4 Change-Id: I995f70d779a1bc6251bc4479c3dcb2ee548314f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80458 Reviewed-by:
-
Jürgen Venne authored
The "global" extbase/Tests/Fixtures folder is unfortunate: Fixtures should be located in more dedicated folders and should not be shareable between unit and functional tests. The patch moves a couple of fixtures to more dedicated locations to avoid confusion. Resolves: #101530 Releases: main, 12.4 Change-Id: I3faad97ca05e7790da8443d615309da03ff91201 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80457 Tested-by:
-
Daniel Hettler authored
The URL param '_stg_debug' is needed to call the debug mode on-site Resolves: #101613 Releases: main, 11.5, 12.4 Change-Id: Iff94ede5c3d388fe8b130e10e5b48658511a0bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80472 Tested-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
-
Benjamin Franzke authored
New runTests.sh option "-g" opens a tab in a local browser pointing to http://localhost:7900/?autoconnect=1. This allows watching acceptance tests clicking around. Releases: main, 12.4, 11.5 Resolves: #101611 Change-Id: I53cbb861d7df6daac96dfcc382183f46847d7894 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80367 Tested-by:
-
Benni Mack authored
Change-Id: I46f8b5ca905e3661ad63d8f8d6e491c9c729a8ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80453 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
Change-Id: Ibdd8edc8f940289469c925b969415c7790c20a61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80452 Tested-by:
-
- Aug 07, 2023
-
-
Andreas Fernandez authored
The module menu is currently in a bad shape where different loose DOM elements and scripts are tangled together and do stuff. Previously, the module state was stored as a JSON-encoded string in the container of the actual module menu, which isn't refreshed when the module menu is reloaded via AJAX, leading to endless "loading" modules a freshly installed extension may add. Also, the JSON string gets parsed once and is then cached for faster access times. This patch accomplished multiple things: * the module state information is moved to the `nav` element of the module menu that's part of the reload process, always having the current state * an internal `flushModuleCache()` function is introduced to clear the cached, parsed state This is not an ideal solution but the best way the issue can be fixed in short-term. In long-term, the whole module structure and its handling need refactoring. Resolves: #100493 Releases: main, 12.4 Change-Id: I28342d7b207638e307c2ca7f4f50f2f4e6d27dbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80366 Tested-by:
-
Oliver Bartsch authored
Resolves: #101605 Releases: main, 12.4 Change-Id: I1da8af5b5b0025ad0f25349fe6d4893eddbd5eaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80432 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Thomas Hohn authored
Moved assignment of $destPid = $sortInfo['pid'] after check if $sortInfo is an array, since the method call to getSortNumber can return other values than an array. Resolves: #101606 Releases: main, 12.4, 11.5 Change-Id: I3cfef35b351a0cd1fa8197702cce9e3b05871fcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80431 Tested-by:
-
Christian Kuhn authored
Remove -j and -k and only use -i to specify database versions. This is more easy to use, parse and validate. Resolves: #101604 Releases: main, 12.4, 11.5 Change-Id: Ie6b9343c6f244a294d636f0e5c09d24c5e1845fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80428 Tested-by:
-
- Aug 06, 2023
-
-
Rémy DANIEL authored
Linkvalidator extension has a couple of known issues, especially with external link checking. Those issues are now documented, so integrators can acknowledge them and implement counter-measures. Resolves: #101597 Releases: main, 12.4, 11.5 Change-Id: I00dc01243426fc56c21a4bd11815c3009e3dd3ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80364 Tested-by:
-
Christian Kuhn authored
Fix a happy little regex to deal with "TCEforms" removal of #97126. This should fix finisher override FormEngine rendering. Resolves: #101050 Related: #97126 Releases: main, 12.4 Change-Id: Ia8d893c3f3b31f7af83b3d9f2ae533b3e557f5a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80363 Tested-by:
-
Chris Müller authored
Resolves: #101600 Related: #101114 Releases: 12.4 Change-Id: I9893e4c8b8eff5e05575984ab37e7f22612b26a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80420 Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Chris Müller authored
In some cases, classes are displayed like "TYPO3CMSCoreTypeContextualFeedbackSeverity" as backslashes are neither quotes not enclosed in a ":php:" directive. Where appropriate, we now link to the source code directly instead of just mentioning a class (with ":t3src:)". This is helpful, for example, for the severity enum, when you just want to know the available cases. Additionally, other mentions of PHP classes are now enclosed in a ":php:" directive instead double ticks. Resolves: #101599 Releases: main, 12.4 Change-Id: I2b384e388e6b6544c0a534a2bb23e97bc7c7fc1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80419 Tested-by:
-
- Aug 05, 2023
-
-
Christian Spoo authored
`PersistedAliasMapper` and `PersistentPatternMapper` both should only use int-like string route arguments as possible UID candidates for the following DB lookup. Thus, check if the arguments are truly numerical before passing them to the database queries. Resolves: #93105 Releases: main, 12.4 Change-Id: Ic3b9b5415abfce602b6be7c8031202823ea25e60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80416 Tested-by:
-
Sebastian Klein authored
Extensions can provide static data using the file "ext_tables_static+adt.sql". If this file exists, a button is automatically created in the Extension Manager. As soon as you click the button, the static SQL data will be imported. Existing data will be dropped. A new modal now warns the user before executing the file, with buttons to start or abort the task. Resolves: #100118 Releases: main, 12.4 Change-Id: Ie33a89d6957428f390edeaa2700639bc13ac8b7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80362 Tested-by:
-
Rémy DANIEL authored
If the svg-tree component is embedded in an iframe, and if the iframe src get changed by navigating to another url, pending AjaxRequest will be cancelled by the browser, without letting us the opportunity to properly catch the thrown error. As a workaround, we register an unload event on the iframe's window, and mute notifications to the user. Resolves: #101340 Releases: main, 12.4, 11.5 Change-Id: I8572fde4bf278481a32a459f802af69356ce28a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80361 Tested-by:
-
Gordon Brüggemann authored
Resolves: #99725 Releases: main, 12.4, 11.5 Change-Id: I4682cbe57b4908e13c219c5be4b0810c0d348bf1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80412 Tested-by:
-
Torben Hansen authored
With the introduction of configurable password policies, the `PasswordPolicyValidator` has been introduced. The class is however marked as `@internal`, which basically was a mistake. 3rd party extensions providing users the possibility to change a password should be able to validate the new password against the globally configured password policy by using the `isValidPassword()` method in the `PasswordPolicyValidator` class. The change therefore mark the class as public API by removing the `@internal` annotation. Resolves: #101579 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I8869a8465199a2c071d3d780af640a0c903404c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80357 Tested-by:
-
Oliver Bartsch authored
Resolves: #101592 Releases: main, 12.4 Change-Id: I56e7f9c4f7768d4034bc267261e3a31ecff4ff4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80410 Tested-by:
-
Oliver Bartsch authored
The listener identifier is now exposed into the ListenerProvider, making this information available, e.g. in the configuration module. Resolves: #101584 Releases: main, 12.4 Change-Id: I3dbcc4182532c6da0239d0e7bd715e081d1c283e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80401 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #101583 Releases: main, 12.4 Change-Id: Ie32b0ba494364b9a0d129f79d7b153243395efbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80360 Tested-by:
-
Anja Leichsenring authored
New ISO data has been published, so we update our set. Resolves: #101582 Releases: main, 12.4 Change-Id: I42bb256121a2dc66d350a8c3e5fbc563abe5310b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80359 Reviewed-by:
-
Daniel Siepmann authored
Ignore missing sys_csp_resolution table and return empty result instead of breaking the installation. Resolves: #101570 Releases: main, 12.4 Change-Id: Id6834e5c0fdb530a2f2fb3a90bef4c223bed1734 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80358 Reviewed-by:
-
- Aug 04, 2023
-
-
Sascha Nowak authored
Resolves: #101577 Releases: 12.4, main Change-Id: If2093146c7066e37881e43ff96c527f5e1efd482 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80356 Tested-by:
-
linawolf authored
The 5th parameter of ExtensionUtility::registerPlugin is thegroup and not `ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT` Fixes the name to the correct function and adds example code. Resolves: #101575 Releases: main, 12.4, 11.5 Change-Id: I05a344ee11aaa8a9b3187a11528e2e506f47756d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80354 Tested-by:
-
Lukas Maxheim authored
* This commit updates the command "redirects:checkintegrity" to use the table format for clearer and more organized output. * Now, the list of hits will be presented in a user-friendly tabular layout, improving readability and overall user experience. Resolves: #99492 Releases: main, 12.4 Change-Id: Id20cb2f39ff797786c2080557db0a993a987b32e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80393 Tested-by:
-
Anja Leichsenring authored
Releases: main, 12.4, 11.5 Resolves: #101574 Change-Id: I6617e9c31a20b84269ae708d177b4ebf81ba97d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80229 Reviewed-by:
-
Stefan Bürk authored
Resolves: #101552 Releases: main, 12.4, 11.5 Change-Id: If9f12fa195f119b715e163c578188d8634b68b50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80315 Tested-by:
-
Christian Spoo authored
parent::__construct() of MemcachedBackend calls setCompression() which determines compression based on state of $this->usePeclModule. This property needs to be set before parent::__construct() is called. Resolves: #99495 Releases: main, 12.4, 11.5 Change-Id: Ibc6c3a2378c5187748b4394d440232600de193e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80387 Tested-by:
-
Tobias Liebig authored
This test checks lowlevel things like usergroup to be changed by GeneralUtility::fixPermissions(). Various tests in this area have been disabled on Windows already. They are problematic in macOS driven docker as well since macOS heavily messes around with access rights. We give up on this now, and reduce the details test checks of GeneralUtility::fixPermissions() a bit by removing that test. Resolves: #101568 Releases: main, 12.4, 11.5 Change-Id: I36e781302285dc1966633723abdc8f15bf84ef06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80382 Tested-by:
-
