- Apr 23, 2019
-
-
Benjamin Kott authored
The indentations in the HTML templates are out of control. Even if we provide an EditorConfig, which should ensure that the files are all uniformly indented. There seems to have been an increasing aversion to TABS over time. This has led to the fact that above all newly created templates have always been indented with SPACES instead of TABS. We now have a mix of TABS and SPACES in our project, partly also in a single file. To avoid this in the future, all existing templates were converted to indentations with SPACES and the provided EditorConfig was adapted. In order to really, really make sure that it doesn't get out of hand, we also introduce a new linter, which ensures that all HTML templates are properly indented. Resolves: #88180 Releases: master Change-Id: I86d23120bc68e3696f398b1ae76f1efc4804d501 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60522 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Wand <wand@itaw.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Daniel Goerz authored
The implementation of storing the depth selection in the workspace module did not account for the "This site" option and the according value "0". With this patch now all options of the depth selector can be stored and loaded from UC. Resolves: #88168 Releases: master, 9.5 Change-Id: I21ea3a4e300dbb71516679ea9f5ac901364b0c4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60508 Reviewed-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Apr 19, 2019
-
-
Benni Mack authored
Workspaces had a field called "unpublish_time" which was not accessible for TYPO3 Core since TYPO3 4.5. The field was still processed, but never in use due to side-effects. The functionality has therefore been removed without substitution. Resolves: #81950 Releases: master Change-Id: I6d79b78246103ef485a4d9d0de791b03d10d08a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60482 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
Currently, when searching a term in CodeMirror (used in EXT:t3editor), the search bar disappears when after the operation, which is super annoying. The configuration of CodeMirror is slightly changed to keep the search bar always present until closed explicitly. Resolves: #88162 Releases: master, 9.5 Change-Id: I8780d9b10816c1667c14b0a23f50428a5f081579 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60490 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Sven Juergens <typo3@blue-side.de> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Susanne Moog authored
Symfony/routing 4.2.7 changed routing behaviour, breaking backwards compatibility and our implementation. Reported at symfony: https://github.com/symfony/symfony/pull/31107#issuecomment-484681404 Mark that version as conflict until the behaviour is fixed. Composer commands: - composer update --lock Resolves: #88171 Releases: master, 9.5 Change-Id: I6f2651a605c6339222626d37c307c04b8f0eadf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60509 Tested-by:
-
- Apr 18, 2019
-
-
Benni Mack authored
A simple typo. In TYPO3 v9.5 there need to be more adjustments done. Resolves: #88007 Releases: master, 9.5 Change-Id: I6cd49b18b048b0e3b4362fc53c89a4617914f913 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60505 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Benni Mack authored
As there is no "pid" available, the new button on new records should not be shown. Resolves: #87721 Releases: master, 9.5 Change-Id: Ie3521882e38f031d3362de841351b058faed9521 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60506 Tested-by:
-
Benni Mack authored
Calling just "index.php" without "id" and "type" parameter should work as expected, as before. Resolves: #88028 Releases: master, 9.5 Change-Id: I36df591b8b334b9b5908563ca554cab98acba32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60503 Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Marco Kaiser authored
Calling something like bla.example.com/?id=34&type=2 runs in a endless loop. The change removes the restrictive redirect. Change-Id: I0457c48640d6b47a0947ed5115a96cf73cc97d81 Resolves: #88032 Releases: master, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59891 Tested-by:
-
Daniel Goerz authored
This patch fixes a regression introduced with https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/60492/ Resolves: #43338 Releases: master, 9.5 Change-Id: I3ac8445ec21097531ff1dcb5e33d0ff271332be3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60495 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Apr 17, 2019
-
-
Benni Mack authored
The stage dialog shows various users relevent in a workspace that should be notified. However, it is hard for editors (UX wise) to uncheck / check everybody when a single element should be pushed into the next stage. The patch adds two buttons to toggle the checkboxes (check/uncheck all). Resolves: #59228 Releases: master, 9.5 Change-Id: I2ebbcb7ec2d46b50880f93aefd243ef791300a2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60494 Tested-by:
-
Benni Mack authored
The depth selector is now stored in the users' UC, so the Persisent Storage API can now be used easily. This way, when changing pages, the depth selector value is kept. Resolves: #43338 Releases: master, 9.5 Change-Id: I8fd49556e24f717cfa1b9e881a603f5adf5ce617 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60492 Tested-by:
-
Jonas Schwabe authored
Sites with error handling were not rendering the correct page for disabled languages because an inaccessible language was used internally. Resolves: #87865 Releases: master, 9.5 Change-Id: I8f6219d742c74359e0009085711f5452dc139f40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60212 Tested-by:
Jonas Schwabe <jonas.schwabe@eyeworkers.de> Tested-by:
-
Benni Mack authored
If no previous result given, an exception should be thrown, instead of a PHP error. Resolves: #88133 Releases: master, 9.5 Change-Id: I708e735e664589b0fc8d125a60b9970128b584af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60474 Tested-by:
-
- Apr 16, 2019
-
-
Stephan Großberndt authored
Add the missing documentation of the hooks * `password_changed` added in TYPO3 4.3 * `login_error` added in TYPO3 6.0 Releases: master, 9.5, 8.7 Resolves: #88131 Related: #87726, #29698 Change-Id: I0dc875a399da58e13b15225e173392565c64bb03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60443 Tested-by:
Julian Geils <j_geils@web.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Benni Mack authored
Some minor remarks are changed within the Workspace Module (ReviewController). - The preview link in docheader now has a text (makes it readable for newcomers) - The checkboxes are now in the first column - The modal box is bigger for increased readability Resolves: #88151 Releases: master, 9.5 Change-Id: I2bbc581d73b0263d77029c533381c52f527dac42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60476 Tested-by:
-
- Apr 15, 2019
-
-
Guido Schmechel authored
The possibility to define the properties changefreq and priority for XML sitemap entries has been implemented. Resolves: #87433 Releases: master Change-Id: I90b8c59ff916110be19aa8e8c888e77f25649bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59834 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Benni Mack authored
Labels regarding sys_workspaces are now in the same file, and the fields / tabs have been grouped to ensure workspace admins can work more efficiently with the records. This way, the functionality is more self-explaining. Resolves: #88152 Releases: master, 9.5 Change-Id: Ie55eada9956375bf0533affde80a927bcebb3502 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60479 Tested-by:
-
Benni Mack authored
When combining or scaling images, the quality setting needs to be applied as well. Resolves: #31664 Releases: master, 9.5 Change-Id: Iab4d7247c1ee51483b9ede705f6c61ba11f37589 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60464 Tested-by:
-
Helmut Hummel authored
Resolves: #87687 Releases: master, 9.5 Change-Id: I8113f3fa2facf6b21bc19ee1c445265c5ff4f4b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59872 Tested-by:
-
- Apr 14, 2019
-
-
Helmut Hummel authored
Only dealing with PHP file resource in writers is not enough to properly initialize a logger on wakeup. A logger has to log with a new request IDs and possibly completely new writers and processors due to configuration changes in the meantime. Therefore the __sleep and __wakeup methods are removed in the FileWriter and new methods are added to the logger instance to make sure a wakeup will have a correctly configured logger instance. Resolves: #86941 Resolves: #87261 Releases: master, 9.5 Change-Id: Ia36e251404eae2bdf0dfdf52ace7dcf1815ec456 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60325 Tested-by:
Ralf Merz <mail@merzilla.de> Tested-by:
-
Jan Delius authored
Within SiteTcaConfiguration, the $finder is now reused as much as possible. A new clean instance is used for the individual actions. Resolves: #87832 Releases: master, 9.5 Change-Id: I34f2d08c51042f2cfe6b4a09ac6152e0b552ab14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59839 Tested-by:
Rico Drexler <rico.drexler@gmx.de> Tested-by:
-
Remo Häusler authored
TYPO3 should silently ignore errors and warnings in svg images. Resolves: #86428 Releases: master, 9.5, 8.7 Change-Id: I54bb19ac0a6c949a8b150808f52562b73653e739 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59802 Tested-by:
-
Alexander Schnitzler authored
This patch removes support for the configuration of persistence related classes via typoscript. This is done as typoscript is too variable, i.e. the configuration may change depending on the day, the hour and whatever possibility typoscript has when it comes to conditions. The functionality must not vanish completely, but the configuration should be immutable and predictable at an early stage of the runtime. To achieve this, the configuration has to be added to files like EXT:Configuration/Extbase/Persistence/Classes.php This patch is considered breaking as the configuration via typoscript stops working immediately and the configuration syntax slightly changed. The easiest way to migrate to the new syntax is to have a look at configuration files in core extensions. Releases: master Resolves: #87623 Change-Id: Id1ceceafd10ec647507bca8078ebf62fe1b02d2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59570 Tested-by:
-
Benni Mack authored
There is a copy/paste typo in LocalCropScaleMaskHelper, which was introduced in TYPO3 v8. The setting $TYPO3_CONF_VARS[GFX][processor_stripColorProfileCommand] is the correct one. Resolves: #87548 Releases: master, 9.5 Change-Id: I4f9e4f3f62e1b577a986c96a31d4438da1bc7f74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60465 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Benni Mack authored
As part of using the SiteBased translation model instead of the legacy TypoScript settings, another test suite is added which mimics the exact same settings and results as in TypoScript for Extbase. Resolves: #88142 Releases: master, 9.5 Change-Id: Ieaa2e0d6cb510e6e00555e848020d89e8e1f5670 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60461 Tested-by:
-
- Apr 13, 2019
-
-
Andreas Fernandez authored
This patch migrates FormEngine's SelectElementTree to TypeScript. Also, a terrible hack that puts the local tree initialitation callback into global scope has been removed. Resolves: #87987 Releases: master Change-Id: Ib34ae7fe4ac1e197af2183b8890cc72e13a900e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60316 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
- Apr 12, 2019
-
-
Julian Wundrak authored
If there are e.g., records that have no translation, the HrefLangGenerator outputs the site-base URL. Expected is that the entry for this page is suppressed. Change-Id: I6fbd4dd00955906dff13c0e5aceea6804c52dd1b Resolves: #88032 Releases: master, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60350 Tested-by:
-
Benni Mack authored
If page.includeCSS.myfile.import = 1 is used, but no "media" is set, a TypeError is thrown, which is now caught and properly checked. Resolves: #88059 Releases: master, 9.5 Change-Id: I0951688bb9ee779329ebe5c7fad698862d73f6c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60420 Tested-by:
-
Benni Mack authored
This "feature" solves a lot of issues, but I really wanted to make sure to cover the generic issues around this topic. In order to understand this, we need to understand the different logic when talking about "language fallbacks", but I don't want to warm up how it was before. This is how it works: - fallbackChain: defines which page translation should be checked when linking or resolving a page in a specific language - fallbackType: Now that we covered all relevant cases, the naming could be better, but here we go, it's actually defining the logic for fetching content. - fallbackType="strict" -> only show the content that is viable in the target language but this is based on "overlays". Fetch all "language=0" records, do overlays and remove the ones that have no overlays. However, take the ones that have no language parent and render them as well ("includeWithoutDefaultTranlsation") This is what we call "do overlays with floating". This is recommended to do in most classic translation cases, with different languages - fallbackType="fallback" -> Do overlays: Fetch all "language=0" records, do overlays but KEEP the ones that have no overlays. However, take the ones that have no language parent and render them as well ("includeWithoutDefaultTranlsation") This is what we call "do overlays in mixed mode". Useful if your translation is Swiss-German but your default language is "German" - fallbackType="free" - Do not do overlays, just fetch all records of the target language Could be seen as "free mode" as we do it in TYPO3 Page module. The new free option is therefore new, also the "fallback" functionality is actually showing more content than before (thus, different, but maybe we could fix that!) as we have the "mixed" mode back. Also the "language fallback" is now possible for any fallbackType. Now, what's still missing - but out of scope - is actually a way to fetch content with multiple possibilities for overlaying. I call this "forward language overlays" however, this is a feature that is theoretically possible but not in v9 anymore. This patch restores the max. types of use cases back for TYPO3 Core. The following things that are really gone for good now and won't come back: - config.sys_language_mode = ignore - config.sys_language_mode = - Option includeRecordsWithoutDefaultTranslation (= always enabled) is not needed anymore Also, there are no ways anymore to use inconsistent multiple TypoScript settings which do not make sense depending if the translated page does not exist (l18n_cfg) but still using TypoScript conditions for that. Resolves: #86762 Resolves: #86712 Releases: master, 9.5 Change-Id: I8b3144410f7d7ed1d705d42f16a46f190275387a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60367 Tested-by:Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com> Tested-by: Steven Hilgendorff Tested-by:
-
Benni Mack authored
In order to see the current behaviour in workspaces when modifying pages, the slug field is added to the existing "Regular" DataHandler tests within workspaces. Resolves: #87904 Releases: master, 9.5 Change-Id: Ie2432fb078f2b04515a24de7b525b1c151186b05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60242 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Frank Naegler authored
Resolves: #88040 Releases: master Change-Id: I5408c30fef735fe52a4b58bda3fb5b4d3b8e002e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60353 Tested-by:
-
Frank Naegler authored
Resolves: #87915 Releases: master Change-Id: I4a7fa727c47b85bfae728f0a1dab0e6e833063ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60250 Tested-by:
-
Frank Naegler authored
Resolves: #88038 Releases: master Change-Id: I0441df6756bb4950b7875c74eed0e5bfff7625a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60352 Tested-by:
-
Benni Mack authored
The existing TypoScript functionality config.cache.all = ... allows a list of tables and PIDs to take into account other records for the current page caches. The cache lifetime of page 42 takes starttime and endtime of news records of page 15 and addresses of page 16 into account: config.cache.42 = tt_news:15,tt_address:16 A new functionality used with "current" allows to take records of the current page into account as well. config.cache.all = fe_users:current Resolves: #83734 Releases: master Change-Id: Ib2063cc89e2c1549b7609b77948243e983d14c1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60419 Tested-by:
Fabien Udriot <fudriot@omic.ch> Reviewed-by:
-
Benni Mack authored
<f:form.select.option> uses the FQDN::class syntax, so late static binding (LSB) is leading to side effects when extending <f:form.select>. Using the self::class syntax in <f:form.select> solves the issue. Resolves: #88017 Releases: master, 9.5 Change-Id: Ic060267cdff06856d1aa0f76980124ecfc0967a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60436 Reviewed-by:
-
- Apr 11, 2019
-
-
Helmut Hummel authored
The cli binary path is changed to be located in TYPO3_PATH_WEB instead of TYPO3_PATH_ROOT. Releases: 9.5, master Resolves: #88088 Change-Id: I96587254d121149b58f35b0abb0084a89a31b0c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60371 Tested-by:
-
- Apr 10, 2019
-
-
Benni Mack authored
When building JOINs with TypoScript of tt_content or any localized table, using "LEFTJOIN tt_content table2" the language restriction check is not using a prefix for the "l10n_parent" field. The "sys_language_uid" field already has the same prefix built in the same method. This error existed in v8 already, but in TYPO3 v9, the "includeRecordsWithoutDefaultTranslation" option is enabled by default (via LanguageAspect), therefore it's more prominent. Resolves: #87521 Releases: master, 9.5 Change-Id: I1a3ee4f1f84d64a5d56cf63607a7aed83fdd13fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60430 Tested-by:
-
Stefan Frömken authored
Releases: master Resolves: #88117 Change-Id: I5fa5da8f6697a74eda785c4655203f9d63c7b632 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60424 Tested-by:
-
Benni Mack authored
Although the documentation and the internal code allows File and FileReference, the functionality requires a FileReference. FileInterface is more appropriate and $cObj->imageLinkWrap() can deal with File and FileReference. Resolves: #82101 Releases: master, 9.5 Change-Id: I37e4f091fe0598509eef050cb811ad7627f16c21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60435 Tested-by:
-
