[BUGFIX] Do not use LSB in <f:form.select>

<f:form.select.option> uses the FQDN::class
syntax, so late static binding (LSB) is leading
to side effects when extending <f:form.select>.

Using the self::class syntax in <f:form.select>
solves the issue.

Resolves: #88017
Releases: master, 9.5
Change-Id: Ic060267cdff06856d1aa0f76980124ecfc0967a5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60436


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Benni Mack <benni@typo3.org>

typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php

@@ -146,8 +146,9 @@ class SelectViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
             }
             // save the parent field name so that any child f:form.select.option
             // tag will know to call registerFieldNameForFormTokenGeneration
+            // this is the reason why "self::class" is used instead of static::class (no LSB)
             $this->viewHelperVariableContainer->addOrUpdate(
-                static::class,
+                self::class,
                 'registerFieldNameForFormTokenGeneration',
                 $name
             );
@@ -155,12 +156,12 @@ class SelectViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
             $this->registerFieldNameForFormTokenGeneration($name);
         }
 
-        $this->viewHelperVariableContainer->addOrUpdate(static::class, 'selectedValue', $this->getSelectedValue());
+        $this->viewHelperVariableContainer->addOrUpdate(self::class, 'selectedValue', $this->getSelectedValue());
         $prependContent = $this->renderPrependOptionTag();
         $tagContent = $this->renderOptionTags($options);
         $childContent = $this->renderChildren();
-        $this->viewHelperVariableContainer->remove(static::class, 'selectedValue');
-        $this->viewHelperVariableContainer->remove(static::class, 'registerFieldNameForFormTokenGeneration');
+        $this->viewHelperVariableContainer->remove(self::class, 'selectedValue');
+        $this->viewHelperVariableContainer->remove(self::class, 'registerFieldNameForFormTokenGeneration');
         if (isset($this->arguments['optionsAfterContent']) && $this->arguments['optionsAfterContent']) {
             $tagContent = $childContent . $tagContent;
         } else {