- Feb 13, 2024
-
-
Andreas Kienast authored
This commit updates ckeditor5 to v41.1. See changelog at https://github.com/ckeditor/ckeditor5/releases/tag/v41.1.0. Executed commands: npm i --save \ @ckeditor/ckeditor5-alignment@^41.1.0 \ @ckeditor/ckeditor5-autoformat@^41.1.0 \ @ckeditor/ckeditor5-basic-styles@^41.1.0 \ @ckeditor/ckeditor5-block-quote@^41.1.0 \ @ckeditor/ckeditor5-clipboard@^41.1.0 \ @ckeditor/ckeditor5-code-block@^41.1.0 \ @ckeditor/ckeditor5-core@^41.1.0 \ @ckeditor/ckeditor5-editor-classic@^41.1.0 \ @ckeditor/ckeditor5-engine@^41.1.0 \ @ckeditor/ckeditor5-essentials@^41.1.0 \ @ckeditor/ckeditor5-find-and-replace@^41.1.0 \ @ckeditor/ckeditor5-heading@^41.1.0 \ @ckeditor/ckeditor5-horizontal-line@^41.1.0 \ @ckeditor/ckeditor5-html-support@^41.1.0 \ @ckeditor/ckeditor5-indent@^41.1.0 \ @ckeditor/ckeditor5-link@^41.1.0 \ @ckeditor/ckeditor5-list@^41.1.0 \ @ckeditor/ckeditor5-paragraph@^41.1.0 \ @ckeditor/ckeditor5-paste-from-office@^41.1.0 \ @ckeditor/ckeditor5-remove-format@^41.1.0 \ @ckeditor/ckeditor5-show-blocks@^41.1.0 \ @ckeditor/ckeditor5-source-editing@^41.1.0 \ @ckeditor/ckeditor5-special-characters@^41.1.0 \ @ckeditor/ckeditor5-style@^41.1.0 \ @ckeditor/ckeditor5-table@^41.1.0 \ @ckeditor/ckeditor5-theme-lark@^41.1.0 \ @ckeditor/ckeditor5-ui@^41.1.0 \ @ckeditor/ckeditor5-undo@^41.1.0 \ @ckeditor/ckeditor5-utils@^41.1.0 \ @ckeditor/ckeditor5-word-count@^41.1.0 npm i --save-dev \ @ckeditor/ckeditor5-dev-utils@^39.6.0 npm run build Resolves: #103069 Releases: main, 12.4 Change-Id: I571ccb8d8531108f99272f6c4cf11c351d3f5692 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82852 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
The database column defined by TCA ctrl 'origUid' ('t3_origuid') had a bumpy ride over the years. It was mostly obsoleted in v8 with the introduction of 'translationSource' ('l10n_source'). A patch to fully remove it with #88495 has been reverted with #88501, leaving the field in limbo. The only remaining "true" usage of 'origUid' is in an inline relation scenario in DataMapProcessor when an inline parent *is* localizable (TCA ctrl 'languageField' and 'transOrigPointerField' set), but a child *is not*: Due to the copy strategy of all inline children upon localization of a parent record, the core needs to know if a child exists already or needs to be created. 'origUid' then stores the uid of the default language child. A couple of tests refer to this scenario as "monoglot" children. We could potentially get rid of that scenario by postulating that an inline child has to be localizable as well if the parent is, but that decision can be taken later. The patch does not touch this scenario, but looks at 'origUid' from a different perspective: If a table *is* localizable, or is not used as inline child, then 'origUid' is not needed. The patch thus removes TCA ctrl 'origUid' from TCA tables, keeping it only in the test scenario extensions 'test_irre_csv', 'test_irre_foreignfield' and 'test_irre_foreignfield_non_ws'. The bulk of the patch is about removing 't3_origuid' from the functional test .csv fixture files, while the most important TCA changes are dropping ctrl 'origUid' from table 'pages' and 'tt_content'. Resolves: #103099 Related: #79856 Related: #88494 Related: #88495 Related: #88501 Releases: main Change-Id: I622afde74294c389639974d312f121d0a6466b60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82888 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
The constant editor has been revamped with #98357 using the new TypoScript parser introduced with TYPO3 v12 under the hood. For category and subCategory handling lower-cased keys have been used, missing to lower-case the custom categories and subcategories names (keys) integrator are able to add since aeons. That leads to a failing match later on, and adding constants to the generic `other` subcategory. The revamped code supports only one category per subCategory sorting value. The documentation say that this **should** be omitted, but it worked in the past and broke with the revamped implementation. This change fixes muliple issues with the constant editor: * Ensure that custom categories and subcategories are read lower-case, otherwise later lookup will fail and sorted into sub-categorie `other`. * Add addtional array level to have `subCategory->items` per second sorting value as array (to avoid overriding). * Add additional item loop to the fluid template to respect the additional array level. Note: In the past it was possible to display a constant in multiple categories/subcategories by adding them again with different category configure comment lines. This is not supported anymore and not considered as bug. Resolves: #103088 Related: #98357 Related: #97816 Releases: main, 12.4 Change-Id: I4403420cc957cdef4bf077365deac0f7af621c71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82898 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Thomas Anders <me@naderio.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Hader authored
Write access to table `sys_file` is denied per default, unless data is being imported. In addition, write access to related FAL entities `sys_file_reference` and `sys_file_metadata` is denied in case a file on legacy storage (uid=0) is used or corresponding user does not have permissions to access a particular file. Resolves: #93969 Releases: main, 13.0, 12.4, 11.5 Change-Id: Ic8ac7132d732bd117aa63f6a33545ceb1d1f421d Security-Bulletin: TYPO3-CORE-SA-2024-006 Security-References: CVE-2024-25121 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82962 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benjamin Franzke authored
Resolves: #93571 Releases: main, 13.0, 12.4, 11.5 Change-Id: I9622bfa47ef9637cecaff4a790f742445f598682 Security-Bulletin: TYPO3-CORE-SA-2024-005 Security-References: CVE-2024-25120 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82961 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benjamin Franzke authored
The encryptionKey is a secret that must never be sent within any request, therefore it is now dropped from the editing interface in "Configure Installation-Wide Options". The log file writer has been adapted to be aware of the fact that the encryption key might not be set when TYPO3 has not yet been installed (which is the case when `vendor/bin/typo3 setup` is executed). Resolves: #103046 Releases: main, 13.0, 12.4, 11.5 Change-Id: I260a8a2e9af29908543dfe48ac3658d8c45cc440 Security-Bulletin: TYPO3-CORE-SA-2024-004 Security-References: CVE-2024-25119 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82960 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Hader authored
Backend form fields of TCA `type=password` should never expose the persisted value - especially, in case the value is explicitly configured not to be hashed (having TCA `hashed=false`). Resolves: #101965 Releases: main, 13.0, 12.4, 11.5 Change-Id: Ie05a708185c621b8a2120ad7851ac4caf180893f Security-Bulletin: TYPO3-CORE-SA-2024-003 Security-References: CVE-2024-25118 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82959 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benjamin Franzke authored
Resolves: #102799 Releases: main, 13.0, 12.4, 11.5 Change-Id: I673b6fbac853b0a977a5e5833a683c6952a55458 Security-Bulletin: TYPO3-CORE-SA-2024-002 Security-References: CVE-2024-22188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82958 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Hader authored
The File Abstraction Layer Local Driver did not verify whether a given absolute file path is allowed, and made it possible to access files outside of the project path, and to by-pass the setting in $GLOBALS['TYPO3_CONF_VARS']['BE']['lockRootPath']. In case lockRootPath is not set, any local file path must be at least located in the base directory of the current project. The lockRootPath setting now supports array values as well. The trailing slash is enforced automatically. Example: * instead of 'lockRootPath=/var/spe' previously matching the paths '/var/specs/' and '/var/specials/, * now both paths need to be declared explicitly, since 'lockRootPath=/var/spe' is evaluated as '/var/spe/' Resolves: #102800 Releases: main, 13.0, 12.4, 11.5 Change-Id: I6561df562c5dbaff1f77d33db24d5f1c6358b198 Security-Bulletin: TYPO3-CORE-SA-2024-001 Security-References: CVE-2023-30451 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82957 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benjamin Kott authored
The style guide should aid in testing and constructing backend components. In this change, we're removing the mandatory light mode for examples to enhance visibility of adjustments within sub-components. Resolves: #103093 Releases: main Change-Id: Ia838d75fdaccb48e4f43a0cdd9fa31e309603d2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82879 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
The autocomplete="off" parameter is ignored by current browsers, autocomplete="new-password" is to be used for disable autocompletion. The explicit request for autocompleting the password is autocomplete="current-password", which is now used in case config TCA autocomplete is set. See following article for more information: * https://web.dev/articles/sign-in-form-best-practices#new-password * https://web.dev/articles/sign-in-form-best-practices#current-password Resolves: #103067 Related: #97104 Releases: main, 12.4 Change-Id: Ice3c7a50020d7e17b14c51dc89c1c8e1700fe9a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82830 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Stefan Bürk authored
A new PHPStan version has been released, which is pulled in automatically in the composerInstallMax nightly test. The higher version allows to remove a ignore pattern from the baseline and a superfluous key unset is detected. This change raises the PHPStan version, removes the superfluous `unset()` and regenerates the baseline to remove the invalid ignore pattern. Used command(s): > Build/Scripts/runTests.sh -s composer \ -- require --dev "phpstan/phpstan":"^1.10.58" > Build/Scripts/runTests.sh \ -s phpstanGenerateBaseline Resolves: #103105 Releases: main, 13.0, 12.4 Change-Id: I689079eaac7f9461084e6a71ff08ef716cf551e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82932 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Feb 12, 2024
-
-
Oliver Hader authored
Executed command: composer update composer/composer see https://github.com/advisories/GHSA-7c6p-848j-wh5h Resolves: #103102 Releases: main, 13.0, 12.4, 11.5 Change-Id: Ib3a0baa5c94f0a19b36b8440a30f47f25eab6e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82899 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Oliver Bartsch authored
This fixes several bugs in FileList: 1. Properly initializing the `searchTerm` ensures it is kept while sorting. 2. Sorting for "filesize" is now working properly, using corresponding collator attribute. 3. Pagination is properly reset on searching. 4. Correct search term is kept on paginating. Resolves: #103053 Releases: main, 12.4 Change-Id: Ibf7dd278d13aed6142286d7408b9380588485801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82826 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Sybille Peters authored
Since the linktypes are automatically registered in Linkvalidator, it is no longer quite as easy to replace the "external" linktype. You cannot register another linktype using the same identifier "external", so a different identifier must be used. A minimal example is added to the developer section in the documentation. Resolves: #101673 Related: #96935 Releases: main, 12.4 Change-Id: I9afa1a77fe56675dff2dbc1bacc3635b1b9b36c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82894 Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Chris Müller <typo3@krue.ml>
-
- Feb 11, 2024
-
-
Oliver Bartsch authored
The query for fetching extension versions is extended to also find "outdated" extension versions (review_state = -2). Note: For now, this does not change anything in the EM, since the remote XML does not use the -2 state currently, due to the wrong constraint. This can however now be properly fixed in XML. Resolves: #93082 Releases: main, 12.4, 11.5 Change-Id: I522a2c166c6d1af6e8b2a14de51d63a15c4211d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82821 Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Torben Hansen authored
The language labels for `noPluginSelected` and `edit` in StandardContentPreviewRenderer can not be resolved, because the extension path is wrong. This change fixes the extension path and additionally streamlines one label output, by using `htmlspecialchars` to escape the generated label similar to the other label output in this class. Additionally a similar wrong extension path in `ExampleLinkType.rst.txt` has been adapted. Resolves: #103095 Related: #100675 Releases: main, 12.4 Change-Id: I4882133025c938fc3b6928b36237e782e9465dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82884 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Feb 10, 2024
-
-
Stefan Bürk authored
New core-testing-* images have been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below. * core-testing-php82 => 1.10 * core-testing-php83 => 1.11 [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/e6719d303eacf2f377e308c800b474b735145d61 [2] https://github.com/advisories/GHSA-7c6p-848j-wh5h Resolves: #103096 Releases: main, 13.0, 12.4, 11.5 Change-Id: If9c5ae00334acc4fa5a1417dcbf9f77d31dff62d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82885 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Torben Hansen <derhansen@gmail.com>
-
- Feb 09, 2024
-
-
Yann authored
An editor can trigger a TypeError exception leading to a 503 error message `trim() expects parameter 1 to be string, null given` in the backend page module by creating `menu_categorized_content` objects with `selected_categories` and then turning them into `menu_section` objects. This change mitigates the type error by using a null-coalesce fallback passing an invalid type to the `trim()` method in `StandardContentPreviewRenderer::generateListForMenuContentTypes()`. Resolves: #103052 Releases: main, 12.4, 11.5 Change-Id: I4c0ecbd20c7cdfee22fa324f6b80391be47a1b88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82794 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Oliver Bartsch authored
The "Export" button in the list module, used to trigger exporting a table does now also respect the `options.impexp.enableExportForNonAdminUser` TSconfig option, preventing a permission exception. The `mod.web_list.noExportRecordsLinks` is no longer used for managing the display of the "Download" button (displayed in the table's header row), but instead a dedicated TSconfig option `mod.web_list.displayRecordDownload` is introduced. Using per-table syntax, it's also possible to manage the "Download" Button for each table individually. Resolves: #99781 Releases: main, 12.4 Change-Id: I8b967218626ecc05dccf4bd7ac441db56a21a753 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82817 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Jochen Roth <rothjochen@gmail.com>
-
Benjamin Kott authored
Resolves: #103094 Releases: main Change-Id: Ib755aacd6f3e9a8149691957c08151b36144325b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82882 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Oliver Bartsch authored
The ExtendedFileUtility component provides the file name as argument for the `fileNotDeletedHasReferences` label. This information is now displayed correctly by adding the missing placeholder to the label. Resolves: #103091 Releases: main, 12.4 Change-Id: Ic9e40034bdf4f3d14e874014210e5d22235cd8c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82875 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen Roth <rothjochen@gmail.com>
-
Andreas Kienast authored
Lit elements need to get created in the correct browser scope (i.e. frame) to get rendered in Firefox, which is a huge issue in modals (that reside in the global scope), that are triggered in an iframe scope. This commit introduces a helper method `loadModuleFrameAgnostic()` that loads the module depending on the context the Install Tool is in (standalone vs. iframe). All Install Tool modules are modified to load renderable modules (info boxes, flash messages and progress bars) explicitly. Also, a superfluous progress bar is removed from the "Directory status" module that breaks the whole modal in case a user prefers reduced motions. Resolves: #103048 Releases: main Change-Id: I00834e1000c689d4581cbd3ef0124a1f8a391186 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82791 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Oliver Bartsch authored
Resolves: #103089 Releases: main Change-Id: I87cfaf2baeafb290930cb6142e80ad490fb1a05c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82872 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Torben Hansen authored
The identifier in the `AsEventListener` PHP attribute uses a space. Allthough this technically works, we do not use spaces elsewhere for event listener identifiers. This change therefore removes the superfluous space. Resolves: #103041 Related: #102440 Releases: main Change-Id: I159ff18e4769e71cba120ccb1dd2b668fd825aea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82784 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Andreas Kienast authored
`argon2id` is available since PHP 7.3. Since this version requirement is fulfilled for quite some time already, it's time to set the hashing algorithm as the default one. Resolves: #103084 Releases: main Change-Id: Iad3f4f4e33a7c3aa1b3d790931cf7bff900935b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82865 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Thomas Hohn authored
The so called "death star" range for replacements has to be used with caution [1] as it replaces all versions of the replaced packages, including old or insecure versions. That effectively means the replacing package marks itself as matching in queries for insecure versions, once a security advisory[2] is submitted for the replaced packages. The extension replacements are now adapted to use the more precise self.version qualifier to avoid matching named security advisories as suggested by: https://github.com/Roave/SecurityAdvisories/issues/127#issuecomment-1933647035 [1] https://getcomposer.org/doc/04-schema.md#replace [2] https://github.com/advisories/GHSA-cgr9-h9qq-x9fx Resolves: #103082 Releases: main, 13.0, 12.4, 11.5 Change-Id: I6353df15d6cbf039bab60644a103669495b26605 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82863 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Benjamin Kott authored
The lower part of the node name was inadvertently truncated. This patch ensures that the text is no longer cut off. Resolves: #103077 Releases: main Change-Id: I54dfe7300d1c15ab0b28393e7b15196e2f42aa8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82870 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org>
-
Andreas Kienast authored
In some cases it was missed to enable modal actions again after their execution in the Install Tool. This patch adds the necessary statements to enable said buttons again. Resolves: #101224 Releases: main, 12.4 Change-Id: I793f157302df15912f0506c376d9db2d6041ebcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82815 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Benjamin Kott authored
With the move to native drag and drop in the tree component #103043, d3js became obsolete and is now removed. Resolves: #103087 Releases: main Change-Id: I8592ca50550b242b9e452ef0a782cbf60e81a8e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82869 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
Executed commands: npm install --save sortablejs@^1.15.2 npm run build Resolves: #103064 Releases: main, 12.4 Change-Id: I34c76bbd6b856c10a7a420d6fe652a47fbf0e095 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82823 Reviewed-by:
Fabien Udriot <fudriot@omic.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Nedbal <andy@pixelde.su>
-
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.0.2 npm run build Resolves: #103038 Releases: main Change-Id: Iba79bd1e91c2ffcdfc7ff23e11786d4f6b9ee305 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82781 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Benni Mack authored
This change ensures that `?id=` only validates against an integer-interpreted value, disallowing `?id=nonsense23` which previously resolved to "23" In case an invalid `?id=` parameter value is provided throw a page not found error. Resolves: #103057 Releases: main, 12.4 Change-Id: Iaeb3096944b6872b73b056b690bf4f7fabbe9a6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82814 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benni Mack <benni@typo3.org>
-
- Feb 08, 2024
-
-
Benjamin Kott authored
The configured browser capabilities (`chromeOptions`) are passed by `codeception/module-webdriver` to `php-webdriver` as is. php-webdriver expects the PHP constant ChromeOptions::CAPABILITY to be used instead of hardcoding any strings. Therefore php-webdriver 1.15 changed this constants value from `chromeOptions` to `goog:chromeOptions` [1], which means that the option `chromeOptions` is no longer respected and the configured window size (and the headless flag) is ignored. We now use the newer W3C webdriver comaptible `goog:chromeOptions` option and define window size definition via codeception's respective option `window_size` while we are at it. [1] https://github.com/php-webdriver/php-webdriver/commit/235c2aa07 Resolves: #103081 Releases: main, 12.4 Change-Id: Iec345b5ec0226d38b62081aa8c3a51dd3100bdb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82860 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com>
-
- Feb 07, 2024
-
-
Simon Schaufelberger authored
A new test case is added to cover the case when a TCA definition exists without `ctrl`. The test case has been added to the test extension `blog_example` which is not part of the public extension. Resolves: #103025 Releases: main, 12.4, 11.5 Change-Id: Iccd4428ad544fd6a94ed48ec97264b2945463d04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82771 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Benjamin Kott authored
The SVG based renderer for the page, file and select trees has been replaced by a HTML based one. It uses reactive rendering based on lit's component model. Using HTML and CSS rendering offers more flexibility than SVG, so that RTL and dark mode support could now be implemented. Releases: main Resolves: #102125 Resolves: #103043 Resolves: #100467 Resolves: #98088 Resolves: #97346 Change-Id: Ic27b1d08c232d9074a734c80e222fb801672b967 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81411 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com>
-
Stefan Bürk authored
This change adds a composer command dispatcher to `Build/Scripts/runTests.sh` to allow the execution of any composer command without the hassle to have a proper composer installed on the host system. This also helps for onboarding new contributors not having a proper php and composer ecosystem installed on the host system. For example, to raise dependencies following can now be used: > Build/Scripts/runTests.sh -s composer -- require --dev \ typo3/testing-framework:dev-main Other examples: > Build/Scripts/runTests.sh -s composer -- dumpautoload > Build/Scripts/runTests.sh -s composer -- info | grep "symfony" Resolves: #103045 Releases: main, 12.4, 11.5 Change-Id: I65fa14e2c8d0d1a1204b3bed701d8c3458b6e3bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82787 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com>
-
Stefan Bürk authored
The COMPOSER_ROOT_VERSION environment variable in `Build/Scripts/runTests.sh` has not been updated. This change corrects this. Resolves: #103073 Releases: main Change-Id: I9fa3406ac471e749546473db10db3020d4f92685 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82857 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Andreas Kienast authored
Executed commands: npm install --save-dev sass@^1.17.0 npm run build Resolves: #103065 Releases: main, 12.4 Change-Id: Id8d3ad111a751299266bdc3abe59c54a15df010c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82824 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com>
-
- Feb 06, 2024
-
-
Christian Kuhn authored
This finediff minor raise alignes supported PHP versions >=8.2 with core, symfony, phpunit v11. Releases: main Resolves: #103066 Change-Id: I7af5103daf65a57ca865fa3236803df9368894bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82825 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-