- Aug 12, 2021
-
-
Oliver Bartsch authored
Clipboard components still used and documented the deprecated shortMD5 method. This is now fixed. Resolves: #94844 Releases: master Change-Id: Idd30ee5af7496b8ded379b862e41c364b10e0d99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70494 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Roman Büchler authored
Resolves: #94838 Releases: master Change-Id: I6e5c5e5dfb58c42956629ddefa85cd5f21a55884 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70486 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Bartsch authored
In case no secondary options are available, the dropdown is not longer rendered in record- and filelist, since this led to display errors. Resolves: #94834 Releases: master Change-Id: I2aa6b60b09dbb3fa4cb3b2f79b3b44a19063c2cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70483 Tested-by:
-
Nikita Hovratov authored
The concept for registration and usage of soft reference parsers received a complete overhaul. Starting with the registration, it is now possible to register soft reference parsers by dependency injection in the extension's Services.(yaml|php) file. For this, the new tag name "softreference.parser" has been introduced. One has to provide the additional attribute "parserKey" to identify the parser. This replaces the old way of registering these parsers in the $GLOBALS array. If a parser is registered with the same key in both ways, the old way takes precedence for b/w compatibility. This comes with a completely new factory service class TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserFactory. This classes' responsibilities are collecting all registered soft reference parsers and serving them to the consumer by calling the method "getSoftReferenceParser" with the desired parser key as the only argument. There is a compatibility layer for the old way of registration and for classes not implementing the new interface. Soft reference parsers now have to implement TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserInterface. The interface defines the implementation of the "parse" method. The first 4 and the last parameter stay the same as in the old method "findRef". The remaining two parameters "spKey" and "spParams" have to be set with the "setParserKey" method, if they are needed. The key can be retrieved by using the "getParserKey" method. The different parser implementations in the old class TYPO3\CMS\Core\Database\SoftReferenceIndex have been extracted and moved into dedicated classes in the TYPO3\CMS\Core\DataHandling\SoftReference namespace. Missing tests for parsers other than "typolink" and "typolink_tag" are added. The method makeTokenID of SoftReferenceIndex has been moved into TYPO3\CMS\Core\DataHandling\SoftReference\AbstractSoftReferenceParser. A parser can extend this abstract class, if this method is needed. The methods of BackendUtility "softRefParserObj" and "explodeSoftRefParserList" are now deprecated and the replacement TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserFactory should be used instead. Resolves: #94687 Resolves: #94741 Releases: master Change-Id: I460bfdd4478194fa4b4111fc44871f7225c6c084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70177 Tested-by:
-
Björn Jacob authored
Some remarks regarding the overrideConfiguration parameter have been documented. Resolves: #89933 Releases: master, 10.4 Change-Id: Iabce22db2257fc85a415d1c7d74d2a9195586ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70479 Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
-
Christian Eßl authored
Before this patch, the DatePickerViewHelper of EXT:form would always render its datepicker JavaScript inline. The DatePickerViewHelper now includes an external JS file for the initialization which is not utilizing any dynamically generated parts anymore. Resolves: #90264 Releases: master Change-Id: I1f72690d41121dc0cd48a2db55de883fe84589c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63263 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Wouter Wolters authored
Also fix method call to flushData with an array as arguments which should be a string. Resolves: #94789 Releases: master Change-Id: I19ef0f8d9b0c008b4036a2e08b674e71082cba84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70406 Tested-by:
Roman Büchler <info@buechler.pro> Tested-by:
-
Benni Mack authored
The workspaces module has a better style and some improvements for editors and administrators: * Editors now get feedback if an AJAX call shows no results * Editors + Administrators now switch workspace via a selector, very helpful when having more than a couple of workspaces * Administrators can now edit a workspace record directly from the module The change cleans up a lot of unused code in the main workspaces module and brings a few UX improvements within the module. * Dropdowns instead of tabs (good when having a lot of workspaces) * Language + Depth + Action selection is now rendered via Controller+Action instead of waiting for a first AJAX round trip * Properly using "moduleData" from "uc" to store information * Solved issues related to language icon rendering * Removed unused inline settings * Consistent usage of Persistent JS module accessing BE_Users' UC * nProgress for showing progress of loading AJAX requests Next steps in this area: * Hand in the first payload as JSON to avoid AJAX call on initial page load * Remove leftover inline JavaScript Resolves: #94819 Releases: master Change-Id: Ie533656a14af56dad4a4039fcbc9b08bde693500 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70452 Tested-by:
-
Jochen Roth authored
The custom backend logo could break the layout if not properly scaled. This issue is fixed by setting max-width and max-height for the image. Resolves: #94778 Releases: master Change-Id: I98221c721e8f9d7a7a648807ce31c0e9a00390a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70397 Tested-by:
-
Wouter Wolters authored
Main changes are: * Use assertArrayHasKey/assertArrayNotHasKey instead of array_key_exists. * Fix misordered assertEquals/assertNotEquals arguments. * Use assertCount instead of assertEquals and count() method. Resolves: #94751 Releases: master Change-Id: Iaa0dbb4744bf41f43f4700714ed47910feaab081 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70292 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christoph Schwob authored
The shortcut link type is invalid and must not be used, see e.g. https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types Resolves: #94821 Releases: master Change-Id: I5b3e5cf594ce5deedafd8b6c66d230a64b22ba58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70454 Tested-by:
-
Wouter Wolters authored
The function array_key_exists should be used instead. Resolves: #94792 Releases: master Change-Id: I19ca8fd7b003ba796d3a963d4fa0c6e7d3cdf061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70408 Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Benni Mack authored
This change falls back for the checksum of a shorter md5 hash sum in order to avoid re-processing all existing processed files. Resolves: #94832 Related: #94684 Releases: master Change-Id: Id23128a2b6466e2daa33c97d56aba24c2a1052fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70478 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Wouter Wolters authored
The function `setMethods` in the MockBuilder class of PHPunit is deprecated. Use `onlyMethods` or `addMethods` instead. Resolves: #94750 Releases: master Change-Id: I08728a7a3c8342c5f7f47146fa907d5ae4e58c9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70291 Tested-by:
Marvin Dosse <marvindosse@gmail.com> Tested-by:
-
Björn Jacob authored
This patch adds a note about the final "nature" of the Redirect finisher. Resolves: #91381 Releases: master, 10.4 Change-Id: I63eab923ab7d63a977cee955bf51a6aac5363f19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70474 Tested-by:
-
Alexander Nitsche authored
This patch serves as a basis for further improving the UX and new features for import / export. * Better separation between controllers and worker services * Refactor code & streamline wording * More strict typing and some PHP 8 related fixes * Streamline exception handling * Support full import configuration in CLI command impexp:import * Functional tests with increased coverage and less mocking * A set of acceptance tests for the backend interface * Minor bug fixes Note: The output of the extension has not been changed in any way, e.g. the format of the export file remains the same. Only the internal processes have been optimized. Resolves: #94772 Releases: master Change-Id: I4df66a6f615e07d6d9767723a12a769aedeb341b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70332 Tested-by:
-
Georg Ringer authored
Use the latest version which gets full support. composer req egulias/email-validator:^3.1 composer req egulias/email-validator:^3.1 -d typo3/sysext/core --no-update Resolves: #94830 Releases: master Change-Id: I6336a15d28401e364d343eb9c2a4d50708b520a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70464 Tested-by:
-
Andreas Fernandez authored
The Core Updater and Reports module were modified to render correct information about non-community supported TYPO3 releases (aka ELTS) with while no ELTS was released yet, in contrast to the Core Updater. The missing case is added with this patch. Resolves: #94827 Related: #94745 Releases: master, 10.4, 9.5 Change-Id: Ib4d8791478b89ad7e9b92930d882a98c76b809a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70462 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Andreas Fernandez authored
The method GeneralUtility::shortMD5() generates an MD5 hash and trims it to a configurable length, where 10 characters is the default. This increases the probability of conflicts whereever this method is used, either as hash stored in the database or as id decorator in DOM. Due to the issues this method brings, it is marked as deprecated now. Resolves: #94684 Releases: master Change-Id: I599211196da8ffd737643d29ed68dc6d0c0f2ae9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70176 Tested-by:
-
Benni Mack authored
The replacement for fsMod comes with a bad side-effect when using the topbar. This change ensures that a "mount" can also be handed in as "null" value. Resolves: #94828 Related: #94762 Releases: master Change-Id: I3e8c7ba7a83384297d8af52807be11e7e4115d59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70463 Tested-by:
-
Oliver Bartsch authored
Bootstrap 5.1.0, we updated to in #94752, introduced a `.vr` (vertical rule) class. This collided with our access module related styles, since we also use a `.vr` class for the legend here. To resolve the collision, our own implementation, which is only used in the access module, is now prefixed with `t3`. Resolves: #94826 Related: #94752 Releases: master Change-Id: I493baa3d0af41b78f42c9e73c9c121b29f417edd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70456 Tested-by:
-
- Aug 11, 2021
-
-
Oliver Hader authored
JavaScript object :js:`top.fsMod` managing the "state" for page-tree and file-tree related contexts in the backend user-interface like this: * `top.fsMod.recentIds.web` contained the current ("recent") page or file related identifier details were shown for * `top.fsMod.navFrameHighlightedID.web` contained the currently selected identifier that was highlighted in page-tree or file-tree * `top.fsMod.currentBank` contained the current mount point or file mount ("bank") used in page-tree or file-tree To get rid of inline JavaScript and reduce usage of JavaScript `top.*`, mentioned `top.fsMod` has been deprecated and replaced by new component `ModuleStateStorage`. Reading data from `top.fsMod` is still possible as a fall-back. Resolves: #94762 Releases: master Change-Id: I9e02a1e4c59ad3a007f5244197c1cdaa2a31ce22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67680 Tested-by: -
Oliver Bartsch authored
This patch moves the "normal" clipboard actions, such as copy and cut, into the secondary dropdown in recordlist and filelist. This means, when in "normal" clipboard mode, the actions are accessible no matter if the clipboard itself is shown or not. The clipboard related actions are divided by a horizontal line in the dropdown. Moving them into the dropdown also means, no superfluous "empty" icons are necessary when clipboard state changes, e.g. from "normal" to "multiple". Resolves: #94824 Releases: master Change-Id: I57666fe880cda9283d649a77f3a3b1bd44206e8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70455 Tested-by:
-
Oliver Bartsch authored
Some content elements, namely "html", "div" and "shortcut" do not display the header field value in the frontend. However, the "name" is shown as link value in menus (e.g. section index). To make this clear to the editor, a new description is added to the "header" field for those elements. Furthermore is the corresponding CSH text adjusted. Resolves: #94704 Releases: master Change-Id: I9767e41a082e4c2776f0c78e7e091bff9eed66bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70352 Tested-by:
-
Oliver Bartsch authored
Since #94414 directly injecting the LanguageService is deprecated. The LanguageServiceFactory has to be used instead. This patch removes some left overs, which still triggered deprecation log entries. Resolves: #94803 Related: #94414 Releases: master Change-Id: Iecbaf0c433ffbad27d82ecb71bd6c170e455c01c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69662 Tested-by:
-
Benni Mack authored
This patch updates bootstrap to version 5.1.0, introducing several bugfixes. See https://github.com/twbs/bootstrap/releases/tag/v5.1.0 for further reference. In addition, Popovers now contain the option to allow HTML at any time (HTML is sanitized by default). Executed commands: yarn add bootstrap@^5.1.0 --cwd Build/ yarn add --dev @types/bootstrap@^5.1.0 --cwd Build/ Resolves: #94752 Releases: master Change-Id: I22923798288b69e9bcab61d12ce8527030527c31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70294 Tested-by:
-
Oliver Bartsch authored
The clipboard copy and cut actions do not longer define a returnUrl, since the action does not switch the module. This previously led to an endless loop of returnUrl parameters being added to the link. Resolves: #94813 Releases: master Change-Id: Ib267fcbc778342cd03d5d0a1a2c81283f98f87d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70453 Tested-by:
-
Simon Gilli authored
Sqlite needs the current table definition in the alterTable() method to be able to alter the table. This patch adds the current definition to the upgrade wizard to work properly with Sqlite databases. Resolves: #94811 Relates: #94460 Releases: master Change-Id: I199b7be03499d74608ba8e8cc2ddd0c11ca888bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70447 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Robert Kärner authored
The checkbox "t3-form-field-eval-null-checkbox" lost its former CSS class "checkbox" and thus its attribute "position: relative". This happened during the recent change to streamline checkboxes in the TYPO3 Backend. This change adds the missing attribute, so that the checkbox is no longer obscured by the "t3-form-field-disable" overlay, which prevented all mouse interactions. Resolves: #94817 Related: #93310 Releases: master Change-Id: I1fba185f58cd927eb186e39feab5c6d9c783315a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70451 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Daniel Siepmann authored
The autoloading was accidentally removed during #94747. Resolves: #94812 Releases: master Change-Id: Ibbabc31607f918d320013ad4ddf06567f2694ec1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70449 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Grégory Jaouën authored
Fix the Formelement selection button on first use. The variable `propertyData` might be a string and the expression `getCurrentlySelectedFormElement().get(propertyPath)` can return an undefined value. The OR operator `||` is used instead of the nullish coalescing operator `??` on browser compatibility purpose. Resolves: #92911 Releases: master, 10.4 Change-Id: Icd0333061edccef4ee0af00abb34dbb56306fe63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66876 Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
Jochen Roth authored
When calling the sitemap (type 1533906435) undefined key warnings are thrown. This is fixed by properly checking the array key. Resolves: #94785 Releases: master Change-Id: I2961a4b776b4e35fc3e489a0cdabd95f4b0602cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70402 Tested-by:
-
Claus Due authored
Allows compatibility with Fluid 3.x. The change is necessary because Fluid 3.x moves away from regular expression to detect Fluid syntax, while also allowing more detailed customisations of what can be written as inline syntax. The result is that the JSON object notation gets seen as Fluid syntax. Even if Fluid 3.x natively was more permissive about such embedding, combining it with calls to Fluid ViewHelpers would still present problems (when is a curly brace JSON and when is it Fluid? Do we process Fluid tag notation only inside strings in that JSON? How aware should Fluid be, not just of JSON but potentially also embedded XML? And can we accept a considerable increase in Fluid's internal complexity to handle these edge cases for any conceivable embedding strategy?). In order to avoid this complexity, Fluid 3.x pragma has been to make it intentionally more naive, at the cost of potentially detecting syntax that in 2.x would not be detected as Fluid syntax. As a side note: there *is* a standard way to tell Fluid "this syntax isn't Fluid" - by prefixing curly brace statements with a backslash - but this approach is not compatible with Fluid 2.x which would simply output the backslash, resulting in invalid JSON syntax. Essentially, while we keep support for Fluid 2.x we are slightly more constrained in what we can choose to embed in Fluid, because whatever we choose to embed, must be compatible with both versions. And though there *are* certain ways we could accommodate JSON-in-Fluid, none of them are straight-forward and may in the end only encourage less than ideal practices (such as embedding script tags with Fluid being used to build variables - which is something that ideally should be handled in a controller, and in TYPO3 context, integrated via the PageRenderer instead of appearing at arbitrary places in DOM). So even though much more detailed explanations/workarounds are possible, TYPO3 CMS should constitute a best-practice reference and be as compatible as we possibly can - which in this case means not embedding Fluid-processed JSON in templates, but rather use the controller and PageRenderer to do such embedding. A similar change was done to embed the "goTo_altDoc" JS function in the page module, to pass the entire function as Fluid variable instead of passing only the function body as variable. PageRenderer was not used for that, since the function was rendered as part of a modal which does not use PageRenderer for output - since PageRenderer is available in context of the Form module, it is preferable to use that strategy. Releases: master Resolves: #90867 Change-Id: I6ea8dda6e6900b236a7801020f796f05c0b0d9b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63965 Tested-by:
-
Oliver Hader authored
... follow-up ... Resolves: #94797 Releases: master Change-Id: I8fedbf9ed7e67bf6db7d248680c9844b1a8c6b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70446 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Tomas Norre Mikkelsen authored
* remove superfluous `}` literal from PHP example * add "Troubleshooting" section of reported side-effects * add "Logging" section, supporting to spot those side-effects Resolves: #94797 Releases: master, 11.3, 10.4, 9.5 Change-Id: I4b154c849b158d920b380f40d1415762d227ae6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70440 Tested-by:
-
Benni Mack authored
This change is a pre-requisite for allowing guzzle/psr7 2.0. Used composer command: composer req --dev codeception/codeception:^4.1.22 -W Resolves: #94800 Related: #94422 Releases: master Change-Id: I1440249440c739d52acc448285ce053aeee67579 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70442 Tested-by:
-
Wouter Wolters authored
Resolves: #94795 Releases: master Change-Id: Ia4a0123a70a2b50b4f89e04e3f15c18559489c97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70438 Tested-by:
-
Torben Hansen authored
When TYPO3 is configured to spam protect email addresses using an offset, then the HTML sanitizer introduced in #94375 will remove the generated JavaScript in the href link attribute. This change makes the HTML sanitizer aware of the `javascript:linkTo_UnCryptMailto` pattern for href attribute. Resolves: #94776 Releases: master, 11.3, 10.4, 9.5 Change-Id: If5f4ab22a686274401390a66b580a24e6d5a8f0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70411 Tested-by:
-
- Aug 10, 2021
-
-
Oliver Hader authored
This reverts commit c35316f6. Not defining replaced version of `t3g/svg-sanitizer` leads to problems with `roave/security-advisories`. Overall it seems to be better, to completely revert previous change. Resolves: #94782 Reverts: #94719 Releases: master, 11.3, 10.4, 9.5 Change-Id: I43c2ea986ffec72bc0c8eb740a84daad33e9257f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70433 Tested-by:
-
Wouter Wolters authored
Resolves: #94788 Releases: master Change-Id: I687ce575ddd15f8a2f9ce4ba9ded6f3087e4b66f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70405 Tested-by:
-
