[TASK] Improve PHPunit used assertions
Main changes are: * Use assertArrayHasKey/assertArrayNotHasKey instead of array_key_exists. * Fix misordered assertEquals/assertNotEquals arguments. * Use assertCount instead of assertEquals and count() method. Resolves: #94751 Releases: master Change-Id: Iaa0dbb4744bf41f43f4700714ed47910feaab081 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70292 Tested-by:core-ci <typo3@b13.com> Tested-by:
Roman Büchler <info@buechler.pro> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Roman Büchler <info@buechler.pro> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
Showing
- typo3/sysext/beuser/Tests/Unit/Domain/Model/BackendUserTest.php 4 additions, 4 deletions...sysext/beuser/Tests/Unit/Domain/Model/BackendUserTest.php
- typo3/sysext/core/Tests/Acceptance/Backend/InstallTool/LoginCest.php 1 addition, 1 deletion...t/core/Tests/Acceptance/Backend/InstallTool/LoginCest.php
- typo3/sysext/core/Tests/Acceptance/Backend/Login/BackendLoginCest.php 1 addition, 1 deletion.../core/Tests/Acceptance/Backend/Login/BackendLoginCest.php
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DefaultValuesTest.php 7 additions, 7 deletions...Functional/DataHandling/DataHandler/DefaultValuesTest.php
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DeleteTranslatedSubpagesTest.php 1 addition, 1 deletion...DataHandling/DataHandler/DeleteTranslatedSubpagesTest.php
- typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.php 8 additions, 2 deletions.../Tests/Functional/IO/PharStreamWrapperInterceptorTest.php
- typo3/sysext/core/Tests/Functional/Messaging/FlashMessageQueueTest.php 2 additions, 2 deletions...core/Tests/Functional/Messaging/FlashMessageQueueTest.php
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php 3 additions, 3 deletions...xt/core/Tests/Functional/Resource/ResourceStorageTest.php
- typo3/sysext/core/Tests/Functional/Session/Backend/DatabaseSessionBackendTest.php 1 addition, 1 deletion...Functional/Session/Backend/DatabaseSessionBackendTest.php
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php 1 addition, 1 deletion...ts/Functional/Session/Backend/RedisSessionBackendTest.php
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2iPasswordHashTest.php 1 addition, 1 deletion...s/Unit/Crypto/PasswordHashing/Argon2iPasswordHashTest.php
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2idPasswordHashTest.php 1 addition, 1 deletion.../Unit/Crypto/PasswordHashing/Argon2idPasswordHashTest.php
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BcryptPasswordHashTest.php 1 addition, 1 deletion...ts/Unit/Crypto/PasswordHashing/BcryptPasswordHashTest.php
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php 1 addition, 1 deletion...3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php
- typo3/sysext/core/Tests/Unit/DependencyInjection/FailsafeContainerTest.php 1 addition, 1 deletion.../Tests/Unit/DependencyInjection/FailsafeContainerTest.php
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php 2 additions, 2 deletions.../core/Tests/Unit/EventDispatcher/ListenerProviderTest.php
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php 4 additions, 1 deletion...e/Tests/Unit/FormProtection/FormProtectionFactoryTest.php
- typo3/sysext/core/Tests/Unit/Http/MessageTest.php 1 addition, 1 deletiontypo3/sysext/core/Tests/Unit/Http/MessageTest.php
- typo3/sysext/core/Tests/Unit/Http/RequestFactoryTest.php 0 additions, 6 deletionstypo3/sysext/core/Tests/Unit/Http/RequestFactoryTest.php
- typo3/sysext/core/Tests/Unit/Http/RequestTest.php 1 addition, 1 deletiontypo3/sysext/core/Tests/Unit/Http/RequestTest.php
Please register or sign in to comment