- Jun 13, 2019
-
-
Benni Mack authored
The two TypoScript options * config.htmlTag_langKey * config.htmlTag_dir have been removed, as they have no effect anymore in TYPO3 v10, which only works with Site Handling. Site Handlings "direction" and "twoLetterIsoCode" are already in place and used when Site Handling is active. Resolves: #88560 Releases: master Change-Id: I8ef2a8b8ccd9c790fd7db940e908e8a362ec4ca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61003 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
Various documentation in TSFE is updated, in addition to having $TSFE->setAbsRefPrefix() to be set within the postProcessing to overcome issues when the call is forgotten in custom TSFE instances. Resolves: #88555 Releases: master Change-Id: Ib3ce22db1e6ce7b0985d486d584c26f25755efa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60998 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Dmytro Nozdrin authored
Conditions with `tree.rootLineIds` if matched caused page cache regeneration on each request. Resolves: #88374 Releases: master, 9.5 Change-Id: I5a9a2a429a80575b654a6894a3515c8ca8ec8db4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60771 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
For further TSFE-related changes, the frontend request workflow now stores user-/session-related information in the middleware. This is a first step in order to reduce the dependencies of TSFE + FrontendUserAuthentication. This patch is breaking as certain hooks (like EOFE) do not have session data stored anymore. Related: #88540 Resolves: #88541 Releases: master Change-Id: I1e9a66b759d6edfd4c0e5a8ede02aa7a73b65b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60939 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
The only occurrence for 'loginSecurityLevel' checks for empty and falls back to 'normal' (also defined in #81852 this must be set to normal). Single usage in AbstractUserAuthentication: trim($GLOBALS['TYPO3_CONF_VARS'][$this->loginType]['loginSecurityLevel']) ?: 'normal'; Instead of having this set to "factory configuration", (= writing to LocalConfiguration.php on new installation), this can be set to 'normal' in DefaultConfiguration directly. EXT:rsaauth can be configured to set this to "rsa" in an instance with RSA enabled (and has already done so before). The main benefit is that this option (if set to "normal") can be removed from LocalConfiguration if set to "normal" as it is then taken from DefaultConfiguration.php Resolves: #88549 Releases: master Change-Id: I2f8c088230b334a03c5acf9d09721dd42e67c059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60972 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Jun 12, 2019
-
-
Gianluigi Martino authored
Add title to the two topbar buttons on the left: - Minimize/maximize module menu - Collapse page tree Resolves: #88385 Releases: master, 9.5 Change-Id: I9641bdf5454f1f50e6c4ab67c96f663b8b5d8c73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60862 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
Extensions should make use of TYPO3's native functionality for using FAL-based folders, or the Environment API and TYPO3's File APIs to create folders when needed. The ext_emconf.php option "createDirs" option is removed, and not evaluted anymore. The public method `ensureConfiguredDirectoriesExist` in FileHandling Utility is removed, however the class is marked as internal. This change is a pre-work for the CLI Initiative where there are currently workarounds in using this functionality for "activating" an extension. Resolves: #88525 Releases: master Change-Id: I52ec31da541d3740977068981944bd5a1dd0d2f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60485 Tested-by:
-
Benni Mack authored
With the introduction of CKEditor in TYPO3 v8, the support for images in RTEs is dropped, however functionality was kept for compatibility with RTEHtmlArea, which was still available in TYPO3 v8 as separate extension. The functionality to handle images in CKEditor is possible to be applied again, however, as this cannot be managed properly via FAL in its current state, the previous functionality is remvoed from Core. Separate CKEditor extensions as already published, are able to manage the image handling in CKEditor directly already. Dropped * setting TYPO3_CONF_VARS[BE][RTE_imageStorageDir] * transformation setting "ts_images". * softref "images" logic * ImportExport->getRTEoriginalFilename() * RteHtmlParser->TS_images_rte() * CLI Command: cleanup:rteimages and Class RteImagesCommand Resolves: #88500 Releases: master Change-Id: Ie564b19a7d0f9b7d46398094c8d7ecd845e31a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60886 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Jonas Eberle authored
Fix two issues in the extension configuration tool if more than one extension is using the same configuration key: * Remove duplicate HTML IDs in extension configuration tool * Correctly add hidden fields with value=0 for checkboxes within every sub-<form>, not only on first occurence (first extension) of any given configuration key Resolves: #88426 Releases: master, 9.5 Change-Id: Ifbdb3b495443aa5521a4b5265ae3c29c2bc222b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60831 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Jun 11, 2019
-
-
Anja Leichsenring authored
Switching from accessibleMock to prophecy resolves a lot of failures. Also, using a concrete instance instead accessibleMockForAbstractClass reduces issues. Resolves: #88530 Releases: master, 9.5 Change-Id: I102597f74a98443fe139a76b8f168abf61349e3d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60903 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Jun 10, 2019
-
-
Stephan Großberndt authored
Releases: master Resolves: #88535 Change-Id: Ibeb645965840c8c4e78f5e4d13272db32e9fc308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60933 Tested-by:
-
- Jun 09, 2019
-
-
Andreas Fernandez authored
If a backend usergroup has no permission to edit page properties, the wizard for content element creation is not rendered properly. This is due to a missing import of the `PageActions` module. This patch now always loads the module and makes its callback depending on proper permissions. Resolves: #88532 Related: #87687 Releases: master, 9.5 Change-Id: Ie3acaf8fbf9bdeee425eae4b4d35cb2eb80b4d1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60907 Tested-by:
-
- Jun 08, 2019
-
-
Benni Mack authored
If a cHash GET parameter is given, but there are no GET parameters that are relevant, a hash_calc() call against an empty string is done. However, the change now allows an invalid cHash if no check is necessary. This could happen when upgrading from older instances where a cHash is not needed anymore. Bots would not then fill up the error log but get the new page (with a valid 200 result) Resolves: #41033 Releases: master, 9.5 Change-Id: Id02701fcbece371a6b9ce0f92fe0be55dd972325 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895 Tested-by:
-
Benni Mack authored
This patch removes unused variables: $GLOBALS['TYPO3_MISC']['microtime_BE_USER_start'] $GLOBALS['TYPO3_MISC']['microtime_BE_USER_end'] $GLOBALS['TYPO3_MISC']['microtime_end'] $GLOBALS['TYPO3_MISC']['microtime_start'] are replaced by properly using - TimeTracker->start() - TimeTracker->finish() (new method) to encapsulate the logic into the main method. Resolves: #88498 Releases: master Change-Id: I158e4b3aed002f688f117488cb0300c6523e791f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60769 Tested-by:
-
- Jun 07, 2019
-
-
Andreas Fernandez authored
With #88459, the closing tag `</property>` was accidentally not removed, leaving a broken XML structure. This patch removes the closing tag. Resolves: #88526 Related: #88459 Releases: master Change-Id: Iee6ca5f11f12d3f84f5bc0ef4afeefcb3b37bf73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60901 Tested-by:
-
Benni Mack authored
The fat BE User object needs a haircut, and the obvious logic for sending out an email is moved out. Resolves: #88454 Releases: master Change-Id: Id009a975c1d4b75d17c8f5ec2ce06f384dda6e12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60838 Tested-by:
-
Benni Mack authored
Due to incomplete handling of "0" and casting, the fallback is always "0" which is wrong. The patch fixes the behavior and adds tests to all use-cases mentioned in the ticket. Resolves: #88490 Releases: master, 9.5 Change-Id: Ie685b96a94213104729261daa0e3be6e8ef29c35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60879 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
- Jun 06, 2019
-
-
Alexander Stehlik authored
Initialize the d3-drag clickDistance setting to prevent clicks where the mouse slightly moves from being detected as drag attempts. See also: https://github.com/d3/d3-drag#drag_clickDistance Resolves: #88160 Releases: master, 9.5 Change-Id: I646591327e1688258e5d2d6ec3ca54000219f97a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488 Reviewed-by:
Paweł Rogowicz <rogowicz.pawel@gmail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Oliver Hader authored
This reverts commit 55f7beae. Unfortunately it's not possible to get rid of t3_origuid completely without introducing new side-effects. Remaining test adjustments for #88494 have shown that non-translatable entities used as reference would rather be deleted & re-created instead of synchronized. t3_origuid did a good job there - dropping it would introduce the mentioned regression. Misusing l10n_source for a non-translatable table sounds as stupid as introducing a new field like sync_origuid. Related: #88494 Reverts: #88495 Resolves: #88501 Releases: master Change-Id: I4de8a0cbac1b7c9825991794830efaa53f270709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60888 Tested-by:
-
Georg Ringer authored
The usage of no_cache should be avoided. If still required it can be added by using the setting additionalGetParameters. As the functionality goes into the PageRouter (effectively adds cHash), and it's possible that "no_cache" is completely disabled, it is not necessary to be set. This was not the case in v9 as Site Handling was not available everywhere. On top, if an editor is actually previewing the content on the page (via EditDocumentController "save + view") DataHandler is actually flushing the cache of the page/record associated (e.g. cacheTags for records), which is much more recommended. Resolves: #87347 Releases: master Change-Id: I2bcedb4f92231329234684c9daae2843d08ec29d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59362 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Jun 05, 2019
-
-
Claus Due authored
Prevents multiple division by zero errors when scaling images, by checking that the input image size is valid (meaning non-zero) before attempting to calculate the ratio for scaling - because the ratio is based on the input size parameters that must not be zero. Change-Id: I33fd3e49a1b3dcdc319309af736a9d785130af94 Releases: master, 9.5, 8.7 Resolves: #87954 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60299 Tested-by:
-
c.essl authored
If an admin user switches to another be_user account via the "Switch User" action in the "Backend users" module, the action is now logged to the sys_log. Resolves: #78432 Releases: master Change-Id: I0a9cb35e2d8734eb86ff475afeeac821a2f2a78a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60824 Tested-by:
-
Stefan Frömken authored
- Show how to use messageArguments - messageCode is mandatory (Don't know why, but yes it is) --> As it is mandatory, it does not make sense to write `if needed` - remove `Default value` from mandatory options --> As all calls in TYPO3 Core are strict types, a value like `null` will throw an Exception Releases: master Resolves: #88247 Change-Id: Ibf101a7c35ae01c975dbcaf162ff38f4eef27221 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60631 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Andreas Fernandez authored
The LinkBrowser used in FormEngine is now opened in a modal window instead of a popup. Resolves: #88471 Releases: master Change-Id: I59992b2fc8a9fbf6b01aa2213c024fd0c13de009 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60860 Tested-by:
-
Oliver Hader authored
In order to drop t3_origuid semantics (see issue #88494) according usages should be purged from functional tests. This way functional changes are easier to spot having to dedicated change-sets. Resolves: #88495 Releases: master Change-Id: Ic54efe30bb112b179a176681a3bb067de1791d44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60880 Tested-by:
-
Benni Mack authored
When no constant is given (due to old OS), a PHP warning is now triggered due to PHP 7.2. This is overcome to use the polyfill functionality instead then. Resolves: #88443 Releases: master, 9.5 Change-Id: I5ac673f10bc1421e543b8f969a0111e9bbc9c11e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60844 Tested-by:
Michael Waack <m.waack@i-d.de> Tested-by:
Thomas Anders <me@naderio.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
Benni Mack authored
The Locales class implies a kind-of singleton approach to fetch configuration information. In addition, Locales does the same functionality all over again: - array_flip for "isoReverseMapping" (not in use directly and can be removed) - taking the built-in supported languages and loops over them both is unnecessary at runtime. Instead, only the user-specific parts are validated. Resolves: #88488 Releases: master Change-Id: Ib1a9589bd670fe77b5bf7f5ca769c9601a2b2b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60877 Tested-by:
-
Benni Mack authored
Due to non-site handling, setting the locale was built on top of TypoScript settings. This was the reason, this was encapsulated within "$TSFE->settingLocale()". However, as the locale is now always available once SiteLanguage has been resolved, this can be handled very early. On top, the functionaltiy can be extracted from TSFE completely, and be universally used within "Locales". The method $TSFE->settingLocale() is now deprecated. Resolves: #88473 Releases: master Change-Id: I28c057ecc6d6ba37153a09812a61e5827cdb7bc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60863 Tested-by:
-
Stefan Neufeind authored
Command used: composer update symfony/* --with-dependencies Following dependencies changed: - Installing symfony/polyfill-php73 (v1.11.0) - Updating symfony/polyfill-mbstring (v1.10.0 => v1.11.0) - Updating symfony/console (v4.2.3 => v4.3.0) - Installing symfony/var-exporter (v4.3.0) - Updating symfony/cache (v4.1.4 => v4.3.0) - Updating symfony/expression-language (v4.1.4 => v4.3.0) - Updating symfony/finder (v4.2.3 => v4.3.0) - Updating symfony/polyfill-php72 (v1.10.0 => v1.11.0) - Updating symfony/polyfill-intl-idn (v1.10.0 => v1.11.0) - Updating symfony/inflector (v4.2.2 => v4.3.0) - Updating symfony/property-access (v4.2.2 => v4.3.0) - Updating symfony/property-info (v4.2.2 => v4.3.0) - Updating symfony/routing (v4.1.4 => v4.3.0) - Updating symfony/yaml (v4.1.4 => v4.3.0) - Updating symfony/filesystem (v4.2.3 => v4.3.0) - Updating symfony/options-resolver (v4.2.3 => v4.3.0) - Updating symfony/polyfill-php70 (v1.10.0 => v1.11.0) - Updating symfony/stopwatch (v4.2.3 =...
-
Benni Mack authored
The check if the pages table is accessible is removed. In TYPO3 v9 this was right after the TSFE creation due to 100% backwards-compatibility in terms of previous code which has now vanished (a legacy hook). This change removes the database initialization check as it is done already anyway earlier in Bootstrap. Resolves: #88481 Releases: master Change-Id: I7ca0c068ece433e9c545163121373b0de2af086d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60866 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
- Jun 04, 2019
-
-
Benni Mack authored
Cache Timeout, configured via config.cache_period can be configured when TypoScript is available. The functionality $TSFE->generatePage_preProcessing() has been thinned out further, as custom PHP Scripts are now handled via custom RequestHandlers anyway, which now rely on this information being set earlier (and also when a page should not be generated). Resolves: #88475 Releases: master Change-Id: Id9b6b0921c797e2b9de8d7b4302c515e59b0217e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60864 Tested-by:
-
Benni Mack authored
This reverts commit 1683f107. Reason for revert: This breaks existing code, as multiple headers are now sent to the client which were previously overridden. As long as there is existing code in TYPO3 where header() is sent, this change can only be done as a breaking change. Change-Id: Id7444b1455855702143b3fde5629203f252ba07e Reverts: #88420 Resolves: #88457 Releases: master, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60839 Reviewed-by:
Markus Poerschke <markus@poerschke.nrw> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Andreas Fernandez authored
Error pages in site configurations don't need to point to an absolute URI. When such error pages get resolved, the scheme, host and port of the request get attached to the resolved page. Resolves: #86935 Releases: master, 9.5 Change-Id: I1b29b7e7ec51c67e6630ed0f2de5f7e3276e8e7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60630 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Tizian Schmidlin <st@cabag.ch> Reviewed-by:
-
Anja Leichsenring authored
The class typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest manipulates the locale setting of the environment without restoring it. So following tests might get affected by this change and are not independent anymore. Resolves: #88484 Releases: master, 9.5 Change-Id: I02617a34bff08606866e9015111496d75bb6dcd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60869 Tested-by:
-
- Jun 03, 2019
-
-
Anja Leichsenring authored
With #88388, the composer.json file was adjusted to the required versions of phpunit/phpunit ^8.1 codeception/codeception ^3 but the composer.lock file did not reflect these changes. Resolves: #88483 Relates: #88388 Releases: master Change-Id: Idc7d4a63d0d9fb427e2c1b63f62e2b4da057b8e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60868 Tested-by:
-
Benni Mack authored
Due to site handling, the TypoScript properties config.language and config.language_alt have no effect anymore and can be removed. This patch removes the last forgotten occurrences. Resolves: #88459 Releases: master Change-Id: Ic4793035264cc00fe1e5d22b6b1c7cafdbdc49ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60842 Tested-by:
-
Benni Mack authored
The SiteMatcher object now always returns a Site / NullSite, so there will never be an exception "SiteNotFoundException" thrown. This dead code, which is never executed, can be removed. Resolves: #88461 Releases: master Change-Id: I458b46f3beea2ea7934a4557acac67453a819784 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60843 Tested-by:
-
- May 31, 2019
-
-
Benjamin Kott authored
Executed tasks: cd Build yarn add @typo3/icons@1.9.0 --dev yarn grunt copy:core_icons yarn grunt copy:extension_icons yarn grunt copy:install_icons yarn grunt copy:module_icons Resolves: #88467 Releases: master, 9.5 Change-Id: Ib04a694d5f68e5543a674bca4da7f957ae20ace3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60858 Tested-by:
-
c.essl authored
There is a "Images on this page" feature in the info module of the adminpanel. This patch adds a simple link icon for each listed image to easily open and view the images in a new tab. Resolves: #88438 Releases: master, 9.5 Change-Id: I150a44e40496f5d525094df7eb940c85e863ba90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60822 Tested-by:
-
c.essl authored
For IRRE relations with a "foreign_selector" relation set to a field of type "group" and internal_type "db", the backend wrongly rendered the message "Allowed file extensions". Instead "Allowed relations" is now shown for table relations. Resolves: #87747 Releases: master, 9.5, 8.7 Change-Id: I8a3b7686af14821ece0f727601c1a1bc0d5e1953 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60830 Tested-by:
-
