- Oct 10, 2024
-
-
Oliver Bartsch authored
This cleans up several details in the site configuration handling, especially in terms of caching. * Remove SingletonInterface from `SiteConfiguration` * Replace @internal properties with constants * Use injected services instead of duplicated makeInstance() calls * Replacing property based cache with runtime cache in `SiteConfiguration` Resolves: #105263 Releases: main Change-Id: Idbcd9553b1fa65ca5781ef838f12157a5024a349 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86546 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Christian Kuhn authored
The SiteFinder is an often injected service, but its stateful due to cache properties and suffers from improper cache eviction when SiteWriter changes site configuration. Note the overall class construct / separation of SiteConfiguration, SiteFinder and some related classes is a bit unfortunate and naming is not perfect. We may want to review these constructs in v14 again. * Avoid sites property altogether since it is a 1:1 call of SiteConfiguration->getAllExistingSites(), which has its own cache. * Declare readonly. * Use runtimeCache for "root id to identifier mapping", get runtimeCache injected. * Avoid loading all sites within __construct()! Do this on demand instead. * Listen on SiteConfigurationChangedEvent (by SiteWriter) to remove the runtime cache for automatic cache eviction on site changes. * Adapt some test cases. Resolves: #105264 Related: #105263 Releases: main Change-Id: Idea0f3d487b32a6b552f77ac52c539d6c793cd35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86548 Tested-by:
-
Oliver Bartsch authored
Resolves: #105247 Releases: main Change-Id: I972b4daec62d03c2413e2906cba47019cbbfab8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86530 Tested-by:
-
Benjamin Franzke authored
The SVG login logo contents will now be read from the original file pointer instead of the resolved absolute public URL in order to be accessible for local processing in a sub-directory installation. Reason: The resolved absolute public folder of a file path includes the sub-directory prefix. This absolute(!) URL must not be used as a relative(!) path within the sub-directory itself. Otherwise, the sub-directory is tried to be retrieved within the sub-directory itself once more. Example of incorrect absolute URL usage as a relative path: server docroot: /var/www/html/ installation path: /var/www/html/my_dir/ resolved URL: /my_dir/typo3/sysext/core/…/typo3_variable.svg incorrectly assumed local SVG path: /var/www/html/my_dir/my_dir/typo3/sysext/core/…/typo3_variable.svg ^^^^^^^^^^^^^ | invalid | ------------- Resolves: #105205 Releases: main Change-Id: I33f00d172ec0d375b90f79e163a0ba78ec65696f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86433 Reviewed-by:Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Kienast <akienast@scripting-base.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #105261 Releases: main Change-Id: I0d7c8eff5d4af070a4103ffacbbea461b9488efd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86544 Reviewed-by:
-
Christian Kuhn authored
* Use runtimeCache instead of a class cache property * Declare readonly * DI dependent services * Declare some safe to set types * Adapt tests * Fix a broken test in BackendUtilityTest that used backendUser and global language object before site configuration has been written Resolves: #105257 Releases: main Change-Id: I80aaca4ed0d71656fc01fa4676868c50e7d70d35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86537 Tested-by:
-
Benjamin Franzke authored
The TreeController was adapted with #104397 to reduce possibly unneeded getTreeLevels calls and refactored the condition that sets the hasChildren flag on a node object. It turns out that this caused search queries to miss the hasChildren flag, as the depth pre-condition always evaluated to false (treeLevelsToFetch is 999 is search-mode). Resolves: #105239 Related: #104397 Releases: main, 12.4, 11.5 Change-Id: I08dc14ae045afd8a526b83ac2b356841af84eacb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86521 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Oct 09, 2024
-
-
Simon Praetorius authored
With #105240 all test files of the filemetadata system extension have been removed. Thus, the composer root now defines a namespace for a folder that does not exist anymore. This patch removes the obsolete definition from the composer root file. The underlying bug in the new Fluid schema generator, which helped discover this issue, will be fixed with Fluid 4.0.2. Resolves: #105260 Related: #105240 Releases: main Change-Id: Ie9898844d0c948bc42ecaa85e971115204785a34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86542 Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
-
Chris Müller authored
Previously, the command exited with an error when an exception occured with Fluid 4.0.0. With Fluid 4.0.1 possible errors are caught and collected. The command now fetches these possible errors and outputs them on the console. This allows extension authors to see those problems which may hint to technical debts. Resolves: #105242 Related: #105187 Releases: main Change-Id: Id0d75dd40d3f94e04fdbf76ac4d3d87f80db45a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86360 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Christian Kuhn authored
Backend layout DefaultDataProvider receives some love: * Use DI and declare public:true since single backend layout data providers are created using GU::makeInstance(). * Relocate @internal BackendLayoutView::getDefaultColumnLayout() to a private constant of DefaultDataProvider. * Annotate DefaultDataProvider @internal since it is an interface implementing leaf class that should not be extended but exchanged using existing API. * Declare DefaultDataProvider readonly since it is now a stateless service. * Inline tableName property (a de facto constant) that is already hard coded at other places. * Avoid a silent catch that would trigger an exception at another place and add a @todo hinting about an indirect ext:backend cross dependency to ext:frontend. Resolves: #105255 Releases: main Change-Id: I0b1fc42c6e802198eae6d0f1089679b28f7feac4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86536 Tested-by:
-
Andreas Kienast authored
The recycler backend module now shows an actual hint that no record were found instead of showing an empty table. Resolves: #104936 Releases: main Change-Id: Icf668ec304552993806eba2bb3219a0c227a1345 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86046 Tested-by:
-
Christian Kuhn authored
DataProviderContext is a DO hand over to single backend layout providers. This is state that should be hand over and must not be injected, using SingletonInterface is an anti-pattern with this class. The patch: * Removes SingletonInterface * Introduces PCPP and instantiates with new() * Declares final * Deprecates all getters and setters * Prepares the class to be set readonly in TYPO3 v14 * Adapts usages * Adds a deprecation ReST Resolves: #105252 Releases: main Change-Id: I72ba069a70415d8b80512e288668d3ef9d9eb3ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86534 Reviewed-by:
-
Andreas Kienast authored
PHP's behavior of `exec()` [1] is flabbergasting: when writing the buffer, trailing whitespace characters are trimmed as follows: 1. the last PHP_EOL character is chopped 2. any left-over trailing literal space characters are trimmed Neither of this was handled in the implementation introduced in #104045, leading to unexpected output. This commit emulates the behavior of PHP's internal `exec()` function, restoring the previous behavior of `CommandUtility::exec()`. [1] https://github.com/php/php-src/blob/master/ext/standard/exec.c Resolves: #105251 Related: #104045 Releases: main Change-Id: I726b6ac0214f2cb3983db7b66c366a1fa58f93f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86533 Reviewed-by:
-
Christian Kuhn authored
TYPO3\CMS\Backend\View\BackendLayout\DataProviderContext is only relevant in DataProviderCollection when calling getBackendLayoutCollections(). TYPO3\CMS\Core\Page\PageLayoutResolver only calls getBackendLayout(), so the setup of DataProviderContext is not needed. The patch resolves this and thus reduces the dependencies from ext:core to ext:backend. Resolves: #105250 Related: #103466 Releases: main Change-Id: I23177858703ed2d6398ff3d23426f8025240d1c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86532 Tested-by:
-
Christian Kuhn authored
Class TYPO3\CMS\Core\Page\JavaScriptItems is a DTO. It is a contract between PHP and JS with some functionality on the PHP side to gather and prepare the data to transfer and to park state on PHP side. As such, this class can not be extended by extensions since that would break the contract. The patch thus declares the class final and changes instantiation to use new(). Resolves: #105246 Releases: main Change-Id: I312926489f529208fa067c4b174556a6f7db9c52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86527 Tested-by:
-
Benjamin Franzke authored
The `SelfEmittableLazyOpenStream` class used by FileDumpController uses `readfile` which is meant to be a performant way to send files to the webserver (implemented by PHP in C) and does not count as runtime memory usage (memory_limit) if the output is unbuffered. Make sure to clear any output buffers before emitting self emittable streams in order for PHP to be able to send the files without copying the contents into a temporary buffer (counting towards memory limit). Resolves: #105212 Releases: main, 12.4 Change-Id: I3528f31c099b5d1cd3f8ba287a4eb45955ff3510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86518 Reviewed-by:
-
- Oct 08, 2024
-
-
Christian Kuhn authored
Inject NodeFactory in a series of missing places instead of retrieving an instance via GU::makeInstance(). Resolves: #105241 Releases: main Change-Id: Ie3c937f557a626cacff04339b4a14497f0c289ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86520 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
Removes two unused internal methods, which were only kept for backwards compatibility. Resolves: #105232 Releases: main Change-Id: I95511a0d46c1c659c2c0e014b5043da57c4b8523 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86492 Reviewed-by:
-
Christian Kuhn authored
Remove a bunch of functional tests that essentially test TCA configuration: * The tests add no crucial value from a functional test point of view since they don't test code but configuration. * These tests have been introduced to enforce consistency within BE. This is a UX thing that should not be tested on a functional test base level, if at all. * FormTestService is problematic from a maintenance point of view and needs continious changes since dependencies can not be handled in a good way. * The tests are doomed to be inconsistent since they will never catch new fields that may have been added to TCA tables over time. Resolves: #105240 Related: #78383 Releases: main Change-Id: I29f63e4ec3eead87a9151a468eb68993b3f437cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86519 Tested-by:
-
Nikita Hovratov authored
Resolves: #104947 Related: #102834 Releases: main Change-Id: I2688e2e51825a6930864e272b1494dd8afc75888 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86076 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Thomas Hohn authored
In the method FileLinkHandler:resolveHandlerData() the call to FileLinkHandler:resolveFile() handles the FileDoesNotExistException correctly. But if it returns null this will lead to a type error. This patch handles the null value properly. Resolves: #104659 Releases: main, 12.4 Change-Id: Iacf3ef8e72d7c18b4b15758da8780d94a9282a96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85677 Reviewed-by:
-
Oliver Bartsch authored
This ensures that `pi_flexform` is actually set, before accessing it and also only tries to convert it, in case it's still a string. Resolves: #105231 Releases: main, 12.4 Change-Id: If6210c9d23db97cac36f904984490e6bf0195ab7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86471 Reviewed-by:
-
Oliver Bartsch authored
On processing a redirect parameter for fetching the backend module it is now properly checked whether the resolved route is a module route. Resolves: #105228 Releases: main, 12.4 Change-Id: I2a09a9a375187c17632f5a7e3a2e3e45a3e39d77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86469 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
André Buchmann authored
Check the pi_flexform value of the request attribute 'currentContentObject' to be of type string before parsing with GU::xml2array(). Resolves: #105195 Releases: main, 12.4 Change-Id: I915deeb89c39b4b90342da582b05acc98a7b86fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86417 Tested-by:
-
Christian Kuhn authored
We worked hard on TypoScriptFrontendController in TYPO3 v13 leaving mainly internal code and usages. A couple of details are still left open, and we can't tackle them in v13 anymore due to time constraints. The most notable area is the main content generation trigger and the *_INT processing. However, all non-internal usages by extensions can be substituted. Usually by using new attributes of the request. The goal is still to get rid of TypoScriptFrontendController in TYPO3 v14. The patch prepares this by declaring TypoScriptFrontendController fully deprecated, even though with some left over internal usages. TYPO3 v14 will see a few preparation patches to reach this goal. The patch polishes a ReST file from 13.0 to add some more "Use this instead" information, and adds a new ReST file declaring TypoScriptFrontendController and $GLOBALS['TSFE'] deprecated. Resolves: #105230 Resolves: #105046 Related: #102621 Related: #104217 Releases: main Change-Id: I0d9ab50e4be9724895f5f2763c0be2ab731cd9f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86493 Reviewed-by:
-
Christian Kuhn authored
Resolves: #105233 Related: #105231 Releases: main Change-Id: Ie8aa214eae6ebe42a4a9c81864e78c65bb1dd437 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86503 Reviewed-by:
-
Christian Kuhn authored
Fourth argument is set but never used and there is no get'er. Resolves: #105236 Related: #103466 Releases: main Change-Id: I81b82b4e1bc55c855f3c914d85747fd8789ba60c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86511 Reviewed-by:
-
Benjamin Franzke authored
The aspects array-key is always set because the capture is not nested and filled in any case. That means: If preg_match was successfull (which is checked before), aspects have been found as well. Executed commands: composer require --dev phpstan/phpstan:^1.12.6 Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #105226 Releases: main, 12.4 Change-Id: I95f5a12b0b66b88af68bd1a7dc6357699e8a8e9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86465 Tested-by:
-
Oliver Hader authored
Backend users were able see page tree items without having access: - in case no DB mounts were configured for a particular user and page permissions configured to allow "everybody" - in case DB mounts were pointing to pages, but actually not having any permission configured for these pages (user/group/everybody) It was not possible to manipulate any of the affected pages. Resolves: #104397 Releases: main, 13.3, 12.4, 11.5 Change-Id: I52079c8cef3d78946083403adb23a3e1a706c652 Security-Bulletin: TYPO3-CORE-SA-2024-012 Security-References: CVE-2024-47780 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86501 Tested-by:
-
Oliver Hader authored
Resolves: #104343 Releases: main, 13.3, 12.4, 11.5 Change-Id: Ie9cd7bec43782282a142ad0911029579442734fd Security-Bulletin: TYPO3-CORE-SA-2024-011 Security-References: CVE-2024-34537 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86500 Tested-by:
-
Andreas Kienast authored
The delete button for sys_notes rendered in the record list is currently nested in a form tag, breaking the user interface. Since this requires a DataHandler call, the button is converted to a Lit component that invokes the `AjaxDataHandler` module. Resolves: #105229 Releases: main Change-Id: I87339d318b94bd2f20d1e24a9bc0270abdfd9ce4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86470 Reviewed-by:
-
Sven Jürgens authored
The API code snippet is related to 'DatePicker' and not to 'AdvancedPassword', probably due to a copy&paste mistake. Releases: main, 12.4, 11.5 Resolves: #105207 Change-Id: Icb57f4f053c8ce86e093bcdfd0f836145c692602 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86435 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Oliver Bartsch authored
Both ElementInformationController as well as RemoteServer previously booted up FormEngine to fetch relevant fields for being displayed in corresponding views. This is bad in multiple terms: performance, misuse of FormEngine, dependency to PSR-7, etc. Therefore, a new VisibleSchemaFieldsCollector is introduced, which uses the TCA schema to provide the fields to be displayed, depending on the record type, the language context and the current backend user. Resolves: #105185 Releases: main Change-Id: I1e39611db467105ddaf2427dc47c7bd94ef7a915 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86405 Tested-by:
-
Garvin Hicking authored
With a larger refactoring of #96473 type hinting was introduced for `AbstractFormViewHelper->renderHiddenIdentityField()`. The phpdoc annotation previously hinted at the input being of type 'object' (or null), and the type hint was thus set to 'object', too. However, the argument restriction of a ViewHelper like `FormViewHelper` defined an 'object' of type 'mixed', and would thus allow arrays. Arrays do not need a hidden identity field, so returning '' for that would allow the ViewHelper to function properly. With this patch, the type hint is changed to 'mixed' now, so that previous ViewHelper usages with arrays should be restored again and not lead to a type exception. Resolves: #105146 Resolves: #103162 Related: #96473 Releases: main, 12.4 Change-Id: I8a431e8909efb2e8d5ad041c69a0c75b7296c721 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86367 Tested-by:
-
Benjamin Kott authored
Resolves: #105227 Releases: main Change-Id: I8bf52b22bc08b596d29041a9a8f962019f8edb7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86468 Reviewed-by:
-
Benjamin Kott authored
Resolves: #105222 Releases: main Change-Id: I3fd765bf2450880b3b498ebce6f83589e2c5a15c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86453 Tested-by:
-
- Oct 07, 2024
-
-
Stefan Bürk authored
Resolves: #105196 Releases: main, 13.3, 12.4, 11.5 Change-Id: I681c2d284097e3e0af604f991e12c7e0fbc76472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86419 Tested-by:
-
Oliver Bartsch authored
The sub types feature of TCA was used for registration of plugins as "list_type". Since it's encouraged to register plugins as CType since a couple of versions already and the deprecation of the "list_type" functionality with #105076 are the sub types now deprecated as well. This special functionality just lead to headaches and should be replaced by using dedicated record types, making configuration much cleaner and more comprehensible. Resolves: #105213 Related: #105076 Releases: main Change-Id: If9ce3f5de7ef69aaf16cf987ebcb62ea50f9a6a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86425 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Benjamin Franzke authored
Resolves: #105218 Related: #105028 Releases: main Change-Id: Id9299db6d9a5dc3529be5dfd0f1fc0d30e8eb3aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86445 Tested-by:
-
Andreas Kienast authored
The `setup` command asks whether a basic site shall be created when installing TYPO3. The question implies that it defaults to "no" value, but fails to accept "no" as input given by the user. This commit adds a normalizer for that question that converts "no" to an empty string, having the same effect as stepping through the question by providing no input at all. Resolves: #105203 Releases: main, 12.4 Change-Id: Ifcbccfa0c3c17304412112318ffc5bb0f0e87790 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86446 Tested-by:
-
