[TASK] Instantiate JavaScriptItems with new()
Class TYPO3\CMS\Core\Page\JavaScriptItems is a DTO. It is a contract between PHP and JS with some functionality on the PHP side to gather and prepare the data to transfer and to park state on PHP side. As such, this class can not be extended by extensions since that would break the contract. The patch thus declares the class final and changes instantiation to use new(). Resolves: #105246 Releases: main Change-Id: I312926489f529208fa067c4b174556a6f7db9c52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86527 Tested-by:Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php 3 additions, 3 deletions...xt/backend/Classes/Controller/FormFilesAjaxController.php
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php 1 addition, 1 deletion...ext/backend/Classes/Controller/FormFlexAjaxController.php
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php 3 additions, 3 deletions...t/backend/Classes/Controller/FormInlineAjaxController.php
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php 2 additions, 2 deletions...t/backend/Classes/Controller/SiteInlineAjaxController.php
- typo3/sysext/core/Classes/Page/AssetRenderer.php 5 additions, 16 deletionstypo3/sysext/core/Classes/Page/AssetRenderer.php
- typo3/sysext/core/Classes/Page/ImportMapCacheWarmer.php 4 additions, 7 deletionstypo3/sysext/core/Classes/Page/ImportMapCacheWarmer.php
- typo3/sysext/core/Classes/Page/ImportMapFactory.php 6 additions, 6 deletionstypo3/sysext/core/Classes/Page/ImportMapFactory.php
- typo3/sysext/core/Classes/Page/JavaScriptItems.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Page/JavaScriptItems.php
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php 7 additions, 1 deletiontypo3/sysext/core/Classes/Page/JavaScriptRenderer.php
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php 3 additions, 20 deletions.../sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php
Please register or sign in to comment