- Aug 15, 2022
-
-
Elias Häußler authored
With #93887 (respectively #92406), a more convenient rendering mechanism for forms was introduced. A new FormRequestHandler centralized all the logic from the <formvh:render> view helper to allow smoother form handling. However, the new implementation used to hide the current ContentObjectRenderer implementation and instead always fetched a new instance with GeneralUtility::makeInstance(). This no longer allows to determine the current content object rendering context from e.g. form finishers. Since the current implementation can be retrieved by the ConfigurationManager, it is now used in the <formvh:render> view helper, falling back to a new ContentObjectRenderer instance in case the ConfigurationManager does not actually provide an instance of ContentObjectRenderer. Resolves: #97977 Related: #93887 Related: #92406 Releases: main, 11.5 Change-Id: Iabf4e93e6aff8da742321958730521ef1696f130 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75447 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Nikita Hovratov authored
With #88276 a new condition has been implemented to check for current selected pageLayout in FE and BE, example: [tree.pagelayout == "pagets__simple"] This has various bugs. Frontend: * The evaluation stops at the sys_template record that has 'root' flag set. This is not in-line with the backend condition implementation, which goes further up in rootline. * The evaluation does not look for first specified layout up in rootline, but goes from root down to selected page. The condition thus calculates wrong layout when different 'backend_layout_next_level' are nested on rootline pages, it picks the uppermost set, not the lowermost one. This is fixed by using TSFE->rootLine instead of tmpl->rootLine, since TSFE->rootLine provides the full rootline in correct order. Backend: * Similar to FE, the evaluation should go up in rootline, but is processed downwards instead. This is fixed by handing over the 'reversed' full rootline. The v12 version of the patch is slightly different: Patch for issue #97963 introduced yet another bug by accessing TSFE->config['rootLine'], which isn't set at all at this point in the frontend processing chain when the page is not yet cached, or has no USER_INT or COA_INT. Resolves: #98044 Related: #88276 Related: #97963 Releases: main, 11.5 Change-Id: I1dc9a4dfc6aea6bec4d8e2eb65a6919d486f4a99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75444 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Aug 13, 2022
-
-
Georg Ringer authored
Providing the exception message helps to understand and solve the issue as the exception can also be thrown by a 3rd party extension. Resolves: #97770 Releases: main, 11.5 Change-Id: I53ff25a141c3d3b522d5eabd270309dbdda7709f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75434 Tested-by:
theline <typo3@root-access.de> Reviewed-by:
-
Nikita Hovratov authored
The former approach in #91808 to fix scoped toggling didn't work with levelLinksPosition "bottom", as the querySelector could find another control container inside another child inline field first. Another solution, which is now possible, works with the ":scope" selector. Only nodes with a direct parent will be found this way. In addition, a new helper class is added for the top control container, as it is wrapped in another div. This enables toggling of both buttons, in case levelLinksPosition "both" is set. Resolves: #97786 Related: #91808 Related: #92382 Releases: main, 11.5 Change-Id: I67146c372d183cd647db847b3e3d83d986585577 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75435 Tested-by:
-
- Aug 12, 2022
-
-
Michael Hitzler authored
The YouTube helper tries to fetch from highest to lowest image for possible previews. The "sd" and "hq" versions were missing while checking for an available image and got added. Resolves: #98098 Releases: main, 11.5 Change-Id: Idec13fdc5c820e6674f8ccebd610455b50d57895 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75456 Tested-by:
-
Helmut Hummel authored
When using the custom element <typo3-backend-icon> with a JS framework, that renders the DOM (e.g. Vue), it can happen, that they set the properties of the custom element instead of an attribute. Since Lit does not reflect these properties to attributes by default, but the icon-element relies on CSS set on the host element that depends on the size attribute, the icon is not rendered in the correct size. See: https://web.dev/custom-elements-best-practices/ on why reflecting properties to attributes might be a good idea in some cases. Releases: main, 11.5 Resolves: #98121 Change-Id: I8435946ad6e6d92b8ec50dd7e289279261d43d5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75415 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Daniel authored
If a sys_file record is directly deleted from database, some undefined array index warnings are triggered if the file is assigned to another database record. Releases: main, 11.5 Resolves: #97987 Change-Id: I2ce115024e637cffacc512528e79b1bb4059f173 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75455 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
This reverts commit b2bb5994. Reason for revert: The commit-msg hook now tends to throw away the message. Fully loosing a commit message is worse than a funny exit code. We revert for now and eventually come up with a different solution later. Change-Id: Ifae1f2658a95c09591fdc5a857084064090a5f82 Reverts: #98094 Resolves: #98094 Releases: main, 11.5, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75454 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Benjamin Kott authored
While trying to restore the full desktop functionality aka mouse and keyboard behavior on a touch-device we came to the conclusion that it feels unintuitive. On touch devices, you have by design fewer input options and differentiators than with dedicated input devices like a mouse. It feels best to disable the drag and drop behavior and enable a smooth scrolling and navigation experience. Resolves: #91755 Resolves: #86946 Resolves: #93960 Releases: main, 11.5, 10.4 Change-Id: Ic08d06283cbb2331ff49983bd7d18b446f8bd76a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75430 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
The StandardContentPreviewRenderer still contained special handling for the tt_content.select_key field, which however was already removed in #77934. The leftover is now removed together with related locallang labels. Resolves: #98125 Related: #77934 Releases: main, 11.5 Change-Id: I38ae07a4eced0cbd3f5ed3076661b70081252321 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75428 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Tomasz Woldański authored
Patch extracts generating url for workspaces in order to better integrate with external extensions, so when external extension want to replace url, extension does not have to override whole handleRequest method. Resolves: #98112 Releases: main, 11.5 Change-Id: I8c8e18fbe7dfecd2ccd400681588d984ac233178 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75367 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 11, 2022
-
-
Česlav Przywara authored
Releases: main, 11.5 Resolves: #98115 Related: #92118 Change-Id: Ibcd5fa26155dbb36216422e1c806c9a4035d878f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75371 Tested-by:
-
Benni Mack authored
Due to a regression in TYPO3 v11.5.11, using typolink.parameter with stdWrap might also return more than just the URL. This change reverts this behavior by overlaying the decoded typolink string with the original decoded typolink string. Resolves: #97869 Related: #90404 Related: #80896 Releases: main, 11.5 Change-Id: I22010983886a8da8a339aa6376d36303f3b729b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75366 Tested-by:
-
Stefan Bürk authored
With #97989 correct workspace overlays in DataMapProcessor should be used to fix a bug. This introduced a failing default "where" if a child table is not workspace aware. The fix itself is straight forward: Query t3ver_wsid field only if the target table is workspace aware. In contrast to the TYPO3 v12 (main) version, the v11 backport delivers just the code change, since functional test structures have been modernized a lot in v12 already. Resolves: #98103 Related: #97989 Releases: main, 11.5 Change-Id: Id8cb51623b206b5effd57823a28099ce7d545b7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75418 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Aug 10, 2022
-
-
Benni Mack authored
With the fix of using versioned numbered filenames for the TYPO3 Backend, a use-case "absolutely referenced, but relative to public path file" did break for Frontend inclusions of CSS or JS files. This is now overcome by only using the original bugfix in the TYPO3 Backend. Resolves: #98106 Related: #97939 Releases: main, 11.5, 10.4 Change-Id: Iff6251bd95e1c0a93a6f5538b9f560e55ba80b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75368 Tested-by:
-
Sybille Peters authored
Resolves: #98119 Releases: main, 11.5 Change-Id: If5e926d002e877e674548f63b8639acf62d5bf99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75370 Tested-by:
-
Markus Klein authored
Resolves: #98113 Releases: main, 11.5 Change-Id: Ia996d0e66f381d71699b33a42e4c8f72bf890054 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75365 Tested-by:
-
- Aug 09, 2022
-
-
Stefan Bürk authored
This patch raises "typo3/class-alias-loader" which contains some bugfixes. Used commands: > composer req "typo3/class-alias-loader":"^1.1.4" \ --no-update -d typo3/sysext/core > composer req "typo3/class-alias-loader":"^1.1.4" Resolves: #98102 Releases: main, 11.5 Change-Id: I772a40dd9676afc7721e819077f05662ce2c6bd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75397 Tested-by:
-
Benni Mack authored
Change-Id: I2195a2186e5053c41a7dcc41a381f9dd9f6379b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75399 Tested-by:
-
Benni Mack authored
Change-Id: Iec25384c741494f4d36eb3e49af90d23682a3a6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75398 Tested-by:
-
Thomas Maroschik authored
Scenario: Given is a cluster of containers/servers that run multiple instances of the same TYPO3 instance. A load balancer round robins requests to those instances. Problem: A backend user logs in and gets a broken backend. No CSS and JavaScript is loaded. Requests to those resources return HTTP 404 errors. Analysis: TYPO3 concatenates assets on the fly per backend module when they are requested and saves them to a local temporary folder. As requests are routed to different containers on every request, the probability of hitting an container/server where the resulting asset is not yet generated, is very high (basically always). The only way to circumvent this, is to put the backend in debug mode, which has other unwanted side effects. Solution: Deactivate asset compression/concatenation altogether for the backend. As most servers deliver HTTP2/3 nowadays, the performance impact should be minimal. By skipping unnecessary processing and allowing browser caching, performance could be even increased. Resolves: #97936 Releases: main, 11.5 Change-Id: Ic696f4a3618e5bed3388ab0262ce2867d334723f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75362 Tested-by:
-
- Aug 08, 2022
-
-
Alexander Schnitzler authored
To gather information about properties of domain objects, extbase used method DomainObjectInterface::_getProperties() which internally used get_object_vars() which does not return uninitialized properties. This leads to the inability to use such uninitialized properties in models. Hence, those properties are not reconstituted at all when converting an object instance from a database row, eventually leading to fatal errors. To mitigate this issue, extbase does now use the existing information about classes gathered via ClassSchema which gathers information via reflection (anyway). Releases: main, 11.5 Resolves: #95819 Change-Id: I00e2eb4967631ca28a5889e934fd409fd3fdef96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75363 Tested-by:
-
Ralf Zimmermann authored
The patchset https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/ has moved the business logic from the RenderViewHelper to the FormRequestHandler. Thereby the process for detecting the prototype name was changed by mistake. The result is that custom prototype names are no longer applied. This patchset restores the correct behavior. Resolves: #98023 Releases: main, 11.5 Change-Id: I5d59e56c0c071879ad60321dd9d82a56cde94172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75225 Tested-by:
Daniel Gohlke <daniel.gohlke@extco.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
Kevin Appelt authored
Resolves: #98078 Releases: main, 11.5 Change-Id: Ic177eeb9581c1513076e2e3301f29c0f97de5cd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75394 Tested-by:
-
- Aug 07, 2022
-
-
Georg Ringer authored
To avoid a type error the method `EditDocumentController::generatePreviewCode` must also allow null as return value because the called method `PreviewUriBuilder::buildImmediateActionElement` can return null as well. Resolves: #98071 Releases: main, 11.5 Change-Id: Icb021503f8dc6417baa9f2c2f883ec426f92dfb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75361 Tested-by:
-
Rémy Daniel authored
When sql strict mode is enabled on the database server, if a value has a wrong data type for the database column, the INSERT or UPDATE query will fail. This happened during a t3d import: relationships are lost. This patch fixes the issue by using the TCA default value for the field. Resolves: #89103 Releases: main, 11.5 Change-Id: I7e995f10359c6935f6b9a50b1150c31e63937ab9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75391 Tested-by:
-
Simon Schaufelberger authored
Resolves: #98094 Releases: main, 11.5, 10.4 Change-Id: If84f67d6ac91aeaa47849067e21bef6b13854f3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75359 Tested-by:
-
Tomas Norre Mikkelsen authored
This adds back the cursor pointer when hovering toggle checkboxes, common checkboxes and radio-buttons. Resolves: #97836 Releases: main, 11.5 Change-Id: Ib4083b95ec76f0909a31788d3e07a3321b8d63ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75390 Tested-by:
-
- Aug 06, 2022
-
-
Xenia Thiem authored
Resolves: #97248 Releases: main, 11.5 Change-Id: I2f9e3f9f2d530c5e416d57ec7e6b2d68a2b85531 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75358 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Chris Müller authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186 the Fluid-based page view layout was introduced. However, a leftover setting from the development of this feature remains in the TYPO3_CONF_VARS setting: BE|fluidPageModule. Instead, a feature flag was used to switch to the deprecated page view layout. See also the comment in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186/50/typo3/sysext/core/Configuration/DefaultConfiguration.php#1078 Resolves: #98095 Related: #90348 Releases: main, 11.5 Change-Id: I8ed24782b53673dc7759bf158fe02186f84c16c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75357 Tested-by:
-
Andreas Fernandez authored
FontAwesome provides CSS classes that align with the old Bootstrap v3 classes, which will cause troubles with the removal of FontAwesome. As another preparation task, those classes are be replaced with the according Bootstrap classes. Classes replaced: * pull-left -> float-start * pull-right -> float-end * sr-only -> visually-hidden Resolves: #98064 Resolves: #94531 Releases: main, 11.5 Change-Id: I4e96572e6b3a0007a7bf68f3018934f73da6249b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75375 Tested-by:
-
- Aug 05, 2022
-
-
Simon Schaufelberger authored
Since the persisted file is stored with a sanitized filename, it must be replaced with a sanitized file name as well, otherwise an error occurs that the source with the un-sanitized file name could not be found. Resolves: #98005 Releases: main, 11.5, 10.4 Change-Id: I9b38316f7a25a281521bff787956dcd6373249d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75355 Tested-by:
-
Stefan Bürk authored
Quite some issues with docker-compose v2 have been fixed We'll now try to use it again and remove a v1 restriction in `Build/Scripts/runTests.sh`. Resolves: #98086 Releases: main, 11.5, 10.4 Change-Id: I7e4ff82df374db33ba42db0e0d1483f6320ba9ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75353 Tested-by:
-
- Aug 04, 2022
-
-
Oliver Bartsch authored
The element information component displays all the records' field values. In case a TCA field does not have a corresponding database field (e.g. with TCA type "none") it is now skipped to prevent PHP errors. Resolves: #97999 Releases: main, 11.5 Change-Id: I817f1dda4275f262768dfbe8440a57d9d6240f7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75352 Tested-by:
-
- Aug 01, 2022
-
-
Benni Mack authored
When using routing and custom enhancers to find out what page translation was exactly used to build special logic for Page resolving, the two language-related properties "sys_language_uid" and "l18n_cfg" are now loaded (and thus, added to the "_page" property of a Route) as well. This is useful as l10n_parent is already loaded anyways. Resolves: #98042 Releases: main, 11.5, 10.4 Change-Id: I23f964d5d22f27a9affebfeae87906d9549efda0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75229 Tested-by:
-
- Jul 31, 2022
-
-
Andreas Fernandez authored
Bootstrap is updated to 5.2.0. Due to a behavior change (perhaps a regression), carousels need adoption if they shouldn't slide automatically as the old approach results in indefinitely sliding: ``` - <div class="carousel slide" data-bs-interval="0" data-bs-ride="carousel"> + <div class="carousel slide" data-bs-ride="false"> ``` However, this is also documented at [1]. Executed commands: cd Build nvm use yarn add bootstrap@^5.2.0 yarn add --dev @types/bootstrap@^5.2.0 grunt build [1] https://getbootstrap.com/docs/5.2/components/carousel/#options Resolves: #98051 Releases: main, 11.5 Change-Id: Ic9c284d9edb3881b4cc8663fad3747c19f078613 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75340 Tested-by: -
Christian Kuhn authored
TCA fields having displayCond='HIDE_FOR_NON_ADMINS' can not be selected as "exclude" fields in user group setup access rights setup. It does not make sense to mark those exclude=true, the patch removes that from affected fields. Change-Id: Ia75248122bb645bd24c7948c7b4b82d2555ed9ee Resolves: #98046 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75339 Tested-by:
-
Peter Kraume authored
Resolves: #98059 Releases: main, 11.5 Change-Id: I078db9039c2f0acb05933fa6a86ca5d73b3fb5d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75231 Tested-by:
-
- Jul 30, 2022
-
-
Stefan Bürk authored
Using database queries without deterministic sorting definition may lead to unreliabe resultsets in some dbms type and version, which also may change over time. Thus it's good practice to have proper defined sorting for queries, at least if result relies on a constant and reliable result sorting. With #96512 and #97774 additional tests has been added, which showed the unreliable of these database queries, blocking the bugfix backport to TYPO3 v10.4. This patch adds sorting definition to two db queries in `\TYPO3\CMS\Backend\Tree\Repository\PageTreeRepository` to ensure consistent results in a deterministic manner and make it possible to provide the related bugfix for TYPO3 v10.4. Resolves: #98056 Related: #96512 Related: #97774 Releases: main, 11.5, 10.4 Change-Id: I8a1bf3b93bcfcaec4c3de3ea6321db62847d0c21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75335 Tested-by:
-
Larry Garfield authored
The $result property's doc type is causing issues for PHPStan. Switching it to a typed property and state resolves them. Other types have been filled in as well as they're private so safe. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98002 Releases: main, 11.5 Change-Id: Ic960858eee4cd40ed010762a44dec944f5114e4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75334 Tested-by:
-
