- Feb 13, 2017
-
-
Helmut Hummel authored
Refactor rendering to use two templates, a layout and a partial to be more flexible. Now also force the crop to be applied, even when the editor does not open the image manipulation. This is important when only one aspect ratio is allowed to not allow the editor to save an invalid state. Eliminate several quirks in the TypeScript code, among them: * reset state when closing the cropper * reset state when modal is dismissed * correctly initialize all previews * show correct size of crop area for big images * avoid accidental dismiss of the modal Last but not least add the accidentally removed form engine wizard html fields again. Resolves: #79764 Resolves: #79731 Resolves: #79753 Resolves: #79674 Releases: master Change-Id: I0a24d6418d6263b00c3fbf31901fd7c67e9fc97e Reviewed-on: https://review.typo3.org/51642 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Tymoteusz Motylewski authored
Acceptance tests for Template module are fixed - seems that element with #ts-overview is not rendered any more when showing table on installation root (pid 0) - the correct id of the site root ("styleguide TCA demo") is #extdd-3 - fix scheduler tests after tooltip were added (title => data-original-title) - adapt tests after context menu refactoring Resolves: #79771 Releases: master Change-Id: I48879315b81267ae65ef92003c5034cbb62d576e Reviewed-on: https://review.typo3.org/51648 Tested-by:Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Feb 12, 2017
-
-
Oliver Hader authored
Wrong data-provider in TcaMigrationTest Resolves: #79242 Releases: master Change-Id: I1dd42c6c47532b61906204f3fa39b45b70a3462c Reviewed-on: https://review.typo3.org/51649 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Georg Ringer authored
To make the doc header nicer on smaller (13") screens, the following changes are applied: - Remove the label of the language select box - Remove the media query Resolves: #79701 Releases: master Change-Id: Ie3581c37f4169c89aa72aa3a429dbdf073901e0f Reviewed-on: https://review.typo3.org/51602 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christer Vindberg authored
In CssStyledContentController::render_textpic if $accessibilityMode evaluates to false and $separateRows is also false, $allRows is never added to $thisImages. This causes images to not be outputted to the frontend. Resolves: #79687 Releases: master Change-Id: I918741aaa8724837ef87567d481072ceedf275fa Reviewed-on: https://review.typo3.org/51585 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Georg Ringer authored
Move the 2 fields of tt_content into one table definition. Resolves: #79767 Releases: master Change-Id: Ie376d095f1ebc4611635b0c487d43796ffa6fdc9 Reviewed-on: https://review.typo3.org/51645 Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Josef Glatz authored
Remove unused array `$migrateFields` in `migrateRequestUpdate()`. Fix a small typo in PHPDoc block. Resolves: #79762 Releases: master Change-Id: I0bb22b01c1d963ef3788bff9437343fc826861ff Reviewed-on: https://review.typo3.org/51639 Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Thomas Hohn authored
Looking at the selects performed on sys_log in the core of TYPO3 reveals that a combination of tstamp, type, userid should giver a better performance for at least 2 SQL statements. One performing a full-table scan - the other approximately half a full-table scan. On installations where a few users have created a lot of entries in sys_log the existing indexes event and user_auth will return too many rows compared to the new combined index. Especially the method printLogErrorMessages in the DataHandler benefits from this index. Resolves: #79696 Releases: master Change-Id: I3e115b8b5a3cc9cd134d0cc995a06488134be40d Reviewed-on: https://review.typo3.org/51595 Tested-by:
-
Marcus Schwemer authored
The itemValue of a field might be null, which is not accepted by getLinkExplanation(). Add a check to ensure we always pass a string. Resolves: #79749 Releases: master Change-Id: Ic1b80faf1e2cc8c4e4119238225c6480a66c4cdc Reviewed-on: https://review.typo3.org/51628 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Dominique Kreemers <dominique.kreemers@icloud.com> Tested-by:
-
Christian Kuhn authored
ListOfFieldsContainer of FormEngine render construct is used to reduce the field list of a full record down to a given list of fields that should be rendered, only. It is triggered for instance from the list module if only a single field of multiple different records should be edited at once. Until now, the container did not fully validate if a given field actually exists within the showitem field or palette and basically delegated the handling down to a different container which in the end skipped that field if it was not configured in TCA for given record type. The patch fixes this by improving the lookup. Field rendering is no longer delegated down to other containers if the field in question does not exist within the 'types' section and is not within a referenced 'palette' of given record type. Change-Id: I750ebf7c3d87ecb381f7bbe21b63528765841277 Resolves: #79750 Releases: master Reviewed-on: https://review.typo3.org/51630 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Feb 11, 2017
-
-
Nicole Cordes authored
The session id regeneration must not touch the sys_anonymous field of the session record, since it only exists for FE session. The FrontendUserAuthentication is responsible for this. Resolves: #79757 Releases: master Change-Id: Iefcc678b9171830b587432fa7fbbc9e77033931f Reviewed-on: https://review.typo3.org/51635 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Andreas Fernandez authored
Resolves: #79729 Releases: master Change-Id: I689e8ecd0ffa2d005931e6162fb8df5d9694da3d Reviewed-on: https://review.typo3.org/51629 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
Nicole Cordes authored
The unit tests for RedisSessionBackendTest rely on a class \Redis which might not be available on all systems. Therefore the tests should be skipped to not fail. Resolves: #79758 Releases: master Change-Id: Ie14911e7ba90eaffd32585c1c18d642996bbf74c Reviewed-on: https://review.typo3.org/51636 Tested-by:
-
Christian Kuhn authored
FormEngine is a two-fold process: First all dependent data is compiled into main "data array" by data providers, then the render engine uses this array to render forms. The main data array is restricted, top level keys can not be added or removed by single data providers. With the recent refactorings on element level, it is now much easier to create powerful extensions to single elements. Those may need additional data, the rest of the FormEngine doesn't know about. To allow custom data providers adding data that is not related to other keys from the data array, a general "customData" is introduced to the array. This is not filled nor used by core related classes, but it can be used by extensions to park data here. For v9, we will probably see another patch giving the form data groups control about the data array structure, but that may follow later. For v8 and v7, allowing custom data should solve the one or the other data provider usage for now. Change-Id: I8e88ec8f9e55eed7fc4a58590cbb5ead19baaae3 Resolves: #79747 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51627 Tested-by:
Artus Kolanowski <artus@ionoi.net> Tested-by:
-
- Feb 10, 2017
-
-
Anders Kostending authored
New features: * Added a new pastel color palette for the Color Button plugin and a new config.colorButton_colorsPerRow configuration option for setting the number of rows in the color selector. * Added a new Azerbaijani localization. * It is now possible to group Widget style definitions, so applying one style disables the other. Fixed Issues: * [Chrome] Fixed: It is possible to type in an unfocused inline editor. * Fixed: Font size and font family reset each other when modified at certain positions. * [Edge] Fixed: List items are lost when pasted from Word. * [Edge] Fixed: A list gets pasted from Word as a set of paragraphs. Added the config.pasteFromWord_heuristicsEdgeList configuration option. * Fixed: Context menu items can be dragged into the editor. * [IE] Fixed: Copy Formatting breaks the editor in Quirks Mode. * [IE] Fixed: Copy Formatting breaks the editor in Compatibility Mode. * Fixed: Styles applied with Copy Formatting to a single table cell are applied to the whole table. * Fixed: element.setSize sets incorrect editor dimensions if the border width is represented as a fraction of pixels. * [Firefox] Fixed: Unable to paste images as Base64 strings when using Clipboard. * Fixed: JavaScript error is thrown when trying to use Find in a <div>-based editor. Resolves: #79689 Releases: master Change-Id: I7e610452ffbab821325cd565dd02fd7bf84fc918 Reviewed-on: https://review.typo3.org/51584 Reviewed-by:
-
Oliver Hader authored
The data-map processing for "allowLanguageSynchronization" tries to resolve language dependencies for IRRE child records, without doing a check wether the the child table does support translation at all. In a result the built database query fails. Resolves: #79746 Releases: master Change-Id: I846c9e47346f5a4d2eb05e3eee639ba179a06419 Reviewed-on: https://review.typo3.org/51631 Tested-by:
-
Markus Klein authored
The data type of customMessage has been changed to string a while ago but the method signatures still have a mixed-type. Normalize this over all updates to make things consistent again. Resolves: #79739 Releases: master Change-Id: I840cc6d217dafb1a83f0af5b7a978fdc60318d5d Reviewed-on: https://review.typo3.org/51624 Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Andreas Fernandez authored
With the removal of the ExtJS state providers, the polyfill `TYPO3ExtJSStateProviderBridge` with a limited functional subset was introduced. Previously, changes were queued to reduce the amount of requests, which got lost since then. This was a complex workaround in first place and the real issue that the same data is sent *per node* lies somewhere deep in ExtJS and was never fixed. As we aim to get rid of the last pieces of ExtJS sooner than later, the queueing mechanism is added again keep the load low and to worship our servers. Resolves: #79693 Related: #79227 Releases: master Change-Id: Ibcccd9be183437192027cbfab634515f710728c6 Reviewed-on: https://review.typo3.org/51591 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
Nicole Cordes authored
Currently no record titles for nested inline elements are shown. Due to the current method to resolve a record title for an inline element always an empty title is returned as there is the same processing as for select fields. This patch introduces an own resolving method according to the already resolved children attached to the current field. Resolves: #78726 Releases: master, 7.6 Change-Id: I7f62ad843552534b36c0ccd91488c79ff796ec0c Reviewed-on: https://review.typo3.org/51115 Tested-by:
-
Tymoteusz Motylewski authored
Since context menu refactoring https://review.typo3.org/#/c/50124/ the context was not showing when right clicking on the page title in the page tree. Resolves: #79710 Releases: master Change-Id: Idcdb9a8afebe050bb0b409b7d475285d1a1d4419 Reviewed-on: https://review.typo3.org/51609 Reviewed-by:
volker kemeter <volker@kemeter.de> Reviewed-by:
-
Anders Kostending authored
New features/fixes: 4.4.4: * Fix calculation of clock skew when page is backgrounded before timers are scheduled. 4.5.0: * Add node.count. * Fix overlapping circles in d3.pack and d3.packSiblings. Resolves: #79713 Releases: master Change-Id: I1d2f4a323bddb4f25a2a5d680912e1f1bbbdb33a Reviewed-on: https://review.typo3.org/51611 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Sascha Egerer authored
In PHP 7.1 it is not possible anymore to assign a value to a variable of type string with `[]` appended. In older PHP versions the variables was silently converted to an array but in PHP 7.1 a warning is thrown. Beside that the variable must be of type string anyway and not an array. Resolves: #79709 Releases: master Change-Id: Ie36dcf89cff23e7837d1f559cd05b3f9f448360e Reviewed-on: https://review.typo3.org/51608 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Georg Ringer authored
Especially if setting links to records, the default size of the popup is just too small. Change it to 1000 px width. Resolves: #79702 Releases: master Change-Id: I63f0837b6fd53d74c4686822ab4d1c8618961454 Reviewed-on: https://review.typo3.org/51603 Tested-by:
-
Christer Vindberg authored
Removed use of undefined variable. Resolves: #79622 Related: #79622 Releases: master Change-Id: I91935ec80e2ff2963dce5b6bbccbaaa52cd186c3 Reviewed-on: https://review.typo3.org/51607 Tested-by:
-
Manuel Selbach authored
Add group "mysql" to select functional tests that require a MySQL Server as a database backend due to testing functionality that is only available on this platform. Resolves: #79509 Releases: master Change-Id: Ia4d653efc56673d666274dabdc86474ffafd4756 Reviewed-on: https://review.typo3.org/51438 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Jan Kiesewetter authored
php-cs-fixer added "no_alias_functions" to its ruleset of risky fixers. This patch allows risky fixers to be run. Change-Id: I50d01864733c3e0ab5d46cb09a5bb76a0a814561 Resolves: #79716 Releases: master Reviewed-on: https://review.typo3.org/51615 Reviewed-by:
-
Christian Kuhn authored
Unit testing user authentication is still a mess since the class does way too much to be well testable. The patch refactors a number of tests that came in with the session framework test to not rely on mocked $subject anymore, but it also marks a couple of tests to be skipped for now - those should be transferred to functional tests which will probably end up to be much easier to understand and maintainable. Change-Id: Ie57245abc75f92a5a1a44ab51079f523974e9818 Resolves: #79678 Related: #70316 Releases: master Reviewed-on: https://review.typo3.org/51620 Tested-by:
-
- Feb 09, 2017
-
-
Georg Ringer authored
Make life of editors easier by providing a value picker for the field 'target' of the page. An editor can now choose "new window" instead of typing "_blank". Resolves: #79705 Releases: master, 7.6 Change-Id: I43d0c5add037679ee7c99b6cf16efcd2079353fc Reviewed-on: https://review.typo3.org/51605 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Tymoteusz Motylewski authored
Add the return url to the clickmenu option "'Create new' wizard". Resolves: #79683 Releases: master Change-Id: Ib38a4e2623d0b2d24597bfdca62f133714297584 Reviewed-on: https://review.typo3.org/51601 Reviewed-by:
-
Josef Glatz authored
Update bower dependency. Add 22 new icons via bower copy task and register them in the IconRegistry. Resolves: #79715 Releases: master Change-Id: I76fa9090e5a26bdea01afc52c3edba281bac2771 Reviewed-on: https://review.typo3.org/51612 Tested-by:
-
Frank Naegler authored
This patch add another icon for the „run on next cron“ button and add tooltips for a better and faster understanding of the buttons. Resolves: #79695 Related: #45537 Releases: master Change-Id: I0ba372f2f884af22c1f4fd74be99208493624971 Reviewed-on: https://review.typo3.org/51598 Reviewed-by:
-
Georg Ringer authored
By using mb_strlen for checking the length, the check counts multibyte values now correctly. Resolves: #79684 Releases: master Change-Id: Idcc9fc6e77d0cd42bc43986acb956af67da2453d Reviewed-on: https://review.typo3.org/51593 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Josef Glatz authored
In addition to 16:9, 4:3, 1:1 and free another common image ratio "3:2" (DSLR default format) is introduced. Resolves: #79677 Releases: master Change-Id: Iac4aff754fe07216a6b956a47ac535eadacab553 Reviewed-on: https://review.typo3.org/51571 Tested-by:
Alexander Grein <alexander.grein@gmail.com> Reviewed-by:
Harry Glatz <glatz@analog.de> Tested-by:
-
Frank Naegler authored
Since the ImageManipulation wizard supports multiple crop variants, the GalleryProcessor is broken. This patch add support for multiple crop variants in the GalleryProcessor and MediaViewHelper Resolves: #79698 Related: #75880 Releases: master Change-Id: I588c5a4b3d44110fa8460094bd4c9fe950b5cc53 Reviewed-on: https://review.typo3.org/51596 Tested-by:
-
Susanne Moog authored
Class DocumentationFile compared a real path with a symlinked path resulting in an exception, even though both paths are the same. Now realpath is called for both paths. Change-Id: Ib1baf8a721ee2bafbba4b4bdeaefc996fdc9a6a8 Resolves: #79690 Releases: master Reviewed-on: https://review.typo3.org/51586 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Josef Glatz authored
Add missing `bottom-margin` by only overriding `margin-top` of generic `h2` style. Resolves: #79699 Releases: master Change-Id: I9dc274305694aef3c526c3a342d7b994765094ec Reviewed-on: https://review.typo3.org/51597 Tested-by:
-
- Feb 08, 2017
-
-
Kevin Appelt authored
When tabbing trough a form in frontend the honeypot textfield was reachable. Add a tabindex -1 which prevents the cursor to enter the hidden field. Resolves: #79688 Releases: master Change-Id: I0dbdb7911fe4c159236c53dd425a62c9404cd973 Reviewed-on: https://review.typo3.org/51581 Reviewed-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Benjamin Kott authored
The database field `section_frame` is only available if CSS Styled Content was installed previously, that needs to be respected by the upgrade wizard and only enable the wizard if the field is present in the database. Releases: master Resolves: #79622 Change-Id: I276dae3ea8ca8a07001b378ab8789e054d76c947 Reviewed-on: https://review.typo3.org/51561 Reviewed-by:
-
Nicole Cordes authored
Due to change https://review.typo3.org/51283/ the defaultPaths in Fluid overwrite the configuration paths for the first (0-indexed) array item. This means currently it is not possible to define an own Fluid template path with index 0. This patch merges both arrays and ensures the configuration paths are added at last. This is needed because Fluid Standalone is using template paths from last to first. Resolves: #79681 Releases: master Change-Id: I84398c8218836b46583333bf64ba87ef4a55625d Reviewed-on: https://review.typo3.org/51575 Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
Claus Due authored
This patch fixes an issue with TemplatePaths, where paths for a given extension key get used at two execution points: * Before TS becomes available * At any time after TS becomes available In this case, TemplatePaths holds on to the fallback paths which the first rendering detects (since TS is not availble, fallback paths get returned) and all subsequent rendering of any template in that extension context, yields only the fallback paths and ignores what is defined in TS. By not allowing fallback paths to be cached in runtime, the problem is prevented. Change-Id: Idd0216f67f9a7f875a4509b34c9a32f66208db93 Resolves: #79662 Releases: master Reviewed-on: https://review.typo3.org/51564 Tested-by:
Morten Pless <mpl@systime.dk> Tested-by:
-
