[BUGFIX] Eliminate gremlins in image cropper
Refactor rendering to use two templates, a layout and a partial to be more flexible. Now also force the crop to be applied, even when the editor does not open the image manipulation. This is important when only one aspect ratio is allowed to not allow the editor to save an invalid state. Eliminate several quirks in the TypeScript code, among them: * reset state when closing the cropper * reset state when modal is dismissed * correctly initialize all previews * show correct size of crop area for big images * avoid accidental dismiss of the modal Last but not least add the accidentally removed form engine wizard html fields again. Resolves: #79764 Resolves: #79731 Resolves: #79753 Resolves: #79674 Releases: master Change-Id: I0a24d6418d6263b00c3fbf31901fd7c67e9fc97e Reviewed-on: https://review.typo3.org/51642 Tested-by:TYPO3com <no-reply@typo3.com> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
Showing
- Build/Resources/Public/Less/TYPO3/_element_cropper.less 1 addition, 1 deletionBuild/Resources/Public/Less/TYPO3/_element_cropper.less
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php 27 additions, 18 deletions...backend/Classes/Form/Element/ImageManipulationElement.php
- typo3/sysext/backend/Classes/Form/Wizard/ImageManipulationWizard.php 4 additions, 2 deletions...t/backend/Classes/Form/Wizard/ImageManipulationWizard.php
- typo3/sysext/backend/Resources/Private/Layouts/ImageManipulation.html 16 additions, 0 deletions.../backend/Resources/Private/Layouts/ImageManipulation.html
- typo3/sysext/backend/Resources/Private/Partials/ImageManipulation/ModalTitle.html 9 additions, 0 deletions...ources/Private/Partials/ImageManipulation/ModalTitle.html
- typo3/sysext/backend/Resources/Private/Templates/ImageManipulation/ImageManipulationElement.html 61 additions, 0 deletions...Templates/ImageManipulation/ImageManipulationElement.html
- typo3/sysext/backend/Resources/Private/Templates/ImageManipulation/ImageManipulationWizard.html 4 additions, 63 deletions.../Templates/ImageManipulation/ImageManipulationWizard.html
- typo3/sysext/backend/Resources/Private/TypeScript/ImageManipulation.ts 135 additions, 51 deletions...backend/Resources/Private/TypeScript/ImageManipulation.ts
- typo3/sysext/backend/Resources/Public/JavaScript/ImageManipulation.js 131 additions, 51 deletions.../backend/Resources/Public/JavaScript/ImageManipulation.js
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Area.php 21 additions, 0 deletionstypo3/sysext/core/Classes/Imaging/ImageManipulation/Area.php
- typo3/sysext/core/Classes/Imaging/ImageManipulation/CropVariant.php 23 additions, 1 deletion...xt/core/Classes/Imaging/ImageManipulation/CropVariant.php
- typo3/sysext/core/Classes/Imaging/ImageManipulation/CropVariantCollection.php 36 additions, 6 deletions...asses/Imaging/ImageManipulation/CropVariantCollection.php
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Ratio.php 16 additions, 0 deletions...3/sysext/core/Classes/Imaging/ImageManipulation/Ratio.php
- typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/AreaTest.php 93 additions, 0 deletions...xt/core/Tests/Unit/Imaging/ImageManipulation/AreaTest.php
Please register or sign in to comment