- May 26, 2024
-
-
Garvin Hicking authored
Change #101653 introduced the auto-creation of DB fields for TCA type "check", but used a hardcoded "0" as default. Since TCA definitions might define a different default, and records may not always be created using the DataHandler to respect TCA defaults, this can lead to DB entries getting created with an unexpected default setting. IMPORTANT: This patch only fixes the root cause of the bug. If an existing v13 installation has already created new records after the DB migration wizard update in 13.0, all records may have wrong defaults. Check the contents of your database for the fields listed below and apply manual adjustments as needed (for example, record storages having "auto_extract_metadata"=1 instead of 0). An example symptom of this is the auto-creation of a file storage record, which uses the QueryBuilder to create a record, without specifying the whole list of all possible fields. For example then leading to added YouTube media files not auto-creating metadata records. This patch uses the proper evaluation of the TCA "default" setting of an auto-created field. In TYPO3 Core this only affected `be_users.options` and `sys_file_storage.auto_extract_metadata` default record creation. The latter field has now been included to the default record creation as a fixed value like the others. A follow-up patch could rewrite this functionality using the DataHandler or QueryBuilder default value injection. Tests have been created to verify this regression, existing tests for be_user creation have been adapted for the proper default values. Executing the DB schema analyzer will now adjust the following fields: * be_users.options (0->3) * sys_file_storage.is_browsable (0->1) * sys_file_storage.is_writable (0->1) * sys_file_storage.is_online (0->1) * sys_file_storage.auto_extract_metadata (0->1) * sys_file_metadata.visible (0->1) * tt_content.sectionIndex (0->1) * tx_styleguide_palette.palette_1_1 (0->1) * tx_styleguide_palette.palette_1_3 (0->1) * tx_styleguide_valuesdefault.checkbox_1 (0->1) * tx_styleguide_valuesdefault.checkbox_2 (0->1) * tx_styleguide_valuesdefault.checkbox_3 (0->5) * tx_styleguide_valuesdefault.checkbox_4 (0->5) * sys_workspace.edit_allow_notificaton_settings (0->3) * sys_workspace.edit_notification_preselection (0->2) * sys_workspace.publish_allow_notificaton_settings (0->3) * sys_workspace.publish_notification_preselection (0->1) * sys_workspace.execute_allow_notificaton_settings (0->3) * sys_workspace.execute_notification_preselection (0->3) * sys_workspace_stage.allow_notificaton_settings (0->3) * sys_workspace_stage.notification_preselection (0->8) Resolves: #103915 Related: #101653 Releases: main Change-Id: Ia42e00b03d1369efe319e41e2b406b5303804854 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84402 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Wand <wand@itaw.de> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
And rename the method since those general getButtons() methods are ugly. Resolves: #103914 Related: #103903 Releases: main, 12.4 Change-Id: Iaa428d711b98d2bf178aa0ba54ab507f7ca1c09b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84399 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- May 25, 2024
-
-
Robert Silén authored
TYPO3 works with various DBMS. Avoid a specific mention of MySQL in README.md, the version matrix reveals details. Releases: main, 12.4 Resolves: #103719 Change-Id: I38cc50be00838643cb0095b3c848ef1d8a0c3014 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84015 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Georg Ringer authored
The shortcut button requires the resolved name as display name and not the LLL path. Resolves: #103903 Releases: main, 12.4 Change-Id: I59e38bf9c40f0a940fecb6ac3178b2976f168069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84388 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Lina Wolf authored
There is no word 'postparation' according to native speaker Sarah McCarthy. And also the sentence was hard to understand for non-native speakers. The command is not only useful during deployment so we mention other usecases. Resolves: #103857 Releases: main, 12.4 Change-Id: I602d8fe70ccbe6831278669fb2078318be4bcf63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84312 Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
* Set this internal method to protected * Add type hints for two arguments that are safe to set * Skip BU::isTableLocalizable(), and check state of the two main TCA 'ctrl' props with an early return instead * add @todo for incomplete use of getTSconfig_pidValue() results * $this->BE_USER->workspace is always an int, skip cast * fetchAllAssociative() always returns an array, remove an if and return early with empty result set instead Resolves: #103912 Related: #103828 Releases: main Change-Id: I3d11822c40c0c58474225ba95ff86c5b672c9f7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84397 Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.1.1 npm run build Resolves: #103890 Releases: main Change-Id: Id8cd17bbb1142a0522e1fd80f7dbd0f83455720a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84378 Tested-by:Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
releaseDoesNotRemoveFilesNotWithinTypo3TempLocksDirectory() is a bit flaky on CI. This seems to happen occassionally with unitRandom, but is hard to track down, and there may be multiple reasons. One possible reason is that touch() fails, maybe due to a different test changing Environment, but not resetting it. Unfortunately, we do not see a warning when touch() fails since it is suppressed with `@`. This was introduced in #88255, then skipping the test, and that skip operation has been removed with #102110. To see if the touch operation is the root of all evil, we'll for now remove the `@` again to potentially receive a php warning with an early fail. This may make this situation reproducible locally, to drill down the true reason of this occassional fail. Resolves: #103911 Related: #88255 Related: #102110 Releases: main Change-Id: I642df9579751e1415c2aa6edb9c27b1aff6d8454 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84396 Tested-by:
-
Georg Ringer authored
The configuration `foreign_table` of the type `select` is optional. Add a check to avoid PHP warnings. Resolves: #103825 Releases: main, 12.4, 11.5 Change-Id: I65925bae287a0ed340c67923ac4e4a2c72ce9d28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84391 Tested-by:
-
André Buchmann authored
When records are copied, DataHandler copies its localizations as well. This is good, but can lead to "orphan" localization records if the target page a record is copied to is not localized to that language. This is inconsistent and leads to various headaches with access rights and when localized records are synchronized later. Also, such localized records suddenly appear, when the parent page is localized to the missing target language, which is an unexpected behavior for BE editors. The patch changes this by skipping copying localizations of records when the target page is not localized to that language. Note DH method copyL10nOverlayRecords() will receive another clean up with another patch to rule out some shenanigans we stumbled upon when implementing this solution. Resolves: #103828 Releases: main Change-Id: Iee5530a5c6dc29180c423301b07f8cf7ecf84fc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84237 Reviewed-by:
-
Anja Leichsenring authored
The test setup used a dataProvider and in order to get it's own setup right, it reverses and resets leftover instances from the previous run. It is way easier to split the test setup according the admin flag, that decides about the resets, and run on a clear dedicated environment. Additionally, the system under test is in itself a mocked instance, which is neither necessary in this case, nor generally recommended. The mock has been resolved. Resolves: #103901 Releases: main, 12.4, 11.5 Change-Id: If40ef38a0e0fc2e73dd5f0bc8caff923cc48d661 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84385 Reviewed-by:
-
Christian Kuhn authored
The @deprecated QueryBuilder->setParameter() annotation for $type does not reflect current signature. Remove it and clean up the other annotations, too. Resolves: #103907 Related: #102875 Releases: main Change-Id: I48215038c1d1d179bb7a44ea29bfaffccf9692a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84389 Reviewed-by:
-
- May 24, 2024
-
-
Georg Ringer authored
Instead of prefixing the type (user, group) for every option an optgroup is used. With this change it is possible to use the keyboard to jump to a specific letter. Furthermore BackendUtility::getRecordTitle is used to retrieve the label instead of using a hardcoded field name. Resolves: #103893 Releases: main, 12.4 Change-Id: I6e9bcd46c2b953660c1b4419eaf567c2d8dc8c80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84380 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
This change adds a new RecordCollector which is similar to CONTENT cObject, except that it does not render the records directly, but instead creates instances of a generic Record object, so the Templating Engine can deal with the way of how the record should be rendered. Based on the Page Layout / Backend Layout, all registered colPos contents are fetched, and grouped, if the Backend Layout has an "identifier" set via a new PageContentFetchingProcessor ("page-content"). The slide functionality can now be defined in the Page Layout as well (Backend Layout), with a Enum defining to Collect, CollectReverse and a simple Slide logic. This feature brings a clearer separation of fetching content from the database and the actual representation in the output (fluid) in place, allowing for further optimizations. In addition, one needs to write much less TypoScript to fetch all contents from a page. Next steps is then to enrich the records with their relations (see next feature), and to optimize the Fluid-based rendering for any kind of content. Resolves: #103894 Releases: main Change-Id: I6a1a0efacefe8c83e86b9551b00199c93e284a28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83638 Reviewed-by:Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Torben Hansen authored
This change removes a 5 years old todo in extbase persistence backend. Although the affected feature `newRecordStoragePid` currently is not documented, it is used in various TER extensions and most likely also in custom projects. In relation to this change, a PR for the TYPO3 documentation has been created on GitHub, so the setting will be documented. Resolves: #103895 Releases: main, 12.4 Change-Id: I5c5cf7e87fdb50ab08e409e69aff2b373d39a022 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84381 Tested-by:
-
Andreas Kienast authored
Previously, the internal method `loadFromServer()` from the module `@typo3/backend/storage/persistent` fetched the data, wrote it into an internal property `data` and also returned it. The code is now simplified to only return the response. Setting `data` is now done within the public `get()` method, which is now also simplified a bit. Resolves: #103886 Releases: main Change-Id: I975a6ad0c2761afdadadfdc05dfa9c11a47779fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84374 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Marvin Buchmann <marvin.buchmann@typo3.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Oliver Bartsch authored
The GenericMetaTagManager as well as the abstract class (used by extensions) does now properly respect the current doctype and therefore omits the ending slash at the end for HTML5. Resolves: #102058 Releases: main, 12.4 Change-Id: I4ce6bcb61a44aff6eda738f52fe2f2548818ee95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84375 Tested-by:
Nikita Hovratov <nikita.h@live.de>
-
- May 22, 2024
-
-
Christian Kuhn authored
This 64bit hash is quicker and shorter than sha1 and should give enough collision protection for this use case. Resolves: #103878 Related: #103839 Releases: main Change-Id: Id071832027bc94e6a60eae07f79c188084c1ea81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84349 Reviewed-by:
-
Sascha Egerer authored
`\TYPO3\CMS\Extbase\Persistence\Generic\Query::execute()` has a boolean flag to define if the result should be a raw result without data mapping to an object. In this case a raw array is returned and not an array with objects. The annotation has been fixed at several places to be in sync with underlying \Doctrine\DBAL\Result::fetchAllAssociative() return type. Resolves: #103874 Releases: main, 12.4 Change-Id: Iea3eda9e805ca064d290f088d6130a44c06c1a42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84343 Tested-by:
-
Stefan Bürk authored
This change adds some tests for the `EXT:backend` ThumbnailViewHelper, mainly to cover fix #102571. Resolves: #103846 Related: #102571 Releases: main, 12.4 Change-Id: Id1acf6ddf6bc68c2dff0bfb7875859e07768e2af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84283 Tested-by:
-
Christian Kuhn authored
Shuffle the permutations of php, dbms, composer/non-composer sets/sys_template and locked/min/max for ac tests around to reduce job count and still catch lots of different combinations. Resolves: #103876 Related: #103869 Releases: main Change-Id: I5b2082f59f2890afd02890aaf2a2622ebcd09401 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84345 Tested-by:
-
Benjamin Franzke authored
The cache identifier of TSCconfig strings is now hashed with the current TYPO3 version number in preparation for an upcoming cache-content change (#79737) which is to be included in an upcoming v12 release. Resolves: #103839 Related: #79737 Releases: main, 12.4 Change-Id: I0864deddc350c6775c5cfe42fc05cfa1b974050e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84279 Reviewed-by:
-
- May 21, 2024
-
-
Ayke Halder authored
Several classes in TYPO3 have class doc comments like `Class NameOfClass`. Those comments have no value and can therefore be removed. RegEx search: `/\*\*(\n \*.*)*\n \* Class [A-Z]` Resolves: #103866 Related: #103862 Releases: main Change-Id: Idb4ea9971d05686edb247cc6c96a03911baa19ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84332 Tested-by:
-
Stefan Bürk authored
With change #103465 a couple of code integrity checks based on the `nikic/php-parser` have been combined into one file scanning script. The goal is to collect the information per visitor type over all files in a internal visitor state, to output per visitor result after all php file have been scanned. However, the visitor message state is reset for each file with the call of `startProcessing()` method within `AbstractPhpIntegrityChecker`, thus keeping only the result of the last error. This change removes the message reset from the the `startProcessing()` method to keep all error, thus displaying all errors in one go. Resolves: #103868 Related: #103465 Releases: main Change-Id: I96395ff648f39fed7e8216e2c32026a3071a41fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84333 Tested-by:
-
Christian Kuhn authored
Less jobs while keeping general pipeline times low. * Simplify runner cache configuration * sqlite pre-merge 3 instead of 5 jobs * sqlite nightly 4 instead of 6 jobs * merge checkIntegrityPhp to general integrity job * merge checkGruntClean to general js job * merge php lint jobs into one * avoid composerInstall for unitJavascript * merge acceptance install jobs into less jobs Note backports are similar but deviate in details. Change-Id: I832543e002824977a98d3ffb35c3d08355b1f5be Resolves: #103869 Releases: main, 12.4, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84336 Tested-by:
-
Oliver Bartsch authored
The value of an `label_alt` field might be an array, e.g. for TCA type `select` fields. Those values must not be formatted as this is done by `BU::getProcessedValue()` after resolving the correct record relation. Resolves: #103838 Releases: main, 12.4 Change-Id: Ibfec36d2df94661fde2d82eb60bb2736205d17c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84334 Tested-by:
-
mogensf authored
The CObjectViewHelper didn't render IMAGE-objects with GIFBUILDER properly. This change avoids the data array in the renderStatic method of the CObjectViewHelper to be null. Resolves: #103863 Related: #102931 Releases: main Change-Id: I7ddbbafbae3d835ecae05c5781e27c633f7441ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84320 Reviewed-by:
-
Torben Hansen authored
Several classes in TYPO3 have class doc comments like `Class NameOfClass`. Those comments have no value and can therefore be removed. Resolves: #103862 Releases: main Change-Id: I0824ba6ce03d4faf9c5067f971674816cedb6dd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84317 Tested-by:
-
Ayke Halder authored
Use all available CPUs with `Build/Scripts/runTests.sh -s lintPhp`. Note podman CI is configured with a cpu-share to prevent starving other jobs when one is greedy, so this change is ok with CI, too. Resolves: #103864 Related: #103851 Related: #102385 Releases: main, 12.4, 11.5 Change-Id: I1cb7079f119677b36d6f4004398ae24bd8c5d284 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84286 Reviewed-by:
-
- May 20, 2024
-
-
Torben Hansen authored
This change removes a superfluous typecast in `TypoScriptFrontendController`. Additionally, the function's doc comment has been revised and the `@param` comment has been removed, since the function parameter is self-explaining. Resolves: #103859 Releases: main Change-Id: I66bdfbbaf0854bff25a801849b253a607cc122b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84313 Tested-by:
-
- May 18, 2024
-
-
Benni Mack authored
With TYPO3 v13.0 the new BeforePageIsRetrievedEvent was added, and the previous hook was removed. This way, it is not possible to manipulate $disableGroupAccessCheck anymore. This change re-adds the possibility to modify this flag in an EventListener. Resolves: #103855 Related: #102806 Releases: main Change-Id: Ic5fbd6c6932b7da5f01592126f1c406d4084103b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84291 Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
-
Benni Mack authored
When migrating to TYPO3 v13, the navigation component for rendering the page tree has been renamed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/81411 In TYPO3 v12: - "@typo3/backend/page-tree/page-tree-element" In TYPO3 v13.1: - "@typo3/backend/tree/page-tree-element" This change adds a proper deprecation message, and a RST file for it. Resolves: #103850 Related: #102125 Releases: main Change-Id: I9b704976030e93cbb0632b637b6f099759733ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84285 Tested-by:
-
- May 17, 2024
-
-
Wouter Wolters authored
Use parallel runner to use more than 1 CPU. composer require --dev friendsofphp/php-cs-fixer:^3.57.1 Resolves: #103851 Releases: main, 12.4, 11.5 Change-Id: I59b5e2566a385792cad1b6c11b9b84b63fd21b98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84284 Tested-by:
-
markuskappe authored
The documentation of EXT:scheduler falsely referred to the Admin Panel extension, which is now corrected. Releases: main, 12.4 Resolves: #103854 Change-Id: I81fe65069bfe0309ba62a5e376e30da4e6f65075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84288 Reviewed-by:
-
Andreas Kienast authored
This commit fixes an long standing typo in the `dataset` of the delete buttons in the record list. `l10parent` is now correctly named `l10nparent`. Resolves: #103852 Releases: main Change-Id: Ibd2bb8425ef502a9b8ca255a48359b8181222dba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84287 Reviewed-by:
-
- May 16, 2024
-
-
Garvin Hicking authored
It has come up a few times that users face problems how to properly utilize the new `_assets/` hashed symlinks for `Resources/Public` assets of extensions. The current ChangeLog entry does not mention key searchwords like `_assets` or `Resources/Public`. Also, vital information is only available on external blog articles. This patch tries to provide a central entry point and may also be ported to the Core-API documentation once the mentioned concepts are approved by the core-team. ChangeLog entries are the vital source of truth for migration instructions and basis for the documentation, thus this is the first place to be addressed. Resolves: #103845 Releases: main, 12.4 Change-Id: Iadeae5de624027b5303a4240b36ca501ae29a31a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84282 Tested-by:
André Buchmann <andy.schliesser@gmail.com> Reviewed-by:
-
Anja Leichsenring authored
With one traverser class and several checkers all necessary checks can be executed within one CI job, which saves time and resources. By feeding all checkers with the same set of files, we can be safe not to lose any files that should be checked. Resolves: #103465 Releases: main Change-Id: I4a2f54c6fac37177c8387a999f5e60102951eba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83568 Reviewed-by:
-
- May 15, 2024
-
-
Nikita Hovratov authored
Resolves: #103835 Releases: main Change-Id: I78159e868390047735490a7d179f90adf3e2e83c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84276 Tested-by:
-
Stefan Bürk authored
With #103692 remembering the sub-module route within the backend user module has been fixed to open the last opened module sub-route. Due to another splitting of composer acceptance tests, the backend user groups tests are executed before the backend user tests within the same instance - and thus staying on the backend user groups view. `ListUserCest` does not ensure to select the backend user lists like it is done for `ListGroupCest`. This change ensures to switch to the backend users sub-route, when the `backend user` module is selected in the `ListUserCest::_before()` similar to `ListGroupCest::_beore()`. Resolves: #103837 Related: #103692 Releases: main, 12.4 Change-Id: If54812a7bfc95e317f5e72737c3f88461da3fda2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84278 Tested-by:
-
Stefan Froemken authored
Resolves: #103836 Releases: main Change-Id: Ia74ab100142aa29c3a1a145c358e77e4eaaca804 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84277 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
