- Oct 28, 2022
-
-
Andreas Fernandez authored
A new method `getByPrefix()` is added to the module `@typo3/backend/storage/abstract-client-storage`, affecting its implementations * `@typo3/backend/storage/browser-session` * `@typo3/backend/storage/client` A developer is now able to obtain multiple items prefixed by a given key either from `localStorage` or `sessionStorage`. Resolves: #98921 Releases: main Change-Id: I343289cc6fa6fdd57c019a0cdd85eae2b5dbdb81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76265 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Chris Müller authored
Resolves: #98946 Related: #96517 Releases: main Change-Id: Ibf44b8dad7a1cc79796a5791f194fc7792e9a355 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76321 Tested-by:
-
- Oct 27, 2022
-
-
Oliver Bartsch authored
With #94641 toolbar dropdown menus were made scrollable, since otherwise bookmarks were cut off at the bottom of the screen. With #98307 the corresponding "max-height" option was removed, leading to the same bug as before. This is now fixed by adding the option again. Resolves: #98940 Related: #98307 Related: #94641 Releases: main Change-Id: I1c2fd17f503189d3ed3466f6d80b451b01ff454d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76310 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98725 Releases: main Change-Id: Ia0cac4637e14e7fbe46fa4216022b6e9bcf3406a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76313 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Torben Hansen authored
Resolves: #98900 Releases: main Change-Id: Ie6f7d98ee293dcc2153a6af191892a7e12c1ea9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76317 Reviewed-by:
-
Torben Hansen authored
Resolves: #98893 Releases: main Change-Id: Idcf53113f2f4acafe11cd953d9d9dd89f3b3dccb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76316 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98726 Releases: main Change-Id: I80f4e40c32193aaffd2c99cdbb307018103e971d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76314 Tested-by:
-
Torben Hansen authored
Resolves: #98890 Releases: main Change-Id: If64893018e062ffb1fe83d3b8f68de3d5f2b2289 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76315 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Anja Leichsenring authored
TYPO3 Core Tests no longer use the vfsStream dependency, so it is removed. Resolves: #98939 Related: #97762 Releases: main Change-Id: I19466200b5dd6c1cfcb035b4ebefb6ac08254c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76308 Reviewed-by:
-
Christian Kuhn authored
* Make some unit tests functional test * Remove some state * Avoid last usages of vfsStream > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: I3c0e4a1bc10aae042c5b850e817e8211918a0458 Resolves: #98740 Related: #97762 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76309 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Torben Hansen authored
Resolves: #98888 Releases: main Change-Id: I54c4cb0bb406f9d6a0a6b8d56a330f89630c9ca4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76311 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Torben Hansen authored
Resolves: #98885 Releases: main Change-Id: Ia51c12a35892c7d9d9f8e332470d5986472f8c67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76312 Tested-by:
-
Torben Hansen authored
Resolves: #98898 Releases: main Change-Id: I62c2915adb19bc8cc124cab51e4f99782053b4d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76304 Tested-by:
-
Torben Hansen authored
Resolves: #98894 Releases: main Change-Id: I7c1d7cf3622f64666adcabbb3ebf30d7c6189d1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76306 Reviewed-by:
-
Torben Hansen authored
Resolves: #98896 Releases: main Change-Id: I3c452a229b8a690d3954cfadfa439c9b3b7be30e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76307 Tested-by:
-
Torben Hansen authored
Resolves: #98895 Releases: main Change-Id: Ib1898a11fcb156d08d0f3fd9cfb738038d3d90ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76305 Tested-by:
-
Benjamin Kott authored
The CKEditor 5 has very limited support for managing links. By default, you only get a simple input field for a string. To bring the known and loved easy-to-use LinkBrowser to CKEditor 5 we need to overwrite the existing linking capabilities. For developers and integrators, this overwrite should be invisible as it was before with the CKEditor 4 integration. Instead of teaching the users that they need to load custom modules to change the link behavior, we are already migrating this in the background for them. A typical developer can just follow the CKEditor 5 guide to configuring the editor to its needs and the Core is already doing the adjustments and replacements of modules for them. We currently overwrite the existing link and unlink commands, but we register the toolbar buttons with a prefix. This makes existing CKEditor configurations incompatible since the linking buttons are missing in the toolbar. To make migrations easier we adjust custom toolbar buttons to match the CKEditor 5 defaults and drop the custom names for the buttons. In addition, we are streamlining the behavior of removing plugins. Since we are already overwriting the "Link" plugin there is no need to remove it if no removePlugin config is passed in the first place. This allows us to better test the behavior and reduces the cases we need to cover in the first place. Resolves: #98925 Releases: main Change-Id: I3d6d158f5ab1b21e73f86471344107a07d71b03e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76267 Tested-by:
-
Wouter Wolters authored
> composer req --dev friendsofphp/php-cs-fixer:^3.12.0 > Build/Scripts/runTests.sh -s cgl -p 8.1 Resolves: #98938 Releases: main, 11.5 Change-Id: I42b247fa4ea51ef20e29fef855c12af1b756d558 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76301 Tested-by:
-
- Oct 26, 2022
-
-
Oliver Klee authored
Resolves: #98937 Related: #98936 Releases: main Change-Id: I55ed2c9546312c8bc9b99ffae2b8d3c8a38b5117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76300 Tested-by:
-
Christian Kuhn authored
To finally tame the FAL related unit tests, the resource related BaseTestCase is dissolved and merged into consuming classes as first step. This simplifies the construct and allows further refactorings. Resolves: #98936 Releases: main Change-Id: Id8da6b47a5d16d7eb38bfecf91d41d9365d4df7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76299 Tested-by:
-
Christian Kuhn authored
The vfsStream setup is not used in the tests. Resolves: #98935 Related: #97762 Releases: main Change-Id: I87ec61c1e5aac2bf82e2463e57bc36a81bb211d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76298 Tested-by:
-
Christian Kuhn authored
We can avoid vfs usages in GeneralUtility tests by creating fixture files and testing these directly. A detail test for mtime is skipped since this is rather obvious in the test subject. Resolves: #98934 Related: #97762 Releases: main Change-Id: I7aecdd2f5dddaf493865f1588b72a30466316541 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76297 Tested-by:
-
Christian Kuhn authored
Testing 'non-writable' directories is flaky in real life since it depends on the user that executes these tests. On gitlab CI, it is useless a-priori, since gitlab runs as root in containers. Establishing a vfs for this does not help us much, especially when it just tests if some exception is thrown, which is done obviously when reading code. This vfsStream usage is simply not worth the dependency. Resolves: #98932 Related: #97762 Releases: main Change-Id: Ifd813d47607e3760e2e617b93a56a59773bc4e62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76296 Tested-by:
-
Christian Kuhn authored
Moving cache framework related FileBackendTest unit tests to functional tests needs less mocks and avoids vfsStream. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98931 Resolves: #98734 Releases: main Change-Id: I0090ae0c0984add6584f3858df35fed5df91ab91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76295 Tested-by:
-
Christian Kuhn authored
Acceptance test cookie output is less noisy due to a new feature in codeception/module-webdriver 3.2.0 and styleguide avoids deprecated core method calls. > composer req --dev codeception/module-webdriver:^3.2.0 > composer u typo3/testing-framework > composer u typo3/cms-styleguide Change-Id: I02af65e21fc13111302762aa937c95546a4c07c6 Resolves: #98928 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76292 Tested-by:
-
Christian Kuhn authored
This property name is too generic as weak match and throws too many false positives. Resolves: #98926 Release: main, 11.5 Change-Id: I0d39287180bb4d53071efe30d42145a313a98ec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76270 Reviewed-by:
-
Christian Kuhn authored
There is little reason to fake filesystems details within functional tests that use an isolated instance. Resolves: #98923 Related: #97762 Releases: main Change-Id: I83579eab82655c4cd464050e4fbcd7608ba0062e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76268 Tested-by:
-
Benjamin Kott authored
CKEditor 5 changed the way it handles links, and introduced new modules to do so. In the automatic migration from CKEditor 4 to CKEditor 5 configuration the previously available separate button "Anchor" is is incorrectly migrated to the new "link" module. In CKEditor 4 there was a differentiation between outgoing links (https://, relative etc.) and anchors on the current page (aka #). CKEditor did not make this differentiation anymore and introduced a unified link handling. There is no replacement for "Anchor" in the new configuration. Keeping the migration would resolve in unintentionally removing the capability of setting links in general, since it would remove the new overarching plugin. In addition, we are now also cleaning up the legacy configuration after migration for removeButtons and format_tags. Resolves: #98714 Releases: main Change-Id: I9f94e831135bf099dec716558120f727301a085c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76241 Tested-by:
-
Andreas Fernandez authored
This patch updates jasmine to the current version 4.4.0. This mainly impacts performance and dropped support for outdated environments and browsers. Karma is also updated and in the same run, unused launchers are removed. Executed commands: npm install --save-dev \ @types/jasmine@^4.3.0 \ jasmine-core@^4.4.0 \ karma@^6.4.1 \ karma-chrome-launcher@^3.1.1 \ karma-coverage@^2.2.0 \ karma-jasmine@^5.1.0 \ karma-junit-reporter@^2.0.1 \ karma-rollup-preprocessor@^7.0.8 npm remove \ karma-firefox-launcher \ karma-ie-launcher \ karma-opera-launcher \ karma-safari-launcher Resolves: #98922 Releases: main Change-Id: Id879aca002de72825d20a9b07ff1bf3a78f95057 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76266 Tested-by:Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Christian Kuhn authored
The class can be hardended a bit and some unused methods removed. The tests are turned into functional tests. Resolves: #98920 Releases: main Change-Id: I11b76004dc5798bca599ab34977d090d8544a32f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76264 Tested-by:
-
- Oct 25, 2022
-
-
Christian Kuhn authored
testing-framework now avoids access to TSFE->tmpl as well. > composer u typo3/testing-framework Resolves: #98919 Releases: main Change-Id: I680377531ebfb7fb1c1f7458ef9328a93dfda734 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76263 Tested-by:
-
Christian Kuhn authored
Resolves: #98918 Releases: main Change-Id: I1d6b9fcb5ec0f84d2a5a65689aa4f23b0ff3f82f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76262 Tested-by:
-
Christian Kuhn authored
The patch introduces the new request attribute TypoScriptRequestAttribute as 'frontend.typoscript'. It is set up in the Frontend middleware chain, extensions and content objects can use this attribute to retrieve TypoScript settings and setup. This obsoletes usages of TSFE->tmpl, the patch switches usages to the request attribute. Note we're also establishing a better wording: The old TypoScript 'constants' are now called 'settings'. This matches much better, should avoid confusion for newcomers and is in line with further renaming of a vaguely anticipated new 'constants editor' towards 'settings editing' or similar. Further patches in this naming area will follow. Change-Id: Ib6ffb91db9bf0976f39759b12983d78418d64efa Resolves: #98914 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76239 Tested-by:
-
Torben Hansen authored
Resolves: #98730 Resolves: #98731 Resolves: #98732 Releases: main Change-Id: Ie13c6f640b07e3b1fd6742ea4d7f300bb0a3d10d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76260 Tested-by:
-
Nikita Hovratov authored
Resolves: #98722 Releases: main Change-Id: Id79d474b607fd024b992bffe669033bf7a974710 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76254 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Nikita Hovratov authored
Resolves: #98723 Releases: main Change-Id: Ia64fed2b7f4f9a0c420e5a836fafb1959c7143d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76255 Tested-by:
-
Oliver Klee authored
Also update the PHPUnit PHPStan configuration. This update gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.11 > composer req --dev phpstan/phpstan-phpunit:^1.1.3 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98913 Releases: main, 11.5 Change-Id: Ifc374d02a2ad343bd6be9a61b2075deb019b98f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76253 Tested-by:
-
Torben Hansen authored
Resolves: #98911 Releases: main Change-Id: I6228795976338f5c8bdf02e03075140272f2511b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76252 Tested-by:
-
- Oct 24, 2022
-
-
Christian Kuhn authored
The "is backend" check will never kick in since this is dispatched in ConfigurationManager already. Resolves: #98721 Related: #98578 Releases: main Change-Id: I9afca12237a618903d47757a6960500058106c21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76244 Tested-by:
-
Andreas Fernandez authored
When a content element gets hidden or visible, the page module is reloaded with an anchor in the URL to scroll to the content element that was updated. After #98471 it was not possible anymore to click the "+ Content" button above such element unless it was dragged and dropped again into the same column. The reason is that a pseudo element `:target:before` is generated with a specific height and margin to overcome the height of the floating module docheader, overlaying the CE action button. In the patch mentioned before, relative positioning was added to the columns as this is needed for the dropzones, finally causing this bug. To solve this issue, the CE actions now have a higher z-index to be clickable again. Resolves: #98703 Related: #98471 Releases: main Change-Id: I32d93a79842cb599526eae9dec3373c3d3fc31eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76234 Tested-by:
-
