- Jun 20, 2017
-
-
Benni Mack authored
This change introduced a flaw in the RteLinkBrowser JS file which needs to override LinkBrowser class instead of just writing RteLinkBrowser. See https://review.typo3.org/#/c/53062/ This reverts commit c5d75c15. Resolves: #81630 Reverts: #81444 Releases: master Change-Id: I4a3a9dc52bd6b9cee183ba6411389e8da2eebd21 Reviewed-on: https://review.typo3.org/53274 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Claus Due authored
Change methods inside ReferenceIndex to allow them to receive an existing record as array rather than a UID to avoid each method loading it from the database again to read record or record fields. For a copy operation on 25 pages with ~100 content elements total there are 1,500 SQL queries less leading to a ~40% time reduction and ~10% memory reduction. Change-Id: I0ed05478dfbc0535efc8d1d29b6a8298d475fb6b Releases: master, 8.7 Resolves: #78634 Reviewed-on: https://review.typo3.org/50566 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
-
Thomas Hohn authored
Wraps the functionality from doesRecordExist in a new method recordInfoWithPermissionCheck. The goal is a general cleanup and avoid unnecessary calls to the database in the case where the actual record is re-fetched from the database for processing just after a doesRecordExist call. Resolves: #79515 Releases: master, 8.7 Change-Id: I76d217a1690ee4b97e28b83f7591ebf8cba18e6e Reviewed-on: https://review.typo3.org/51447 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- Jun 19, 2017
-
-
Henrik Elsner authored
The quoting parameter constants \PDO::PARAM_* are in fact integers. The annotation shipped with doctrine says string, and the strict type processing in core leads to a wrong parameter error. Changing the strict type to int, as would be correct, solves the problem. Releases: master, 8.7 Resolves: #81613 Change-Id: Ic327b2d761b74868cc46d781acab1f4fd9e6cfdb Reviewed-on: https://review.typo3.org/53260 Reviewed-by:
Anja Leichsenring <anja.leichsenring@typo3.com> Tested-by:
-
- Jun 18, 2017
-
-
Christian Kuhn authored
If a records has not been persisted and a flex section container is added, the form compiler needs the "NEW123" uid of parent to prefix form fields correctly. Change-Id: Iab3945efa93d2becf636c5cf4f8596bc696cd2e0 Resolves: #80825 Related: #80100 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53215 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Susanne Moog authored
Adjust grunt and tsconfig to allow writing unit tests in TypeScript. Test example is included. Additionally configuration was adjusted to allow running grunt tasks on windows and linux. Change-Id: Ibeb0c501242afbbe796726a85329d14257acfd1c Resolves: #81601 Releases: master Reviewed-on: https://review.typo3.org/53248 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Fernandez authored
The parameter `$errorMode` is removed from the method `GeneralUtility::callUserFunction()`. Thus, the checks agains this variable are removed as well, causing exceptions being always thrown now. Resolves: #74533 Releases: master Change-Id: Ibf8b0c9de55b4d8d210dac8fc6c82b14ca7c849d Reviewed-on: https://review.typo3.org/50996 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jun 17, 2017
-
-
Georg Ringer authored
Move the report as a first step to get rid of EXT:sv. Resolves: #81536 Releases: master Change-Id: I46e38b5c4bf8d5466e1bcc1db510b1cd660a7b38 Reviewed-on: https://review.typo3.org/53163 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Ralf Hettinger authored
CKEditor fields now triggers FormEngine.Validation.markFieldAsChanged therefore a warning of unsaved changes on closing the form is raised based on changes within these CKEditor fields. Resolves: #68955 Releases: master, 8.7 Change-Id: I0da98c2204b20b0f6cd27a53b66f2df3d369a145 Reviewed-on: https://review.typo3.org/52968 Tested-by:
-
Benni Mack authored
Fixing one issue with the wrong variable name. Resolves: #81575 Releases: master, 8.7 Change-Id: I820a3bcfc9a250a35ca2bec69b71a40fc7c8d01a Reviewed-on: https://review.typo3.org/53245 Reviewed-by:
-
Georg Ringer authored
The method DocumentTemplate::formWidth() is not needed anymore as the styling can be done by using bootstrap and regular CSS classes. Resolves: #81540 Releases: master Change-Id: Id767665e71afc454f04002b6989876ca28354fe3 Reviewed-on: https://review.typo3.org/53185 Tested-by:
-
Christian Toffolo authored
In Extbase query expressions the second operand is converted to a plain value which is either an integer or a string. This type must also be specified when creating a named parameter in the query. Resolves: #79473 Resolves: #80978 Resolves: #81487 Resolves: #81019 Resolves: #81056 Releases: master, 8.7 Change-Id: I835643653e03b98bfcd5a8b35b5de750641ecb79 Reviewed-on: https://review.typo3.org/52802 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Johannes Goslar authored
Resolves: #81444 Releases: master Change-Id: I7247ef2c88ff60c484c3ca7ff0af48d3b8e72aac Reviewed-on: https://review.typo3.org/53062 Tested-by:
-
Morton Jonuschat authored
The errorCode() method returns a string representation of the error that happened. Comparing this to an integer value to determine is not reliable. In addition Doctrine throws Exceptions when database statements fail so this part of the code could not be reached. Catch the DBALException, extract the error message and let the re-raised extension bubble up to show the actual error message to the user. Change-Id: I042b94329e3d52f9520ded812247ee78a73ea402 Resolves: #79870 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53130 Tested-by:
-
Sascha Egerer authored
The backend list view must respect the selected pages even if the search level is set to infinite. This bug was introduced by the Doctrine migration. Resolves: #81278 Releases: master,8.7 Change-Id: I6ab0e93a019a001f9df08e00c01f7525a6621284 Reviewed-on: https://review.typo3.org/52873 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
Benni Mack authored
When removing the extbase query cache in 8.3, the TypoScript option was not removed which has no effect anymore since then. Resolves: #77460 Releases: master, 8.7 Change-Id: I72d3907fd1c3aa302a03cc1f41bfe28b97020216 Reviewed-on: https://review.typo3.org/53235 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Benni Mack authored
There are still places left in TYPO3 where methods are called with integers as parameters, although they are marked as boolean. These places are changed to the correct and necessary value. Resolves: #81595 Releases: master, 8.7 Change-Id: I1664e7d5e3962f0d2cf59ba6148812291d0b803b Reviewed-on: https://review.typo3.org/53236 Tested-by:
-
- Jun 16, 2017
-
-
Christian Kuhn authored
Atlassian bamboo allows to define test plans in files since version 6. The test plans are based on rather simple Java files. The patch delivers build information of default core pre-merge plan. Changes of bamboo test configuration for these plans are now coordinated via casual patch requests and can be reviewed just as all other code. This adds full transparency on what exactly the core test environment does and can be used by others as reference for local execution and extension test plan boilerplates. Upload to bamboo.typo3.com to update test plans can be done by a bamboo administrator. Change-Id: I756cb65eba3a58e9edf0995aa9f1f2d4f96f7926 Resolves: #81589 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53225 Reviewed-by:
-
Thorben Nissen authored
When entering a date string in the admin panel to simulate a certain date/time and clicking the "update" button an exception it thrown. Due to the names and ordering of the fields, the timestamp from the hidden field gets overridden by the date string. Move the hidden timestamp field after the human readable date string field to avoid the timestamp being overridden by the date string. Add a comment to explain the ordering and avoid future changes. Resolves: #81174 Releases: master, 8.7 Change-Id: I87236c9b8ef84dabb3ec63e0530f14582ecbe6fe Reviewed-on: https://review.typo3.org/53230 Tested-by:
-
Benni Mack authored
The mode "capitalWords" was just a todo statement that indicated a missing implementation. The implementation is now added. Resolves: #81588 Releases: master, 8.7 Change-Id: I12b733da703de34568c6b79c083031f0333cdb92 Reviewed-on: https://review.typo3.org/53221 Reviewed-by:
-
Benni Mack authored
There are several places where mb_* methods are still not used, although they are even better to use instead of the $csConv->parseCharset() method for instance, as it has more aliases defined already. Same goes for "entities_to_utf8" which is a PHP user-space implementation of html_entity_decode() dated back to Kaspers' change in 2003. Using native PHP methods should also increase performance marginally. Resolves: #81575 Releases: master, 8.7 Change-Id: I5e97881cc7107883a5ff53d534161a7ec17e1ee5 Reviewed-on: https://review.typo3.org/53208 Tested-by:
-
Benni Mack authored
There is a class called "ObjectManagerException" which was introduced very early with Extbase and was a clone of the (now further developed) object manager. It was originally used in the wrong place in workspaces and then changed in workspaces to the real object manager but the class was kept. This class was then wrongly renamed in TYPO3 6.0 with the change to namespaces and called "Exception" which it is definitively NOT and thus, plain wrong in the place as it is. The class (and the interface) should be removed as it is not just plain useless and a hard mistake we carried on for 7 years now. Resolves: #52825 Releases: master, 8.7 Change-Id: I615caaa9d297631a338ca6488bfe8e5c29594e3b Reviewed-on: https://review.typo3.org/53231 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Jun 15, 2017
-
-
Markus Klein authored
Releases: master, 8.7 Resolves: #80952 Change-Id: I94a5124a16c9ad9893c1c2346967089fd16ad142 Reviewed-on: https://review.typo3.org/52112 Tested-by:
Mario T <typoser@trashmail.de> Tested-by:
-
Claus Due authored
Followup patch to migrate f:widget.autocomplete which had been missed by the previous patch. Change-Id: I9e2552925df84f225144b1120a93bf65d9874047 Resolves: #81213 Releases: master Reviewed-on: https://review.typo3.org/53199 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Markus Klein authored
Add more information about the table argument and when it should be set. Resolves: #81545 Releases: master, 8.7 Change-Id: Ic95794869b384e0932d59747df545f15afe2825f Reviewed-on: https://review.typo3.org/53188 Tested-by:
Robert Wildling <robertwildling@gmail.com> Tested-by:
-
Thorben Nissen authored
Due to the changed link syntax ("t3://...") instead of "<link ...>" the links to files and internal pages are not recognised anymore. Furthermore are external links now written with <a href="..."> and are therefore also not recognized anymore. Rewrite code for detecting "typolink_tags" correctly. When recognizing urls, e.g. from "external url" pages or plain urls in texts, include https and not only http and ftp. Resolves: #80991 Resolves: #80988 Releases: master, 8.7 Change-Id: I5a9267b1d4ab53a6a39efdbd411e610dc9233ead Reviewed-on: https://review.typo3.org/52592 Reviewed-by:Christer V <cvi@systime.dk> Tested-by:
-
- Jun 14, 2017
-
-
Georg Ringer authored
Apply the classes 'btn btn-default' directly to the a tag instead to have the full button area clickable. Resolves: #81579 Releases: master, 8.7 Change-Id: Ib296d8e8e56c45d5d879cb7cb7a749b1c7141b2f Reviewed-on: https://review.typo3.org/53216 Reviewed-by:
-
Oliver Hader authored
Complete data-map for a table is handed over in $idValues to DataMapProcessor::fetchDependencies(string $tableName, array $ids), but should only contain the id-values - either integer or string. Resolves: #80239 Releases: master, 8.7 Change-Id: If12562dad839687b7d60855fa99d9ffc21bc1167 Reviewed-on: https://review.typo3.org/53213 Tested-by:
-
Oliver Hader authored
The current implementation of DataMapProcessor to determine the necessity of synchronizing record localizations is too strict since it expects real persisted database records and cannot resolve new records that have been handed with the very same data-map to the DataHandler. This mentioned constraint is resolved. Besides that, an additional value processing for internal fields is added. This method resolves new record ids to their real persisted UIDs using the famous remap stack. This only is executed, if these fields have not been processed in a relation-aware context and have a meaning to TYPO3 data-structures - for instance this is the case for 'l10n_source' field defined as TCA type 'passthrough'. Change-Id: Id1291910d85b3d314af7203314b8696a337fe364 Resolves: #80239 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52871 Tested-by:
-
Susanne Moog authored
databaseRow should not be set incompletely in a FormDataProvider or controller as subsequent processing may rely on the complete database row being set (for example language fields). Resolves: #80855 Related: #80100 Release: master, 8.7, 7.6 Change-Id: I139b426c6598a93a2012cae088e3cbece4e1a83b Reviewed-on: https://review.typo3.org/52543 Tested-by:
Faton Haliti <fha@systime.dk> Tested-by:
-
Benni Mack authored
Calling GeneralUtility::devLog() can be called but the method itself should check whether the devlog is enabled, instead of having third-party code rely on checking the option with an if statement. This effectively removes the need for checks on if (TYPO3_DLOG) and the other two constants TYPO3_ERROR_DLOG and TYPO3_EXCEPTION_DLOG in all callers' code. Resolves: #80289 Releases: master, 8.7 Change-Id: Ibaeeca6300bdb37a513a07fb46c2616cfc51c7f2 Reviewed-on: https://review.typo3.org/52751 Tested-by:
-
- Jun 13, 2017
-
-
Benjamin Kott authored
Resolves: #81539 Releases: master, 8.7 Change-Id: I2633df64020e9f6a8e95048ed2d23f84d3013313 Reviewed-on: https://review.typo3.org/53184 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Benni Mack authored
When having an empty Yaml file, the error that is thrown isn't helpful for the developer, and in case of RTE, the RTE is not shown at all. Resolves: #81557 Releases: master, 8.7 Change-Id: Ie435b9f42623962637a9ead0243be6cde15c82c6 Reviewed-on: https://review.typo3.org/53197 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Claus Due authored
Deprecates usage of arguments on render methods and refactors the abstract ViewHelper class to avoid injecting ReflectionService in every ViewHelper, calling on it only when the ViewHelper actually requires it. Safe removal since the DI property is declared private and thus cannot be accessed in ViewHelper classes. Change-Id: I94bb7e9f306b34c25dc31519eb17316c88ea0540 Resolves: #81213 Releases: master Reviewed-on: https://review.typo3.org/52796 Tested-by:
-
Oliver Hader authored
If edit forms have unsaved changes, changing the IFRAME URL is caught by explicitly sending interaction requests that are handled by individual client components, such as the FormEngine. This feature does not use the Window.beforeunload event, but some custom messaging API instead. Click events on the ExtJS page-tree are caught if those trigger a change request for the content component, however highlighting the clicked page node is not caught due to nested ExtJS event hierarchies. Resolves: #77268 Releases: master Change-Id: I3e2359cf27d95197b17e8d8489759ace403ce1af Reviewed-on: https://review.typo3.org/53075 Tested-by:
Jasmina Ließmann <code@frauliessmann.de> Reviewed-by:
-
Anders Kostending authored
Updates the version of CKEditor to 4.7. This update fixes 30+ bugs, that can be seen here: http://ckeditor.com/release/CKEditor-4.7.0 In addition there will be simpler tables, better support for CSP, better paste from Excel and Word and so on. Added one fix to the typo3link plugin. Resolves: #81483 Releases: master, 8.7 Change-Id: Id5a023e5bf9ad9bfac5e7c9c103670978ef95d8f Reviewed-on: https://review.typo3.org/53138 Reviewed-by:
Anders Kostending <aha@systime.dk> Tested-by:
-
- Jun 12, 2017
-
-
Claus Due authored
Last pass, touches all remaining ViewHelpers which are capable of conversion to the compilation helper traits from Fluid. Change-Id: I73e32da48b00444b66a568f462ab41ff66969503 Resolves: #81200 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52784 Tested-by:
-
Sascha Egerer authored
The backend query view, used for csv exports and lists, uses a date format where single digit days of a date value are prefixed with a whitespace instead of a 0. This ends up in useless CSV exports that can not be interpreted by tools like Excel. Change-Id: Ie11c5f8a923eb412f014f06df528a2aa0101a0d4 Resolves: #81551 Releases: master,8.7 Reviewed-on: https://review.typo3.org/53189 Tested-by:
-
Christian Kuhn authored
ext:rte_ckeditor declares the default config yml preset pointers of TYPO3_CONF_VARS['RTE'] in its ext_localconf.php file. This file is loaded after LocalConfiguration.php. The patch wraps the declarations in guards to ensure any previously set pointers are not blindly reset. Change-Id: Ic945d988f436aab7453b7f7fba8694bbf3580b1d Resolves: #81537 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53181 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Johannes Goslar authored
Remove package from lock file. Resolves: #81493 Releases: master Change-Id: I92e72464a509a5a76a84e28b0044b2e8f6678a21 Reviewed-on: https://review.typo3.org/53186 Tested-by:
-
