- Jun 10, 2021
-
-
Oliver Bartsch authored
Recordlist features the clipboard functionality. When activated, multiple clipboard actions, such as "copy" or "edit marked", are displayed in each tables' header. Since translated records can never be selected, this led to exceptions and JavaScript errors when using such action on the "Page Translations" table. This is now fixed by not rendering those actions for this special table. Resolves: #94296 Releases: master, 10.4 Change-Id: I47459cf1d82d90f634a4f8902ea04c958cbd1bdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69427 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Torben Hansen authored
Usage of FriendsOfTYPO3/rsaauth is pretty low and there is no reason to support the extension any more in TYPO3 11. This patch removes all ext:rsaauth related code. Resolves: #94279 Releases: master Change-Id: I8e318bcc3c04fcc66a033507d0dddb931529c17d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69397 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Oliver Bartsch authored
This fixes a regression introduced in #94057, which effectively removed the possibility to toggle the clipboard in the recordlist. Resolves: #94301 Related: #94057 Releases: master Change-Id: I6d6ffe9a33bd96f8a41c3f23f3367cf750d29472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69452 Tested-by:
-
Oliver Bartsch authored
Besides all available versions of a TER extension, the "Show all versions" view in EXT:extensionmanager also displays general information such as the category or the dependencies, making it more or less an extension detail view. Since those information are also relevant for already installed extensions, it's now possible to access this view in the "Installed extensions" list, using a new link on the extensions' version string. Resolves: #94298 Releases: master Change-Id: Iab131e5494f143315abd607de1a79f5f0571a2dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69429 Tested-by:
-
Christian Kuhn authored
Register an implementation and adapt consumers. Resolves: #94300 Related: #90803 Releases: master Change-Id: I43117cf3094e0784d05c97d7f28f3365d12bd1f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69431 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
An install tool upgrade wizard slated for removal has been forgotten during v11.0 cleanup: FormFileExtensionUpdate has been added for upgrade to v9 (and even backported to v8), has then been kept for update to v10 and can be removed now. Resolves: #94299 Releases: master Change-Id: I882e7ef3926895bcc1e455bc2c0cda287c822680 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69430 Tested-by:
-
Christian Kuhn authored
Make ext:form TypoScriptService injectable and adapt consumers. Fixes a broken $this->objectManager call from #94093 in ConfigurationManager. Resolves: #94297 Related: #90803 Related: #94093 Releases: master Change-Id: Ideaa5b0828d3148ba9cbd7287ab50ed51079ce21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69428 Tested-by:
-
Christian Kuhn authored
The namespace of core TypoScriptService is TYPO3\CMS\Core\TypoScript, not TYPO3\CMS\Core\Service. The entry is thus obsolete and can be dropped. The service with correct name is already handled by ext:core ServiceProvider.php. Change-Id: Ia4a3ef02dd3490547a9379ad57930afdd974a2de Resolves: #94295 Related: #94093 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69426 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
The method DatabaseRecordList::makeFieldList() creates a list of fields to select for a table. Since selector. This method however automatically adds some management fields, such as `crdate`. As those fields may also be included in TCA `columns`, e.g. for sys_redirects since #94143, they may be added multiple times, which leads to different errors. This is now fixed by applying array_unique to the final field list. Resolves: #94294 Releases: master Change-Id: I6e5cefaa4fb5d5a3dff9581105d19618143c1e79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69424 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Oliver Bartsch authored
The "View" respectively "Save & View" functionality of EditDocumentController is as following: 1. Clicking the corresponding button saves the form and a JavaScript event handler opens a new blank window 2. After the data was persisted, the form reloads and the preview code (using the ImmediateAction component) is written to the module body. This update the previously opened window with the correct preview URL. However, since #94114, a redirect is performed as soon as the data has been persisted. This is done to ensure persisting is only done for POST requests. Since the information whether the form was stored using the "View" respectively "Save & View" is not forwarded in the redirect, the new window remains blank. This is now fixed by adding the corresponding information to the redirect URL. Also a now unnecessary code block in processRequest() is removed. Resolves: #94287 Releases: master Change-Id: I4f9be3fb286a6cdfe6e1d3e071eb0c6df0801f5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69415 Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Larry Garfield authored
Manual testing found a bunch more cases of undefined variables that need to be addressed. Resolves: #94057 Releases: master Change-Id: I0f602d2de5fcfdc8b41545eafacc5ff79bbfdf86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69393 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Jun 09, 2021
-
-
Guido Schmechel authored
To avoid confusion for the editor, the "sha1" field is now removed from the searchFields of sys_file. Those who wish to continue searching this field can adapt the corresponding TCA via TCA overrides. Resolves: #94273 Releases: master, 10.4 Change-Id: I8b2676c868e97e67b5fa453fa53658fcadae9ce8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69399 Tested-by:
-
Oliver Bartsch authored
Extension updates are important, since they may contain security fixes. Therefore, in non-composer based installations, the extension listing in the EXT:extensionmanager "Installed extensions" view is now always sorted by the extensions' update state, as soon as one extension can be updated. For composer based projects, the behaviour does not change, since updating extensions is usually done via CLI and chaning the sorting can still be done manually in the module. Resolves: #70157 Releases: master Change-Id: I25a28f3b1483ed736872e90e46939f30bca47f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69400 Tested-by:
-
Oliver Bartsch authored
The shortcut links in the toolbar contain an icon, which gets calculated based on the backend module and the record type, the shortcut was created for. Since IconFactory->getIconForRecord() is used to fetch the correct record type icon, the database row has to be provided. This was previously done by simply querying the table with an uid constraint. In case the table, the shortcut was initially created for, does not longer exist, e.g. since a third-party extension was removed, this led to an exception. The database row is therefore now fetched using BackendUtility::getRecordWSOL(), which checks if the table is (still) configured in TCA, since this is anyways a prerequisite for using getIconForRecord() and for working with shortcuts - Especially when `record_edit` is the target module. As a positive side effect of this change, a possible workspace version is now also taken into account, when generating the record icon. Resolves: #94286 Releases: master, 10.4 Change-Id: I1d6e1327f10ad06863ef7f5bb1e3706a3f10bcfe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69416 Tested-by:
-
Oliver Bartsch authored
Since #93508 additional information about the inline parent are available in the $parameters array of an itemsProcFunc. Those information are only available in FormEngine context and not in the DataHandler. This is now properly documented in the corresponding class. Resolves: #94290 Related: #93508 Releases: master, 10.4 Change-Id: Id20390b113f1cd9261a2b33413031233524f6623 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69417 Tested-by:
-
Oliver Bartsch authored
EXT:seo defines two additional types for "Page Overview" in the info module. Since the special uid field, which has a special treatment in PageInformationController, was previously missing, no view and no edit options were displayed. Besides the already existing special treatments, in master, the field is also used to determine the row tag to be used (either `<th>`or `<td>`). Therefore, the two EXT:seo types previously always used `<th>`, which leads to all cells were bold (in at least the chrome browser, due to user agent styles). This is now fixed by adding the special uid field to the mod.web_info.fieldDefinitions declaration in EXT:seo. Resolves: #94291 Releases: master, 10.4 Change-Id: I5c20528008160a2c5d853b6d70cc84e3cf3ad89a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69418 Tested-by:
-
Benjamin Franzke authored
Symfony deprecation messages are prefixed by an @-sign in order to only be thrown if an explicit error handler for E_USER_DEPRECATED is registered. Other than for regular silenced errors, we want these deprecation messages to be logged in any case, and therefore ignore the @-sign for E_USER_DEPRECATED errors now. Releases: master Resolves: #94269 Change-Id: I2d1fb443ef0bf5d01361f1980ab74b94a116fb1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69366 Tested-by:
-
Oliver Bartsch authored
Since translated records do not contain a checkbox for the clipboard functionality, we have to check the element before accessing the "checked" property. Note: There is still a problem in master, which will be tackled in a separate patch. Resolves: #94293 Releases: master, 10.4 Change-Id: I795b99f7112e8ae5d8eef79b6161b19b5bb77e0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69420 Tested-by:
-
Simon Gilli authored
This patch introduces a new type for the Pagetree overview in the info module. It displays the relevant layout fields, e.g. backend layout and frontent layout, next to an additional field which contains the actually used backend layout, inherited from a parent page. This follows #94210, which already introduced a field information for the pages.backend_layout field. This effectively allows an editor to have a detailed overview of the configured and - more importantly - actually used backend layouts for a page or even a complete page tree. Resolves: #89700 Releases: master Change-Id: I4851cd8133d4dbac9ccc1e0d04b534077729c6cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62338 Tested-by:
-
Christian Kuhn authored
RenderingContext is a good case for a class that creates "arbitrary" objects: The PreProcessor class names are retrieved from global configuration in order to be instantiated. This initialization is moved into a (install tool mode compatible) factory in order to transform ObjectManager into a fallback layer for PreProcessors that are not defined in the newer PSR container. Therefore $container->has() is used prior to $container->get(), in order to fallback to ObjectManager for objects that can't be retrieved – due to missing configuration – via ContainerInterface yet. Resolves: #94285 Related: #90803 Releases: master Change-Id: I3fd1751b8580de7c8307e9b84da38e1551c2c622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69412 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Oliver Hader authored
`GeneratorClassesResolver` used for the extension scanner preprocesses `GeneralUtility::makeInstance` calls, transforms class-string values to their corresponding class-constants and provides a low-level class instantiation using `new`. When modifying PHP parser nodes, only expected types shall be used, which is `ClassConstFetch` instead of `FullyQualified`. Resolves: #94283 Releases: master Change-Id: I3a802212dc067c5ced0e03aa2cce6519d5ed1dbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69403 Tested-by:
-
Oliver Bartsch authored
When dumping the ModuleTemplate with DebuggerUtility a property access exception is thrown, since the FlashMessageQueue is neither initialized nor declared as nullable. This is fixed by initializing the FlashMessageQueue in the constructor now. This instance can however still be overwritten by the corresponding setter method. Resolves: #94276 Releases: master Change-Id: I64bd52e05cd41112a4edb7cc9629db52a093764b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69395 Tested-by:
-
- Jun 08, 2021
-
-
Oliver Bartsch authored
Atfer a lot of preperation in #93048 and #93988, it's finally possible to share URLs to TYPO3 backend modules. Even special modules such as FormEngine. To ease the use for editors, the ShortcutButton is extended for a new option. If enabled, which is the default behaviour, the shortcut button in the module header is replaced. The new button allows to open a dropdown with the additional possibility to copy the URL of the current page to the operating systems' clipboard. Next to the already exisiting "Add shortcut" option. Since those URLs should not contain the user specific token, the UriBuilder features a new constant "SHAREABLE_URL". If set as $referenceType in one of the supporting methods, e.g. buildUriFromRoute(), an absoulte URL without the token is returned. To copy the URL to the operating systems' clipboard, a new web component "CopyToClipboard" is introduced. This component is added without any dependency to the URL sharing functionality and can therefore be freely used for other backend components as well. For the new button, the font awesome "share-alt" icon is registered in the IconRegistry. Resolves: #93921 Releases: master Change-Id: Id1dcfe1f2af764fbe000659ddb49a7369322d5b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69338 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
This allows to access the ModuleTemplate instance in PageLayoutController related hooks and therefore enables extension authors to be more flexible when manipulating the page module view. Resolves: #92358 Releases: master Change-Id: I6f3d370d0c8d730dfcdf631d8516a8691360167b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69396 Tested-by:
-
- Jun 07, 2021
-
-
Oliver Bartsch authored
The EXT:linkvalidator documentation is extended to include a note about the behaviour and usage of page TSconfig when recursively checking for broken links. Resolves: #84887 Releases: master, 10.4, 9.5 Change-Id: I183bc3fdf734db1a871a509fafd6b82d75ea16aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69407 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Oliver Bartsch authored
The translation mode buttons in the localization wizard are now translatable as the rest of the wizard. Resolves: #94277 Releases: master, 10.4 Change-Id: Ie2bbaebbcf5c701a8e3446a3406dece565c2013b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69405 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #94130 Releases: master, 10.4 Change-Id: I4a0ebef62b3bf80c10b4552ced2d94a584b600b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69151 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
- Jun 04, 2021
-
-
Benni Mack authored
The run() method for all Applications contained a callback which was added in TYPO3 v7, before proper solutions for subrequests and a more streamlined boot process, was in place. The additional code can now be handled via PSR-15 middlewares. Therefore, the callback argument in Application->run() is now marked as deprecated. Resolves: #94272 Releases: master Change-Id: I9fe00e7b3663553dadc1b48b89c3083537206c5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69258 Tested-by:
-
- Jun 03, 2021
-
-
Oliver Bartsch authored
To reduce usages of GeneralUtility::_GP(), GeneralUtility::compileSelectedGetVarsFromArray() is deprecated. Its only usage in the core is adjusted by accessing the PSR-7 Request instead. Side note: Actually also the method name is misleading. Since _GP() is used internally, also POST data are checked. Resolves: #94252 Releases: master Change-Id: Ia3d569dbc9bdb21770e6d5981752f40b2fe59d0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69362 Tested-by:
-
- Jun 02, 2021
-
-
Oliver Bartsch authored
While reworking the Shortcut API in #93093, some arguments in the ShortcutButtonViewHelper have been deprecated. However, in #94209 the whole view helper has been deprecated, which makes the mentioned comments obsolete. Therefore, and because they might just confuse developers on upgrading, they are removed. Resolves: #94268 Releases: master Change-Id: I5da2dd4193c016e12bcda06f63abcd5b11b53d0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69365 Tested-by:
-
- Jun 01, 2021
-
-
Sybille Peters authored
Documentation can be generated from the existing README.rst. A Settings.cfg is necessary so that the title is set. Online rendering of EXT:lowlevel documentation is now possible. Resolves: #94238 Releases: master, 10.4 Change-Id: I1f20e7c95b6fa337805b14677640d23262709d34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69330 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Daniel Goerz authored
composer req friendsoftypo3/phpstan-typo3 ^0.8.1 --dev This patch is the next step towards full level 3 compatibility of the TYPO3 core. Releases: master Resolves: #94127 Change-Id: I5092ce3a9248a7e5ecba3f42183765c1b1d5b1cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69327 Tested-by:
-
Benni Mack authored
This change enables the usage of pages containing a trailing slash in their "slug" like "/my-page/subpage/" to be working, and modifies tests to cover this use-case. The main routing first fetches all records including the trailing slash (= also fetches pages with a trailing slash in their slug). The symfony routing then checks for e.g. "/my-page/" at the very end, but will fail if the page was named "/my-page", and then re-runs the symfony routing to find the "/my-page" request (same behavior as before). This change therefore solves two issues: 1. Pages with a slug with a trailing slash are properly resolved 2. Pages with a slug with trailing slash can be also called via "/my-page" and (new) pages without a trailing slash can be called WITH the trailing slash (as before) keeping maximum backwards-compatibility with RealURL logic. Resolves: #89091 Releases: master, 10.4 Change-Id: I5b82389f9769284d09d98b9335e11ed60c701896 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64655 Tested-by:
-
Christian Kuhn authored
We recently added a Services.yaml to ext:install. This isn't an incredible great idea since the install tool is designed to work with uncached DI via ServiceProviders in general. The config made Symfony scan all classes, but we need Symfony DI for the backend adapter class only. The patch reduces Symfony DI registration down to this class. Resolves: #94250 Related: #94209 Releases: master Change-Id: I5345e369a1080ddcab5da27ec1ef1c75e48f72d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69361 Tested-by:
crell <larry@garfieldtech.com> Tested-by:
-
Jochen Roth authored
* Removes duplicated dropdown caret and use bootstraps css caret (gridelement inside/after and finisher) * Fix preview mode dropdown in workspaces Resolves: #94198 Releases: master Change-Id: I7785f3ce21a6ee9773ebcd192b7a6abaded57273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69266 Tested-by:
-
André Buchmann authored
Set inlineTopMostParentUid fallback to "null" as "0" is a valid sys_language. "0" gives false positives in the check which languages are already defined. Resolves: #94248 Related: #94057 Releases: master Change-Id: I7975c0fa91940c502faec25cdbe0b30426300ee5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69355 Tested-by:
-
Christian Kuhn authored
The removed unit test mocks the system under test and checks for specific method calls. The test relies on AbstractTagBasedViewHelper from TYPO3Fluid\Fluid which added a feature in 2.7.0. This fails in core v9 and v10 which allow 2.6 and 2.7. This whitebox test is kinda useless anyway, so we drop it. Resolves: #94249 Releases: master, 10.4, 9.5 Change-Id: I70804f2881a84352ca793e7d523531a583a44b34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69358 Tested-by:
-
Daniel Goerz authored
* EXT:core Resolves: #94122 Releases: master Change-Id: I843e50719c5e5a2c3de425f49eae2f112e0df32f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69321 Tested-by:
-
André Buchmann authored
$GLOBALS['TYPO3_CONF_VARS']['MAIL']['format'] allows to configure the format for the mails, sent by TYPO3. The format "txt" does not exist and is therefore replaced by the correct value: "plain". Resolves: #94247 Releases: master, 10.4 Change-Id: I55535355f0f708a9e76cdbe1e0cae1583af93bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69354 Tested-by:
-
Oliver Hader authored
In order to determine whether HTTP referrer headers would be submitted to server-side backend API, a corresponding "reload" was triggered for the backend's main login form. Since the behavior resulted in reduced user experience, the refreshing mechanism was replaced by an equivalent AJAX endpoint and request. Resolves: #92293 Releases: master, 10.4, 9.5 Change-Id: I745d266a97135496276437b8eaf9dd206bc5806e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69336 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
