- Mar 22, 2022
-
-
Stefan Bürk authored
This patch raises doctrine/dbal to 2.13.8 as minimum version, which contains a bugfix to avoid a native php error is emitted, stating "mysqli::real_connect(): Passing null to parameter #7". See: https://github.com/doctrine/dbal/pull/5296 One phpstan ignore pattern slightly changed because of a changed return type declarion of doctrine/dbal. Tackling the corresponding error should be done in a dedicated test after proper investigation. Used commands: > composer req doctrine/dbal:^2.13.8 > composer req doctrine/dbal:^2.13.8 \ -d typo3/sysext/core --no-update > composer req doctrine/dbal:^2.13.8 \ -d typo3/sysext/install --no-update > composer req doctrine/dbal:^2.13.8 \ -d typo3/sysext/redirects --no-update > composer req doctrine/dbal:^2.13.8 \ -d typo3/sysext/core --no-update > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97222 Releases: 11.5 Change-Id: I6c1712a792780bd2966b3977d43f767e59304bd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74013 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Mar 21, 2022
-
-
Oliver Bartsch authored
Resolves: #97199 Releases: main, 11.5 Change-Id: Ibb65dbccbf26b0522ce1c8ccf8c78a1cea29e9c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73958 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Since bitwise operators requires the operands to be integers, a possible raw database value for a checkbox element is now properly casted, before used as operand, preventing a TypeError. Note: PHP < 8, this only triggered a warning. Resolves: #97194 Releases: main, 11.5 Change-Id: I40b53ba4eb11341792649516de2f3c6b86ae5a61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73957 Tested-by:
-
Simon Schaufelberger authored
Annotations are not needed since .phpstorm.meta.php takes care of it. Resolves: #97213 Releases: main, 11.5 Change-Id: I00687c4ea2c938e5b531016faf80f2a84ea1cdd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74002 Tested-by:
-
Susanne Moog authored
The TemplateService - if no TSFE is available - uses the rootline to find a matching site. Previously it only considered the top most element of the root line for finding a site, now it also considers all pages in the rootline with is_siteroot set. Resolves: #97172 Releases: main, 11.5 Change-Id: I39d2e980b91addbbce40666cada5ee63cb88d6a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73956 Tested-by:
-
Benni Mack authored
The new release allows versions 1, 2, or 3 of psr/log, so unblocks core using psr/log 3. Commands run: > composer req typo3/html-sanitizer ^2.0.14 > composer req typo3/html-sanitizer ^2.0.14 \ -d typo3/sysext/core --no-update Resolves: #97183 Releases: main, 11.5 Change-Id: Id0369aefb034ce477d4aa863f58e04518485ee47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73997 Tested-by:
-
- Mar 18, 2022
-
-
Markus Klein authored
The FileHandlingUtility may be used from a context where there is no BE_USER. Avoid a warning in PHP 8 Resolves: #97204 Releases: main, 11.5 Change-Id: Iae4d2d77cc69f46811933b6b081044256a1c7ce2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73955 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Mar 17, 2022
-
-
dev-rke authored
Releases: main, 11.5 Resolves: #97196 Change-Id: I75ac3c5ced9214ff4b5ed0d52772a42dddec1ec1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73981 Tested-by:
-
dev-rke authored
Since PHP 8.1, passing null to non-nullable internal function parameters is deprecated. Therefore the str_replace() call in ResourceFactory:retrieveFileOrFolderObject() might trigger a PHP deprecation. This is now fixed by adding a typecast to the input value. Resolves: #97195 Releases: main, 11.5 Change-Id: I0ca2fc3524b77b9d6b257b4797219046aa7beb15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73954 Tested-by:
-
- Mar 15, 2022
-
-
Benni Mack authored
When logging, the "DELETE" action is used when trying to read a record which should be copied. This change uses the INSERT action, so the log is proper. Resolves: #97182 Releases: main, 11.5 Change-Id: I294ee08e24327e67b6de2812163a00e6ca35f043 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73953 Tested-by:
-
Oliver Bartsch authored
In case an internal link targets a content element, defined by an anchor, this element is checked for e.g. being moved, hidden or deleted. In case the element is moved the "title" attribute was not filled, leading to a PHP warning. This is now fixed by always adding the correct record title. Resolves: #97147 Releases: main, 11.5 Change-Id: Ia78c34465bdc056a5714fc4e1bb7d7981be1e409 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73952 Tested-by:
-
- Mar 14, 2022
-
-
Benni Mack authored
Historically, a stage change (publishing or "editing => ready to publish") has been tracked - along with the comment in sys_log with the action=6 (update) and details_nr=30, where then the logs are read again for the workspaces module. Reading from sys_log is a problem as this data is very volatile (there is even a scheduler task to delete old sys_log entries older than e.g. 90 days, so we loose comments). This change now stores the information inside the sys_history table about a stage change, so the history of such an action is preserved, along with the comment. The workspaces module now reads from sys_history (via RecordHistory class) and from sys_log if there are still old comments. The reading from sys_log can then be removed at a later change. Resolves: #97158 Releases: main, 11.5 Change-Id: I055b944462f57a889681a6a236c329af29bb8d80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73878 Tested-by:
-
Francois Suter authored
In class \TYPO3\CMS\Workspaces\Preview\PreviewUriBuilder the value for TSconfig option "options.workspaces.previewPageId" is tested for a syntax like field:value but if the actual value does not use a colon, it will result in an undefined array key warning. Resolves: #97169 Releases: main, 11.5 Change-Id: I08fc2865a7163e7770bf6ee56a24369b15ff0240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73879 Reviewed-by:
-
- Mar 11, 2022
-
-
Nikita Hovratov authored
t3ver_oid might be missing if the table is not workspace enabled. Resolves: #97168 Releases: main, 11.5 Change-Id: I378ec155922f26d6ed536eda9131c612bb0e20a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73877 Tested-by:
-
- Mar 10, 2022
-
-
Georg Ringer authored
Resolves: #97143 Releases: main, 11.5 Change-Id: I172c876d967017c32ba0210c47c8f07601d8ffb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73875 Tested-by:
-
criwe authored
Correct the array key order of the TCA definition. Releases: main, 11.5 Resolves: #97165 Change-Id: If25125365b4ceae51644eec2064d296ea5235718 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73876 Tested-by:
-
Oliver Bartsch authored
This update gets rid of a false positive: https://github.com/phpstan/phpstan-phpunit/issues/120 Resolves: #97163 Releases: main, 11.5 Change-Id: I6f7ecd909a127b5940b928d81c94ab7b3404cd49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73896 Reviewed-by:
-
criwe authored
Correct syntax error, add missing ' in PHP code example. Releases: main, 11.5 Resolves: #97164 Change-Id: I222d8b6e39bdc0f6a0e31bd26f7b9582cb9aa500 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73874 Tested-by:
-
- Mar 09, 2022
-
-
Benni Mack authored
DataHandler and a few other places still used hard-coded values in the details field of sys_log, which is why certain logs could not be cleaned up due to different messages. This change removes all direct left-over places where variables are written directly as message (a few special cases will be handled separately). Resolves: #97155 Releases: main, 11.5 Change-Id: Idcf0e29ae41c6c1cf108b9c00c07fb180e16223b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73864 Tested-by:
-
Benni Mack authored
This change allows using PSR-3 provided placeholders such as "{myVariable}" in various places related to logging rendering, and fixes places in DataHandler where placeholders weren't used in the past and hard-coded strings were used instead of labels. Various logging calls to sys_log can now be read in a unified way, as the Logging API already used the placeholders in some places. Resolves: #97148 Releases: main, 11.5 Change-Id: Idd248fe6b5edf4dbc0476a602ba3dbb1d165b588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73873 Tested-by: -
Georg Ringer authored
The uid might not be set if not part of the select fields. A check is needed to avoid an undefined array key error. Resolves: #97146 Releases: main, 11.5 Change-Id: I3840b513046470d78a3da0f053ebc2b59ba2a30e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73872 Tested-by:
-
- Mar 08, 2022
-
-
Benni Mack authored
Change-Id: I2a98957ae609b33a6e3da9f89886283d25d76f06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73855 Tested-by:
-
Benni Mack authored
Change-Id: I1965f6060e592f436ec20bb99375f4a67f28bc9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73854 Tested-by:
-
- Mar 07, 2022
-
-
Simon Ackermann authored
Do not call reset and end functions on an empty array Resolves: #97127 Releases: master, 11.5 Change-Id: I1e05d743797f0ca3c84b360ef6a1cfd3aace8fca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73789 Tested-by:
-
Daniel authored
The function call seems superfluous, the condition tests if the array key exists, so the first parameter should be empty, the called function cObjGet tests if the first parameter is an array, if not, an empty string is returned. So i think we could use the empty string directly. Releases: main, 11.5 Resolves: #96805 Change-Id: Ib0fcf38fd67ed66cc7078530a215629a2c2cde1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73788 Tested-by:
-
Oliver Bartsch authored
Since the pid, evaluated in AddRecord, might be a marker such as '###PAGE_TSCONFIG_ID###', the variable must not be cast to int. Resolves: #97128 Related: #95001 Releases: main, 11.5 Change-Id: Ia400dabfebffd36d46701a27836572ca749d2c6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73787 Tested-by:
-
Helmut Hummel authored
The ExpressionLanguageResolver should be generic and not implement some TypoScript related logic. Therefore the check for "ELSE" expression is moved to AbstractConditionMatcher Dead code is removed on the go. Resolves: #97077 Releases: 10.4, 11.5, main Change-Id: Ic5037b46c65ffb80f2f5b242e671e2454922171c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73783 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Benni Mack authored
The method "getPagesOverlay" always returns the original array even if the page was not translated. The patch adds some tests and checks if the page was actually overlaid. Resolves: #96541 Related: #96492 Releases: main, 11.5 Change-Id: I942f3856d04fba1ae7bb58273f146e31bcc9bc64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73786 Tested-by:
-
Torben Hansen authored
When ext:felogin is configured to redirectMode "getpost,login", the extension does always redirect to a page configured in TS/Flexform although a valid redirect URL is provided using `return_url` or `redirect_url` GET parameter. Root cause of the problem is the wrong assignment of the fluid variable `redirectURL`, which should be used for GET/POST redirect urls only. This patch ensures, that the fluid variable `redirectURL` is assigned either with GET data from `return_url` or `redirect_url` if available. Resolves: #92068 Releases: main, 11.5, 10.4 Change-Id: Iae3ba5c4345b26a1cf9d52801c6d101c5986dbb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73784 Tested-by:
-
Chris Müller authored
Resolves: #96953 Releases: main, 11.5 Change-Id: I5071050dd7e2eac39c8578fd8dcb915b94a22aa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73658 Tested-by:
-
- Mar 05, 2022
-
-
Nikita Hovratov authored
AbstractFormElement->formMaxWidth declares its return type as of type int. But the ceil function returns float. The return value is now cast to int to prevent unexpected values. Resolves: #97108 Releases: main, 11.5 Change-Id: I2426a0a1f2bf78ef89ad0eec89158498136b0885 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73830 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Nikita Hovratov authored
Resolves: #97107 Releases: main, 11.5 Change-Id: I9a8c83e5aafed32fdee86d395597cfb8315e2b97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73782 Tested-by:
-
- Mar 04, 2022
-
-
Stefan Bürk authored
doctrine/dbal changed their API and usage for CompositeExpression and ExpressionBuilder with 4.0, which they already deprecated in 3.x. To avoid a big drift over time core has to follow these changes in the provided facade implementations, but keep the core promises up. Furthermore this paves the way to be able to raise doctrine/dbal:^4.0 later without being breaking. At least this is one preparation for this goal, not the last. To give extension developers the ability to support their extensions for two core versions without doing dirty hacks to avoid deprecation messages spammed into the logs, this patch provides the new methods as a forward-compatible backport change. Core usages and the finally deprecation will be done in dedicated follow up patches for the main branch. This patch provides following new methods: * static 'CompositeExpression::and()' and 'or()' as drop-in replacement for 'new CompositeExpress( $type , array $parts)', where $type is 'and' or 'or' * 'ExpressionBuilder::and()' as drop-in replacement for 'andX()' * 'ExpressionBuilder::or()' as drop-in replacement for 'orX()' Argument types of the new methods will be made strict with the following deprecation patch as union types are not supported by all required PHP versions for v11.5. Resolves: #97081 Releases: main, 11.5 Change-Id: Ia3db19afe0d6e4375f92080ea278b7ab6d96a3a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73766 Tested-by:
-
Stefan Bürk authored
The testing-framework with FE requests using sub requests is now able to handle DELETE,PATCH,PUT and POST requests. The situation in testing-framework is not the final solution, though. The patch adds a test to verify if testing-framework request details are properly received in the FE application. This not only adds a use case to the core for these kind of requests, but also ensures that we don't break this detail again when testing-framework internal handling is further refactored. Also needs a testing-framework bugfix in v11: > composer req --dev typo3/testing-framework:^6.16.2 Resolves: #97084 Releases: main, 11.5 Change-Id: I8268625d4b439f1657168d6b9c9a3878b36477bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73768 Tested-by:
-
Susanne Moog authored
Fixes an exception thrown when creating a backend user group for a new user. Resolves: #97085 Releases: main, 11.5 Change-Id: Id1a5c4663d100ece1178ffefc7abf8a2f20f4b26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73813 Tested-by:
-
Jochen Roth authored
When a creating a static route with a link that does not contain a uid, php throws an undefined array key warning. This has been fixed by adding a fallback for pageuid. Resolves: #97100 Releases: main, 11.5 Change-Id: I910d936b6e015378a2f6ccb4afbe9c9223ce9592 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73781 Tested-by:
-
André Buchmann authored
Resolves: #97098 Releases: main, 11.5 Change-Id: Idb2613c44964c86a61b534137f7ced60c69b238f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73777 Tested-by:
-
Helmut Hummel authored
As a followup to #96424, expressive API is introduced and covered with unit tests, to better convey the intention in the places it is used. Resolves: #96424 Releases: main, 11.5 Change-Id: I9596e2269b891042cbb03ccbedfcbc086f2897ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73711 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Björn Jacob authored
A new subchapter has been added to the form documentation. It addresses a common misconfiguration when removing form elements from the form editor. In addition, the chapter has been reorganized and a sphinx warning has been fixed. Resolves: #97103 Releases: main, 11.5 Change-Id: Ie90c6f4076d2b13675b9db686974efbb7f833bd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73812 Tested-by:
-
Nikita Hovratov authored
The new version finds some new possible bugs and removes some incorrect ones. Combined with a TF raise. Used commands: > composer req --dev phpstan/phpstan:^1.4.8 > composer req --dev typo3/testing-framework:^6.16.1 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97097 Releases: main, 11.5 Change-Id: I97cec4c07f70b6d451ba55f9aaec7df109c36f71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73811 Tested-by:
-
