- Aug 18, 2023
-
-
Sybille Peters authored
Fix handling link attributes (such as target, title) in link browser. The attributes were formerly not always applied to the link currently being edited. The problem appeared to be that the current selection in the editor lost focus and when link attributes were handled for this case, only the href attribute was applied. This is a follow-up patch for patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/80034 which did not fully resolve problems with setting the link attributes. Resolves: #101638 Related: #101360 Related: #101205 Releases: main, 12.4 Change-Id: Id5aeaae11341169b7a7bda15f62aeb2937486f88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80576 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Aug 17, 2023
-
-
Torben Hansen authored
If the CKEditor configuration has a language configuration, but does not define the `ui` language setting, no fallback language is added to the editor configuration and an undefined array key exception is thrown. This change ensures, that the `ui` language is properly set when the editor configuration has a language configuration and the `ui` language is missing. Resolves: #101401 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Id8bc03fd832413cf6ed1f9c5d443fa9f3387811c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80575 Tested-by:
-
Chris Müller authored
Resolves: #101672 Releases: main, 12.4 Change-Id: If00942d0876e36be53d745e099b8507c26f66cfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80574 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Aug 16, 2023
-
-
Andreas Fernandez authored
The methods `createRenderRoot()` and `render()` are considered being protected, but were public in some cases my mistake. This doesn't have any functional impact, but is now fixed nonetheless. Resolves: #101689 Releases: main, 12.4 Change-Id: I6bb88f90a8a44e0118dd8203433a54517b5dfa2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80561 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Nikita Hovratov authored
Since the major refactoring of ElementBrowsers into the file list module the order in which the currently selected folder from the user is loaded got messed up. The retrieval of the folder was moved from the render method to the initialization chain. However, at this point the session data is not processed yet. To fix this, the folder retrieval is moved back to the start of the render method. Resolves: #100837 Related: #99861 Releases: main, 12.4 Change-Id: I410306c8c1641e538367d6773474a660e9f383e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80573 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Andreas Fernandez authored
Google Chrome (and other browser vendors will probably follow) deprecates the unload event with Chrome 117 [1] and encourages using the Page Lifecycle API [2] instead. This patch replaces any usage of the `unload` event with the `pagehide` event that is available for all supported browsers [3]. [1] https://developer.chrome.com/en/blog/deprecating-unload/ [2] https://developer.chrome.com/blog/page-lifecycle-api/ [3] https://caniuse.com/mdn-api_window_pagehide_event Resolves: #101662 Releases: main, 12.4, 11.5 Change-Id: I675b180e855d8fb1070a84f5ba865e9250b2c0aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80559 Tested-by:
-
- Aug 15, 2023
-
-
Benni Mack authored
This change adds a test for localized pages that have a l10n_source "custom" value (e.g. "pages.author"). When copying the page and its translation, the l10n_state field is then set to "source", which is wrong. copyRecord() sets l10n_source=0, however DataMapItem expects "null". The patch makes DataMapItem understand 0 as value for l10n_source as well. Resolves: #88974 Releases: main, 12.4 Change-Id: I326765d92ea52bb49d94bc4965b998b993b5e673 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80572 Reviewed-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
-
- Aug 14, 2023
-
-
Thomas Hohn authored
Fix undefined array key "pages" in FileContentParser by adding a null coalescing operator. Resolves: #101450 Releases: main, 12.4, 11.5 Change-Id: Idc3bba5d5ab5516689925fadec86e6fac5978e73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80545 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Aug 12, 2023
-
-
Christian Kuhn authored
The low level service SchemaMigrator is used in ext:install and testing-framework. To allow DI in SchemaMigrator, testing-framework needs a pre-patch, which needs this pre-patch in core. Resolves: #101669 Releases: main, 12.4 Change-Id: Ie1f7e9ece05e4fa12c0fd27c1e3f871d4870b99b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80531 Tested-by:
Jasmina Lie�mann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
- Aug 11, 2023
-
-
Andreas Fernandez authored
There's currently a bug in the DataHandler that kicks in when copying a localized page that uses a "Custom" translation behavior on text fields. Due to the bug, state is broken and the JavaScript part cannot determine expected state, leading to a JavaScript error that leads to an endless spinner. This patch only fixes the JavaScript issue and renders a warning in the console, but FormEngine is usable again. Resolves: #101658 Releases: main, 12.4 Change-Id: I4fab1dae49928423c53906b0ae4fe5b4bddfaacd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80523 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Nikita Hovratov authored
The csp.yaml shouldn't be taken into account when merging current and new site configuration via the GUI. Resolves: #101626 Releases: main, 12.4 Change-Id: Ib08b7707cfb43733985b0c7aa5bf12bcc5fa603c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80480 Tested-by:
-
Torben Hansen authored
With the update from CKEditor 4 to CKEditor 5, parts of the extension documentation got outdated. This patch includes the following changes: * Updated external links to CKEditor 5 documentation * Updated screenshots to show CKEditor 5 * Updated configuration examples and removed unsupported options * Updated configuration reference * Added "Grouping toolbar items in drop-downs" example * Added "How do I create a custom plugin?" example Resolves: #101465 Releases: main, 12.4 Signed-off-by:
-
- Aug 10, 2023
-
-
Andreas Fernandez authored
If the "Add media by URL" button is used in FormEngine, a modal appears with an input field, allowing the user to enter a media URL. If an error occurs, the modal now stays open and the error is rendered via a notification. Previously, the modal was closed and another modal was opened informing about the error. Resolves: #101650 Releases: 12.4 Change-Id: I3b0852bb485e041e1d008a6842cff6de1c27bb98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80508 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Tomasz Woldański authored
This implements a rather unexpected detail when combining reference "=<" and copy "<" operator from old TypoScript parser. Copy operator: lib.source1 = TEXT lib.source1.value = source1Value lib.source2.otherValue = source2OtherValue tt_content.target < lib.source1 tt_content.target < lib.source2 Result: tt_content.target = TEXT tt_content.target.otherValue = source2OtherValue The tt_content.target existing value from lib.source1 is kept, but children are reset - lib.source1.value is not within tt_content.target anymore. Now reference first, then copy: lib.source1 = TEXT lib.source1.value = source1Value lib.source2.otherValue = source2OtherValue tt_content.target =< lib.source1 tt_content.target < lib.source2 Old parser after resolving reference in FE: tt_content.target = TEXT tt_content.target.value = source1Value tt_content.target.otherValue = source2OtherValue New parser after resolving reference in FE: tt_content.target = TEXT tt_content.target.otherValue = source2OtherValue The old parser keeps existing references when the copy operator does not reset the value to something else. The patch adapts the new parser to behave identical and refactors the AST copy method to better documented, more easy and eventually also quicker code. Resolves: #100115 Releases: main, 12.4 Change-Id: Ia03cefd6e550833bdc9120a179881d04bf70d117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80509 Reviewed-by:
-
Andreas Fernandez authored
This patch removes jQuery from the `@typo3/scheduler/scheduler` module in favor of native APIs. Extra fields are now hidden via the `hidden` attribute and not via CSS styling anymore. Resolves: #101619 Releases: main, 12.4 Change-Id: Ida87f82cde264785c8cd5b0d3619304bc6dfadfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80478 Tested-by:
-
Benjamin Franzke authored
Also raise the fixed linters to error level in order to not introduce similar errors again. The linter @typescript-eslint/no-explicit-any is disabled for now, in order for errors to be visible at first glance. Resolves: #101645 Releases: main, 12.4 Change-Id: I48229f148298ac13acd6d12deb55d606a3c7ef59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80504 Tested-by:
-
Benjamin Franzke authored
Missing declarations caused some method calls and assignments to not be type checked, as all members of the (top.|window.)TYPO3 object were declared to `any`. This actually revealed some invalid API usage. which is fixed as a drive-by. (No real bugs were found, as type checking in the APIs caught/ignored such cases) Resolves: #101644 Releases: main, 12.4 Change-Id: I2e188e53a02d9e0ae875084cadc28600c7a59aa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80502 Reviewed-by:
-
Andreas Fernandez authored
Executed commands: npm install --save bootstrap@^5.3.1 npm run build Resolves: #101629 Releases: main, 12.4 Change-Id: Idcb9f78543e945e0e948a19bb2574827b15806b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80493 Tested-by:
-
- Aug 09, 2023
-
-
Ernesto Baschny authored
In case you add a new TCA field of type "slug" in the pages table but without a config "eval", you get an exception in the backend. Resolves: #101640 Related: #93640 Releases: main, 12.4, 11.5 Change-Id: Ia9fc65707c581c288101eb9d54957aa9d025b98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80497 Tested-by:
-
Oliver Klee authored
Fix a case where the name of the testcase did not follow the name of the tested class. Resolves: #101631 Releases: main, 12.4 Change-Id: Ic5225f692c8610b18769bbceb5acdb427ef4c5d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80477 Reviewed-by:
-
- Aug 08, 2023
-
-
Oliver Klee authored
This change fixes places where the code violates the contract. Also, the change will avoid type errors when the `GeneralUtility` array functions are switched to native type declarations. All of these changes fix places where the acceptance test break with the GU array methods using native type declarations. Resolves: #101616 Related: #101453 Releases: main, 12.4 Change-Id: I6f86f7a371d50b20a34275ebc771604d407917bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80476 Tested-by:
-
Stephan Bauer authored
Releases: main, 12.4, 11.5 Resolves: #101620 Change-Id: I18563030fd382331a1389c500f313e28383901d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80475 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow current best practices. This changes tackles the classes where we can mock an interface instead of an abstract class, allowing us to use `createMock` instead of `getMockForAbstractClass`. Resolves: #101609 Related: #101601 Releases: main, 12.4 Change-Id: I995f70d779a1bc6251bc4479c3dcb2ee548314f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80458 Reviewed-by:
-
Jürgen Venne authored
The "global" extbase/Tests/Fixtures folder is unfortunate: Fixtures should be located in more dedicated folders and should not be shareable between unit and functional tests. The patch moves a couple of fixtures to more dedicated locations to avoid confusion. Resolves: #101530 Releases: main, 12.4 Change-Id: I3faad97ca05e7790da8443d615309da03ff91201 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80457 Tested-by:
-
Daniel Hettler authored
The URL param '_stg_debug' is needed to call the debug mode on-site Resolves: #101613 Releases: main, 11.5, 12.4 Change-Id: Iff94ede5c3d388fe8b130e10e5b48658511a0bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80472 Tested-by:
-
Benjamin Franzke authored
New runTests.sh option "-g" opens a tab in a local browser pointing to http://localhost:7900/?autoconnect=1. This allows watching acceptance tests clicking around. Releases: main, 12.4, 11.5 Resolves: #101611 Change-Id: I53cbb861d7df6daac96dfcc382183f46847d7894 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80367 Tested-by:
-
Benni Mack authored
Change-Id: I46f8b5ca905e3661ad63d8f8d6e491c9c729a8ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80453 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
Change-Id: Ibdd8edc8f940289469c925b969415c7790c20a61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80452 Tested-by:
-
- Aug 07, 2023
-
-
Andreas Fernandez authored
The module menu is currently in a bad shape where different loose DOM elements and scripts are tangled together and do stuff. Previously, the module state was stored as a JSON-encoded string in the container of the actual module menu, which isn't refreshed when the module menu is reloaded via AJAX, leading to endless "loading" modules a freshly installed extension may add. Also, the JSON string gets parsed once and is then cached for faster access times. This patch accomplished multiple things: * the module state information is moved to the `nav` element of the module menu that's part of the reload process, always having the current state * an internal `flushModuleCache()` function is introduced to clear the cached, parsed state This is not an ideal solution but the best way the issue can be fixed in short-term. In long-term, the whole module structure and its handling need refactoring. Resolves: #100493 Releases: main, 12.4 Change-Id: I28342d7b207638e307c2ca7f4f50f2f4e6d27dbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80366 Tested-by:
-
Oliver Bartsch authored
Resolves: #101605 Releases: main, 12.4 Change-Id: I1da8af5b5b0025ad0f25349fe6d4893eddbd5eaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80432 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Thomas Hohn authored
Moved assignment of $destPid = $sortInfo['pid'] after check if $sortInfo is an array, since the method call to getSortNumber can return other values than an array. Resolves: #101606 Releases: main, 12.4, 11.5 Change-Id: I3cfef35b351a0cd1fa8197702cce9e3b05871fcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80431 Tested-by:
-
Christian Kuhn authored
Remove -j and -k and only use -i to specify database versions. This is more easy to use, parse and validate. Resolves: #101604 Releases: main, 12.4, 11.5 Change-Id: Ie6b9343c6f244a294d636f0e5c09d24c5e1845fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80428 Tested-by:
-
- Aug 06, 2023
-
-
Rémy DANIEL authored
Linkvalidator extension has a couple of known issues, especially with external link checking. Those issues are now documented, so integrators can acknowledge them and implement counter-measures. Resolves: #101597 Releases: main, 12.4, 11.5 Change-Id: I00dc01243426fc56c21a4bd11815c3009e3dd3ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80364 Tested-by:
-
Christian Kuhn authored
Fix a happy little regex to deal with "TCEforms" removal of #97126. This should fix finisher override FormEngine rendering. Resolves: #101050 Related: #97126 Releases: main, 12.4 Change-Id: Ia8d893c3f3b31f7af83b3d9f2ae533b3e557f5a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80363 Tested-by:
-
Chris Müller authored
Resolves: #101600 Related: #101114 Releases: 12.4 Change-Id: I9893e4c8b8eff5e05575984ab37e7f22612b26a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80420 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Chris Müller authored
In some cases, classes are displayed like "TYPO3CMSCoreTypeContextualFeedbackSeverity" as backslashes are neither quotes not enclosed in a ":php:" directive. Where appropriate, we now link to the source code directly instead of just mentioning a class (with ":t3src:)". This is helpful, for example, for the severity enum, when you just want to know the available cases. Additionally, other mentions of PHP classes are now enclosed in a ":php:" directive instead double ticks. Resolves: #101599 Releases: main, 12.4 Change-Id: I2b384e388e6b6544c0a534a2bb23e97bc7c7fc1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80419 Tested-by:
-
- Aug 05, 2023
-
-
Christian Spoo authored
`PersistedAliasMapper` and `PersistentPatternMapper` both should only use int-like string route arguments as possible UID candidates for the following DB lookup. Thus, check if the arguments are truly numerical before passing them to the database queries. Resolves: #93105 Releases: main, 12.4 Change-Id: Ic3b9b5415abfce602b6be7c8031202823ea25e60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80416 Tested-by:
-
Sebastian Klein authored
Extensions can provide static data using the file "ext_tables_static+adt.sql". If this file exists, a button is automatically created in the Extension Manager. As soon as you click the button, the static SQL data will be imported. Existing data will be dropped. A new modal now warns the user before executing the file, with buttons to start or abort the task. Resolves: #100118 Releases: main, 12.4 Change-Id: Ie33a89d6957428f390edeaa2700639bc13ac8b7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80362 Tested-by:
-
Rémy DANIEL authored
If the svg-tree component is embedded in an iframe, and if the iframe src get changed by navigating to another url, pending AjaxRequest will be cancelled by the browser, without letting us the opportunity to properly catch the thrown error. As a workaround, we register an unload event on the iframe's window, and mute notifications to the user. Resolves: #101340 Releases: main, 12.4, 11.5 Change-Id: I8572fde4bf278481a32a459f802af69356ce28a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80361 Tested-by:
-
Gordon Brüggemann authored
Resolves: #99725 Releases: main, 12.4, 11.5 Change-Id: I4682cbe57b4908e13c219c5be4b0810c0d348bf1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80412 Tested-by:
-
