- Aug 29, 2023
-
-
Benjamin Franzke authored
IDEs like PhpSstorm complain about the same thing, so better we have that defined and checked via CI. Commands executed: node_modules/.bin/eslint --fix Sources/TypeScript/ Resolves: #101780 Releases: main, 12.4 Change-Id: I01e0289b671dfd4348319bca90dddaec085fbfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80747 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com>
-
Benjamin Franzke authored
This helps to prevent hard-to-discover build failures, that only happen on clean installs (e.g. CI). This is because TypeScript will by default scan the entire source dictionary (Build/ in our case) for possible includes. We previously excluded /Build/composer in #95046, but it is actually much better to explicitly include the actually used source paths to also exclude build output (Build/JavaScript/) from being reinterpreted by subsequential eslint or tsc compile runs. Note that we also refactor the types/ directory in order to be a folder that conforms to the @types/* packages conventions, by being actually usable in the compilerOptions.types property. Note that our custom global type definitions (types/) were previously implicitly loaded as globally available sourcepaths. With the new `include` option we could add them back, but then we wouldn't notice if we do not add proper index.d.ts files (like we did until now). Therefore index.d.ts files are added in here. Now, with TypeScript being "clean", we need a another small adjustment in order for eslint to still being able to lint our types/ folder. Therefore tsconfig.json is extended to include the types directory. See [1] for more information on why eslint needs that. [1] https://typescript-eslint.io/linting/troubleshooting/#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file Resolves: #101782 Related: #95046 Releases: main, 12.4 Change-Id: I3ab8b874192d25470bbd5e71cc5d99e853259f89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80746 Reviewed-by:
-
Benjamin Franzke authored
This allows to drop a npm patch that had been applied to the TypeScript @types/jquery before, in order to achieve the same effect. With eslint we can additionally provide a good hint for the developer, what to use instead. For the v12 backport @types/jqueryui is removed additionally, as it conflicts with the bootstrap jquery definitions and was unused. This showed a small adaption that needed to be changed in upgrade-docs, which has already been fixed in main and is reapplied in here. Commands executed: npm remove patch-package npm install npm remove @types/jqueryui Resolves: #101697 Releases: main, 12.4 Change-Id: I77e15a4b4c2a18f8b72ec2a5f41c7e54a7966c30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80686 Tested-by:
-
Benjamin Franzke authored
Remove unused files that have been forgotten to be removed when there respective TypeScript source files where removed. Resolves: #101786 Related: #101783 Releases: main, 12.4 Change-Id: I75a74996e9dc1f9f30fd3b2f08914e25452df06f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80685 Reviewed-by:
-
Andreas Fernandez authored
The Install Tool router attempts to build URLs manually by wild string replacements and manipulation, which is rather error-prone. This patch changes the approach to use the URL API instead. Resolves: #101789 Releases: main, 12.4 Change-Id: I07ee73764b4fc5167f732d67faf2843fef0db199 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80745 Tested-by:
-
Benjamin Franzke authored
…of a new form element, that has not yet been persisted. Tabbing through an elemenet is considered an "input" by the browser, which is why the "input" even is triggered. The result is an empty input element (as before), but an intent is made to delete the underlying property from the form element object model. When the object model is empty (remeber, it is a new element), and an input field refers to a nested property (e.g. properties.fluidAdditionalAttributes.placeholder) removing an element (e.g. 'placeholder') will fail when the parent has not yet been set (e.g. properties.fluidAdditionalAttributes) Resolves: #101750 Releases: main, 12.4, 11.5 Change-Id: I49a9ead343e671c3d0289bd6d969316b888d05eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80729 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Aug 28, 2023
-
-
Christian Kuhn authored
The extbase ConfigurationManager is (unfortunately) a stateful singleton that we can not get rid of without a bigger rewrite. While stateful singletons are bad enough, the extbase LocalizationUtility makes this worse by parking an instance of ConfigurationManager in a static property, re-using it as a "cached" singleton. LocalizationUtility does this since it in itself is static, which makes this service just so convenient to use. When it comes to sub requests and similar, static state is doomed and we need to get rid of it, we've had a couple of patches in v12 dealing with similar things. Mid-term, extbase LocalizationUtility needs to vanish anyways, but in the meantime, we have to get rid of static state that kills sub request scope. The patch removes the static $configurationManager property and adapts functional tests that already showed the current solution was a hack. There are various upper and lower cache layers that ensure removing this "cache layer" won't make things more expensive in practice, which allows us to remove this static state without further fallback. In main, this needs a TF update: > composer u typo3/testing-framework In 12.4, this need a TF raise: > composer req --dev typo3/testing-framework:^8.0.3 Resolves: #101779 Releases: main, 12.4 Change-Id: Ie5db07b0475f612a996d369ab3417672b33fbb2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80737 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Fernandez authored
Previously, the `keyup` event was intercepted in "Extension Configuration", which doesn't work with `clearable()`. This patch changes the code to listen to `input` and `change` events instead. Resolves: #101772 Releases: 12.4 Change-Id: I1e90ede6ab1693fd76dcb6aafb1dab0a616b5784 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80714 Reviewed-by:
-
Torben Hansen authored
With #90002, all occurrences of the `list()` function have been migrated to the short list syntax. Our php-cs-fixer configuration does however not check the short list syntax usage, so we have one usage of `list()` in our codebase again. This change extends the php-cs-fixer configuration to ensure, that only the short list syntax is used. The new ruleset has been applied to the codebase and one usage of the `list()` function has been migrated. Resolves: #101777 Related: #90002 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I30f5822e27a36515c2c77a19089a0754ff6fdcfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80684 Tested-by:
-
Benjamin Franzke authored
Resolves: #101738 Related: #82577 Releases: main, 12.4 Change-Id: Id857430ae81322cf9197ba6df422780695f59f50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80728 Tested-by:
-
Benjamin Franzke authored
Resolves: #101737 Related: #82577 Releases: main, 12.4 Change-Id: Ibc8ed8be6a8defc7dba4910e3f1df937809600aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80727 Tested-by:
-
Benjamin Franzke authored
Resolves: #101736 Related: #82577 Releases: main, 12.4 Change-Id: If77dc697ac23b5f1fb3f36dd15fe36cfb369700d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80726 Tested-by:
-
Benjamin Franzke authored
Resolves: #101735 Related: #82577 Releases: main, 12.4 Change-Id: I5584528f69fddba7a5f7f4b3592ca4bf9e83938c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80725 Tested-by:
-
Benjamin Franzke authored
Resolves: #101734 Related: #82577 Releases: main, 12.4 Change-Id: I0619297a3fbf3e2fd18b1aef1a0c82794a5ca714 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80724 Tested-by:
-
Benjamin Franzke authored
Resolves: #101733 Related: #82577 Releases: main, 12.4 Change-Id: I4d9f92287d9a2b69fa4421de2377f7bf9806147c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80723 Reviewed-by:
-
Benjamin Franzke authored
Resolves: #101717 Related: #82577 Releases: main, 12.4 Change-Id: I9e0a42954b387d34ded5ebd1bde533b9feb4e70e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80722 Tested-by:
-
Benjamin Franzke authored
Resolves: #101713 Related: #82577 Releases: main, 12.4 Change-Id: Ic7b41b79552a4c14d7395609e0ac3dda9c47b20f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80721 Tested-by:
-
Benjamin Franzke authored
Resolves: #101712 Related: #82577 Releases: main, 12.4 Change-Id: Id77b6cd93cff41c26220ca0b10b948813c1242be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80720 Tested-by:
-
Benjamin Franzke authored
Resolves: #101702 Related: #82577 Releases: main, 12.4 Change-Id: I4ec165e645ee367d71404338e83ba6f40cb28494 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80719 Tested-by:
-
Benjamin Franzke authored
Resolves: #101634 Related: #82577 Releases: main, 12.4 Change-Id: Ia9ad4d39e925f671707ec62cd989bfca6dbf32ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80718 Tested-by:
-
Christian Kuhn authored
Use the new v12 EXTBASEPLUGIN in TS setup to streamline frontend functional tests a bit. Resolves: #101773 Related: #100293 Releases: main, 12.4 Change-Id: I84e3cc93f617e3d8feeb76e6acf2c02bc4070a6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80683 Tested-by:
-
Andreas Fernandez authored
When resetting the tag filter in "View Upgrade Documentation", the `hidden` class now gets removed, making previously filtered upgrade docs visible again. Resolves: #101771 Releases: main, 12.4 Change-Id: Ie8bc14cc20fed803ae9644308eeb7cf2daa15a09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80715 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Achim Fritz authored
Resolves: #101754 Related: #100307 Releases: main, 12.4 Change-Id: I43c43f1635fd789e3f035e9840d37fb70528cb66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80682 Reviewed-by:
-
Benjamin Kott authored
The `script` tag is defined to hold executable code or data and not template html markup. We are switching this to the `template` tag that is indended for this usecase. Resolves: #101769 Releases: main, 12.4 Change-Id: I0657e5cbce7e13770ce88918cb9e4137bf017590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80681 Tested-by:
-
Benjamin Franzke authored
The ajax Icon API is currently not available during first install, therefore neither getIcon nor the icon web component may be used to render an icon. The icon markup is therefore now pre-rendered via fluid for both states and toggled via CSS. Resolves: #101765 Related: #98089 Releases: main, 12.4 Change-Id: Ib72c06e41f083e4dc7392845058fc86aae95af9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80712 Reviewed-by:
-
Oliver Klee authored
This fixes an issue in the acceptance tests where `null` is passed to `GeneralUtility::xml2array()` (which expects a `string`). Having an early check for an empty string also avoids pointless XML parsing (which should help performance a bit). Resolves: #101757 Releases: main, 12.4, 11.5 Change-Id: Ifc4406536c273baca9acdda7a0af7a91594f57bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80679 Tested-by:
-
Mathias Bolt Lesniak authored
The constructor of `\TYPO3\CMS\Core\Http\Request` now correctly accepts resources of the type "stream" as $body argument. Resolves: #101764 Related: #97620 Releases: main, 12.4 Change-Id: I2e7000c11ef4a16334f3305142ef8fb7fe6c639f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80710 Reviewed-by:
-
Oliver Klee authored
The new versions find some more possible problems, and also improve performance. > composer req --dev phpstan/phpstan:^1.10.32 > composer req --dev phpstan/phpstan-phpunit:^1.3.14 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101756 Releases: main, 12.4, 11.5 Change-Id: I23429a98b25ce340405b8b9dc384869526c6f920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80707 Reviewed-by:
-
- Aug 26, 2023
-
-
Torben Hansen authored
With CKEditor v38.0.0 a small "Powered by CKEditor" logo has been added to the bottom right of the editor component. The logo is visible as soon as the CKEditor component receives the focus. The current placement of the logo does however overlay the border of the editor component and the term "Powered by" does not suit well to the TYPO3 backend. With this change, the CKEditor configuration has been extended, so it is now possible to configure `config.ui.*` settings. The `Base.yaml` file has been extended with CKEditor UI specific settings, which remove the term "Powered by" from the logo and which optimize the logo placement, so it appears in the bottom right corner of the editor component without overlaying the border. Resolves: #101759 Releases: main, 12.4 Signed-off-by:
-
- Aug 23, 2023
-
-
Oliver Hader authored
Due to #101083 absolute path URIs like `/path/some-file.png` are handled as external URL, which leads to scenarios, that the fully qualified domain name is not applied anymore, when using `typolink.forceAbsoluteUrl=1`. Resolves: #101709 Related: #101083 Releases: main, 12.4 Change-Id: Ie4fe94169c4ab78dd61d2b228a684f1521337fc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80663 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Jochen Roth authored
The change introduced with #101444 broke the binary finder mechanims. This has been fixed by "continue" the loop instead of "break" the loop. So all paths are tested instead of just the first one. Resolves: #101687 Related: #101444 Releases: main, 12.4 Change-Id: Iddf55f2e936f79038c2f52a93040ac48c8a9a1dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80677 Tested-by:
-
Sybille Peters authored
The following problems are now fixed: 1. do not check links on hidden pages (if checkhidden=0) 2. show links on hidden pages (if checkhidden=1) Also, unit tests are introduced for PagesRepository. More functional tests can be added in additional patches. Resolves: #93895 Releases: main, 12.4 Change-Id: Id8fc2ea6df4d0c8d1adbaee114d5a4a6d556b8d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80661 Tested-by:
-
Ingo Fabbri authored
This commit adds two new keys to table sys_log: - channel - level Resolves: #101707 Releases: main, 12.4 Change-Id: Iddc61daf268573c658a068a655b97c482e438c31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80660 Tested-by:
-
Andreas Fernandez authored
When a backend user is created via the Install Tool, a notification is rendered to tell the system maintainer that the action was successful. However, the original patch mixed up the title and the message, which is now fixed. Resolves: #101741 Related: #91461 Releases: main, 12.4, 11.5 Change-Id: Ie25efa0476a118cfaa99a54d3cb4fe27ca5ef8e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80675 Reviewed-by:
-
Garvin Hicking authored
The 'uuid' FormEngine TCA element misses the call to render registered field controls. Add it and merge it into rendered HTML. Resolves: #101740 Related: #101703 Related: #100171 Releases: main, 12.4 Change-Id: I18983883d2ae4460929a40aa3ccee1a7c261ab63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80656 Tested-by:
-
Andreas Fernandez authored
This patch makes use of `PathUtility::getAbsoluteWebPath()` in EXT:indexed_search's SearchController which is suitable for calculating asset paths in both, Composer and non-Composer scenarios. Resolves: #101727 Releases: main, 12.4, 11.5 Change-Id: I88f487b1fdf88b404fc51a3d5d6131dba5483cdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80673 Tested-by:
-
Dominic Petit authored
Allow to save a phone link with a comma or a semicolon. Resolves: #101721 Releases: main, 12.4, 11.5 Change-Id: I54e19fbfb2b1b184db4454a19728f08e70cddc4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80654 Tested-by:
-
Stefan Bürk authored
This change reduces the column length for `tablenames` and `fieldname` for TCA based auto-creation to the max possible length of 64. This reduces the needed size for the auto-created primary key and ensure a working index for instances using mysql or mariadb server backends without increased maximum innodb index key length. Resolves: #101731 Related: #101425 Releases: main, 12.4 Change-Id: Iba40730687a7033ea2f43c0aa6049f9df1212683 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80672 Tested-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
-
Garvin Hicking authored
FormEngine fieldControl "passwordGenerator" can be handy with TCA type="input" as well. The patch removes a restriction in PasswordGenerator that binds this fieldControl exclusively to TCA type="password". Resolves: #101703 Related: #98540 Releases: main, 12.4 Change-Id: Ice09e0af2269d5f0aad5afa2d08215d51a04e394 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80653 Tested-by:
-
Sybille Peters authored
If there is not a newline before and after the list, the list may not be formatted correctly. A newline was added before and after lists in .rst files. Additionally, some lines beginning with "- " (which would result in false positives when checking) were modified so that list checking can be performed more easily in the future. Lists can be checked for example by using the following regular expressions: find typo3/sysext/*/Documentation -name "*.rst" | while read i;do grep -B1 -H -E "^(\-|\*)\s" "$i" | grep "\.rst-" \ | grep -v -E "\.rst-($|\-|\*|\s)" grep -A1 -H -E "^(\-|\*)\s" "$i" | grep "\.rst-" \ | grep -v -E "\.rst-($|\-|\*|\s)" done https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/ \ WritingReST/CommonPitfalls/Lists.html Resolves: #101715 Releases: main, 12.4, 11.5 Change-Id: I8dca5634ae3dcd7e702197cb72b43d79a05f3f5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80631 Tested-by:Christian Kuhn <lolli@schwarzbu.c...>
-
