- Sep 02, 2022
-
-
Stefan Bürk authored
PHPStan fails with composer max installation due changes in the detection. Raising the version to corresponding version leads to abnormal performance decrease. Thus not an option we can use. This change pins phpstan to a fixed version to avoid failing nightlies until the performance issue in the PHPStan tool has been fixed. See: https://github.com/phpstan/phpstan/issues/7903 Used commands: > composer req --dev "phpstan/phpstan":"1.8.2" Resolves: #98253 Releases: main, 11.5 Change-Id: I38a31b87c36b9ae4c5915422dd3f09a6fca38b57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75601 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Stefan Bürk authored
PHP8.1 introduced native return types to native methods and interfaces, which crashes if they are not compatible. As a workaround the introduced `#[\ReturnTypeWillChange]` attribute can be used to mitigate this, which has been used to mitigate quite some issues with it. PHPStan has released a new version which fixes a bunch of bugs, which detects more issues in core. These will be addressed with the dedicated PHPStan raise patch #98246. However, one issue cannot be solved or added to the baseline and must be fixed beforehand. The reason is, that phpstan also evaluates the PHPDoc return type. This change uses the `#[\ReturnTypeWillChange]` attribute to silence this as a backportable intermediate solution. Resolves: #98251 Related: #98246 Releases: main, 11.5 Change-Id: I24e7d24e735d2dffbca0eca21de602c40f7e7d2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75575 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Nikita Hovratov authored
With patch #97786 a bug was fixed, to only toggle inline controls in their own scope. For this a new helper class was introduced and added for vanilla inline controls. However, there are two other special inline control types for record selectors. Most commonly known from the FileSelector for FAL. The helper class is now added there as well. Resolves: #98233 Related: #97786 Releases: main, 11.5 Change-Id: Ifb2eb4205ecec50540a70943163c639f04de5ea1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75574 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Aug 30, 2022
-
-
Lina Wolf authored
Releases: main, 11.5 Resolves: #98219 Change-Id: Ib60a14ff4a80eb4333187d3eff4ebf2a0262383d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75573 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
linawolf authored
Replace the todo with information. Thanks at Florian Weiss for pointing this out and providing me with the screenshot Releases: main, 11.5 Resolves: #98215 Change-Id: Ia14e18ecd260ee9dfa98dae88aa68e8e7b4f1612 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75572 Tested-by:
-
- Aug 28, 2022
-
-
Stefan Bürk authored
Symfony recently released new version v5.4.12 and v6.1.4 of the framework which contains a change in `symfony/mailer` throwing a TransportException and passing null as 2nd ($code) argument. This is deprecated since PHP8.1 and emits now a corresponding depcreaction warning in some circumenstances and breaking one mailer unit test. See: https://github.com/symfony/symfony/issues/47402 This change temporarly skips the test for PHP8.1 until the fix has been merged and released a new version by symfony. Resolves: #98216 Releases: main, 11.5 Change-Id: I12a18f425bd573e1943dddad909c7c3256c1fd87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75501 Tested-by:
-
- Aug 25, 2022
-
-
Oliver Hader authored
Change-Id: Ic0df4413b78775ca2c9fc17e0180c4f1ba3db6c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75548 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I16a29c9ce3ae6d3d430b2d09b0cc952533e67cfe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75547 Tested-by:
-
- Aug 24, 2022
-
-
Daniel Hettler authored
Properly guard array key access for "sheetTitle" in `\TYPO3\CMS\Backend\Form\Container\FlexFormTabsContainer->render()`. Resolves: #98201 Releases: main, 11.5 Change-Id: Iafa5fd4623d53501e655739d7aabc543d26ed216 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75500 Tested-by:
-
Oliver Bartsch authored
InlineControlContainer allows to add custom controls via a userFunc (hook). However, since the resultArray was not passed to the userFunc, e.g. no JS module could be added for the custom control. This is now fixed by passing the resultArray by reference to the userFunc. Resolves: #98199 Releases: main, 11.5 Change-Id: I404d2673a65bb40cf7f389fb5c0f7bec7dcd7c4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75499 Tested-by:
-
Tobias Jungmann authored
If a preview page is already open, clicking on the "view" button in the content editor window would not reload the page. That means, that the preview page would not show changes if the preview page url and the target url are similar (e.g. only differentiate in hash/query or are exactly the same). This patch looks if a window with the given windowName is already open (looking in `this.windows` did not work well because the existing windows aren't saved in a global context, yet) and compares the URL of an open window (if there's one) with the given URL. If the URLs are similiar (i.e. the origin and the path name are the same) the page will be reloaded. Resolves: #93706 Releases: main, 11.5 Change-Id: Ib3d9e49f56e6ef45df1cd7d82fa58dffb74a3750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75492 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Stefan Bürk authored
With #95819 the detection of Domain Object properties was changed to use ClassSchema in order to support uninitialized properties is models. This was not possible with `DomainObjectInterface::_getProperties()` which used `get_object_vars()` under the hood. However, with mentioned change, other properties which had been ignored by `get_object_vars()` were now propagated to persistence, even if those properties were not configured in TCA. The change in behavior is considered a regression and is now addressed: The retrieval of the property value is delayed until after it is ensured that the property is a persistable property (which asserts that we are not reading from private properties). Resolves: #98148 Related: #95819 Releases: main, 11.5 Change-Id: I94d41715a49953045d32361a00bc274c15112a1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75541 Tested-by:
-
- Aug 22, 2022
-
-
Kevin Appelt authored
The check if the image has to be processed has been moved to dedicated methods to enhance readability and testability The condition still checks if the image is wider than the defined maximum width. The check if the entire image is used should now be easier to understand. No offset and 100% of the width and height of the image correspond to the full image and negated in its entirety. Resolves: #98118 Releases: main, 11.5 Change-Id: I8283e2f74310654455fb247e84c9e4204f3e1dd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75531 Tested-by:
-
Oliver Hader authored
Avoid undefined array key warning in case 'config' is not given in TypoScript settings. Resolves: #98145 Releases: main, 11.5 Change-Id: I20df94bd34f9f7197eee7905f5aa1c2af35d0601 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75530 Tested-by:
-
- Aug 21, 2022
-
-
Peter Kraume authored
Resolves: #98183 Releases: main, 11.5 Change-Id: Ib4d123e86a9b158b86e20322fc53ca94ff5b9be7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75528 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Aug 19, 2022
-
-
Chris Müller authored
If either labels or base are not given, the default values kick in: labels = iec and base = 1024 With the new fallback values in place test ContentObjectRendererTest notAllStdWrapProcessorsAreCallableWithEmptyConfiguration() needs a minor adaption. Resolves: #98154 Releases: main, 11.5 Change-Id: Ib2a242454197be94a75fb3d5bffbb8d0be8a1523 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75519 Tested-by:
-
Torben Hansen authored
This patch fixes a warning on PHP 8.1, when a FlexForm has a sheet with no fields in it. Resolves: #98166 Releases: main, 11.5 Change-Id: Iec814a10bb755fb78a8de95b432d8cb6042a07d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75518 Tested-by:
-
Andreas Fernandez authored
The configuration definition of `content` in the Modal API is extended to accept objects of types `Element` and `DocumentFragment` as well, which allows passing arbitrary DOM nodes to the API, if TypeScript is used. Since jQuery is still the main actor in the Modal API, no further adjustments are required for now as jQuery can consume the added types. In the same run, the API definition got stricter as `Modal.advanced()` allowed to pass any arbitrary configuration not covered by the internal `Configuration` interface. Resolves: #98164 Releases: main, 11.5 Change-Id: Ibf7cc836fcffa870a1eb4c5d4615c44e046cf192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75515 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Aug 17, 2022
-
-
Torben Hansen authored
Since ext:felogin already uses strict type declarations for function arguments and return types, various parameter- and return-type declarations in PHPDoc comments can safely be removed. With this patch the following changes are applied: * removed superfluous @param type declarations * removed superfluous @return declarations * removed non-thrown @throws annotations * added missing function type declarations in tests Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98139 Releases: main, 11.5 Change-Id: I47749a748e808f6801928951397ed0bff8d6a115 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75446 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Tomasz Woldański authored
Patch fixes warning on PHP 8.1 in AbstractItemProvider Resolves: #98151 Releases: main, 11.5 Change-Id: Ic74ec7771be077aa5e6a84e8db3310fc895dcc02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75498 Tested-by:
-
Tomasz Woldański authored
Patch fixes warning on PHP 8.1 in extbase Backend class. Resolves: #98149 Releases: main, 11.5 Change-Id: I6f32f67672332758cc02708d07481b93edb09b82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75497 Tested-by:
-
Tomasz Woldański authored
Patch fixes warning on PHP 8.1 in MenuProcessor Resolves: #98150 Releases: main, 11.5 Change-Id: I9cee1d6d0adcde22a74e040ac53657db3348c514 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75496 Tested-by:
-
Torben Hansen authored
When a FlexForm has an empty data structure, a warning is thrown in PHP8, because it is not checked in FlexFormNoTabsContainer if the resolved sheet name actually exists as key in the flexFormRowData array. This patch uses the null coalescing operator to fix the problem. Resolves: #98147 Releases: main, 11.5 Change-Id: Ie4bde3af79a9a473cc02aff9f1ec299fff1bc259 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75495 Tested-by:
-
Christian Kuhn authored
Workspace backend module: With #94935 the "Entire workspace" mass drop down has been placed more prominently by moving it to the first position in the action drop down row. The "Entire workspace" action publishes *all* pending workspace changes of *all* pages at once. Depending on use case, this can be dangerous: There are cases where a workspace is used to prepare a small amount of changes, to then publish everything at once. This is fine. There are also use cases where editors use one big workspace to prepare distinct changes in multiple pages and then publish single pages only. In the latter case, accidently using the "Publish absolutely everything" drop down will publish lots of unwanted changes. To mitigate this risk, admins get a new toggle in the workspace 'publish_access' field of workspace records to hide the "Entire workspace" action drop down of this workspace when checked. Resolves: #98155 Related: #94935 Related: #96468 Releases: main, 11.5 Change-Id: Ia55bf509df17842ad1f6c5fdea031fb633419f08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75479 Tested-by:
-
- Aug 16, 2022
-
-
Benni Mack authored
Backend modules which use absolute paths (which do not exist) should not raise an exception / error when using versionNumberInFilename checks. This happens e.g. with EXT:solr backend modules since #97939 was fixed. In the long-term extensions should define proper paths, so they also work in TYPO3 installations within a subfolder but for the time being, this change helps to solve the problem. Resolves: #98152 Related: #98106 Related: #97939 Releases: main, 11.5, 10.4 Change-Id: I071f2e63d4423d157f0f060a1295cb145474ee9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75493 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 15, 2022
-
-
Elias Häußler authored
With #93887 (respectively #92406), a more convenient rendering mechanism for forms was introduced. A new FormRequestHandler centralized all the logic from the <formvh:render> view helper to allow smoother form handling. However, the new implementation used to hide the current ContentObjectRenderer implementation and instead always fetched a new instance with GeneralUtility::makeInstance(). This no longer allows to determine the current content object rendering context from e.g. form finishers. Since the current implementation can be retrieved by the ConfigurationManager, it is now used in the <formvh:render> view helper, falling back to a new ContentObjectRenderer instance in case the ConfigurationManager does not actually provide an instance of ContentObjectRenderer. Resolves: #97977 Related: #93887 Related: #92406 Releases: main, 11.5 Change-Id: Iabf4e93e6aff8da742321958730521ef1696f130 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75447 Tested-by:
-
Nikita Hovratov authored
With #88276 a new condition has been implemented to check for current selected pageLayout in FE and BE, example: [tree.pagelayout == "pagets__simple"] This has various bugs. Frontend: * The evaluation stops at the sys_template record that has 'root' flag set. This is not in-line with the backend condition implementation, which goes further up in rootline. * The evaluation does not look for first specified layout up in rootline, but goes from root down to selected page. The condition thus calculates wrong layout when different 'backend_layout_next_level' are nested on rootline pages, it picks the uppermost set, not the lowermost one. This is fixed by using TSFE->rootLine instead of tmpl->rootLine, since TSFE->rootLine provides the full rootline in correct order. Backend: * Similar to FE, the evaluation should go up in rootline, but is processed downwards instead. This is fixed by handing over the 'reversed' full rootline. The v12 version of the patch is slightly different: Patch for issue #97963 introduced yet another bug by accessing TSFE->config['rootLine'], which isn't set at all at this point in the frontend processing chain when the page is not yet cached, or has no USER_INT or COA_INT. Resolves: #98044 Related: #88276 Related: #97963 Releases: main, 11.5 Change-Id: I1dc9a4dfc6aea6bec4d8e2eb65a6919d486f4a99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75444 Tested-by:
-
- Aug 13, 2022
-
-
Georg Ringer authored
Providing the exception message helps to understand and solve the issue as the exception can also be thrown by a 3rd party extension. Resolves: #97770 Releases: main, 11.5 Change-Id: I53ff25a141c3d3b522d5eabd270309dbdda7709f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75434 Tested-by:
theline <typo3@root-access.de> Reviewed-by:
-
Nikita Hovratov authored
The former approach in #91808 to fix scoped toggling didn't work with levelLinksPosition "bottom", as the querySelector could find another control container inside another child inline field first. Another solution, which is now possible, works with the ":scope" selector. Only nodes with a direct parent will be found this way. In addition, a new helper class is added for the top control container, as it is wrapped in another div. This enables toggling of both buttons, in case levelLinksPosition "both" is set. Resolves: #97786 Related: #91808 Related: #92382 Releases: main, 11.5 Change-Id: I67146c372d183cd647db847b3e3d83d986585577 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75435 Tested-by:
-
- Aug 12, 2022
-
-
Michael Hitzler authored
The YouTube helper tries to fetch from highest to lowest image for possible previews. The "sd" and "hq" versions were missing while checking for an available image and got added. Resolves: #98098 Releases: main, 11.5 Change-Id: Idec13fdc5c820e6674f8ccebd610455b50d57895 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75456 Tested-by:
-
Helmut Hummel authored
When using the custom element <typo3-backend-icon> with a JS framework, that renders the DOM (e.g. Vue), it can happen, that they set the properties of the custom element instead of an attribute. Since Lit does not reflect these properties to attributes by default, but the icon-element relies on CSS set on the host element that depends on the size attribute, the icon is not rendered in the correct size. See: https://web.dev/custom-elements-best-practices/ on why reflecting properties to attributes might be a good idea in some cases. Releases: main, 11.5 Resolves: #98121 Change-Id: I8435946ad6e6d92b8ec50dd7e289279261d43d5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75415 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Daniel authored
If a sys_file record is directly deleted from database, some undefined array index warnings are triggered if the file is assigned to another database record. Releases: main, 11.5 Resolves: #97987 Change-Id: I2ce115024e637cffacc512528e79b1bb4059f173 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75455 Tested-by:
-
Christian Kuhn authored
This reverts commit b2bb5994. Reason for revert: The commit-msg hook now tends to throw away the message. Fully loosing a commit message is worse than a funny exit code. We revert for now and eventually come up with a different solution later. Change-Id: Ifae1f2658a95c09591fdc5a857084064090a5f82 Reverts: #98094 Resolves: #98094 Releases: main, 11.5, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75454 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Benjamin Kott authored
While trying to restore the full desktop functionality aka mouse and keyboard behavior on a touch-device we came to the conclusion that it feels unintuitive. On touch devices, you have by design fewer input options and differentiators than with dedicated input devices like a mouse. It feels best to disable the drag and drop behavior and enable a smooth scrolling and navigation experience. Resolves: #91755 Resolves: #86946 Resolves: #93960 Releases: main, 11.5, 10.4 Change-Id: Ic08d06283cbb2331ff49983bd7d18b446f8bd76a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75430 Tested-by:
-
Oliver Bartsch authored
The StandardContentPreviewRenderer still contained special handling for the tt_content.select_key field, which however was already removed in #77934. The leftover is now removed together with related locallang labels. Resolves: #98125 Related: #77934 Releases: main, 11.5 Change-Id: I38ae07a4eced0cbd3f5ed3076661b70081252321 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75428 Tested-by:
-
Tomasz Woldański authored
Patch extracts generating url for workspaces in order to better integrate with external extensions, so when external extension want to replace url, extension does not have to override whole handleRequest method. Resolves: #98112 Releases: main, 11.5 Change-Id: I8c8e18fbe7dfecd2ccd400681588d984ac233178 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75367 Tested-by:
-
- Aug 11, 2022
-
-
Česlav Przywara authored
Releases: main, 11.5 Resolves: #98115 Related: #92118 Change-Id: Ibcd5fa26155dbb36216422e1c806c9a4035d878f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75371 Tested-by:
-
Benni Mack authored
Due to a regression in TYPO3 v11.5.11, using typolink.parameter with stdWrap might also return more than just the URL. This change reverts this behavior by overlaying the decoded typolink string with the original decoded typolink string. Resolves: #97869 Related: #90404 Related: #80896 Releases: main, 11.5 Change-Id: I22010983886a8da8a339aa6376d36303f3b729b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75366 Tested-by:
-
Stefan Bürk authored
With #97989 correct workspace overlays in DataMapProcessor should be used to fix a bug. This introduced a failing default "where" if a child table is not workspace aware. The fix itself is straight forward: Query t3ver_wsid field only if the target table is workspace aware. In contrast to the TYPO3 v12 (main) version, the v11 backport delivers just the code change, since functional test structures have been modernized a lot in v12 already. Resolves: #98103 Related: #97989 Releases: main, 11.5 Change-Id: Id8cb51623b206b5effd57823a28099ce7d545b7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75418 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
- Aug 10, 2022
-
-
Benni Mack authored
With the fix of using versioned numbered filenames for the TYPO3 Backend, a use-case "absolutely referenced, but relative to public path file" did break for Frontend inclusions of CSS or JS files. This is now overcome by only using the original bugfix in the TYPO3 Backend. Resolves: #98106 Related: #97939 Releases: main, 11.5, 10.4 Change-Id: Iff6251bd95e1c0a93a6f5538b9f560e55ba80b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75368 Tested-by:
-
