- May 24, 2019
-
-
Benni Mack authored
The TypoScript option config.defaultGetVars is not evaluated anymore, as this conflicts with TypoScript logic itself: After TypoScript parsing and condition evaluation in a Frontend Request, config.defaultGetVars is set, this would effectively mean that TypoScript parsing should be re-done in order to meet new possible matches in Conditions. As this logic is flawed and should now easily be handled via a custom middleware (previously this was helpful for setting e.g. L=0 for default pages with RealURL), it is now removed from Core. Resolves: #88419 Releases: master Change-Id: Ic286c96f71953062d7649d71abb72f8f0f20f1a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60799 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Andreas Fernandez authored
The file `jsfunc.evalfield.js` responsible for form value evaluation and validation has been removed. This job is now done by `TYPO3/CMS/Backend/FormEngineValidation` since TYPO3 7.4. Resolves: #88427 Releases: master Change-Id: Ib366ccbc5795b9c428743f52098c0a6fbca47735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60792 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
This patch refactors the IRRE handling on client side, the JavaScript land has been rewritten to have a better structure and do less repeating on-the-fly calculations. Each IRRE container is represented by a independent instance of InlineControlContainer. Most of the internally used `scriptCall` directives have been removed. Currently, `scriptCall` can't get removed completely, as further refactorings in different areas are required. All of the "external" communication via `inline.foobar()` has been replaced by a event-driven approach. This also affects ElementBrowser windows, those use a minimalistic API based on postMessage. Some code that was never evaluated in ElementBrowser is considered dead and has been removed regarding inserting multiple items. A new sorting library has been added in order to replace jqueryui piece by piece. Executed command: yarn add --dev sortablejs On PHP side, some code has been removed as well since the rewritten client code is event-based and doesn't depend on external calls anymore. Resolves: #88182 Releases: master Change-Id: I4176483d2882cef49fbaddb5e2e1914c1f76c908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59324 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Stefan Frömken authored
Releases: master Resolves: #88409 Change-Id: Iff722b6b6f4206e4912fd2d2f7bc8e55d860133f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60788 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Frank Naegler authored
This commit also removes superfluous code and streamlines the search template. Resolves: #88333 Releases: master Change-Id: Id6761796dd8e774497223fe7de6f811b4610e245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60730 Tested-by:
-
GeraSchneider authored
The documentation had no information where to create custom workspaces in the backend. That information has been added. Releases: master, 9.5 Resolves: #88378 Change-Id: I8bd6d7ad2ac291e3576b89d39f9698ce16a5572c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60772 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Frank Naegler authored
Resolves: #88345 Releases: master Change-Id: I1da8e97558b0a4697db8aae6b1a098e2628fa519 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60315 Tested-by:
-
Andreas Fernandez authored
This patch removes the TBE_EDITOR.typo3form object, which is unused for a long time now. This "API" was used to either get or set values of form fields in a very old iteration of the FormEngine. Resolves: #88411 Releases: master Change-Id: If7d6e1d13c89944383d06c42d63f2f3a3b40d999 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60791 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- May 22, 2019
-
-
Benni Mack authored
Having Site Handling in place, the option "useCacheHash" rendered useless as it is added by TYPO3 Core automatically when necessary with SiteHandling. Any Fluid Arguments haven't been deprecated as this was part of the the legacy functionality. Now the options are still available, but trigger a deprecation message that the option is superfluous and should be removed. Calling typolink.useCacheHash will now trigger a deprecation message. Resolves: #88406 Releases: master Change-Id: I2243a335188c3466b8f8f59e8d3e417f13bf854d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60774 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Georg Ringer authored
The argument `showLabel` must be used while creating a button. Resolves: #88408 Releases: master, 9.5 Change-Id: I5bfcc25d03aac9da6ca11b651658749bf25d7bf1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60789 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- May 21, 2019
-
-
Anja Leichsenring authored
assertNotNull takes only one parameter, but due to a left over from former refactoring, it got two, and the first one was a static string. So the test actually did not test what it was supposed to test. Resolves: #88387 Relates: #87764 Releases: master Change-Id: Ib39d4eb623f7b079a5a4a6159ffc7520ac70642b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60778 Tested-by:
-
Frank Naegler authored
The following methods changed from protected to private: ConditionMatcher->determinePageId() ConditionMatcher->getPageIdByRecord() Resolves: #88407 Related: #87193 Releases: master Change-Id: Iea9789aeb7f74ed3dad55ee81245b7ebb5806fde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60786 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
With the introduction of site handling, the old "pageNotFound_handling" mechanisms can be removed. If a site configuration hasn't configured a error handler, a 404/403/500 response with the default error renderer is now returned. Making PageNotFoundExceptions rendering the frontend very seldom. The following options are removed: - $TYPO3_CONF_VARS[FE][pageNotFound_handling] - $TYPO3_CONF_VARS[FE][pageNotFound_handling_statheader] - $TYPO3_CONF_VARS[FE][pageNotFound_handling_accessdeniedheader] - $TYPO3_CONF_VARS[FE][pageUnavailable_handling] - $TYPO3_CONF_VARS[FE][pageUnavailable_handling_statheader] Tests have been adopted to check against status code / message rather than on the exceptions (not) thrown (anymore). In addition, a JsonResponse is now returned if JSON was requested, instead of the regular HTML content. Resolves: #88376 Releases: master Change-Id: I6be57fadaa0ddf83039fbdcc9186ef93d5a51158 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60453 Tested-by:
-
- May 20, 2019
-
-
Anja Leichsenring authored
commands: composer update typo3/testing-framework composer require --dev codeception/codeception:^3 composer update codeception/codeception --with-dependencies Leads to: typo3/testing-framework 5.0.9 codeception/codeception: 3.0.0 phpunit/phpunit: 8.1.5 Resolves: #88388 Releases: master, 9.5 Change-Id: Ic394bdf21025705534a6f7b74ca78e155dba6a39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60779 Tested-by:
-
Benni Mack authored
A few places still use t3ver_state instead of the available constants in VersionState. To increase the semantics of the used code, the constants are used instead. Resolves: #88395 Releases: master, 9.5 Change-Id: I3c2927c2d4c8814d581f06f84de8f4c85d6226a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60780 Tested-by:
-
- May 16, 2019
-
-
Benni Mack authored
Due to some heavy history on the caching framework, all Database caches start with "cf_cache_", which is optimized so they are only called e.g. "cache_pagesection" in the database tables. In addition, the prefix "cache_" (in e.g. "cache_core") is unnecessary, and also there due to legacy reasons, reading $this->getCache('cache_runtime') seems very illogical. The following caches have been renamed: - cache_core => core - cache_hash => hash - cache_pages => pages - cache_pagesection => pagesection - cache_runtime => runtime - cache_rootline => rootline - cache_imagesizes => imagesizes Old identifiers can still be called within PHP, but the caching framework throws a deprecation message on setting up such a cache. A silent upgrade wizard will update one's LocalConfiguration to use the new naming scheme. The result is a cleaner, more readable and more streamlined code base (we have caches like "extbase" or "assets" where there is no prefix) and database structure. The patch is breaking due to the change in the database tables. Resolves: #88366 Releases: master Change-Id: I13dcdb0d1bf78f0899615e850856de081b715358 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59661 Tested-by:
-
- May 15, 2019
-
-
Benni Mack authored
This change removes the compatibility layer of Site Handling, called "PseudoSite" handling. Any TypoScript-related Language properties are removed. - config.sys_language_uid - config.sys_language_mode - config.sys_language_overlay - config.locale_all - config.language - config.typolinkEnableLinksAcrossDomains - typolink.useCacheHash The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tstemplate.php']['linkData-PostProc'] is removed. In addition, all tests related to PseudoSite and linking without SiteHandling are removed, linking to pages without a site will not be linked anymore. Adding `useCacheHash` to typolink triggers a "this does not do anything anymore" deprecation message. Further related removals (old "pageNotFound" handling and "useCacheHash" in all viewhelpers), are removed separately. Resolves: #88363 Releases: master Change-Id: I14f2f854e69c98df7fab8b14f92f1ec2440a15a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59366 Tested-by:
-
Nicole Cordes authored
This patch provides the current set database value in a hidden field as early as the whole select tree JavaScript is provided. This prevents data loss if the current record is saved before the select tree was loaded. Resolves: #86954 Releases: master, 9.5, 8.7 Change-Id: I467b2a52d34b806713cd201a8a2a4f9bb8e92c71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60415 Tested-by:
-
Benni Mack authored
The database field "t3ver_id" which is managed by TYPO3 to store the number of the version for a specific version is not in use anymore, as this was related to the non-workspace managed versioning concept. This linear versioning concept was removed, so the database field is not needed anymore. It is recommended for all extensions with TYPO3 v10.0+ compat only to remove this field. Resolves: #88143 Releases: master Change-Id: I283e8e2ba2d755dcc8b2054e2439f9fef5462511 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60459 Tested-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Oliver Hader authored
https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.2 * #34: Normalize resolved Windows path to Unix-style * #42: Avoid analysing non-phar files on alias resolving * #40: Add Windows tests using AppVeyor * #33: Add alternative mime-type resolving (without ext-fileinfo) composer require typo3/phar-stream-wrapper:^3.1.2 Resolves: #88354 Releases: master, 9.5, 8.7 Change-Id: I4560881006a6f9c48761161f0b96b78f02c0659d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60754 Tested-by:
-
Benni Mack authored
All functional tests that run a frontend subrequest should be tested against Site Handling, as the PseudoSite Handling is about to removed. This patch is actually a precursor to make sure that all tests work with site handling now. The AbstractDataHandlerActionTestCase adds e site configuration on each setUp(). This way, all DataHandler-related tests are running with a Site configuration of three languages. In addition, when "localizing" something, a translated page needs to exist, so most DataHandler related changes add this functionality. For some DataHandler tests, the SiteConfiguration is adapted to define the previous behavior built in TypoScript. One addition in PageResolver is made: If an GET / POST &id query parameter is given, and it is not accessible, it will fail now. Resolves: #88357 Releases: master Change-Id: I3dafec3382d8c6797f32b3acde2763dacd13e0f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60757 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Daniel Dorndorf authored
A wrong evaluation of the null coalesce assignment (?? is evaluted and && later-on), the if() condition was always true for any previews of records with versioning enabled. The Backend API is used instead. Resolves: #88356 Releases: master, 9.5 Change-Id: I89ba14bd99bbeb17637b64d99a8d6de265a6e7c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60758 Tested-by:
-
Oliver Hader authored
Given that e.g. public/typo3conf/ext/my_extension is symlinked to packages/my_extension, PharStreamWrapper denies invocation since realpath is resolved. For the specific PharStreamWrapperInterceptor it is okay to avoid realpath resolving. Resolves: #88340 Releases: master, 9.5, 8.7 Change-Id: I46b7100547dd0e40d1d4d76a71047ef977d8ce63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60739 Tested-by:
tomalo.stuttgart <loeffler@spooner-web.de> Tested-by:
Rudy Gnodde <rgn@windinternet.nl> Reviewed-by:
Kevin Meckl <kevin.meckl@zdrei.com> Reviewed-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Anja Leichsenring authored
Resolves: #88335 Releases: master, 9.5 Change-Id: I40569702c9cec50aa9150c666488c7a71c28b47b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60732 Tested-by:
-
- May 13, 2019
-
-
Susanne Moog authored
Resolves: #88334 Releases: master, 9.5 Change-Id: I380c0aa3dd63ab6d1a8587138e0ff33df6941ca4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60731 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Reviewed-by:
-
Frank Naegler authored
Resolves: #86804 Releases: master, 9.5, 8.7 Change-Id: I81332dd5d5ede768f4ca90bac9d4d3a611f91d2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60736 Tested-by:
-
Benjamin Franzke authored
When NormalizedParams was introduced, the code that was refactored from GeneralUtility:getIndpEnv did not take into account that PATH_INFO could be set, but be empty. (which happens with the Debian 9 NGINX default configuration which uses `fastcgi_split_path_info` and set's `fastcgi_param PATH_INFO` even if it's empty). Now, the fallback to PATH_INFO has been introduced with the initial revision of TYPO3 and isn't needed at all nowadays, it's actually wrong, as a REQUEST_URI to /index.php/foo/bar would incorrectly be interpreted as $scriptName == "/foo/bar". This patch additionally replaces PATH_INFO with SCRIPT_NAME in test cases where this variable is actually wrong (we assume test cases have been modeled to match (old) code, instead of reality here): * ProxyPass does not result in PATH_INFO being set, it's SCRIPT_NAME here. * PATH_INFO is not set for regular request to /typo3/index.php Resolves: #88304 Releases: master, 9.5 Change-Id: I501ad3bc10b0988385906a1fe9cb668c5e3696b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60719 Tested-by:
Benny Schimmer <b.schimmer@saint-elmos.com> Tested-by:
-
- May 12, 2019
-
-
Dennis Grün authored
Resolves: #88315 Releases: master, 9.5 Change-Id: I76f75986b39ff15bd2d57ab94ec290a509381275 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60726 Reviewed-by:
Daniel Haupt <dh@schiffel.it> Reviewed-by:
-
- May 10, 2019
-
-
Frank Naegler authored
Resolves: #87924 Releases: master Change-Id: I50332d97fbbfa9b04f1a2d8de761aabe84b3c367 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60260 Tested-by:
-
Guido Schmechel authored
Set the correct status value for the JsonResponse returned in case no database is selected. Additionally, a typo in the key `success` itself is fixed. Resolves: #88066 Releases: master, 9.5 Change-Id: I3153f6cabc878b270fe48983cbdedb8ed918d566 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60466 Reviewed-by:
-
Sybille Peters authored
Resolves: #87647 Releases: master Change-Id: I4f2a9db50481c12f84682ebe0147b962c8d8438d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60345 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Andreas Fernandez authored
With #87324 parts of the FormEngine have been split into smaller, maintainable parts. However, `SelectCheckboxElement` brings it's own "Revert selection" implementation that has nothing in common with the "Reset selection" field control used for select boxes. The code is now rewritten to handle the revert on its own. Additionally, another inline `onclick` handler was removed. Resolves: #88314 Related: #87324 Releases: master Change-Id: Ifca1b67a960a8caab8145f2a7d5c8301918819fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60728 Tested-by:
-
Andreas Fernandez authored
This patch aims to reduce the size of the .editorconfig file used by IDEs to get rid of duplicated configuration (indent_style), obsolete configuration (bower.json) and merge related configuration (scss, css). Resolves: #88271 Releases: master Change-Id: I5a34536858b0cea5e4eb5a1f9fc7ca566aa144e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60653 Tested-by:
-
Andreas Fernandez authored
Resolves: #88226 Related: #88040 Releases: master Change-Id: Ie8726b689362119a3d4d087582b3be2cb2b86e4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60572 Tested-by:
-
- May 08, 2019
-
-
Benni Mack authored
On old OS with ICU < 4.6, the constant INTL_IDNA_VARIANT_UTS46 is not available, even if php-intl is installed. Therefore, a wrapper is created in HttpUtility to check if the constant is available, then uses INTL_IDNA_VARIANT_UTS46 otherwise the 2003 version of the HttpUtility. Also see the section about INTL_IDNA_VARIANT_UTS46 within https://www.php.net/manual/en/intl.constants.php Resolves: #87953 Releases: master, 9.5 Change-Id: I594c0ffd9afa115de595b0c027bf2474c3abfafb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60710 Reviewed-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
Timo Poppinga <timo.poppinga@zdrei.com> Reviewed-by:
-
- May 07, 2019
-
-
Oliver Hader authored
In order to enclose and avoid type guessing done by ImageMagick based on mime-type and internal file content checks, new value object class ImageMagickFile has been introduced as guard for those invocations. Resolves: #87588 Releases: master, 9.5, 8.7 Security-Commit: d4f18684b2b2078b51cc7e93abdb251ea846984a Security-Bulletin: TYPO3-CORE-SA-2019-012 Change-Id: I9a2dd74e8548530d7bc83bd18af2f4f0a8212019 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60705 Tested-by:
-
Frank Naegler authored
On DataHandler update or when updating a users password via EXT:felogin, all existing sessions are destroyed except for the current session. Resolves: #87298 Releases: master, 9.5, 8.7 Security-Commit: df7c0dbcf73be20e5ae9d4cf03b82c8326c9fccc Security-Bulletin: TYPO3-CORE-SA-2019-011 Change-Id: Iff673d2ab774dde0f116c4bc9040d40374492a7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60704 Tested-by:
-
Helmut Hummel authored
In order to avoid logging sensitive information during authentication using the logging framework, according log level DEBUG is used. Resolves: #88230 Releases: master, 9.5 Security-Commit: 625428b6364308f9f07f331bd176110d01e6c2f2 Security-Bulletin: TYPO3-CORE-SA-2019-010 Change-Id: I3e19afad6937515e0f6e1ab0a1c6d7004d182b79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60703 Tested-by:
-
Oliver Hader authored
Due to a pass-by-reference error pages a user does not have access to were still visible in the page tree. Resolves: #87676 Releases: master, 9.5 Security-Commit: 5d2c69c00554ec64ea020ec803f593ae772fa367 Security-Bulletin: TYPO3-CORE-SA-2019-009 Change-Id: Ic8ba91b596e1589860bc28b746e551ac6bc47588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60701 Tested-by:
-
Benni Mack authored
Due to some encoding issue, documentation of the new feature for slug TCA hooks is broken. The patch adapts the RST file. Resolves: #88289 Related: #88198 Releases: master, 9.5 Change-Id: I8e9027aba14678d678751246380833fce8a0e07b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60694 Tested-by:
-
