- Oct 10, 2022
-
-
Mario Lubenka authored
DebuggerUtility::var_dump() is commonly used to debug PHP classes. We recommend hardening PHP classes by using typed properties in PHP classes. Previously uninitialized properties resulted in a PHP exception when passing the class instance into DebuggerUtility::var_dump. Uninitialized properties will not be processed by DebuggerUtility::var_dump anymore. Instead a label "uninitialized" indicates that it has not been initialized at the time of debugging. Resolves: #98519 Releases: main, 11.5 Change-Id: Ifbb9fd4d0de2e6214ab4b876b04302b2adaf6d2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75981 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Stefan Bürk authored
PostgresSQL is picky if aggregation functions like `order by`, `group by` and similar are used, but missing the corresponding columns in the "SELECT" column listing. ext:redirects backend module builds query using the QueryBuilder based on the demand dto object, which so far is a good practice. To get the total count of records based on selection and properly building the pagination it uses the same technique but executing a simple count query, which leads to the aggregation error using PostgresSQL dbms due the containing `order by` sortings. This changes simply omits the orderBy part of the build query to avoid this error and still counting on a correct full dataset. Resolves: #98534 Releases: main, 11.5 Change-Id: I09e5f88d9d4f7c0aa578f8e1503cd1b17bc2c5dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76037 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Fernandez authored
The library `imagesloaded` is only used in the image cropper to initialize the cropper functionality once the image is loaded. This can be achieved with native browser API, `imagesloaded` is therefor not needed anymore and thus removed. See https://caniuse.com/mdn-api_htmlimageelement_complete for compatibility. Executed command: npm remove --save imagesloaded @types/imagesloaded Resolves: #98548 Releases: main Change-Id: I154ef22b41febb3788599e8220dd55f6989c3048 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76001 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- Oct 09, 2022
-
-
Anja Leichsenring authored
Resolves: #98558 Releases: main, 11.5 Change-Id: Ic7bfd4812e49481f51603826a729423951275dbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76032 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Stefan Bürk authored
This change properly removes registered exception handlers in tests to avoid side effects. Thus acting as pre-patch to tighten unit tests with auto dangling error- and exception handler detection through the testing-framework BaseTestCase. Resolves: #98554 Releases: main, 11.5 Change-Id: I8efb23a84d380dff1643ce61c87e59a7550a72e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76009 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Oct 08, 2022
-
-
Stefan Bürk authored
This change ensures that unit tests has a valid `setUp()` parent call chain down to the testing-framework base class and acts as a pre-patch to introduce tightend safe-guard checks on testing-framework level afterwards. Resolves: #98553 Releases: main, 11.5 Change-Id: I6ea1ddf5c979b6565b9dbfcb86776f224531fcdd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76007 Tested-by:
-
Stefan Bürk authored
With the introduction of CSRF-like request tokens in #97305 a 3rd party dependency has been added with a PHP8.2 deprecation. To mitigate this, a workaround has been added to set and reset the error level in the implementation in JwtTrait. However, if the called methods throw exception on invalid tokens the reset has been left out, leaving the `error_reporting` in a changed state and thus changing the system. This can be verified using: > Build/Scripts/runTests.sh -s unitRandom -p 8.2 -o 1665191152 This change wraps the method calls in try-catch blocks and ensure the error_reporting is properly reset before re-throw the exception to keep the exception handling workflow intact. Resolves: #98551 Releases: main Change-Id: I692188ee9be2583bdf26f39b646784580cd783e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76006 Tested-by:
-
Stefan Bürk authored
Use guard to avoid undefined array key acces in core viewhelper `\TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper`. Resolves: #98509 Releases: main, 11.5 Change-Id: Ief8594f08c0ab13b477491f89b93060998107e80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76004 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Oct 07, 2022
-
-
Christian Kuhn authored
Hook call runThroughTemplatesPostProcessing related to the old TypoScript parser is now removed in the new TypoScript parser: This hook has been marked as breaking in 12.0 already and was only kept for b/w compat in typo3/testing-framework, which has been adapted meanwhile. The substitution event AfterTemplatesHaveBeenDeterminedEvent is slightly changed to provide the full Request to listeners instead of just the Site object. > composer u typo3/testing-framework Change-Id: I0b46aa50c576782f6853f91105478cd66d0ddcc3 Resolves: #98550 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75995 Tested-by:
-
Jan Stockfisch authored
Introduce tag attributes for the following TypoScript configurations: * page.includeCSS * page.includeCSSLibs * page.includeJS * page.includeJSFooter * page.includeJSLibs * page.includeJSFooterlibs The syntax can then be * page.includeCSS.my-attribute = my-value Resolves: #91499 Releases: main Change-Id: Icadaa53d379eb5417ea995dff7b5a2b8ade4ec9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65008 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
TYPO3 core required the package `tagsort` since at least version 8 but it seems to be unused since then. The library is therefore removed. Executed command: npm remove --save tagsort Resolves: #98546 Releases: main Change-Id: If74d7dee9c0faeb505daefddd49fce1f3572763f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76000 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Oct 06, 2022
-
-
Oliver Klee authored
This update finds new problems and gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.8 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98541 Releases: main, 11.5 Change-Id: Idff8e6f7f9baa700a79ec0e823aee14f0fb63efb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75998 Tested-by:
-
Chris Müller authored
Resolves: #98542 Related: #98535 Releases: main Change-Id: Iacda5665031458eca739aa7d42b364ff66d57631 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75999 Tested-by:
-
- Oct 05, 2022
-
-
Oliver Bartsch authored
With #98443, EXT:recordlist was moved into EXT:backend. The moved classes were added to the class alias map, however there is one special case for the RecordLinkHandler service. The service id (fully-qualified class name) is used as static string in custom linkHandler configurations. This is not automatically resolved by Symfony DI. This is now fixed by adding a corresponding alias to the service configuration. Resolves: #98535 Related: #98443 Releases: main Change-Id: I8bfa435153137fb4041eb8ab6938b9efd5a671c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75994 Tested-by:
-
Oliver Bartsch authored
Resolves: #98533 Releases: main Change-Id: Icf0718383c01b675ee9118aab07b61f21bd82cbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75993 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Andreas Fernandez authored
The button to change the orientation in the EXT:viewpage module now correctly "rotates" the preview again. Resolves: #98531 Related: #98430 Releases: main Change-Id: I060b0a658662b6c36ed8e3d992729bd1622a4a77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75990 Tested-by:
-
Benni Mack authored
This change moves the access of the link target for files / external URLs and pages into the actual AbstractTypolinkBuilder to increases readability and to avoid errors when using the method. Resolves: #98383 Releases: main Change-Id: I758cb92ede47bf99bed5a8d274daf08396c0e4b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75794 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Christian Kuhn authored
Also, nikic/php-parser is only a dependency of ext:install, ext:core does not use it, so we can remove it from ext:core/compser.json > composer req nikic/php-parser:^4.15.1 > composer req nikic/php-parser:^4.15.1 -d typo3/sysext/install --no-update > composer rem nikic/php-parser -d typo3/sysext/core --no-update Change-Id: If6a2e8351a7c45d7741dd8c93fd0b3d84e19d99f Resolves: #98532 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75992 Reviewed-by:
-
- Oct 04, 2022
-
-
Christian Kuhn authored
> composer req --dev codeception/codeception:^5.0.3 > composer req --dev codeception/module-webdriver:^3.1.3 > composer req --dev codeception/lib-asserts:^2.0.1 > composer req --dev composer/composer:^2.4.2 -w > composer req --dev php-webdriver/webdriver:^1.13.0 > composer req --dev composer/package-versions-deprecated:^1.11.99.5 > composer u symfony/stopwatch > composer u symfony/cache > composer u typo3/testing-framework Change-Id: Ia3df83005ff305049ec3f8c4bccd45db9d5ab49e Resolves: #98529 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75989 Tested-by:
-
Andreas Fernandez authored
This patch reimplements the drag&drop functionality in the page module with interactjs and thus removes the need of jQuery and jQuery UI, which is removed. Due to the fact the iframe is not scrollable, but the module body is scrollable, we need to intercept the position calculation at some places. Resolves: #98471 Releases: main Change-Id: I0ea04795e3e03cd35487ce828a6887b4cdaf181d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75887 Tested-by:
-
Oliver Hader authored
This change addresses several "undefined array key" issues that have been identified by PsalmPHP (see issue #98321). Resolves: #98411 Related: #98321 Releases: main, 11.5 Change-Id: Iec52d5b511c8c4af9fa97e3a5081a7a1ac1e5e3d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75843 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
This introduces a new PSR-14 event, enabling extension authors to modify the form data, used by FormEngine to generate the edit file form in the filelist module. TYPO3 internally makes use of this event to initialize t3editor with the suitable format options for the file to be edited. This functionality was previously done in a hook (#98494), which however did no longer work due to the removal of said hook in #97452. Effectively this means, the new Event is an improved replacement for the removed hook, since the Event now provides the whole form data array as well as the resolved FileInterface and the current PSR-7 Request. Resolves: #98521 Related: #98494 Related: #97452 Releases: main Change-Id: I5de9f8ea72fcb4296f6539449f991347cbef17b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75982 Tested-by:
-
Christian Kuhn authored
Using <em:be.trigger triggers="{triggers}" /> in the template seems to be obsolete since the controller never sets the triggers variable. This avoids a nasty cross-dependency from ext:backend to ext:extensionmanager. Change-Id: I0e7e452765c110b44696e3f234763f912aa9e5fc Resolves: #98527 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75988 Tested-by: -
Oliver Klee authored
This update finds new problems and gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.7 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98524 Releases: main, 11.5 Change-Id: Idbb8e62aac0b480eb0590e483968741f2b58916d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75983 Tested-by:
-
Christian Kuhn authored
Some minor php-cs-fixer modifications: * Move main config file to Build/php-cs-fixer * Adapt runTests.sh setup and helper scripts * Check Build/ directory, too * Simplify config a bit Change-Id: I74bea96791c9b74331030bd7c9c26d566ce6c90c Resolves: #98525 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75984 Tested-by:
-
Christian Kuhn authored
This avoids abandoned php-cs-fixer/diff. The raise brings a series of CGL changes. > composer req --dev friendsofphp/php-cs-fixer:^3.11.0 > Build/Scripts/runTests.sh -s cgl -p 8.1 Change-Id: I84704208cc891916e5354c0900dc4bac4e771380 Resolves: #98522 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75979 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Christian Kuhn authored
> composer req --dev phpunit/phpunit:^9.5.25 -w > composer u typo3/testing-framework > composer u typo3/cms-styleguide The testing-framework change slightly changes load order in functional tests, ext:impexp functional tests are sensible to this and need minor fixture updates. Change-Id: I4ab7ff9b5f45425d96fb810c69832113053b07ce Resolves: #98520 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75978 Tested-by:
-
linawolf authored
Releases: main Resolves: #98499 Change-Id: I39030ab03f82b34d96f5b39d5966068019c2cf22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75940 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Oliver Hader authored
Change-Id: I1feb236aeae9b3b7da1c50d5f65daf4fca4727bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75974 Tested-by:
-
Oliver Hader authored
Change-Id: I90d3ef8740698afac0327dff0591e4597b51e3e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75973 Tested-by:
-
Benjamin Kott authored
Adjust the whitespace of the bookmark edit form in the backend toolbar, to look more aligned to the other dropdowns. Resolves: #98514 Releases: main Change-Id: If25101e0ceb3568d086c38f5b4f193be90b58620 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75972 Tested-by:
-
- Oct 03, 2022
-
-
Benni Mack authored
A followup to #97452 where a hook was removed but TYPO3 Core still used it - the hook implementation is now removed. Resolves: #98494 Related: #97452 Releases: main Change-Id: I90265620d3488520ba37f9ecd5cf33be61e56102 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75933 Tested-by:
-
Oliver Hader authored
Several performance analysis showed that `AbstractUserAuthentication` takes a reasonable amount of processing time, even if a session ID are not given or invalid. In order to reduce database invocations for invalid sessions, user session cookies are sent as hash-signed JWT - which allows to check their validity without invoking storages. Required typo3/testing-framework preparation has been merged with https://github.com/TYPO3/testing-framework/pull/365 and updated. Custom implementations, handling cookies on their own, have to use the introduced method \TYPO3\CMS\Core\Session\UserSession::getJwt() instead of existing \TYPO3\CMS\Core\Session\UserSession::getIdentifier(). Resolves: #94243 Releases: main Change-Id: Icfdc17bf6d6d715a0cfab76517aaef96fd985f1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69337 Tested-by:
-
linawolf authored
- Add cross references for changelog files - Remove additional empty lines - Rename core -> Core - Rename composer -> Composer - Fix grammar: extensions' -> extension's - Indent lists with 4 spaces (including the asterisk character) - Indent code-blocks with 4 spaces (including the two dots) - Simplify code examples - Fix some typos and simplify sentences along the way Releases: main Resolves: #98498 Change-Id: I70f0b68ba9bcf69f6ac70d8aef95f70a0cb10923 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75938 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Benjamin Franzke authored
The RequireJS project has been discontinued [1] and was therefore replaced by native ECMAScript v6/v11 modules in TYPO3 with #96510. The infrastructure for configuration and loading of RequireJS modules is now deprecated and will be removed in TYPO3 v13. [1] https://github.com/requirejs/requirejs/issues/1816 Releases: main Resolves: #97057 Resolves: #97067 Related: #96510 Change-Id: I75a45cdb9a107f01ec2bb72bb9a73b1b0f158031 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75781 Tested-by:
-
Christian Kuhn authored
This switches from TemplateService to new TypoScript parser logic in TypoScriptFrontendController. The central methods getFromcache() and getConfigArray() were called in PrepareTypoScriptFrontendRendering after each other: getConfigArray() is now merged into getFromcache() directly. One main goal is to get rid of the 'pagesection' cache and leverage the new cache strategy of the new TypoScript parser: This cache strategy is more effective and allows caching TypoScript between different pages. We essentially get rid of the pagesection query load, but instead need the list of relevant sys_template rows early, which is done with a single query. This code is moved out of IncludeTree/TreeBuilder to new class IncludeTree/SysTemplateRepository, since the result is now needed to build page cache identifiers and thus must be exposed. An event is added as well, for extensions like ext:bolt to manipulate sys_template rows resolving. The old runThroughTemplatesPostProcessing hook is marked @internal now and will vanish during further v12 development when testing-framework has been changed to deal with it. The central getFromcache() is much better documented and should be far easier to understand now. Some parts of the code are currently a bit naive and there is quite a bit potential to further optimize parsetime especially in "full cached" scenarios. We also have the potential to make USER_INT parsing significantly quicker. Dedicated patches will follow with continued v12 development. The patch also sets a couple of properties to @internal, and marks the old TypoScriptParser and TemplateService @deprecated, even though it is currently still used for instance for TSconfig parsing, which will switch to the new parser soon as well. Resolves: #98503 Related: #97816 Releases: main Change-Id: I904e9add4a425479df4a6768a1d63a54d7b252d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75944 Tested-by:
-
Georg Ringer authored
Checking for a not existing value of a flexform sheet must not lead to a notice. Resolves: #98483 Releases: main, 11.5 Change-Id: I8ea7f6e8ecafcd14cc572e4c7207dc5e67300a18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75942 Tested-by:
-
Nikita Hovratov authored
Internal calls to this method have already been adjusted by previous patches. Another one has been found in acceptance tests, which is now fixed as well. Resolves: #98511 Related: #95913 Related: #97887 Releases: main Change-Id: Icf68ed4a05d761e0dcfff33dcb7670c80a934b37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75950 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Oliver Hader authored
Resolves: #98507 Related: #98488 Releases: main Change-Id: Id947f9b9ca75fa97b4f3fd2d270e0d92ac6a88e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75947 Tested-by:
-
Oliver Hader authored
Resolves: #98508 Related: #97305 Releases: main Change-Id: Id0f77fe51946cffeedf3699bf800169f0972657c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75948 Tested-by:
-
