- Sep 05, 2017
-
-
Benni Mack authored
StandaloneView currently replicates a lot of code which is already present within TemplateView (= Extbase), however, both classes inherit from AbstractTemplateView. In order to see which parts are different (and continue on streamlining fluid) the parts can be placed within AbstractTemplateView. Resolves: #82269 Releases: master Change-Id: I4184a5899b98227cf50f93db6c3ae38812cc86ec Reviewed-on: https://review.typo3.org/53831 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Sep 04, 2017
-
-
Jörg Bösche authored
The locallang_ttc.xlf has a typo in the key "space_before_class" which is shown in the access list of a page content field. Resolves: #82284 Releases: master, 8.7 Change-Id: Id61c8c7d5c5da11b8f7bb3e55e49d7613e593730 Reviewed-on: https://review.typo3.org/53875 Reviewed-by:
-
Georg Ringer authored
Remove a not needed </td> tag which has not been removed with the refactoring. Resolves: #82279 Releases: master, 8.7, 7.6 Change-Id: I2077e9e0b0119e6b064b0a6d4ebb9c3dc1d848a4 Reviewed-on: https://review.typo3.org/53873 Tested-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
-
- Sep 01, 2017
-
-
Benni Mack authored
Resolves: #82270 Releases: master Change-Id: I37fbb8c1d5199239eaa4cd432fb49d958bc86123 Reviewed-on: https://review.typo3.org/53859 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Claus Due authored
This patch improves the performance of TemplatePaths in two ways: * GeneralUtility::removeDotsFromTS() is called on a far smaller array instead of all TypoScript. * Fallback paths are allowed to be cached in the runtime cache which avoids re-reading TypoScript when no paths are configured in TS. Saves several thousand calls to removeDotsFromTs which in turn saves several tens of thousands of calls to in_array. Change-Id: Ib8aef69dc9136d355441ac05f21fe391e524eacc Resolves: #82232 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53824 Tested-by:
Wolfgang Klinger <wolfgang@wazum.com> Reviewed-by:
-
Justus Leon Moroni authored
The TranslationService uses the additional key 'error' in its translations of the validation errors. See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Service/TranslationService.php#L428. Releases: master,8.7 Resolves: #82264 Change-Id: Id00b60de0bf1b2b882f583f538be9bc8e40c010f Reviewed-on: https://review.typo3.org/53851 Reviewed-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
- Aug 31, 2017
-
-
Benni Mack authored
Uses PSR-7 instead of plain echo() and die - and shutdown the install tool properly (except for redirects currently). In the future, we should introduce proper PSR-7 response objects for certain responses (JSON, Redirect) but this will happen in a separate step. Resolves: #82268 Releases: master Change-Id: If8124f975936f6205f45009d30d979204765d8d1 Reviewed-on: https://review.typo3.org/53856 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Benni Mack authored
A new option $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemMaintainers'] is introduced, which contains a list of Backend User uids. It is then possible to restrict access to backend modules to system maintainers - most importantly the four Install Tool modules. When this option is not set in LocalConfiguration.php, then all admins are system maintainers, same goes for accessing TYPO3 in Development context. This is the first step to remove the necessary "enter your intall tool password" when accessing the install tool from within TYPO3 Backend. Resolves: #82266 Releases: master Change-Id: If0026748ede694394b4e7f39788a650816160146 Reviewed-on: https://review.typo3.org/53830 Reviewed-by:
-
Christian Kuhn authored
The master version of this 8.7 patch just removes last mentions of suhosin from the codebase. Change-Id: If003a8db37660662c65290a1e1bf25ef61375b80 Resolves: #82267 Related: #82257 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53858 Reviewed-by:
-
Benni Mack authored
The PHP request flow logic for authentication against the install tool password is moved into a new class called AuthenticationService. Additionally, all logic which is only needed inside the StepController is moved from the AbstractController into the StepController or the recovery request handler. ToolController and AjaxController are now free of session handling completely. Resolves: #82265 Releases: master Change-Id: Ib75c920877da81d7d859feaa5e6cbbcf4f0fd2cf Reviewed-on: https://review.typo3.org/53837 Tested-by:
-
Christian Kuhn authored
The install tool brought its own "status message" class structure since the 6.2 refactoring. This is used at many places in the install tool for message handling. The core has a very similar class construct "Messaging" with only little dependencies, too. To simplify a later separation of 'install tool' and 'installer' the internal status message class structure is removed and transitioned to the core Messaging structure. to get rid of just another special thing the install tool does. The ext:core FlashMessage and FlashMessageQueue now both implement the \JsonSerialize interface. This allows direct json_encode() calls on these objects, helpful for instance for ajax responses. In ext:install "Environment checks" suhosin specific checks have been removed since the project is dead and only has a pre-alpha php 7.0 fork, so probably nobody is using that with the given core PHP constraints anymore. Change-Id: Ifecd3cd4889d8db5aaf3e87f317c98be706ae82b Resolves: #82257 Releases: master Reviewed-on: https://review.typo3.org/53835 Tested-by:
-
Benni Mack authored
The left-over signals in EXT:install/ext_localconf.php belong to EXT:core (uses classes from EXT:core anyways) and since both extensions are required at any time (part of minimal system) this is just a separation cleanup. Resolves: #82241 Releases: master Change-Id: I9ec93ada9b4985ced285276fa5c33b851ec0be8f Reviewed-on: https://review.typo3.org/53836 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Mathias Brodala authored
Resolves: #82175 Releases: master, 8.7 Change-Id: I4b70b2a662b1818171bb180f88f8d40a48ee91ed Reviewed-on: https://review.typo3.org/53788 Reviewed-by:
-
Fabian Thommen authored
Releases: master Resolves: #82194 Change-Id: I6bb00c14dc331ec362614d00e48bf169da7cd572 Reviewed-on: https://review.typo3.org/53799 Tested-by:
Sidoine Ghomsi Nokam <s.ghomsinokam@neusta.de> Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Susanne Moog authored
PHP already converts strings representing 8-bit integers to int - so there are no numeric array keys that are of type string that ArrayUtility should reorder. Change-Id: Ieff77f4b1b8d6cbadba73dad06e9ec02d8748e85 Resolves: #82201 Releases: master Reviewed-on: https://review.typo3.org/53805 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
-
Daniel Siepmann authored
Within the docs, an incorrect identifier is used for a custom finisher. This has been fixed and is in line with the example code above. Releases: master,8.7 Resolves: #82234 Change-Id: I41881f825e7961f4945805360683c3189f2f9fcb Reviewed-on: https://review.typo3.org/53825 Reviewed-by:
-
Ralf Zimmermann authored
Use the configured finisher identifier for translation keys instead of the finisher class name. Resolves: #81591 Releases: master, 8.7 Change-Id: Ib78e942121b4b6e299ae394c30261603760444f7 Reviewed-on: https://review.typo3.org/53363 Tested-by:
Denis Mir <mir.denis@googlemail.com> Tested-by:
-
Christian Kuhn authored
Brings a bug fix in frontend functional test parsing. Change-Id: I3e95f4ee12069bbbfc225fb5045793273eff6f95 Resolves: #82256 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53840 Tested-by:
-
- Aug 30, 2017
-
-
Ludwig Rafelsberger authored
Releases: master,8.7 Resolves: #82239 Change-Id: I90d4ecdb4917c567a652a7bf5d24b55b39d646fd Reviewed-on: https://review.typo3.org/53833 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Benni Mack authored
In order to get the controllers free of security checks, the logic of authentication/session handling is moved from various controllers into the RequestHandler and the Application. Additionally, a second RequestHandler (RecoveryRequestHandler) is introduced which acts as a fallback if TYPO3 is not installed yet, or the installation is broken (e.g. missing PackageStates.php). This brings a cleaner dispatching mechanism, having the RecoveryRequestHandler (which can handle any request) dealing with the StepController, and the regular RequestHandler (with higher priority) for handling the maintenance functionality for running installations. Resolves: #82238 Releases: master Change-Id: I906ab3f15479bbe70202608f6bd7838cc22d9e3a Reviewed-on: https://review.typo3.org/53800 Tested-by:
-
- Aug 29, 2017
-
-
Claus Due authored
This patch updates the composer Fluid dependency to version 2.4.0 and above. Fixes multiple bugs and performance issues - and adds a few new features. Full list of changes: https://github.com/TYPO3/Fluid/compare/2.3.4...2.4.0 Change-Id: I2d16c6c95ecb6c985da772736d066d8e10da8761 Resolves: #82230 Releases: master Reviewed-on: https://review.typo3.org/53823 Tested-by:
-
Christian Kuhn authored
The database analyzer buttons "Run again" and "Apply" are now disabled when a scan is in progress. This prevents multiple ajax calls in parallel which lead to duplicate output. Change-Id: I28df15e2c7169960e0889aed903bbd72034f07cc Resolves: #82152 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53821 Reviewed-by:
-
Benni Mack authored
The CmsVariableProvider within EXT:fluid extends a Fluid core class with the same functionality and can be removed. A class alias ensures that the PHP class is still available. Resolves: #82229 Releases: master Change-Id: I71eb7beaf0684631d9c7e857bbed91f08b75d47c Reviewed-on: https://review.typo3.org/53227 Tested-by:
Claus Due <claus@phpmind.net> Tested-by:
-
Anders Kostending authored
Update CKEditor to the lastest version that fixes a lot of bugs. Release notes: https://ckeditor.com/release-notes Fixes: * Added Advanced Content Filter integration with the Justify plugin. * [Chrome] Fixed: Clicking the scrollbar throws an Uncaught TypeError: element.is is not a functionerror. * Fixed: Widgets cannot be properly pasted into a table cell. * Fixed: Internal cke_table-faked-selection-table class is visible in the Stylesheet Classes field of the Table Properties dialog. * [Edge] Fixed: Error thrown when pressing the Select All button in Source Mode. * Fixed: Double slash in the path to stylesheet needed by the Table Selection plugin. * Fixed: Unnecessary dependency on the Editor Toolbar plugin inside the Notification plugin. * Fixed: Error thrown into the browser console after opening the Styles Combo plugin menu in the editor without any selection. * Fixed: Double click does not open the dialog for modifying anchors inserted via the Link plugin. * [IE8-9] Fixed: Clicking inside an empty read-only editor throws an error. * [IE10] Fixed: Clicking below a single horizontal rule throws an error. * Fixed: The range.cloneContents method selects the whole element when the selection starts at the beginning of that element. * Fixed: The range.extractContents method returns an incorrect result when multiple nodes are selected. * Fixed: The elementPath.contains method incorrectly excludes the last element instead of root when the fromTop parameter is set to true. * Fixed: SCAYT leaves underlined word after the CKEditor Replace dialog corrects it. * Added the CKEDITOR.dom.nodeList.toArray method which returns an array representation of a node list. Resolves: #82143 Releases: master, 8.7 Change-Id: I6f6037e48d768e4a2887c799c1791f3201ce40c8 Reviewed-on: https://review.typo3.org/53751 Reviewed-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Tested-by:
-
Johannes Schlier authored
The trigger values can be hardcoded here, as the previous filtering only gives us fields for which we want to hide the explanation and show the input field. Previuosly each time a new link field was created (as an IRRE element for example) the input and explanation fields were triggered. This created confusion with editors and also broke the trigger button, so that fields that were in the explanation mode could not be triggered back to input mode. Resolves: #82179 Releases: master, 8.7 Change-Id: Ic92129c6cdafe5fab19fbc76b9e9b7713b9e8736 Reviewed-on: https://review.typo3.org/53790 Reviewed-by:
Anja Leichsenring <anja.leichsenring@typo3.com> Tested-by:
-
Christian Kuhn authored
Fix "Find imagemagick / graphicsmagic in specific direcory" input field in image preset handling. The preset handling is still a bit ugly and does not integrate too well into the ajax based handling all other cards use. This needs a bigger refactoring and is not done with this patch. For now, submitting a path to the image preset path input field reloads the view and executes the path test, so the functionality is there, it's just a bit ugly to use. Change-Id: I2da1680b44ff34df05aecc4eb589a293bb8d72c2 Resolves: #82188 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53822 Tested-by:
-
- Aug 28, 2017
-
-
Markus Hoelzle authored
Render additionalAttributes and data-* attributes in VideoTag, YouTube, Vimeo and AudioRenderer if set in the Fluid MediaViewHelper. Releases: master Resolves: #81741 Change-Id: Ieef9eae905a33e09e225d3a563c3f31988a65a57 Reviewed-on: https://review.typo3.org/53488 Tested-by:
-
Andreas Fernandez authored
The install tool (/typo3/install.php) is at the same directory location as the backend interface. The links are fixed to point to the correct locations. Remove an obsolete f:if along the way, this partial is only loaded in non backend context anyway. Resolves: #82199 Related: #76084 Releases: master Change-Id: I73ff8b0a3bd22827fa2a2c319b0e0bb2ad4e5afa Reviewed-on: https://review.typo3.org/53803 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Tymoteusz Motylewski authored
During doctrine migration a change of behaviour was introduced. In v7 when a translated record is hidden, it's not shown, while before this patch, a record from default language was shown. Resolves: #82161 Releases: master, 8.7 Change-Id: Ib8127eff7218f9dd064febbab4956af44f3164b9 Reviewed-on: https://review.typo3.org/53796 Tested-by:
-
Andreas Fernandez authored
Due to invalid syntax used at the code blocks, the code is not rendered at all. This patch adds the missing blank linkes. Resolves: #82218 Related: #81901 Releases: master Change-Id: Iadb034f0cfd250cf1871b65d417844e999d836e5 Reviewed-on: https://review.typo3.org/53814 Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
-
- Aug 25, 2017
-
-
Benni Mack authored
The field pages.urltype contains "0", "1", "2" which maps to a protocol, however most people want to just paste the url in the "pages.url" field. This change drops the DB field "pages.urltype" and merges the value into "pages.url" directly. Resolves: #71306 Releases: master Change-Id: I309724ba48ac9c5674a75e79da6cbb6e4880e521 Reviewed-on: https://review.typo3.org/53198 Tested-by:
-
Andreas Fernandez authored
CodeMirror is offered as a minified version. As there is no benefit of using a "full-blown" version, switch to minified version instead. Resolves: #82204 Releases: master Change-Id: I8e15e1ea8266951430ebeb86445b3cd2db524caf Reviewed-on: https://review.typo3.org/53806 Tested-by:
-
Christian Kuhn authored
Before refactoring of the install tool with #76084, a 'fatal error handler' was in place to redirect to the extension checker if a fatal php error was detected during one of the main "tool" actions. Now, the main controllers of the install tool never load non-core extension data anymore, those can't fail due to issues with specific ext_localconf.php or ext_tables.php files. This extension loading now happens only in ajax actions and thus can't kill the whole install tool anymore. Left over error handler code is removed from the ToolController with this patch. Change-Id: I0d0398f7b66a6a2c64dec48fe60a722698688a59 Resolves: #82200 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53804 Tested-by:
-
Christian Kuhn authored
With the doctrine migration a signal formerly located in class SqlExpectedSchemaService has been moved to class SqlReader. The old SqlExpectedSchemaService has been removed with issue #82148. Slot for that moved signal should now switch to the string literal of the class name. Change-Id: Id1cb28b236c7025308b0f0be3f969903df4c4ea5 Resolves: #82197 Related: #82148 Releases: master Reviewed-on: https://review.typo3.org/53801 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #82198 Releases: master Change-Id: I62e3f378031197d87c318b2062d434a99c9a71a4 Reviewed-on: https://review.typo3.org/53802 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
- Aug 24, 2017
-
-
Oliver Hader authored
Since Doctrine DBAL has been integrated into the TYPO3 core during version 8 development and Extbase queries have been adjusted with TYPO3 version 8.4.0, the behavior on distinct query results were mixed up as well. Extbase queries using the query-builder until TYPO3 7 LTS contained a dedicated `SELECT DISTINCT` when retrieving data which lead to unique entities, especially when implicit `LEFT JOIN` statements have been added to the query to resolve cardinalities of the types one-to-many and many-to-many. Besides that using `GROUP BY` is not reliable in this particular Extbase scenario. Further details can be found in MySQL documentation: https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html Change-Id: Ic5fd1d4752eefec7fcff37d8d62f55ea7299e8d6 Resolves: #80380 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53658 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Christian Kuhn authored
If im / gm are not configured, the Environment module may throw a fatal since refactoring. The patch sanitizes that and fixes the "Current configuration" view in "Image Processing" card which broke during refactoring, too. Change-Id: I6180a10150e63182c23dd7d7e8257e99a8652533 Resolves: #82160 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53797 Tested-by:
-
- Aug 23, 2017
-
-
Frank Naegler authored
Some install tool cards load content on opening the card. The patch now fires events on open and modules single card JS binds to those events to load content. This fixes the prev/next buttons in docheader to init card content correctly. Resolves: #82185 Releases: master Change-Id: Iad04a0fc560df8511f716982456b2ac3ae0644bb Reviewed-on: https://review.typo3.org/53794 Reviewed-by:
-
Wouter Wolters authored
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
Mathias Brodala authored
Change-Id: I9e5a04c3ef0ee8fed53d22df4d6ea472266145e7 Resolves: #82131 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53731 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
