- Nov 07, 2019
-
-
Benni Mack authored
Guzzle is our HTTP fetching library, which should be updated to the latest version due to some bugfixes regarding cookie handling. Executed command: composer update guzzlehttp/guzzle --with-all-dependencies Resolves: #89602 Releases: master, 9.5 Change-Id: Ice5cbf96b5459b451872be6ff0ac11661b0e39b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62237 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Georg Ringer authored
To improve the accessibility of the backend login, the following changes are applied: - Remove wrong role from login news - Add aria-label to the input fields The color contrast of the login button (white text on orange background) needs to be tackled in a different commit as it requires a lot of changes in other areas as well. Resolves: #89596 Releases: master, 9.5 Change-Id: I31fc62c8f3e8f151b7172cf502842b0d2510b401 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62211 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Benni Mack authored
A simple copy/paste error fetches a wrong DB connection when having multiple database connections configured. Resolves: #89598 Releases: master, 9.5 Change-Id: I38b67a0a361e2ee00959aa0e6aa17a015aaf541d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62233 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Nov 06, 2019
-
-
Nicole Cordes authored
This patch streamlines the return values for softref type typoscript and typoscript_tag. Furthermore tests for the API method findRef() are added to ensure same return results. Furthermore a non-reachable part in findRef_typolink_tag is removed. As the incoming content is split by <a> tags, the <LINK> tag condition within this function will be never fulfilled. Resolves: #88207 Related: #87652 Releases: master, 9.5 Change-Id: Ifca40c5d0e049c5b5d92a507a9d5ec0249e9953e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62196 Tested-by:
-
Alexander Vidoni authored
The example makes use of a reference, not a copy. This is now reflected by the text. Releases: master, 9.5 Resolves: #89571 Change-Id: I5d039de75f48b7524a32b036ec8d4d071b60d6f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62181 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Tomita Militaru authored
"TypoScript Configuration" renamed to "Page TSconfig" "Include Page TSconfig (from extensions)" renamed to "Include static Page TSconfig (from extensions)". Resolves: #89164 Releases: master Change-Id: I815524f32c7668350c9959a011adf598eb4be3d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62202 Tested-by:
-
- Nov 05, 2019
-
-
Josef Glatz authored
Since the default language can be different from site configuration to site configuration, "flags-multiple" icon is used instead of the fallback "default-not-found" icon when no default language is configured (e.g. when editing a translated sys_file_metadata record in filelist module). Resolves: #88909 Releases: master Change-Id: Ie755cc06b43e4b735000ab598f14853773d58ced Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61432 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Daniel Windloff authored
The func module has been removed. The according PageTsConfig filter has been removed as well. Resolves: #88821 Releases: master Change-Id: I9ab509f518ab87e68a0e0c7d7fe91fdf7041493e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61340 Tested-by:
-
Alexander Schnitzler authored
This commit cleans up the ColumnMap class by removing unused, superfluous methods and constants and by defining the visibility of class constants and by adding references to the TCA documentation. Releases: master Resolves: #89490 Change-Id: I3abecc0671312e75147e3a9a3213864f9d9b12bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62083 Tested-by:
-
Benni Mack authored
Resolves: #24737 Releases: master, 9.5 Change-Id: I5a5f1b0a26951266a0e90c46af670602247693e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60501 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
Daniel Siepmann authored
There were two double quotes within two exception messages. That could lead to irritation whether one was part of header name respectively the display condition string. Resolves: #89583 Releases: master, 9.5 Change-Id: Idbe6efc296e1d064b14806fc248c2a23c9dadf24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62193 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
This change adds null coalescing operators at multiple places in `ShortcutRepository` to avoid type errors if the shortcut url doesn't contain a query part (e.g. coming from legacy URLs when a TYPO3 v7 installation was migrated). Resolves: #89533 Releases: master, 9.5 Change-Id: I9bd1bdf0cf2f8d8954c4bf9eada6c720f2103af1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62178 Tested-by:
-
Benni Mack authored
The languageService and pageRenderer instantiate their language / locale information at a very late point, allowing to only use TSFE's language features when TypoScript was loaded. However, since TYPO3 v10, the SiteLanguage information is always present in an earlier stage, so the initialization can happen earlier. Resolves: #89575 Releases: master Change-Id: Id9dc8268946041353430cb02e12631b048364acf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62183 Tested-by:
-
Georg Ringer authored
The current language of the TYPO3 Backend user is now added as attribute 'lang' to the html tag of any module using the ModuleTemplate. This improves accessibility, as it is used by screen readers that switch language profiles to provide the correct accent and pronunciation. In addition, DocumentTemplate behaves the same by adding proper htmlspecialchars() Resolves: #89559 Releases: master Change-Id: I42132e24475b4aa7decbf5173e3717297eda897e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62169 Tested-by:
-
- Nov 04, 2019
-
-
Wolfgang Klinger authored
Cast the properties useRegExp and useOptionSplitReplace to boolean and fix the if condition logic. Resolves: #85015 Releases: master, 9.5 Change-Id: I99b7bd1b793e1dfbd7584fe539eee878e39acbfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58945 Tested-by:
-
Rémy DANIEL authored
Since the introduction of the new TypoLink format like t3://page?uid=1 the SoftReferenceIndex is parsing these TypoLinks wrong, and does not parse t3://record at all. This patch adds the same parsing of typolinks than the one done by LinkService, and removes old and duplicated code. This patch also fixes the missing softref when a typolink contains an anchor to a tt_content. The signal `getTypoLinkParts` is removed from execution, because it is not needed anymore, as all is handled via LinkService capabilities directly. Resolves: #84016 Releases: master, 9.5 Change-Id: I4b83cd43af938de084aebc1b4bf424e6bb2d9682 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57610 Tested-by:
-
Wolfgang Klinger authored
Resolves: #86969 Releases: master, 9.5 Change-Id: I75c7d5a5467871b0a40df605059c0ebd1bca0438 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58928 Tested-by:
-
Alexander Vidoni authored
Use correct filename (like in previous paragraph). Releases: master, 9.5, 8.7 Resolves: #89570 Change-Id: Ieb34118a18c302746677e11b7f15ab02690d435a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62180 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
The `$data` array can contain column-value pairs or just the values. The `$columns` array only contains the column names. Resolves: #89538 Releases: master, 9.5 Change-Id: Ieb24407321f6899d5271975430d72a1f8b92335e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62177 Tested-by:
-
- Oct 30, 2019
-
-
Benni Mack authored
A new fluid standalone version 2.6.6 reverted the changes that had regressions in v2.6.5 and v2.6.4. Composer command: composer req typo3fluid/fluid:^2.6.6 Resolves: #89542 Releases: master, 9.5, 8.7 Change-Id: I30a29a3cc07a277bd4a72e83a67a6c3260adc5d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62156 Tested-by:
-
Georg Ringer authored
The feature switch `betaTranslationServer` makes it possible for users to test and use the new translation server. The integration is currently work in progress but will be finished before the LTS release of version 10. Once the work has been stabilized and tested well, the feature flag will be removed for 10 and backported for 9. Resolves: #89526 Releases: master Change-Id: Ic88e4b6568dbe53cd88e63a8a1dd39787219e9e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62127 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
Benni Mack authored
When a custom FAL / sys_file_reference inline element is registered, and there are custom allowed file extensions, the property "elementBrowserAllowed" is not properly run through "GeneralUtility::trimExplode()", however, all other places do this properly. The changes moves the trimExplode to the correct place, so uploading of files directly in FormEngine works properly. Resolves: #89540 Releases: master, 9.5 Change-Id: I9a486f8c932078629761bd86cc1d9455120fc7a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62155 Tested-by:
Daniel Gorges <daniel.gorges@b13.com> Tested-by:
-
Markus Klein authored
The existing check on the data-type of $rootLine has to be adjusted since the default value is now an array. Resolves: #89512 Related: #89482 Releases: master, 9.5 Change-Id: Ia1d673ff2fe1f45e615c5bc6c81b574b63ec2e54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62112 Tested-by:
-
Benni Mack authored
Creating links to specific records (LinkHandler functionality) does require a global TSFE object. In addition, calling LinkBuilder directly will result in a fatal error when linking e.g. to EXT:news records. Currently, this is not possible as the RedirectService is not prepared for this. The patch modifies the places accordingly. Resolves: #87574 Releases: master, 9.5 Change-Id: Iebda76bad0a2681df30f2ea4c42cfd3b5cd4a39f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62128 Tested-by:
-
Georg Ringer authored
Hide the following options in the LinkBrowser of a sys_redirect record because those don't work for redirects and confuse users: - mail - folder - telephone Resolves: #89532 Releases: master, 9.5 Change-Id: I6d540ce96bb6e6dc19e35454bf70aca099be09f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62131 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Oct 29, 2019
-
-
Christian Eßl authored
Backend users each have a serialized array of individual user configuration, called "uc" persisted in the be_users table. Before TYPO3 9.5, the structure of this configuration could sometimes contain stdClass objects, which is no longer supported. Logging in as a backend user with such an outdated "uc" array would then crash several parts of the TYPO3 backend, because the BackendUserConfiguration class will try to access an stdClass type configuration like an array. An UpgradeWizard called "BackendUserConfigurationUpdate" is now provided, which allows to update any outdated "uc" structure of all backend users. Resolves: #89269 Resolves: #89268 Resolves: #86398 Releases: master, 9.5 Change-Id: Ic2158b34e70c7f931f4ef8acc8c39af618e241e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61906 Tested-by:
-
Oliver Bartsch authored
All database result values must be proper typecasted as database drivers may use and return different data types. Resolves: #89531 Related: #56351 Releases: master, 9.5 Change-Id: I2e48bd548b178aa1e684db0ff908259cdfec377f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62153 Tested-by:
Patrick Broens <patrick@patrickbroens.nl> Tested-by:
-
- Oct 28, 2019
-
-
Benjamin Franzke authored
The TypoScript editing module "Template" currently has different cache flush behaviours, depending on *how* the data is being modified: a) The DataHandler cache command 'all' is triggered when a TypoScript constant is changed via the ObjectBrowser or ConstantEditor controllers and when a new sys_template record is created. b) Tag-based cache clearing in group 'pages' is performed by the DataHandler when a TypoScript template is edited via "Edit the whole template record" button. Note: This is because the edit functionality is using the plain record_edit FromEngine controller which means EXT:tstemplate controllers only act as proxy here. Note that both cases are wrong for sys_template records: * Case a) flushes too many caches: The DataHandler cache command 'all' flushes TCA, ext_localconf and Dependency Injection caches – since #75581 even opcache caches. All these (performance relevant) caches are never influenced by TypoScript and must not be flushed in production systems (results in slow responses due to cache rebuilds). * Case b) flushes too few caches: A sys_template record influences (in 99.9% cases) the page tree. By flushing the record via DataHandler tag flushed there are two caches being flushed: * pageId_[pidOfSysTemplateRecord] * sys_template_[uidOfSysTemplateRecord] * sys_template Non of these tags are assigned to page caches that rely on this sys_template record. There are two options to consolidate cache clearing: * Use DataHandler tag-based flushing as in case b). The drawback: generates *a lot* of cache tags which are then flushed very rarely. * Flush the 'pages' cache group in both cases. This variant flushes a bit too much (of course, tags are more precise), as pages which did not rely on a currently modified sys_template record are flushed as well. This change implements the latter option as we think the drawbacks of flushing a bit too much is better than the drawback of generating a ton of cache tags. As all cases where the cache command 'all' was used, already modify sys_template though DataHandler processing, we can remove the previous cache commands and move the flush logic for all cases into a hook that is triggered by the DataHandler when records are being created/changed. Releases: master Resolves: #89280 Change-Id: I4b705398634048ccf9fb7fe53acf2eb15fa55562 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61834 Reviewed-by: -
Devid Messner authored
Resolves: #89079 Releases: master, 9.5 Change-Id: Iac9f58064a54fb64ae7fad82d35bbbbaecd2ae95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61619 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
linawolf authored
Fields without softref are not being checked. Since pages:media does not have softref set in its TCA it will never get checked. Field pages:url has an unresolved issue since 6 years. So better don't mention it as an example for configuration until it works. The default configuration also contains the two fields. Releases: master, 9.5 Resolves: #89163 Change-Id: Ia9968ef297cedb3d09747acffa4ca07fff2fa0c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61700 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Markus Klein authored
If the JsonView traverses array with numeric indexes and an exclude configuration is set, the first array element is now handled correctly. The comparison of array index 0 with a string within in_array() yields TRUE, hence the first element was skipped. Resolves: #89510 Releases: master, 9.5, 8.7 Change-Id: I38561f7fc05dcefaf23f9178d5ba987591ffaf45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62111 Reviewed-by:
Florian Weiss <typo3org@leblanc.at> Reviewed-by:
-
Alexander Stehlik authored
This prevents typolinks called in the stdWrap of ATagParams from modifying the original link URL. Resolves: #89521 Releases: master, 9.5 Change-Id: Ief6d7c8a7345bab16b98d840e31807e5ab07763d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62126 Tested-by:
-
- Oct 26, 2019
-
-
Ralf Zimmermann authored
If a form element property is not defined through a form editor inspector, the "predefinedDefaults" value from the form editor setup will be used for some data integrity checks (such properties are immutable). Now, such checks against the "predefinedDefaults" values are *only* used in scenarios where form elements are newely created. All the following integrety checks on this value will be based on hmac validation. In addition, this patchset fixes a faulty validation in the following (edgy) scenario: * backend language is EN * open the form edtior and add a ContentElement form element * switch to another browser tab and change the backend language to DE * clear the cache * go back to the form editor and click the save button This is done by getting all translations (for all backend languages) for the untranslated! "predefinedDefaults" value and compare the (already translated) value (from the form definition) against the possible translations from "predefinedDefaults". There is an extended scenario which is out of scope for fixing: * the same scenario as above + delete the previous chosen backend language within the maintenance tool Resolves: #87520 Releases: master, 9.5 Change-Id: I6f486956c24121c0065b67b4f2179301e2a344c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60638 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
Julian Geils <j_geils@web.de> Tested-by:
-
Richard Haeser authored
In some edge cases you may want to disable rendering of hreflang and canonical links. We added some hints how to disable the rendering of these tags. Resolves: #88242 Resolves: #88140 Releases: master, 9.5 Change-Id: I197062de0031fc1bb3a21eb84ab124d3d0967f20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62122 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Eßl authored
In the typoLink() function of ContentObjectRenderer, not all links will have a 'target' value. - If the protocol is not natively supported by TYPO3, as in "tel:", only a 'url' parameter will be resolved. For that reason, make the $target parameter of addSecurityRelValues() nullable to avoid frontend errors when using custom link protocols. Resolves: #89338 Releases: master Change-Id: I6bca872e38e2f5618a5c06a5ebd3476beb2e60a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61879 Tested-by:
-
- Oct 25, 2019
-
-
Michael Telgkamp authored
Change highlighting of :hover, :focus and active states to lighter background as it was in TYPO3 7. Resolves: #88269 Releases: master, 9.5, 8.7 Change-Id: I62ffae36990f8b3dbaceec9c6064675b3842a902 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62116 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Kay Strobach authored
Add TypoScript examples and general recommendations. Resolves: #89497 Releases: master Change-Id: I4e39e389763b9065abccc4eb70d245543e1a9552 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62092 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Georg Großberger authored
A new feature switch has been introduced to change the ordering of the redirect middleware and the base redirect middleware. If enabled, the redirect is executed before the base-redirect-resolver to ensure configured redirects are hit first. To not break the current behaviour the new order is not applied by default. Resolves: #88902 Releases: master Change-Id: I3ba732f4611c03f589c10bf74ddcb61deefe8816 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61426 Tested-by:
-
Andreas Fernandez authored
This patch updates all related eslint packages to their latest versions. Executed commands: yarn add --dev eslint@^6.5.1 yarn add --dev @typescript-eslint/eslint-plugin@^2.5.0 yarn add --dev @typescript-eslint/parser@^2.5.0 yarn add --dev @typescript-eslint/typescript-estree@^2.5.0 The `eslint` also fixes a security vulnerability, which is "very unlikely to be exploited" and may hit in core development context only. See - https://github.com/eslint/eslint/issues/10002 - https://github.com/eslint/eslint/commit/f6901d0b Resolves: #89516 Releases: master Change-Id: I600253c901b2438ba99835ba7ad78ca7d521f961 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62115 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Liddy authored
* Use a less abstract example that should help TYPO3 beginners for better understanding * Switch DataProcessor and preview block * Add doc and reference for extending tt_content for custom fields * Extend preview block with example for simple template override Releases: master Resolves: #89514 Change-Id: I1c23ab7a2d68924eb10ddc17a45844e70fae032b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62114 Tested-by:
-
