Corrects several whitespace related issues.

Special focus lies on files
* typo3/class.db_list_extra.inc (127 violations)
* typo3/template.php (148 violations)
* EXT: rtehtmlarea/class.tx_rtehtmlarea_base.php (129 violations)

Sonar / metrics terms to be improved:

* OpeningFunctionBraceKernighanRitchieSpaceBeforeBrace
* FunctionCallArgumentSpacingSpaceBeforeComma
* FunctionCallArgumentSpacingTooMuchSpaceAfterComma
* SemicolonSpacingIncorrect

Change-Id: I18a971c64e62ad976d9da5daf6d9a4d5aa463425
Fixes: #37295
Releases: 6.0
Reviewed-on: http://review.typo3.org/11295
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The fix for issue #35260 introduced a new bug in method
t3lib_TCEmain::getPreviousLocalizedRecordUid() by adding a
field in a query in the wrong place. In particular, this breaks
the localization of tt_content elements used with IRRE.

This patch fixes the problem by separating the list of fields
used for selecting and for sorting.

Change-Id: I66101071a0320b7c2b1826c3422e7bf99671a122
Fixes: #37221
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11250
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

Change-Id: Id5bf3756e215b50eb9d789648b2bca57bb8bb712
Resolves: #37264
Releases: 6.0
Reviewed-on: http://review.typo3.org/11277
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

If no cli key is given, cli_dispatch.phpsh exits with a generic
error message that a key must supplied to run the script. If a
key is given, but it is no registered cli script, the script
exits with a list of valid keys.

The patch removes the first test to also show the list of valid
keys if there is no key at all and adapts the error message a bit.

Change-Id: I4d356a1837218aaeb92ef85d9c5b8833b2737e08
Resolves: #37238
Releases: 6.0
Reviewed-on: http://review.typo3.org/11263
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Klee
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in typo3/sysext/install/mod/class.tx_install.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Iad13d9b4f2bad80cb7921ae44f46c3723f82cc20
Resolves: #37254
Releases: 6.0
Reviewed-on: http://review.typo3.org/11274
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in class.tslib_fe.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Ib4a8d95b99e06e1342a4f5c5a53df5582a9b7d86
Resolves: #37253
Releases: 6.0
Reviewed-on: http://review.typo3.org/11272
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_parsehtml_proc.php
* t3lib/class.t3lib_positionmap.php
* t3lib/class.t3lib_querygenerator.php
* t3lib/class.t3lib_readmail.php
* t3lib/class.t3lib_recordlist.php
* t3lib/class.t3lib_registry.php
* t3lib/class.t3lib_rteapi.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I42a5b48a8eda5d77605a963ba8168d1d4342fa5f
Resolves: #37252
Releases: 6.0
Reviewed-on: http://review.typo3.org/11271
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I255e5067c3d2608870e4b35d35faf305af0f6b22
Releases: 6.0
Resolves: #37250
Reviewed-on: http://review.typo3.org/11269
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_pagerenderer.php
* t3lib/class.t3lib_pagetree.php
* t3lib/class.t3lib_parsehtml.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I56ffee774456d7712cf68cbd74652aad1b0f07bb
Resolves: #37242
Releases: 6.0
Reviewed-on: http://review.typo3.org/11265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix some cgl flaws that slipped through during the bootstrap refactoring.

Change-Id: Id2d122d0afdb3e0e1091a13eeecf62c1c67236f4
Resolves: #37236
Releases: 6.0
Reviewed-on: http://review.typo3.org/11261
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ibbb16ff84edf3dfae9ca4152b62211f37afb4cda
Resolves: #37235
Releases: 6.0
Reviewed-on: http://review.typo3.org/11256
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Extract code from init.php and put it to methods in Bootstrap.php.
Additionally, cli_dispatch and install/index.php do not require
init.php anymore and have a uncoupled bootstrap now.

There is still room for improvement,
this patch is just another intermediate step.

Change-Id: I5c6d84b8acb7760c8a77f192b2b5ba063b417b0d
Resolves: #37130
Releases: 6.0
Reviewed-on: http://review.typo3.org/11153
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Make sure port number gets appended when backend
is locked to SSL and port number is set to something
other than the standard 443.

Change-Id: I5fcb04fa0e0b8cbde3f19e9c54366e11d14fdf8e
Fixes: #37076
Releases: 6.0
Reviewed-on: http://review.typo3.org/11225
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

typo3/class.show_rechis.inc was forgotten
during the cleanup round for 6.0

Change-Id: I1805b0845fa4e9f44ec2ec37cbceb02bcdcd015d
Resolves: #37207
Releases: 6.0
Reviewed-on: http://review.typo3.org/11231
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I941fc2dfd028235ee0988d7e96cb374333987ae8
Resolves: #37206
Releases: 6.0
Reviewed-on: http://review.typo3.org/11230
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This made jenkins unhappy with
https://review.typo3.org/#/c/11225/3

Change-Id: I02ae564546eea8982300e2c42b9abe72c463bb51
Resolves: #37205
Releases: 6.0
Reviewed-on: http://review.typo3.org/11229
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_formmail.php
* t3lib/class.t3lib_frontendedit.php
* t3lib/class.t3lib_iconworks.php
* t3lib/class.t3lib_install.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I48a245d96f760c8957bebc8970cbe76446287084
Resolves: #37137
Releases: 6.0
Reviewed-on: http://review.typo3.org/11154
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_install_sql.php
* t3lib/class.t3lib_loaddbgroup.php
* t3lib/class.t3lib_loadmodules.php
* t3lib/class.t3lib_lock.php
* t3lib/class.t3lib_modsettings.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I0465b7d41e492ae4746f0649b676eae4ad2a145a
Resolves: #37202
Releases: 6.0
Reviewed-on: http://review.typo3.org/11228
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This fixes the UI issue with the deletion overlay and drag&drop
with nodes at the very bottom of the page tree viewport too.

Change-Id: I5cee23ea9441fcd1910a998547772bc3f2e53fb5
Fixes: #35182
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10411
Reviewed-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

This is a follow-up to 37142.
It removes the last violation for this topic.

Change-Id: Ia788655833a5ab3778ce0ca16d3105f4a479fd6a
Fixes: #37178
Releases: 6.0
Reviewed-on: http://review.typo3.org/11204
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

EXT: indexed_search $TCA for table index_config is only loaded
when EXT: crawler is installed but $TCA must always be included.
Removes condition to limit $TCA inclusion.

Change-Id: I9768ae18c40fa95084fbca54880ffc7b31e1f0a1
Fixes: #32815
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/11145
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

tbl_pages.php references non-existing labels.
Actually they have different names.

Change-Id: I9b89fd5dcc7355480e534c2b48130a8461f03ef4
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #37158
Reviewed-on: http://review.typo3.org/11178
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: I0518d9dd06c7d126dfe5d885e4b2751b7e7462b6
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #36459
Reviewed-on: http://review.typo3.org/11138
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

on metrics.typo3.org the violations drilldown says
that is 1 violation against
"FunctionCallArgumentSpacingNoSpaceAfterEquals"
and 1 violation against
"FunctionCallArgumentSpacingNoSpaceBeforeEquals":
both in typo3/alt_shortcut.php.

this should be fixed.

after that i guess these 2 coding guidline sniffs
could be activated in the CI-server jobs?

Change-Id: I4ff9d4f57f97e2f502088d8d6026544615331cd6
Fixes: #37139
Releases: 6.0
Reviewed-on: http://review.typo3.org/11157
Reviewed-by: Roland Waldner
Tested-by: Roland Waldner
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

on metrics.typo3.org the violations drilldown
says that are 2 violations against
"ArrayBracketSpacingSpaceBeforeBracket" in
tests/Unit/t3lib/utility/
class.t3lib_utility_mailTest.php.

this should be fixed.

after that i guess this coding guidline sniff
could be activated in the CI-server jobs?

Change-Id: I6fb7c6b67611ebac903466b28c7c473b3d36ee51
Fixes: #37141
Releases: 6.0
Reviewed-on: http://review.typo3.org/11159
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

on metrics.typo3.org the violations drilldown
says that are some violations against:

LogicalOperatorSpacingNoSpaceBefore (19)
LogicalOperatorSpacingNoSpaceAfter (18)
LogicalOperatorSpacingTooMuchSpaceAfter (17)
LogicalOperatorSpacingTooMuchSpaceBefore (6)

this should be fixed.

after that i guess these coding guidline sniffs
could be activated in the CI-server jobs?

Change-Id: Iffe732fdb94992f814dfaa8e34ccb04d71d8bd7d
Fixes: #37142
Releases: 6.0
Reviewed-on: http://review.typo3.org/11160
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Some of the most basic functions should be covered with unit tests.

The change creates tests for inList, expandList, rmFromList
and uniqueList.

Change-Id: I0fd1e47d7aec96e950b69b4c44898e55920ff4fd
Resolves: #36968
Releases: 6.0
Reviewed-on: http://review.typo3.org/11089
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Remove the hurdle that class names in ext_autoload (the key part of
the returned array) have to be lower cased.

The patch adds two tests, the first one expects that a case sensitive
class name in ext_autoload.php in actually lowercases before it is
written to the autoload cache file. It fails if the autoloader patch
is not applied.
The second tests that camel cased classes can be successfully autoloaded.

Change-Id: I2ccf916d43a288a520f6f89e9002bdc4df2da0b2
Resolves: #37110
Releases: 6.0
Reviewed-on: http://review.typo3.org/11148
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Philipp Gampe
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Some tasks may want to provide the user with information about how
far progress of their jobs has come.

Currently there is no way to do this in a nice way. The existing
method getAdditionalInformation() does not allow to output HTML.

Fixes: #36802
Releases: 6.0
Change-Id: I86877b3a3ec70e8c6ef5deae7e54442c35afada3
Reviewed-on: http://review.typo3.org/10946
Reviewed-by: Philipp Gampe
Reviewed-by: Nikolas Hagelstein
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Adds min-width to content elements in page backend module
to fix problem with line breaking icons.

Change-Id: Id66622c91433782e0813b6fb20097fa7a0c48793
Fixes: #35962
Releases: 6.0
Reviewed-on: http://review.typo3.org/10390
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski

CGL cleanup: this patch replaces a space indentation in two SQL
statements with tabs.

Change-Id: I88d4461a635fcadb3725a9c5178b439298356374
Resolves: #36871
Related: #37020
Releases: 6.0
Reviewed-on: http://review.typo3.org/11128
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler

This is a follow up to #36871.
Some whitespace indentions came back into core.
This patch removes them.

Change-Id: Iabc8eb2fed79ae6de8e8e9e12fcdb7a5bcb65a40
Related: #36871
Resolves: #37020
Releases: 6.0
Reviewed-on: http://review.typo3.org/11120
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The calculation of the page cache expirationy timestamp based on
property config.cache.xx = table:yy fails in some specific
scenarios, name when there are records having either a start time
in the future but no end time, or an end time in the future
and no start time. Contrary to what is being done so far, calculation
must be performed separately for each time field to avoid
interferences.

Change-Id: I4e4e259083a10f7125760d14ede11ff6a68022fe
Fixes: #35684
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10156
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Xavier Perseguers
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Removing one column was forgotten which results in an SQL error while
inserting the static data.

Change-Id: Ia54b7fc3121f6a50620d64223d610d633b3c76f0
Fixes: #34692
Releases: 4.7,4.8
Reviewed-on: http://review.typo3.org/9516
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Tested-by: Oliver Hader
Reviewed-by: Sebastian Fischer
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

This change also cleans up some comments and the existing unit test.

Change-Id: Ifb80b7b6f70d06f6531656c579e673a0b0e5ad0b
Resolves: #36942
Releases: 6.0
Reviewed-on: http://review.typo3.org/11068
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Currently the suggest wizard only searches through the label fields
of the records. In some setups other data might be useful to find
records.

The patch adds an configuration option to extend the wizard configuration
to include further fields into the search.

Change-Id: I14e88912a664195467502678eedb3bcdb9e4cf5f
Resolves: #36780
Releases: 6.0
Reviewed-on: http://review.typo3.org/10930
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

Removes page action related icons from the docHeader in work area
within page module:

* Create new page
* Move page
* Page history

and within list module:

* Up one level
* Hide/unhide
* Move page

Also removes "New content element" from page, these are added to columns.

Change-Id: I6bf996437e7af6e2149e6962990af2580655eced
Fixes: #34705
Releases: 6.0
Reviewed-on: http://review.typo3.org/10115
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The page module should also list the content elements
with language set to "All"

Change-Id: I6d8aaf4829a70b3945508884d9a09cf23d1e4842
Resolves: #24087
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9840
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Andreas Otto
Tested-by: Andreas Otto
Reviewed-by: Max Roesch
Tested-by: Max Roesch
Tested-by: Klaus Weidenbach
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

FAL needs mime type info. Use fileInfo functions here and make
fileinfo PHP extension mandatory.

Change-Id: If6fc39d4b42e0264927ecf6918e7deeb7ef9823c
Fixes: #36706
Releases: 6.0
Reviewed-on: http://review.typo3.org/10914
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The user rights have checks for new / edit / delete, but paste was missing
leading to an error. Page actions 'paste into' and 'page after' now checks
if the user has rights for adding new pages to the current page.

Change-Id: Ief80a511d61ba386d667c62263d6f5335d1c87b8
Fixes: #33546
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10483
Reviewed-by: Kilian Hann
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer