- Feb 14, 2020
-
-
Susanne Moog authored
To promote the new PSR-14 Events and to make it easier for people to see which kinds of events may be used, the admin panel now displays all events that are dispatched in the current request with their parameters. Resolves: #90265 Releases: master Change-Id: I3c73ab19168954e66ca3bb73762a26a3cb9628a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63041 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
SystemEnvironmentBuilder calls error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED)); which in turn is called on every test to setup the environment. This basically enforces this exact error reporting and does not allow to configure the error reporting in phpunit.xml AT ALL. Until TYPO3 v9, this was covered in each BaseTestCase in setUpBeforeClass() to re-add E_NOTICE to make all tests run without notice. The functionality in SystemEnvironmentBuilder was added in TYPO3 v6.0 while refactoring TYPO3's Bootstrap to ensure that no notices in ext_localconf.php or ext_tables.php were breaking the output. However, nowadays, TYPO3's error reporting is set up directly after LocalConfiguration.php inclusion, making this logic obsolete. The functionality is therefore moved to the Bootstrap at a later point, which is called for Functional and Acceptance Tests. Resolves: #90125 Releases: master Change-Id: I8d6348ffbf6622c03abecedc1cb0ce286ba1044c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62926 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Feb 13, 2020
-
-
Sebastian Fischer authored
With adding progressbar support while updating the reference index, it is now possible to see which table is updated and how much progress has already been achieved. To be able to implement the progressbar in the frontend in a different way, a progress listener interface is introduced which can be added separately. At the same time, the FlashMessage logic is now put in the TYPO3 Backend controller and the $cli_echo is now used to inject the progress listener interface Resolves: #82062 Releases: master Change-Id: Id11ba8a9f3e033eaea9f3aff5a7f5eb0602cfa02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/53748 Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
-
Benni Mack authored
This change introduces a new security option for setting the SameSite option to all cookies sent by TYPO3 Core. Namely: - Frontend User Sessions ("lax" by default) - Backend User Sessions ("strict" by default) - Install Tool Sessions ("strict", none-configurable) - Last Login Provider in Backend ("strict", non-configurable) This means that these can only be accessed by scripts and requests by the same site, and not by any third-party scripts. Since we're talking about actual cookies for a user, and not ads-related or third-party login-dependant cookies, the default options fit just perfectly. All modern browsers except Internet Explorer respect this option to be set. Please note that Firefox and Chrome will have "SameSite=lax" set in Q1/2020 by default if NO SameSite option is set at all. This change allows to configure this. Backend and Frontend User Cookies can be configured to "strict", "lax" or "none" (= same as before), whereas "none" only works for secure connections (= HTTPS). If "strict" is in place, security via CSRF is not needed anymore, and can be dropped in the future. Resolves: #90351 Releases: master, 9.5, 8.7 Change-Id: I8095e2a552faa9d1fd4fa7855297302a9ec6a75f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63183 Tested-by: -
Benni Mack authored
There are a few places where unused options can be simplified, and the dependency on the PagePositionMap class can be placed in one dedicated method. Several guard clauses are useless due to method parameter types, and are cleaned up. This is a pre-patch to bring more functionality into New Content Element Wizard. Resolves: #90366 Releases: master Change-Id: I912efbe25f6ff79670f404d7f44dbad0993295db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63211 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Feb 12, 2020
-
-
Benni Mack authored
TYPO3 uses "phpdocumentor/reflection-docblock" (added in Jan 2019) but also added "webmozart/assert" which is not needed directly (as it is a subdependency). Thus, TYPO3 Core should only require what is directly used, therefore the dependency is removed. Used composer command: composer remove webmozart/assert Resolves: #90364 Releases: master Change-Id: Ief2787cb98c0080517f73e321ab34568b0addafb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63209 Tested-by:
-
Andreas Fernandez authored
This patch fixes some code issues with unit tests and HTML formatting that were not noticed due to missing builds during the infrastructure outage. Resolves: #90363 Releases: master Change-Id: Iab2e9965e711d0ca655c1105b16ec9a5434d3d87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63208 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #90362 Releases: master, 9.5, 8.7 Change-Id: I5716164f88e1fcead60bf64cd76bbb7d31cfd6b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63205 Tested-by:
-
Anja Leichsenring authored
Added the missing keyword abstract to the class definition to prevent phpunit from issuing a warning about the class not containing any tests. Resolves: #90357 Releases: master, 9.5 Change-Id: I4b2d5c8111d63e73039658efffe73888b0c84179 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63204 Reviewed-by:
-
- Feb 11, 2020
-
-
Georg Ringer authored
TYPO3 supports now translations from Macedonian which uses `mk` as locale. Resolves: #90328 Releases: master, 9.5 Change-Id: I25bec5840e48a74e23fe9d1b0d565f2cdd036f22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63178 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Sybille Peters authored
The changelog "Use new Translation Server" has a title indicating it is a feature, but has a filename starting with "Important". Resolves: #90352 Releases: master Change-Id: Ibfd5dc6aebabf36b81e26ac7d181ec3ed1624007 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63198 Reviewed-by:
-
- Feb 10, 2020
-
-
Andreas Fernandez authored
With #90238 the JavaScript function `goToalt_doc` is registered as a Fluid variable. However, the check for an existing event in the template broke as the variable now always has a value. To fix the situation, a new boolean variable `hasClickEvent` is introduced. Resolves: #90344 Related: #90238 Releases: master, 9.5 Change-Id: I7d86d300be923db82a0f79c3dd479a708230d92d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63185 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Michael Schams authored
This feature separates system extensions from 3rd-party extensions visually. The extension list shown in the Extension Manager can now be filtered by certain extension types (system and 3rd-party extensions). The selected filter is saved to the backend user configuration. Resolves: #89894 Releases: master Change-Id: Ifd2916129c792fa2a05cb0df52ee49456cfb16ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62595 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Benni Mack authored
The PageLayoutView monster class has been chunked up into smaller parts and some other functionality was removed. In detail this patch changes: - start() method is removed, as it is not needed anymore - public properties which are not in use or have been left-overs ("nextThree") are removed - rendering a single content element is now split up into smaller parts - rendering the "localization view" is now separated into a separate method - unnecessary functionality in separate methods (addPageIdConstraint) is moved into the main SQL function Resolves: #90315 Releases: master Change-Id: I53cd10beb5904bf49618d8b9d6147701f783125f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63172 Tested-by:Daniel Gorges <daniel.gorges@b13.com> Tested-by:
-
Benni Mack authored
This patch removes the dependency to DocumentTemplate from all LinkHandler + ElementBrowser popups, paving the way to move HTML generation of these parts into Fluid templates more and more. In this iteration however, the main focus relies on using ModuleTemplate instead of having everything built within Fluid. Resolves: #90326 Releases: master Change-Id: Idfa3f10a43392893e875bbbd2290f7a8557dc8e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63176 Tested-by:
-
Georg Ringer authored
Reset the variables holding information about locale and status to avoid showing wrong output. Resolves: #90334 Releases: master, 9.5 Change-Id: I20cb5847382be28b0aaaf0a8c8afec626cd99c9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63180 Reviewed-by:
-
- Feb 05, 2020
-
-
Benni Mack authored
This patch removes the marker-based template for Web=>Info=>Linkanalyzer and replaces this with custom Fluid Views to move HTML generation out of the PHP code as much as possible, and to remove the dependency to DocumentTemplate. Resolves: #90319 Releases: master Change-Id: I700b6e07f0c7978bea2292d00698e3f659116406 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63173 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
- Feb 04, 2020
-
-
Benni Mack authored
If a page has a shortcut to a MountPoint page, the MP parameter should not be doubled, when the mount_pid_ol flag was set. Resolves: #90322 Releases: master, 9.5 Change-Id: I18a3109b353be2ea3367f6321b1fab1fa771fe7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63174 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
-
Benni Mack authored
This is a pre-patch to fluidize the Backend module and the linkvalidator email as next steps. - Remove unused functionality - Move database calls to linkvalidator table into BrokenLinkRepository (incl. json_decode) - Fix PHP comments and method argument handling Resolves: #90314 Releases: master Change-Id: I1850b182577c72a3ad97247fb33bc164ea5e7925 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63170 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- Feb 03, 2020
-
-
Claus Due authored
Assigns the entire goToalt_doc JS method from the new content wizard controller, which prevents the need for using a JS escaping trick in Fluid. Releases: master, 9.5, 8.7 Resolves: #90283 Change-Id: I9a3a49e4d32f25cf940672101f58da5064e9a478 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63110 Tested-by:
-
Guido Schmechel authored
Redirects do not require a link title, so the title field is removed. Resolves: #90306 Releases: master, 9.5 Change-Id: I3c083a087d800cb142a5fc8f736175402e7284d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63161 Tested-by:
-
Benni Mack authored
ModuleTemplate has been introduced in TYPO3 v7 to supersed DocumentTemplate. LoginController is one of the few places in TYPO3 Backend where the old API is still used. The patch uses ModuleTemplate and avoids using Fluid view in Fluid view by using ModuleTemplates' already established View. Resolves: #90304 Releases: master Change-Id: I2dbee8dd4a031a6ceabd74d6650b9b4cfc6893a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63157 Tested-by:
-
Benni Mack authored
This is a pre-patch for the custom new module to fluidify this backend module. Resolves: #90311 Releases: master Change-Id: I263c179a50c856b44fdd00a344170b093c90f8f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63168 Tested-by:
-
Benni Mack authored
A new FluidEmail class is added that depends on symfony/mime to allow sending templated emails via Fluid (HTML + Text). TYPO3 Install Tool ("Test Mail Setup") and the Backend User Login Notification are migrated to the mail setup, allowing to sending out HTML mails. It is used for some TYPO3-system-based emails, and can be configured on a per-installation level. In addition, a base layout is shipped for TYPO3 messages, so most of the TYPO3-system emails can now be migrated further-on. Resolves: #90266 Releases: master Change-Id: I6961b4ffd7ba39c947f1ce7a85626349c1b4032e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62362 Tested-by:Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Benni Mack authored
With PageLayoutView, the PageLayoutController class shows various options that are not evaluated anymore, and thus, can be streamlined to make adjustments easier. The fields "new_unique_uid", "returnUrl" and "popViewId" is not in use in the Page Module. The ContentLayoutPagePositionMap (UX for choosing a new content element in two steps) is not in use anymore since the modal box (New Content Element Wizard) was added. Resolves: #90309 Releases: master Change-Id: If2c4e8bf3c0bc1a8bc81ce6c9fa417efcef8b428 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63166 Tested-by:
-
Andreas Fernandez authored
To keep compatibility with existing code, the AJAX API now removes undefined values from any payload (either JSON, FormData or SearchParams). Resolves: #90310 Related: #89740 Releases: master Change-Id: I5f36c566036739b62631e3838e8cbdecb46084fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63167 Tested-by:
-
Christian Eßl authored
If an editor has no edit permissions for the default language, but for other languages, then opens the page module and switches to "Languages" mode, the edit permissions are only checked for the language, that is currently selected in the switch. If this is the default langauge, the editor has no edit permissions for, the topbar buttons in the content elements would then also be hidden for all other languages. This commit fixes this issue by independently checking the access permissions for each language. Resolves: #90164 Releases: master, 9.5 Change-Id: Ic5cc7d5a1c09a144744b40aa524e446a39a84a8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63009 Tested-by:
-
Benni Mack authored
In order to decouple Web->Info from Web->Layout, the PageInformationController now contains all code that is needed to render the tree within the module. All renderings relevant for pages are removed from PageLayoutView and moved to PageInformationController. Resolves: #90303 Releases: master Change-Id: I7a66e5d3227b1cef227e48850bf71868e914d783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63156 Tested-by:
-
Benni Mack authored
This change updates fluid standalone to 2.6.9, which solves some PCRE-related issues with recent PHP versions. Composer command used: composer update typo3fluid/fluid Resolves: #90308 Releases: master, 9.5, 8.7 Change-Id: I6ba96f4ab1f46a2b8af58a1b2836397dc9493c40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63163 Tested-by:
-
Benni Mack authored
If a MountPoint page was overlaid with the Mounted page, a redirect was triggered. This happened because the slugs were not identical, so the Mounted Page was not in the list of the slug candidates. The behaviour is now resolved, as the Mounted Page is now added to the candidates and its slug is replaced by the original slug of the MountPoint page. Resolves: #90307 Releases: master, 9.5 Change-Id: I0a5bcc320b92e8a2e99ace49f2f84d56cd0b620b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63162 Tested-by:
-
Simon Gilli authored
This patch converts the $mailSettings['transport_smtp_encrypt'] explicit to a bool as expected by Symfony/Mailer. Additionally this setting is corrected in the admin tool which was not adapted correctly with the introduction of the Symfony/Mailer. Resolves: #90295 Releases: master Change-Id: Ia5f48eec810bfda7936d462c098f5d5eba4332c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63146 Tested-by:
Martin Hotmann <martinhotmann@gmail.com> Tested-by:
-
Benni Mack authored
A lot of code within PageLayoutView is not properly applicable anymore. The next step in this area is to: - Extract Logic for PageInformationController into a separate class - Extract Helper logic for custom content element previews into a separate class Resolves: #90272 Releases: master Change-Id: Ied94677c3a957eb81d18f281afab658c55214b48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63097 Tested-by:
-
Benni Mack authored
The main entry point for the TYPO3 backend is the BackendController. Some changes are made: - Only instantiate necessary code - Use $uriBuilder as property - Use ModuleTemplate's view to not instantiate a Fluid view multiple times This eases the way to lower the usage of DocumentTemplate again. Resolves: #90282 Releases: master Change-Id: I7ebc0f564f898f7451a5821ec357d05bda5bbda4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63109 Tested-by:
-
Elias Häußler authored
If slugs are generated within Backend forms, the visual output (= label below slug field) of the generated slug proposal might be broken if no slash is prepended to the generated slug. This might be the case in custom database tables where custom slug fields are defined with the configuration "prependSlash" set to "false" (which is the default value). It can also be the case if the configuration "prefixParentPageSlug" is set to "false". In order to ensure a clean visual output for those labels, the slug proposalwithin them will now always be prepended by a slash. This makes sure that the resulting url which is shown within those labels is always valid. Note that this only effects visual output and is not meant to modify any slug proposal generated by the SlugHelper class. Resolves: #90222 Releases: master, 9.5 Change-Id: I93587cfec0db6c3d889fdce60a4515ef47decc82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63051 Tested-by: TYPO3com <noreply...
-
Stefan Horst authored
The REPORT HTTP method is specified in RFC 3253. Releases: master, 9.5 Resolves: #90297 Change-Id: Ia78f602266bede3a8cf9d31e320bea7fe385aa08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63147 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
-
Benni Mack authored
The FileList class was originally a derivative of DatabaseRecordList, which was decoupled in TYPO3 v9 and and marked as internal. It is responsible for showing the actual "FileList" in the TYPO3 Backend module. A lot of this code has grown historically, and can be removed and simplified, as it is not directly connected to the abstract record list anymore. This patch removes unused public properties like $JScode as this is part of a "multi-table" setup as is possible in the database listings. Some methods are split into smaller parts to make the methods themselves smaller. This is however just the first step, next to separating the curation and the output (and moving this into a fluid template), also using proper pagination for fetching files and folders, or building DI for the class now is much easier to do. Resolves: #90242 Releases: master Change-Id: Ie66964d9df355a9d74dbe9d0a8a17f9cecdf7c83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63067 Tested-by:
-
- Feb 02, 2020
-
-
Andreas Fernandez authored
The payload sent with the AJAX API is now automatically converted to a JSON-encoded string, if the request's Content-Type header is set to `application/json` or any variant of this. Resolves: #90291 Releases: master Change-Id: Ia81c74d9314fb56de99f4a74e073af7a671b472b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63140 Tested-by:
-
Oliver Hader authored
https://github.com/TYPO3/testing-framework/commit/2111db60e8e1391fabdac4f2253af553f291d460 Resolves: #90294 Releases: master, 9.5 Change-Id: I21d8ad233b753c4a56c2227b4d2fec6944340c81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63144 Tested-by:
-
Oliver Hader authored
Resolves: #90269 Releases: master, 9.5 Change-Id: I7366c213d5d417575b9c85c18728a4fdf4273520 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63142 Tested-by:
-
Oliver Hader authored
Resolves: #90278 Releases: master, 9.5 Change-Id: I158a7ea2c27b0081b3cdf5ee9452f2394cc31593 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63104 Tested-by:
-
