- Jan 04, 2022
-
-
Benjamin Franzke authored
With the changes in #95854, database mounts are no longer sorted by the order they are defined in the group/user settings, but undefined by the order the database returns. DB mounts aren't sorted against each other, that means sorting values are not meaningful anyway, and results in uncontrolable orderings. Explicitly preserve the order using usort(). Also revert groupAndSortPages() to the state prior to #95854, as the forcePid parameter would now be unused. Releases: main, 11.5, 10.4 Resolves: #96359 Related: #95854 Change-Id: I64b8d90c68246cc0ac01abcbf3678aa1055189e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72854 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Christian Kuhn authored
The busybox variant as packaged with the test images based on alpine of mktemp needs six 'X' as template in cglFixMyCommit.sh. It otherwise emits a warning executing the command: > Build/Scripts/runTests.sh -s cglGit Resolves: #96432 Releases: main, 11.5, 10.4 Change-Id: I1c1853aabe79186694161c21f5fe0341e1bd2e75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72874 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Georg Ringer authored
The option "autoplay" only works if "mute" is enabled. See https://developer.chrome.com/blog/autoplay/ for reference. Resolves: #96320 Releases: main, 11.5, 10.4 Change-Id: Ic4e2de0576fe3d1619af8e35274adeb013c72b31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72846 Tested-by:
-
- Dec 30, 2021
-
-
Benjamin Franzke authored
With the changes in #95854, implicit rootPid dbmounts caused duplicated pages in pagetree, because explicit page mounts have been considered multiple times for the pid=0 tree: * First time because of their relationship to pid = 0 * Second time because of their explicit mount (which was sorted into the pid = 0 tree) This happened because #95854 optimized to only use one call to the PageTree repository, which then had the side effect of merging "multiple" pages into one tree, instead of showing "two" separate trees. The patch ensures that multiple page trees are used when the rootPid (0) is included as a webmount. Releases: main, 11.5, 10.4 Resolves: #96367 Related: #95854 Change-Id: I7f421995f2d4aa88bb266fec684565102a4dc080 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72816 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Nikita Hovratov authored
The TCA option "appearance" is an array, with pre-defined configuration keys. The column "custom_stages" of the table "sys_workspace" set a csv value for this option. This does not work. The configuration is now transformed into the correct array format. Resolves: #96437 Releases: main, 11.5, 10.4 Change-Id: I25112d7ea1ce605376d70fa2dabceddd3c121faa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72834 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Dec 27, 2021
-
-
Torben Hansen authored
Added the following Composer plugins as allowed/trusted * composer/package-versions-deprecated * typo3/class-alias-loader * typo3/cms-composer-installers Resolves: #96428 Releases: main, 11.5, 10.4 Change-Id: Iabb8f00411279f502bca1d1ba79714cc58d82d3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72782 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Dec 23, 2021
-
-
Oliver Bartsch authored
This fixes several issues for the case that an editor only has access to translated pages and not to the default language (L=0). Resolves: #95795 Releases: main, 11.5, 10.4 Change-Id: Ied31c7aa5229d3b8686741dd97005f9b5f16ef16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72617 Tested-by:
-
- Dec 21, 2021
-
-
Simon Gilli authored
The core version service now uses the new entry point of the REST API available via https://get.typo3.org/api. The old entry point is still available but should not be longer used. For more information see `https://get.typo3.org/api/doc <https://get.typo3.org/api/doc>`_ and `https://github.com/TYPO3/get.typo3.org/pull/272 <https://github.com/TYPO3/get.typo3.org/pull/272>`_. Resolves: #92020 Releases: main, 11.5, 10.4 Change-Id: I2c92554e9ba212827b6412d4a88ac5c92e26aa17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72757 Tested-by:
-
- Dec 20, 2021
-
-
Sybille Peters authored
Remove the deprecated parameter useCacheHash from Typolink viewhelper documentation (included in comments). The parameters useCacheHash and noCacheHash have been deprecated in TYPO3 v10 and should no longer be used. The change applies to TYPO3 v10 only. Resolves: #91956 Releases: 10.4 Change-Id: I1db7c06307d7e69a48ef91d7bafcdc63ee1e22ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72707 Tested-by:
-
- Dec 17, 2021
-
-
Helmut Hummel authored
Get rid of the select query entirely, which optimises the task to only require one update query instead of one select and possibly multiple update queries and gets rid of doctrine version related incompatibilities with fetching the select result. Resolves: #96369 Related: #87162 Releases: main, 11.5, 10.4 Change-Id: I87b570f5efa3d77ed5f2c5fc0074e84bef4675a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72692 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Dec 15, 2021
-
-
Marc Bastian Heinrichs authored
Resolves: #96308 Releases: main, 11.5, 10.4 Change-Id: Ibcbda7fd97a338d721cf00b38026727e941c72ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72681 Tested-by:
-
Guido Schmechel authored
If a language in the SiteConfig is set to the fallbackType free and there is no translated page for this language, then there is now no generated hreflang. Previously, a link was always generated with default language slug, which lead to 404 page not found. Resolves: #94270 Releases: main, 11.5, 10.4 Change-Id: Ifb261cf388fccbaabbf2bcae9ac805b143c9b42f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72674 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- Dec 14, 2021
-
-
Benni Mack authored
Change-Id: I2427fff61df9c82b8f13145265c3ef95ec076251 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72652 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
Change-Id: Iecf91dfa57e2486f331374db6d6ea6626cbbbfc9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72651 Tested-by:
-
- Dec 13, 2021
-
-
Helmut Hummel authored
With the introduction of site settings being exposed to TypoScript with https://review.typo3.org/64128 it has become important to allow more characters as TypoScript keys. Allowing a slash in addition should cover cases where paths are exposed as keys. Additionally the above change reveals, that the ArrayUtility::flatten method does not properly handle array keys that has dots in between, as those must be escaped to produce a correct result. This change introduces a new flatten method after several failed attempts to guess what fixes might not be breaking. The new method is used in places where no TypoScript is used, as in those the weird edge case behaviour of the flatten method isn't expected anyway. The new method is marked internal until it is decided how to proceed with the flatten method. Resolves: #94646 Releases: main, 10.4 Change-Id: I4ebad8a0beece975702d8601a343aa1fdaaa285c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72120 Tested-by:
-
- Dec 11, 2021
-
-
Benni Mack authored
This avoids an error-prone AJAX call in the backend module. This issue does not happen in TYPO3 v11+ anymore, as the method is not called via AJAX directly anymore. Resolves: #90073 Resolves: #91679 Releases: 10.4 Change-Id: I0dd9caba77352ee60e0e56138bffa3bbc02a98d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72609 Tested-by:
-
- Dec 10, 2021
-
-
linawolf authored
* Adjusts all configuration files using the main branch instead of master * Makes all "Edit on Github" links in the Changelog and System Extension manuals work again after master - main switch. * Fixes all link to Github or Docs using the path containing main instead of master Resolves: #96138 Releases: main, 11.5, 10.4 Change-Id: Ifde73dd2bb8efdbf54eb2ba7625d6f201de9bd11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72573 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Rémy DANIEL authored
If TSFE->set_no_cache is called, either a warning or a notice is triggered, depending if a BE user is connected or not. With this change, the preview mode will trigger a notice instead of a warning. This restores the same behaviour than before #86002. Resolves: #96306 Releases: main, 11.5, 10.4 Change-Id: I40b9b1d90d42f14de2977aca61c24a9fd698ced0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72578 Tested-by:
-
Albrecht Koehnlein authored
Make HTML parser more tolerant for single tags with ending slash but without white spaces. So `<hr/>` already was allowed and internally converted to `<hr />` while parsing the HTML. This patch extends this replace rule to all tags so that also `<br/>` can be used in RTE fields. Resolves: #96307 Releases: main, 11.5, 10.4 Change-Id: I7ba6c88e35804c6b5f991fb6b730fbc3d7a2514e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72580 Tested-by:
-
- Dec 06, 2021
-
-
Christian Kuhn authored
Populate a series of minor deprecations and updates. composer req --dev typo3/testing-framework:^6.15.1 composer req --dev typo3/testing-framework:^6.15.1 -d typo3/sysext/core/ --no-update Resolves: #96265 Releases: 10.4 Change-Id: If8c9e5e9b424e907607edf4d718f92a926c3a15d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72533 Tested-by:
-
Christian Kuhn authored
Additional backport of #96166 to v10 since it is useful for nightly execution, too. Change-Id: I8e461592eecd0a66b0fcf6ee5ab14509ebec8277 Resolves: #96166 Releases: master, 11.5, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72532 Tested-by:
-
Christian Kuhn authored
The patch changes runTests.sh and the container definition to avoid mounting users home, /etc/passwd and /etc/group. yarn based setups need some special treatment but in the end bow to shell power, too. Change-Id: I4e5665d31c5bef4e046e992eddd534ae597cce31 Resolves: #96253 Releases: main, 11.5, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72517 Tested-by:
-
- Dec 04, 2021
-
-
Christian Kuhn authored
APCu cache backend is a shared memory per user and typically bound to the executing posix user-id. Calculating different cache identifiers per user is useless since those won't share the same shm. Resolves: #96232 Releases: master, 11.5, 10.4 Change-Id: If6b6a744828d06d55f2c9b5656aef48193da7384 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72511 Tested-by:
-
- Dec 03, 2021
-
-
Oliver Bartsch authored
A false check in the TER API allowed to use arbitrary version strings, as soon as they start with the known `XXX.XXX.XXX` schema. This will be fixed in TER API. However, core as receiver should also validate the incoming data, before storing them in the database. Therefore, the same version number check, which is used in the TER API, is now also applied in the ExtensionXmlParser. Resolves: #96209 Releases: main, 11.5, 10.4 Change-Id: I487eed34c6b25a5e3841d5263b52b9a73aaf681a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72484 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Dec 01, 2021
-
-
Georg Ringer authored
The translations need to use the language of the current backend user and not the one of the current language of the site in the frontend. Resolves: #96004 Releases: master, 11.5, 10.4 Change-Id: Id409e759de4f0324835cc932f87719147b6e1b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72362 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Nov 29, 2021
-
-
Oliver Hader authored
Resolves: #96133 Releases: main, 11.5, 10.4 Change-Id: Ic1924bbf34b746bf1891419da6cb54e547a509a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72365 Tested-by:
-
- Nov 28, 2021
-
-
Stefan Bürk authored
Creating auto redirects, if page slug is changed, has been extended to add the target with LinkHandler 't3://' uri schema with #89327, adding language argument '_language' to enforce the language for the redirect, missing that that did not worked, which was solved through adding '_language' argument handling in #96043. As language arguments '_language' and 'L' are ignored, if the provided page uid is already the uid of the localized page, the parameter was meaning less. Further this breaks language fallback handling, if the localized page record is deleted. This patch uses now the default language page uid for creating target of auto-redirects to mitigate the issue that redirect will break if localized page is deleted but language fallback is configured. Resolves: #96103 Related: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I2ece06bf053bda4edb542910c3f51b1e6c8e052c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72359 Tested-by:
-
- Nov 25, 2021
-
-
Stefan Bürk authored
This patch fixes a bug where a t3 page URI with _language != 0 was resolved to a page in the default language. This caused automatically generated redirects to translated pages to redirect to the page in the default language. We now use the same override handling for the '_language' parameter (as already existed for 'L') when t3 page URIs are resolved. Also, we ensure that both parameters are always removed when the final URL is generated. Furthermore, this patch adds tests to cover these cases. Using the historical 'L' parameter still works and has been added to be handled as language override. Background information: The '_language parameter' is the preferred parameter to be used to specify the language in a t3 URI, not 'L'. The behaviour of creating auto redirects on slug changes was changed previously: The target was added as LinkHandler URI (instead of the path). Along with this change, the '_language' parameter was used to ensure the target URL is generated in the needed language (#89327). This introduced a problem where a redirect always redirected to the page in default language if a t3: page URI was used with '_language'. Resolves: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I95bdeff4827eed3be30528c02331b9c9ff2836b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72271 Tested-by:
-
- Nov 22, 2021
-
-
Stefan Bürk authored
TCA slug field generator option 'prefixParentPageSlug' has been added to be used for page records only. Slug generation for non-page records with pid=0 has been fixed with #94655 which introduced a endless loop if 'prefixParentPageSlug' is used as slug field generator option for record tables. This patch only process 'prefixParentPageSlug' for page records, thus ignoring it for non-page records and avoiding the endlees loop and as such prevent segmentation faults or memory_limit fatal errors. Resolves: #95485 Related: #94655 Releases: master, 11.5, 10.4 Change-Id: I20e1ac68bad6ad9447b03debbedb646495045ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72257 Tested-by:
-
- Nov 19, 2021
-
-
frpuser authored
Releases: master, 11.5, 10.4 Resolves: #96040 Change-Id: Idc83eedacc1ab00f761e179e394e173a071b6b0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72130 Tested-by:
-
Benjamin Franzke authored
This applies to rendering of database mounts (from groups or from workspaces): They are now shown as children of the virtual root page (uid=0) as it used to be in TYPO3 v8. This is to allow workspace users to get an overview of all changes of all mounts by navigating to the virtual page uid=0. Releases: master, 11.5, 10.4 Resolves: #95854 Related: #95972 Related: #91145 Change-Id: I7f6370f327711396193cf56b63f15876350c2559 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72078 Tested-by:
-
Oliver Bartsch authored
The example for the CommaSeparatedValueProcessor was missing a value for the fieldEnclosure property. This might lead to the assumption that this property can be "unset", which is not the case as it always defaults to a quotation mark ("). This is now fixed by adding an example value. Resolves: #93190 Releases: master Change-Id: If4ee5f358f71d83d0117cf0e9c2e07c619966b9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72122 Tested-by:
-
- Nov 17, 2021
-
-
Simon Gilli authored
docker on mac and windows WSL2 encapsulate a VM into the system. The current xdebug remote config does not work in those cases since the host IP can not be determined with the current solution. Switching to host.docker.internal works for macOS and WSL2, and works for linux too in combination with an extra_hosts setting. This requires linux to use at least docker 20.10, which shouldn't be a huge issue with casual developer machines. Resolves: #95999 Resolves: #94932 Releases: master, 10.4 Change-Id: I02acfeefc08f338841b4fecdb952c7da37ff65e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72218 Tested-by:
-
Christian Kuhn authored
Switching to 20.10 gives us a feature we need in runTests.sh. Resolves: #96013 Related: #94932 Related: #95999 Releases: master, 10.4 Change-Id: I7eef83c130b76cab84dff7d595b7807d34b22ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72213 Tested-by:
-
Henrik Ziegenhain authored
The identifier from the linkHandler page TSconfig was formerly used as the reference table name "ref_table". This identifier is free to choose and shouldn't be interpreted as a name of a table. In order to resolve the correct table name, which is stated in the configuration, the page id of the reference record is now used. This allows the TypolinkSoftReferenceParser to read the according page TSconfig and to set the correct table name. Resolves: #95380 Releases: master, 10.4 Change-Id: I28817a7267a107df27828d99f7e0cf2eeaaf2de1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72202 Tested-by:
Henrik Ziegenhain <henrik@ziegenhain.me> Tested-by:
-
- Nov 15, 2021
-
-
Nicole Cordes authored
The ConditionMatcher tries to resolve the current page id from global variables. One of this possibilities uses the cmdMap that is sent to the DataHandler. This patch ensures that the correct target uid is used to resolve the page id. Resolves: #95967 Releases: master, 10.4 Change-Id: I0fb7968c3118f2ab78c1cbb1dda3643e9f2f450e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72119 Tested-by:
-
Benjamin Franzke authored
empty() returns true if a record contains 0 as value. Therefore isset() needs to be used instead. The corresponding fix that was introduced with #91145 to workaround this flaw is removed again. Change-Id: I7286cf2337e3d7c942844881f95041bc54f8e811 Resolves: #95972 Related: #91145 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72117 Tested-by:
-
Simon Gilli authored
This patch applies the current recommendations for BASH scripts see https://github.com/koalaman/shellcheck#readme. Resolves: #95964 Releases: master, 10.4 Change-Id: I21ba18cb151acc0ff8f33a2135ef289669d15bab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72179 Tested-by:
-
Christian Kuhn authored
Brings a series of core v11 relevant PHP 8.1 E_ALL preparations and a couple of minor details. composer req --dev typo3/testing-framework:^6.13.0 mikey179/vfsstream:^1.6.10 composer req --dev typo3/testing-framework:^6.13.0 mikey179/vfsstream:^1.6.10 -d typo3/sysext/core/ --no-update Change-Id: I140866e8fb7014efbc33b7c1f25b2f840bd19ce2 Resolves: #95979 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72177 Tested-by:
-
- Nov 11, 2021
-
-
Gabe Troyan authored
Currently, the value of `USdateFormat` is disregarded because the corresponding property, `FormEngineValidation.USmode`, is set to zero regardless in `FormEngineValidation.initialize()`. This change will ensure that `USmode` will remain 1 without conflicting with core functionality that relies on `USmode` being set *before* `initialize()` is called. Resolves: #86679 Releases: master, 10.4 Related-to: #91105 Change-Id: I5584ca7fe92742e28147f9883fedf53e0556f1b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72116 Tested-by:
-
