- Feb 10, 2023
-
-
Christian Kuhn authored
Get the registry injected in UpgradeWizardsService and get the service injected in InstallStatusReport. Resolves: #99924 Releases: main Change-Id: I988ba9146fa540f4ca529e0050c861a44b48c071 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77826 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Benni Mack authored
Used command: composer req --dev "friendsofphp/php-cs-fixer:^3.14.4" -W Resolves: #99925 Releases: main Change-Id: I835e44bd1a0eef9ccbeb27863cac0eb0209552a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77718 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Fernandez authored
This patch introduces a new global `LiveSearchConfigurator` module that can be used anywhere in the TYPO3 backend to load configuration of the Live Search. The methods `LiveSearch.addRenderer()` and `LiveSearch.addInvokeHandler()` were removed. Instead, `LiveSearchConfigurator` should be used. Web components where thinned out to not rely on getting such configuration handed in anymore. However, there's a small API change: `LiveSearchConfigurator.addRenderer()` now requires a new argument `module` to be able to load modules on-demand if they were not loaded already in the current backend scope. Resolves: #99891 Releases: main Change-Id: I30d9562b92671d0c6d1f8d1234dfcdd9da742a3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77796 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Christian Kuhn authored
The constructor argument is unused in core for this internal class and can be removed. This frees the constructor to be used for DI easily. Resolves: #99921 Related: #94745 Releases: main Change-Id: If48dc098adb308cab7c46558591dca5fff945ef6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77824 Tested-by:
-
Benni Mack authored
Site Configuration of a language has a lot of option, one of them being "direction", defining the direction of the language for Frontend Output. Guess what? There are exactly 15 languages in the world which have a "right-to-left" direction, and the HTML standard actually defines that "ltr" (left to right) does not need to be set. So this check is now done automatically. The option is now removed from the GUI, however previous settings still apply. Resolves: #99916 Releases: main Change-Id: Icc98e6514658ab6915be25f012b02d2c0b76b38d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77814 Tested-by:
-
Andreas Fernandez authored
When listing the contents of the folder "form_definitions", `ProcessFileListActionsEventListener` modifies the available actions in that directory by setting any disallowed action to `null`. With #99861, a necessary null check was removed, leading to PHP warnings. To solve the issue, `ProcessFileListActionsEventListener` now unsets disallowed actions. Additionally, the `array_filter()` call to remove empty actions is now executed after handling the `ProcessFileListActionsEvent` event. Resolves: #99915 Related: #99861 Releases: main Change-Id: Ia04ac7f3d6db3eb986e6eaad3e3d41f8a6d54bec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77821 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Jochen Roth authored
Currently there is no indication for a user to see if a task group is disabled/hidden. This has been changed by adding a badge for disabled/hidden groups and also another badge for tasks belonging to a disabled group. The "late" badge and "next excecution" are now hidden as well. Resolves: #99849 Releases: main Change-Id: I22a44e6940fe38639999a78e6ebc7e6f65ffb7d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77722 Tested-by:
-
Benjamin Kott authored
The tables within the TYPO3 backend are wrapped within an element with overflow to enable scrolling and make them usable on smaller viewports. The dropdowns with the TYPO3 backend are used in conjunction with button groups as a container that defines the position for child elements relative to the group. While non of these definition is a problem in it self, it leads to clipping dropdowns when used in combination. Dropdown positions are calculated with JavaScript and placed absolute to the next relative container. Since the next container is inside the table that overflows, the dropdown display is cut off. To resolve the issue for all placements, we define the standard behavior of button groups to be static. The parent container to calculate is now outside the table wrapper and the dropdown fully visible. Resolves: #99914 Releases: main Change-Id: I76258852a9984bfce136b54669e90d6fd4967e42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77820 Tested-by:
-
Benjamin Kott authored
The file list is the default implementation for TYPO3 to navigate and manage assets. This patch extends the usage of the file list to the element browser, the build-in component to select the assets for file fields and folder fields in the backend. The rendering of files and folder now deliver a unified experience and allow the user to use the tile view to select assets. The search within the file browser now respects the selected folder and searches all subfolders for the provided search term. To have a even more reliable experience, the user will now always start the selection process in the root folder of the default storage. Resource tiles are now adapting to the surrounding container instead of the viewport, to make better use of the available space. The file list now holds all related code to the file- and folderbrowser. Resolves: #99861 Releases: main Change-Id: I76e9412f552406326777d01c64c6da4a5d44c330 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77592 Tested-by:
-
Sybille Peters authored
Resolves: #99846 Releases: main, 11.5 Change-Id: Ie635412ce817f537c34143aac493e4038e3b9afc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77789 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Thomas Hohn authored
Added Null coalescing operator, when accessing $this->register['SYS_LASTCHANGED']. Resolves: #99876 Releases: main, 11.5 Change-Id: I56a94d20195fdb82000259fdbe3e2eb723695383 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77784 Reviewed-by:
-
Benni Mack authored
With the introduction of the Locale API in 12.2 and its inclusion in SiteLanguage->getLocale(), the property "hreflang" can be completely removed from the Site Configuration, as the Locale API can convert the hreflang property properly into a format like "de-AT" directly. This format is described as IETF RFC 5646 language tag standard: https://www.rfc-editor.org/rfc/rfc5646.html Resolves: #99908 Releases: main Change-Id: Ie712a89b41e5f00d1c592fc3cc978f58712ef0c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77807 Reviewed-by:
-
Oliver Hader authored
Resolves: #99910 Releases: main Change-Id: Ic0ec59b4a646ad4ecc04e8081afe743b5b3cbfcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77813 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Feb 09, 2023
-
-
Benni Mack authored
Due to the introduction of the unified Locale class, the SiteLanguage now resolves the two-letter-iso code from the locale if it wasn't set before. It is thus removed from the GUI when editing or creating site languages, and also automatically populated as fallback, however it is recommended to fill the locale properly and the method is deprecated. Resolves: #99905 Releases: main Change-Id: Ib98a119b97ae81c96e50fda9835adc36ac41eb37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77597 Tested-by:
-
Thomas Hohn authored
Handle faulty HTML tags that can cause a PHP warning. This is done by adding a isset() guard. Resolves: #99896 Releases: main, 11.5 Change-Id: I69c03fa55d7ad3d3f355bf76c43b3fff6e0a1f85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77799 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Thomas Hohn authored
Handle faulty HTML tags missing an ending ' or ". This is done by adding a missing Null coalescing operator. Resolves: #99892 Releases: main, 11.5 Change-Id: I8a514f365699ab15fc0004141597e7e32d7ccb8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77797 Reviewed-by:
-
Jasmina Ließmann authored
The heading in the dropdown content now matches the label already shown as button to open the dropdown in small viewports. With #99742 a heading was introduced to structure the messages listed below. With this change this heading will be removed again. In addition, the standard link markup is now also used in the introductory text. The badge contains the amount of error messages. Badge position is now aligned horizontally in the middle of the row in small viewports. Resolves: #99853 Related: #99742 Related: #99538 Releases: main Change-Id: Iea5a88c6b088ce810fc073a886251e8bfd1c880b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77721 Tested-by:
-
Benjamin Kott authored
To avoid layout shifts when dragging elements in the page layout module, we are now creating a clone that consumes the original space when dragging the element. Resolves: #99903 Releases: main Change-Id: If09463e3b79c9377351a02f0af9ea29c9ad512a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77804 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
Benjamin Kott authored
This patch aligns the appearance of the record list with panels in the backend. - Align checkboxes for multi record selection properly - Streamline recordlist header actions - Streamline first and last child edge padding - Make typo3-backend-new-content-element-wizard-button component immitate button behaviour - Make typo3-recordlist-record-download-button component immitate button behaviour - Correct action spacing in page module Resolves: #99865 Releases: main Change-Id: I7cf439cf9aac1fabf54f76cb7f1cb496e4584620 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77751 Reviewed-by:
-
Christian Kuhn authored
The ext:lowlevel "System > Configuration" table views are now client-side collapsible and search aware, without reload. This is similar to what has been established with "Active TypoScript" and "Active PageTsConfig" already. Change-Id: I7c9f275505881a939b244a470c00e639b35fa30a Resolves: #99899 Related: #99747 Related: #99782 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77794 Reviewed-by:
-
Jochen Roth authored
Hidden task groups are not shown in the dropdown when editing a task. When a task was saved the selected (hidden) group is lost. This has been fixed by extending the query to include hidden groups. Resolves: #99855 Releases: main, 11.5 Change-Id: I8bd94fd3dfad4d0c19e08e8f91904ec2c2f32367 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77724 Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Benjamin Kott authored
With this patch, we are starting to declutter the record list. The search box and Clipboard toggles are now available in the "View" settings of the record list view. This change follows the pattern we already introduced in the file list. For the search box, the level selector is now always visible. Resolves: #99895 Releases: main Change-Id: I55cd65f3eda491d44199d9886610c4d6135acc38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77793 Tested-by:
-
Benni Mack authored
This change removes the default configuration of "typo3Language" in the site language configuration. This served the language key used for rendering translated labels from XLF files. The option is removed from the UI, and if the "typo3Language" is not set in the language configuration, the language is resolved from the locale. In addition, certain values regarding system locales in POSIX format (values such as "C" or "POSIX") are now handled in the Locale class as well. Resolves: #99882 Releases: main Change-Id: Ifeeec5d54984426c792ab59b1af44a01d0cdae5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77726 Reviewed-by:
-
Franz Holzinger authored
use TYPO3\CMS\Core\Http\ApplicationType; Releases: main, 11.5 Resolves: #99888 Change-Id: Ifd2e9bcb46fb08efba5579e2b2ed45605f31157d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77791 Reviewed-by:
-
Alexander Grein authored
The recursive function pagesToFlatArray make use of the page tree repository on two places, which always instantiates the same object. To improve the performance this patch instantiates the page tree only once and stores it in a protected property. Moreover, it adds another protected property editPageAndDefaultLanguageAccess, which holds the general allowance of a backend user to modify pages and access to the default language. This information is needed in the pagesToFlatArray as well and was requested over and over again. Finally, the array_merge construction inside fetchDataAction and filterDataAction was changed to a more performant solution, by merging it after the loop. Overall, this reduces the request time of a page tree ajax call (data and filter) for around 10%. Resolves: #99852 Releases: main, 11.5 Change-Id: I75e8fca96c3eebec72a00e328c634338191d31c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77750 Tested-by:
-
Georg Ringer authored
An empty end date of a scheduler task is valid and must be allowed. Resolves: #99175 Resolves: #99878 Releases: main Change-Id: I7dd1fd515a400e83c7eb71894c973817d0bb6261 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76805 Tested-by:
-
Benjamin Kott authored
Add visible fallback to avoid unnessesary layout shift until component is fully loaded. Resolves: #99890 Releases: main Change-Id: Ie3d49a420e5d7bc45cfef611616836482fd3b0b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77795 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Feb 08, 2023
-
-
Benjamin Kott authored
The editable page component now looks and feels like a regular h1 element, and keeps this appereance when edit mode is triggered. The new edit mode blends in and avoids layout shifts as much as possible. Resolves: #99879 Releases: main Change-Id: Ie21ed58a822731a70342247fc13c1a45a00f2504 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77786 Tested-by:
-
Stefan Bürk authored
Use null coalescing operator to guard against undefined array key "templateName" accesss in `\TYPO3\CMS\Form\Controller\FormEditorController`. Resolves: #99870 Releases: main, 11.5 Change-Id: I3ebc40e6caab8c2f5bb32563848e836171c44f7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77776 Reviewed-by:
-
Oliver Klee authored
Used commands: > composer req doctrine/dbal:^3.6.0 > composer req doctrine/dbal:^3.6.0 --no-update -d typo3/sysext/core/ > composer req doctrine/dbal:^3.6.0 --no-update -d typo3/sysext/install/ > composer req doctrine/dbal:^3.6.0 --no-update -d typo3/sysext/redirects/ > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99875 Releases: main Change-Id: I8105e999a1f0766170da44125f0f21e32ac91e82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77783 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Benjamin Kott authored
Ensure toolbar dropdowns are fully visible if space is available. Resolves: #99862 Releases: main Change-Id: I05272f6a02fa5fd3e808753d47c46cfdb66663b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77736 Tested-by:
-
Benjamin Kott authored
Enable record icons for better orientation and correct display of tree lines. Moving the additional edit button to the end of the table because has the same functionality as clicking the item. The form styling was adjusted and does not look out of place anymore. Resolves: #99871 Releases: main Change-Id: Id26f83b85728c8407b5107582fcd6e2ddbc78f22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77774 Tested-by:
-
- Feb 07, 2023
-
-
Benjamin Kott authored
Executed commands: npm install @typo3/icons@^3.5.0 npm run build Version 3.5.0 onwards the icons for add and remove have been renamed to plus and minus. While an alias exists to ensure that integrations keep working, we are using the new identifiers in core from now on. Element selection icons are now available and used. Resovles: #99869 Releases: main Change-Id: Ied8dbc17e4fe10d24849af4973ab96dadc16ef17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77773 Tested-by:
-
linawolf authored
Merge right after releasing TYPO3 v12.2 Resolves: #99814 Releases: main Change-Id: I973fe516bc72f177c2d7d70bc82ecbe8a1ada104 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77689 Tested-by:
-
Benni Mack authored
Change-Id: Ie632b791d59866eddbe3e22f654fb261b7e02f6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77747 Tested-by:
-
Benni Mack authored
Change-Id: I716386d2d91ecd2f463e4500b592498cade9dea2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77746 Reviewed-by:
-
Oliver Hader authored
This reverts commit d38764ff. Reason for revert: Release script pushed to wrong branch Change-Id: I17778c7f3e0fd7f56a8e22725b7ff02ee0149064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77754 Tested-by:
-
Oliver Hader authored
Change-Id: I93476c966ba30ade007c8f5ada514ef3c286fad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77740 Reviewed-by:
-
Benjamin Franzke authored
As already started in #88304 (but only for NormalizedParams) and later reverted in #89312 (because of cgi-bin problems), PATH_INFO is no longer considered as a preferable SCRIPT_NAME alternative. All known server configurations set SCRIPT_NAME these days to a proper value when cgi.fix_pathinfo is set. The fallback to PATH_INFO has been introduced with the initial revision of TYPO3 and isn't needed at all nowadays, it's actually wrong, as a REQUEST_URI like /index.php/foo/bar would incorrectly be interpreted as $scriptName == "/foo/bar", which let's all calculations on $scriptName fail and even leads to XSS where values derived from $scriptName are printed without being escaped. Also any ORIG_SCRIPT_NAME evaluation is dropped, as this variable contains the SCRIPT_NAME that was set by the webserver configuration before PHP applied cgi.fix_pathinfo. Using ORIG_SCRIPT_NAME effectively meant bypassing PHP's pathinfo fix. It usually contains the cgi-wrapper paths, which is why PATH_INFO was used to overrule wrong ORIG_SCRIPT_NAME values. GeneralUtility::getIndpEnv('PATH_INFO') is adapted to trust the servers PATH_INFO information, now that we no longer allow servers to send SCRIPT_NAME as PATH_INFO (we enforce cgi.fix_pathinfo=1 for CGI installations). The normalized SCRIPT_NAME is now adapted to be encoded as a URL path by default, as all TYPO3 usages expect this to be an URL path. Note that $_SERVER['SCRIPT_NAME'] refers to the servers file system path, not the URL encoded value. This SCRIPT_NAME sanitization actually enables: a) TYPO3 to be run in a subfolder that contains characters that need URL encoding e.g. `/test:site/` – url encoded that'd be `/test3Asite/`. b) prevention of XSS in case third party extensions missed to escape any URL that is derived from SCRIPT_NAME (while making sure that properly escaped output is not double escaped) Resolves: #99651 Related: #88304 Related: #89312 Releases: main, 11.5, 10.4 Change-Id: Ief95253d764665db5182a15ce8ffd02ea02ee61e Security-Bulletin: TYPO3-CORE-SA-2023-001 Security-References: CVE-2023-24814 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77739 Tested-by: -
Benjamin Franzke authored
Make clear that the early-bail out for empty pageArguments is done to prevent setting `disableCaches` to `true`. Also makes that that the $pageNotFoundOnCacheHashError condition is really tied to pageArguments being non-empty. Prevents us from refactoring that code and missing this bit. Resolves: #99860 Related: #99859 Releases: main, 11.5, 10.4 Change-Id: I98ffa3dffe76a37970784979a2c4f2a9a64aa5bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77735 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
