- May 11, 2018
-
-
Frank Naegler authored
Resolves: #84969 Releases: master Change-Id: I871656c436a9ded5c82fbade4a28d5bd5e84de26 Reviewed-on: https://review.typo3.org/56921 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
A lot of functionality has been migrated from TypoScriptFrontendController into middlewares - functionality that has now no direct influence in the so-called controller of the frontend (TSFE) anymore. The respective methods are never called anymore from TYPO3 Core, and extensions that bootstrap their own frontend should ensure that the respective Middlewares are boot up and called, e.g. via custom stacks or just by setting up the "frontend" middleware stack. The following methods are now deprecated: - connectToDB() - checkAlternativeIdMethods() - initializeBackendUser() - handleDataSubmission() - setCSS() - convPOSTCharset() Additionally, there are some methods in TSFE which have been marked as "internal" but had the PHP visibility "public", which were now migrated to "protected". - getPageAndRootline() - checkRootlineForIncludeSection() - setSysPageWhereClause() - checkAndSetAlias() - getHash() - getLockHash() - setUrlIdToken() Resolves: #84965 Releases: master Change-Id: Ia8e29268189179061c09a204bb7275d231fea0dc Reviewed-on: https://review.typo3.org/56916 Tested-by:
Cristian Buja <cristian.buja@intera.it> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Benni Mack authored
This patch is a small summary of clean ups in various places of TYPO3 Core. - EditDocumentController can be simplified to retrieve the closeUrl() - Comment adaptions in GeneralUtility - Comment adaptions and code simplification in ContentObjectRenderer - HMENU debug option can be fetched from TSFE TypoScript directly - TypoLinkBuilder can use "TSFE->initTemplate()" directly to instantiate the TemplateService, and should hand over proper values in the constructor. Resolves: #84966 Releases: master Change-Id: I145b99842eea2a2386742b1525b33a49022c9339 Reviewed-on: https://review.typo3.org/56919 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
TYPO3 Core supports PSR-3 through the LoggerAwareTrait and LoggerAwareInterface since TYPO3 v9 in all available PHP classes via makeInstance() automatically. However, during the migration, ContentObjectRenderer was not replaced. Resolves: #84967 Releases: master Change-Id: I5e3481273f60858fe9bf1d8fed30d27ad1cd5707 Reviewed-on: https://review.typo3.org/56920 Tested-by:
-
Alexander Opitz authored
We should not manipulate document.domain in workspace preview as we need to communicate with our parent master window. Releases: master, 8.7 Resolves: #78401 Change-Id: Id3f581545a5547ca4ab8c46ee204b1c947ff6e56 Reviewed-on: https://review.typo3.org/56843 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- May 10, 2018
-
-
Benni Mack authored
For historical purposes, TimeTracker->push() is called with an empty string in the second parameter, however, as this parameter is optional and set to '' by default as well, the code readability can be improved by just using the first parameter when using TimeTracker->push() Resolves: #84964 Releases: master Change-Id: I37a338268f9b2df9f2a98414075d207b63dc542e Reviewed-on: https://review.typo3.org/56913 Tested-by:
-
Nicole Cordes authored
This patch ensures using an integer value for turning a timestamp to a DateTime object as otherwise a PHP error is thrown. Resolves: #84962 Releases: master, 8.7, 7.6 Change-Id: I18e82c8f91f42c29c4014985a1ad11671b5a31f4 Reviewed-on: https://review.typo3.org/56909 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Guido Schmechel authored
LocalCropScaleMaskHelper generates thumbnails with imageMagickConvert and custom crop parameters. This will overwrite the default settings. Append the GFX/jpg_quality parameter to the convert command. Resolves: #81796 Releases: master Change-Id: Iaa09e8b9134659c9ffba1c2984ef06d2c8250580 Reviewed-on: https://review.typo3.org/56779 Reviewed-by:
Bernhard Kraft <kraftb@think-open.at> Reviewed-by:
Alessandro <alessandro.filira@pallino.it> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Georg Ringer authored
The localization overview within the info module should hide hidden sys_language records as those are also not available to editors in the page or list module. Resolves: #82400 Releases: master, 8.7 Change-Id: I92cdf995c189187682c01beb1d5f5baff934d2cd Reviewed-on: https://review.typo3.org/56432 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
All logic regarding generating preview links for workspaces has been extracted into the "PreviewUriBuilder" method. Previously this was all scattered between the WorkspaceService and the legacy "PreviewHook" which was not used as a hook. Separating this functionality allows to further split up the entry points (Controllers / Handlers) and clean up concerns. Resolves: #84940 Releases: master Change-Id: I648fa12bab29ecb53ae319938d1086f95abfff58 Reviewed-on: https://review.typo3.org/56875 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Stefan Froemken authored
Percona toolkit found some duplicate indices in some ext_tables.sql. Remove or update the mentioned indices. Resolves: #82671 Releases: master,8.7 Change-Id: Icdb60e2ee9f16cad097c0371e258e2c176c3b50c Reviewed-on: https://review.typo3.org/56856 Tested-by:
-
Benni Mack authored
The TypoScript option config.ftu is used to transfer a session via GET parameters. However this option is - unlike other TypoScript settings - evaluted later in a frontend request. This makes it impossible to use the option during various hooks, where redirect URLs are generated. Moving this evaluation to the same place as other TypoScript options solves the issue. Resolves: #84963 Releases: master Change-Id: Icfcc830d9299b362ac13105fa19dda1d418cacc5 Reviewed-on: https://review.typo3.org/56910 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Resolves: #84960 Releases: master Change-Id: I26d76f9e4a636bc47190244f8e388e1bd94c4d50 Reviewed-on: https://review.typo3.org/56907 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Anja authored
composer update typo3/cms-composer-installers Change-Id: I23e4474adf0942fafacd0bc6e61bdf8f9831a704 Resolves: #84959 Releases: master Reviewed-on: https://review.typo3.org/56906 Tested-by:
Massimiliano Fani <massimiliano.fani@gmail.com>
-
Stefan Neufeind authored
Command used: composer require nikic/php-parser ^4.0 Resolves: #84237 Releases: master Change-Id: I7eed5bbc31f2be6084356d86b35231d93bc6ecb2 Reviewed-on: https://review.typo3.org/56128 Tested-by:
-
Torben Hansen authored
This patch enables the localizationStateSelector for the selectTreeElement, so an editor can select the localization state when allowLanguageSynchronization is enabled for the element. Resolves: #84564 Releases: master, 8.7 Change-Id: I7b315bc19b165d7c9603c0a35ee11b03b7f77c4f Reviewed-on: https://review.typo3.org/56487 Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
-
Andreas Fernandez authored
Using `transOrigPointerField` to fetch localized records does not work for records that were copied into a different language via DataHandler's `copyLanguage` command. `BackendUtility::getRecordLocalization()` now takes `translationSource` into consideration to fetch the appropriate localization of a record. Resolves: #84951 Releases: master, 8.7 Change-Id: I8fc9ea3c1fdaf3e54110196c6a27411e0c66b366 Reviewed-on: https://review.typo3.org/56894 Tested-by:
-
Tom Warwick authored
This feature adds some new SEO fields to the Pages TCA. It also introduces a new SEO tab containing all SEO related meta data. The description field is moved to this tab. Other meta data that is not important for SEO, is still on the Metadata tab. Resolves: #84798 Releases: master Change-Id: I75d47d2121d8cc40e10b8df926f2de6f68db6585 Reviewed-on: https://review.typo3.org/56769 Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Gianluca Piccolo <gianluca.piccolo@pallino.it> Tested-by:
-
Guido Schmechel authored
Now also searching for metadata in the filebrowser is possible. The corresponding files are then listed. Resolves: #71644 Releases: master Change-Id: Ibea04dfb716496247ded3c22e9fd326cce5427d8 Reviewed-on: https://review.typo3.org/56891 Tested-by:
Elena Bartolotti <bartolotti.elena@gmail.com> Tested-by:
-
Guido Schmechel authored
When a file gets moved to the recycler folder on delete. The processed files should not be moved to the recycler folder but directly deleted. Resolves: #81836 Releases: master, 8.7 Change-Id: I7a53830ea5d96735243fd9ee89e8c5aa80d084c0 Reviewed-on: https://review.typo3.org/56503 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Andreas Allacher authored
If a link doesn't set a pageType and there is no target that defines a pageType, then forceTypeValue needs to be used instead of always assuming a pageType of 0. With this fix, it is possible to actually use the TypoScript option config.forceTypeValue again. Resolves: #84925 Releases: master, 8.7 Change-Id: Iae6ba57e943489e4d6a6c690a7668d6908d1623e Reviewed-on: https://review.typo3.org/56863 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Alexander Schnitzler authored
Supported since PHP 5.6. This makes the code easier to read and allows to properly document using phpdoc. https://secure.php.net/manual/en/functions.arguments.php#functions.variable-arg-list Releases: master Resolves: #84956 Change-Id: I73256207c114ef3c35a64518dd039dac2e33976a Reviewed-on: https://review.typo3.org/56902 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Mathias Brodala authored
Releases: master, 8.7, 7.6 Resolves: #84947 Change-Id: I4d81174497158b411c291ee51b331c1d3652e4a1 Reviewed-on: https://review.typo3.org/56887 Tested-by:
-
Helmut Hummel authored
Instead of using HttpUtility to redirect and exit the program flow, we now return a proper redirect response in a middleware. Resolves: #84946 Releases: master Change-Id: I397790ea1d46ae46ef41bd9c2f03f3aac079d1a4 Reviewed-on: https://review.typo3.org/56886 Tested-by:
-
- May 09, 2018
-
-
Christian Kuhn authored
Our dependencies are meanwhile phpunit 7 compatible so we can upgrade to it now. Some minor changes in the tests are needed along the way. composer update --with-dependencies \ typo3/testing-framework \ phpunit/phpunit \ codeception/codeception composer require --dev fiunchinho/phpunit-randomizer:^4.0 Change-Id: I161d43a9063b048085f27c5a7ae9249df8d6a2a9 Resolves: #84958 Releases: master Reviewed-on: https://review.typo3.org/56900 Tested-by:
-
Georg Ringer authored
Improve the privacy of users by using the no-cookie domain of youtube by default and just use youtube.com if explicitly set. Resolves: #84843 Releases: master, 8.7, 7.6 Change-Id: I01472f93e32c2011b5494c4670d07f29348016c3 Reviewed-on: https://review.typo3.org/56880 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
-
Anja Leichsenring authored
By removing the graphicFunctions object from global scope, unit tests are easier to add in this area. Change-Id: I8ddf4e0282d42325ecb03c98bede91bf6e1b636c Resolves: #84933 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/56867 Reviewed-by:
-
Helmut Hummel authored
With the introduced cleanup, one removed condition was essential to avoid calling page rendering preparations twice. Resolves: #84945 Releases: master Change-Id: Ic7b977b2d2c52dc619686f95e9001eed4202717b Reviewed-on: https://review.typo3.org/56898 Reviewed-by:
-
Christian Kuhn authored
Two packages are defined in composer.lock that are no dependents of any other package. Remove them: composer remove symfony/polyfill-php54 gecko-packages/gecko-php-unit Change-Id: I1051c78b8f7101e3aa07f543df275b2917a6dd44 Resolves: #84952 Releases: master Reviewed-on: https://review.typo3.org/56897 Reviewed-by:
-
Anja Leichsenring authored
Change-Id: I3d9ef96e3296de676d02aa84a5ebd926b10cae53 Resolves: #84934 Relates: #84583 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/56868 Tested-by:
-
Helmut Hummel authored
The additional isINTincScript check stems from the time where this code was in a separate file, which was included two times and page generation should be skipped for the second inclusion. As INT scripts are only generated during page rendering (or when fetching the page from cache) we can safely remove this condition now. Additionally, we can now easily get rid of the elseif and move the page rendering preparation directly after the same condition is checked later in the code flow. This is fine, because this code does not need to be executed before the lock is released. Last but not least we clean up admin panel messages to clearly distinguish between page generation and rendering preparation. As this is a pure non breaking cleanup, this can safely go into 8.7 branch as well. Resolves: #84945 Releases: master, 8.7 Change-Id: If12b82a549d4cc47619c46f73c5423df70621b1b Reviewed-on: https://review.typo3.org/56884 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- May 08, 2018
-
-
Anja Leichsenring authored
The agent update introduced a higher chromedriver version that caused several acceptance tests to fail. Adjusting wait states brings them back to green. The bamboo plan update now uses a php.ini without xdebug and simplifies the unit test runs in this area, too. And we need a patch for typo3/testing-framework version 3.4.2: composer update typo3/testing-framework Change-Id: Icc7b6b062ad652db2c92ae7a7c5197477abf2b7d Resolves: #84939 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/56885 Reviewed-by:
-
Philipp Wrann authored
When attaching or updating 1:N relations via extbase (INLINE) the parents uid property was taken as parentKey for the relation entity. This behaviour is inconsistant to the FormEngine resulting in wrong weird rendering resconstitution of 1:N relations. This patch sets the _localizedUid of the parent object (if set) as parentKey to the parentKeyFieldColumn. Resolves: #73726 Releases: master Change-Id: I47fa0f05eb46353f5b893fff07f0123325a0d515 Reviewed-on: https://review.typo3.org/46996 Tested-by:
Timo Pfeffer <pfeffer.timo+typo3@gmail.com> Reviewed-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #82579 Releases: master Change-Id: I58165fff637ca72e921057e9441f6bc73f175808 Reviewed-on: https://review.typo3.org/56865 Tested-by:
-
Carsten Dietrich authored
Make the checkbox input field transparent, instead of hiding it completely, so it can still be accessed via keyboard. Use the :focus CSS pseudo-class to highlight the input label with a box shadow, similar to current text input fields. Resolves: #84936 Releases: master Change-Id: I9e176cea1517617c978f05b63d881ab6af99380f Reviewed-on: https://review.typo3.org/56871 Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #84817 Change-Id: Id3d2cc7c47c7ba3ff46b8689970a3c8490261802 Reviewed-on: https://review.typo3.org/56760 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- May 07, 2018
-
-
Christian Kuhn authored
* bamboo composer environment is a9.3.0@dev * Adapt a test result parsing to slightly changed git output in younger versions * Raise a timeout when installing introduction package in ac tests for less false positives. Resolves: #84944 Releases: master Change-Id: I3f0ec103985a96d05d4a42fab8edd92fad219114 Reviewed-on: https://review.typo3.org/56883 Reviewed-by:
-
Helmut Hummel authored
Put labels into the configuration description file to have everything in one place. With that in place, we can put the description directly into the configuration data that is prepared for the edit view. If we do so, we can get rid of the view helper and one method in the configuration service which only returned the labels. Resolves: #84938 Releases: master Change-Id: I12e5cf1ce3873d41789a52e41e6bac87da86cf9e Reviewed-on: https://review.typo3.org/56876 Tested-by:
-
- May 06, 2018
-
-
Benni Mack authored
The AJAX endpoints for the workspaces backend module on the PHP side still are 1:1 like the good old ExtJS times. In order to abstract and separate concerns in this area, and make the AJAX-based endpoints true PSR-7 compliant requests and responses, some cleanups are necessary. In this first step, the AbstractHandler is removed, as some methods can be removed or simplified in the child classes. Resolves: #84937 Releases: master Change-Id: If390d4b51d19059b18f579691371669c27a337d4 Reviewed-on: https://review.typo3.org/56872 Tested-by:
-
Benni Mack authored
The sort-subpages functionality available in the context menu of a page now also allows to sort by nav_title. This also fixes a typo ("create" instead of "crdate") and streamlines some templating functionality. Resolves: #84932 Releases: master Change-Id: I5a59745214c7cb1682e652efb865fcd949a0e413 Reviewed-on: https://review.typo3.org/56866 Reviewed-by:
-
