- Mar 05, 2024
-
-
Benjamin Franzke authored
This reverts commit 4fda3505. Reason for revert: The patch has been merged with too few votes. Change-Id: I50e4b27adad119fdd9634276a60f1d6200838f8a Releases: main, 12.4 Resolves: #103287 Reverts: #103240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83215 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Willi Wehmeier authored
The thumbCode method in the BackendUtility sets the filename as the alt text for images. That's why the backend representation of content elements like textmedia doesn't respect any set alternative text, whether it's set in the file_reference or the sys_file record itself. This change uses the alternative text and only sets the filename as a fallback if there's no alternative text provided for the file. Resolves: #103285 Releases: main, 12.4 Change-Id: I3c11bb7a56f001e37eafdd1f0a998cb51fb2b460 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83232 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benjamin Franzke authored
A local instance can sometimes be easier to debug and browser issues can be introspected, when acceptance tests are possible to be run on the host instead of in containers only. Allow to run acceptance tests against a local server using a local chromedriver. Also avoid the usage of precalculated session hashes, which has no clear advantage, but requires codecept to perform database connections directly: The tests now login via the backend login form instead and store the session cookies between test runs. As a side effect the codeception suites are cleaned up, to use more efficient module config, instead of redundantly repeating all WebDriver settings for headless and non-headless environment. To execute codeception with local chromedriver against a custom server URL run: chromedriver --silent & # use `killall chromedriver` when done typo3TestingAcceptanceBaseUrl=https://mycore.example.com/ \ typo3TestingAcceptanceAdminPassword=...
-
- Mar 04, 2024
-
-
Oliver Bartsch authored
The trigger to open the context menu is now a proper `button` element. Resolves: #103269 Releases: main, 12.4 Change-Id: Ia3932e4932ccd347b6816e08ee763420c70fbbba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83202 Tested-by:
-
Oliver Bartsch authored
With #102992, the delimiter for the allowed / disallowed list in the `bparams` parameter has been changed from `;` to `~`. To not break the display in the FileBrowser, the old syntax is respected as fallback in v12 with corresponding deprecation message. Resolves: #103178 Related: #102992 Releases: 12.4 Change-Id: Ie5ff38bb2c4c898e8c45fca02da08f9adb16619e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83180 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Oliver Bartsch authored
The FileLinkHandler, used to select a file in the link wizard does now also allow to search for files, like it's also possible in the FileBrowser already. Resolves: #103241 Releases: main, 12.4 Change-Id: Icf3ded3d317e5fbdbd4bc17db0e5969f7b2a055f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83111 Tested-by:
-
Oliver Hader authored
Resolves: #103190 Releases: main, 12.4 Change-Id: Icb71b994b3ca14463dbb86b91551af6d60918096 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83110 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Kienast authored
Google gradually rolls out the `gad_source` parameter as a replacement for the already excluded `gad` parameter. This patch modifies the exclude list. Resolves: #103264 Releases: main, 12.4, 11.5 Change-Id: I4feacd48ed2cd1640e4d7a4ba95470e8702303d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83108 Reviewed-by:
-
Lina Wolf authored
Releases: main, 12.4 Resolves: #103262 Change-Id: I30f4c1c7fd0f27b1712bbead42ceea6bf5f5e0f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83107 Tested-by:
-
André Buchmann authored
The documentation is updated to reflect that pages.no_index=1 also removes a page from the XML Sitemap. Releases: main, 12.4 Resolves: #103259 Change-Id: Ifab520afad4afca29e7fa20bbc342e384a6d65b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83106 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Simon Schaufelberger authored
For some fluid templates, the namespace has been migrated from the "{namespace}" notation to the html tag notation. Additionally, some formatting was applied. Resolves: #103240 Releases: main, 12.4 Change-Id: Ia6873fa0707df0b0c95b6933f7e9bac26442cae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83104 Tested-by:Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
Andreas Kienast authored
This commit changes the rendering behavior of context menus. Previously, the context menu became visible once the server requests were handled successfully. This is an issue in scenarios where either the server is under load and may need some time to send a response, or the network connectivity of the backend user is not optimal. Now, when requesting a context menu, it's container is shown before any data is received and a spinner is rendered. Resolves: #103197 Releases: main, 12.4 Change-Id: I0cd36976a407bce7ce45520d86d7d28a5719cd92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83187 Tested-by:
-
Benjamin Franzke authored
Read mouse position from the triggering event instead of relying on values from a throttled mousemove event, which caused race conditions where mouse position was not updated at all when moving the mouse from iframe to outer frame. Resolves: #103044 Releases: main, 12.4 Change-Id: If22aee7eea958969fb3e7e24b15523897b70e1ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83185 Tested-by:
-
Andreas Kienast authored
When (de-)mounting pages in the page tree, always two requests are sent to the server that fetch the tree data: * when the `mountPointPath` path property is changed as it's a state property * explicitly after changing said property Especially when de-mounting a page, this tends to race conditions, as the mount state is additionally stored in the backend user's UC that needs to get unset as well. This bugfix now changes the handling when the state property, that triggers a re-rendering of the tree component, is updated. The de-mounting process now unsets the backend user's UC first and then changes the property to make sure that 1. the state is updated once the configuration is flushed 2. the tree nodes are fetched only once In the mounting process, the UC is correctly updated first. However, the state was updated and then the nodes were reloaded explicitly. The latter is not required at all. Resolves: #103185 Releases: main, 12.4, 11.5 Change-Id: I7a06852c6af40e1a41691a7cc7acd41db4f84adc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83089 Tested-by:
-
- Mar 02, 2024
-
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Replace sphinx-only syntax * remove superfluous genindex, it is not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backports need manual changes to the guides.xml. Resolves: #103238 Releases: main, 12.4, 11.5 Change-Id: I5d9239a9217d8d6c2faa08cef58436971ee83113 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83102 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Christian Kuhn authored
The page tree can be colored using user TS, example for page uid '65' and all pages below: `options.pageTree.backgroundColor.65 = #41afd8` If a record is changed in workspaces, that page is also colored. In v11, the 'ws changed' color has a higher priority than the custom background color, which is good UX wise. This stopped working in v12 with #97344. v13 is not affected since the "color approach" has been changed. The v12 patch is to re-add the "ws changed" color as "fill" with an !important, to force overriding the svg inline style of the custom background color, similar to v11. Resolves: #103239 Related: #97344 Releases: 12.4 Change-Id: I8e9eee7d85fb2ca18c28247f9fdcb68dc7a9139f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83172 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Mar 01, 2024
-
-
Oliver Bartsch authored
Resolves: #102451 Releases: main, 12.4 Change-Id: I50944fe4eb4aa1557c6289f9ae8eefe67717fb75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83101 Reviewed-by:
-
Willi Wehmeier authored
To deliver a meaningful tooltip text for screenreaders the title of the page is added to the tooltip message in the pagetree view. Resolves: #102451 Releases: main, 12.4 Change-Id: I8af2e3652d38abb6b2a090c2f8bd0e4427ab255a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83100 Tested-by:
-
- Feb 29, 2024
-
-
Christian Kuhn authored
When a record localization is changed in workspaces, `transOrigPointerField` ("l10n_parent") can point to either the default language -live-, OR default language -workspace- record, depending on workspace action chains as detailed below. FormEngine did not deal with that properly when `showPossibleLocalizationRecords` for inline (or file) children is enabled, and did tend to show a possible localization child even though a record has been localized already ("shown twice"). This issue exists for a long time already, but became more obvious with #94623, which enabled `showPossibleLocalizationRecords` for tt_content image. The main fix of the patch is to make FormEngine aware of this scenario and suppress listing a localized workspace record as "can be synchronized" when its l10n_parent field points to live. As drive-by, the patch fixes a missing reference index update call in DH when "synchronizing" a relation in workspaces. The patch also adds some `@todo`s to point out situations where the "parent count" fields are incorrect. The added tests show scenarios where a localized workspace record points to either its live, or its workspace default language "parent" in the "l10n_parent" field. We're adding the tests for FAL, but the situation is similar with parent (here: tt_content), with inline csv and inline foreign field: a) modifyContentLocalizeAddDefaultLangRelationSynchronize() Having a content element and a localization in live. Add an image in workspace default language and synchronize into workspace localized record: l10n_parent of new localized sys_file_reference points to the workspace sys_file_reference record. This is quite obvious, since there is no live record to point to. b) localizeLiveModifyWsLocalizationAddLiveWsSync() Having a content element and a localization in live. Modify the localization in workspaces, by for instance changing the title of the content element. This creates a workspace overlay of that localized element in workspaces. Then add an image to the default language live content element, and synchronize this in the localized workspace element. Now, l10n_parent of the new localized sys_file_reference points to the live sys_file_reference record. This is because an overlay of the default language record does not exist. c) localizeLiveModifyWsDefaultLang() Having a content element with image and a localization in live. Modify the default content element in workspaces, by for instance changing the title of the content element. This creates workspace overlays of the default language record, *and* overlays of the localized content elements. It also creates overlays of the attached images in both the default language record and its localizations. l10n_parent of the sys_file_reference localized records now point to the live version. This scenario is debatable since overlays of the default language record exist. We decided to keep this behavior, since we'd otherwise have to deal with updating these pointers when publishing localizations. Change-Id: Iaab27586ff19cdc5f491324ca6dbc2cceff73373 Resolves: #97548 Resolves: #89858 Related: #94623 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83165 Tested-by: -
Andreas Kienast authored
The Lit element `typo3-backend-spinner` uses a hard-coded SVG string, which has to be the same as the `spinner-circle` asset file. However, the SVG string was outdated as it neither respected the `currentColor`, nor respected the configured icon size. Both issues are fixed in this commit. Since `currentColor` is now taken into account, the variant styling has been removed. Resolves: #103198 Releases: main, 12.4 Change-Id: I24eababb8716076eb4db55a6bcd3eb43e98ea1fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83164 Tested-by:
-
- Feb 28, 2024
-
-
Till Hörner authored
Resolves: #103221 Releases: main, 12.4 Change-Id: I4089a733f9ce2c888c05a4f1e4f7834a00ad1bfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83099 Tested-by:
-
Markus Klein authored
In relation mode "manyToMany" it is okay to have a limit of one. Code-wise the FlexForm code is slightly simplified as there is no support for the "manytoMany" case. Resolves: #103188 Releases: main, 12.4, 11.5 Change-Id: Ib2bbafadefc39f603a9ec4fda20aebcee85cdd7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83113 Tested-by:
-
- Feb 26, 2024
-
-
Christian Kuhn authored
Use the attribute in favor of `@dataProvider` annotation. Adapt the acceptance test splitter to deal with it. Clean up annotationChecker to no longer allow `@dataProvider` and disallow a series of further not used annotations along the way. Resolves: #103204 Related: #103180 Releases: main, 12.4 Change-Id: If8e4d5a87d07d574065d596acb4c44a48f265ffa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83138 Tested-by:
-
Mathias Brodala authored
Resolves: #103202 Releases: main, 12.4 Related: #40096 Change-Id: If64a5d16da9d500180d070b8d5f6a7fd96609010 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83137 Tested-by:
-
Christian Kuhn authored
Unblocks phpunit 11, backport to v12 to keep php-cs-fixer in sync. > composer req --dev friendsofphp/php-cs-fixer:^3.50 Resolves: #103200 Releases: main, 12.4 Change-Id: I1ab390c816caf3eabba00e8404d00fe2c9009fd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83134 Tested-by:
-
Christian Kuhn authored
phpunit 11 deprecates annotations like `@test` and `@dataProvider` in favor of their attribute counterparts. We'll adapt core main & v12 to keep v12 backports simple. The patch takes care of Tests/Functional and Tests/FunctionalDeprecated. Script `Build/Scripts/splitFunctionalTests.php` is adapted to deal with annotations for CI to continue splitting functional tests into chunks. This also fixes detection in two test cases that had unexpected `@test` annotation combinations which were not properly detected before. > composer req --dev rector/rector > wget https://forge.typo3.org/attachments/download/38273/rector.php > find typo3/ -name \*Test.php | grep Tests/Functional | xargs bin/rector process > rm rector.php > composer rem --dev rector/rector Minor manual adaption in a few files plus cgl fixes. Also deny `@test` annotion in annotationChecker.php now to not introduce new occurences with other patches anymore. The script will receive another cleanup...
-
- Feb 25, 2024
-
-
Oliver Bartsch authored
Resolves: #103192 Releases: main, 12.4 Change-Id: I81c0c655b75332790243c05be14f24593c5b9d6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83098 Tested-by:
-
- Feb 24, 2024
-
-
Oliver Klee authored
Due to a typo, #103193 downgraded the minimum required phpstan/phpstan-phpunit version. Executed command: composer require --dev \ phpstan/phpstan-phpunit:^1.3.16 Resolves: #103194 Related: #103193 Releases: main, 12.4 Change-Id: Ied12668b57b500a42bdb9f901952094cd48bd1b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83123 Tested-by: -
Oliver Klee authored
The new version changes the format of a warning. Executed commands: composer require --dev \ phpstan/phpstan:^1.10.59 \ phpstan/phpdoc-parser:^1.26.0 \ phpstan/phpstan-phpunit:^1.2.16 ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #103193 Releases: main, 12.4 Change-Id: I36a6b4f98e03b73dbf076d84ce1ea900c26fcfb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83121 Tested-by:
-
- Feb 23, 2024
-
-
Oliver Bartsch authored
A couple of places (mostly paginations) are using the action ViewHelpers without providing the `action` argument. Those links will therefore fall back to the default action, which might be wrong e.g. in the backend user group listing. To preserve the current action on paginating, the corresponding action is now always set. Resolves: #103189 Related: #101729 Releases: main, 12.4 Change-Id: I1db9a637a4b320f90aae3a93fe903c939384ea3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83117 Tested-by:
-
tiggr authored
fixes error introduced by https://review.typo3.org/c/Packages/TYPO3.CMS/+/83080 Releases: main, 12.4 Resolves: #103191 Related: #103181 Change-Id: I4636c5c0f39beff6824ec7fb967993087c2fdbc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83097 Tested-by:
-
Christian Kuhn authored
phpunit 11 deprecates annotations like `@test` and `@dataProvider` in favor of their attribute counterparts. We'll adapt core main & v12 to keep v12 backports simple. The patch takes care of Tests/Unit and Tests/UnitDeprecated, functional test need some additional quirk for the test splitter to continue to work. > composer req --dev rector/rector > wget https://forge.typo3.org/attachments/download/38273/rector.php > find typo3/ -name \*Test.php | grep Tests/Unit | xargs bin/rector process > rm rector.php > composer rem --dev rector/rector Minor manual adaption in ErrorHandlerTest.php and GeneralUtilityTest.php, and `runTests.sh -s cglGit`. Number of executed unit tests and unitDeprecated tests should stay the same. Change-Id: I63d2be40b8aa022f0918edd8dc1c360017316c46 Resolves: #103180 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83091 Tested-by:
-
tiggr authored
To add a custom table to the list of tables, the corresponding TCA field name "table_name" has to be used. Releases: main, 12.4 Resolves: #103181 Change-Id: I1349465f320f882f2cf628a34dd445ceef375f2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83096 Tested-by:
-
Oliver Bartsch authored
A couple of tests are adding services to a container instance. Since the `ContainerInterface` does not define the used `set()` method, the tests are adjusted to explicitly require the symfony service container, which provides mentioned `set()` method. Resolves: #103183 Releases: main, 12.4 Change-Id: Icdb36a0ea871d79cd2c280d5f17a00569b49cb2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83088 Tested-by:
-
Oliver Bartsch authored
Resolves: #103182 Releases: main, 12.4 Change-Id: If16e37c638a07e3afbb59d665141cc2ade583f4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83095 Tested-by:
-
Benjamin Franzke authored
The event provides access to the `$resultArray` and documents that it can be modified to set `javaScriptModules`, but missed to take the resulting data into account. Releases: main, 12.4 Resolves: #103174 Change-Id: I0a53d1fbcdff0a3d57de237b44d3ff68f60c721d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83081 Reviewed-by:
-
Benjamin Franzke authored
When CKEditor5 `contentsCss` configuration options references multiple CSS, respective `fetch()` requests may finish in non-sequential order, depending on server load and file size, causing intended CSS ordering to break. Ensure sequential ordering by waiting for all promises to be settled via `Promise.allSettled()`. It is guaranteed to return the promise status and values "in the order of the promises passed, regardless of completion order": https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/allSettled#return_value Releases: main, 12.4 Resolves: #103152 Related: #100768 Change-Id: I5954b438cc6b8c6d74c81fda0227e963d7d89cf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83094 Tested-by:
-
- Feb 22, 2024
-
-
Benjamin Franzke authored
Using timestamps as array keys in form yaml configuration can result in sparse [1] JavaScript arrays which contain "empty slots". Example yaml configuration: templateRootPaths: 1708504268: 'EXT:example/Resources/Private/Emails/Templates' This value is properly serialized into an object by PHP json_encode (as it does not contain sequential integer keys starting at 0), but the FormEditor data model produces arrays from numerical keys during clone operations of such data sets and basically creates sparse arrays like: > const example = [] > example[1708504268] = 'EXT:example/Resources/Private/Emails/Templates' > console.log(example) [ <1708504268 empty items>, 'EXT:forms_extended/Resources/Private/Emails/Templates' ] Some array-looping operations like Array.reduce() will loop through all empty slots [1] and therefore preduce a lot of processing load (1708504269 loops for the example above) that ultimately cause freezes. The array to object copy operation is now replaced by a modern spread operation that is defined to skip empty slots. [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Indexed_collections#sparse_arrays Releases: main, 12.4, 11.5 Resolves: #103168 Change-Id: I10b586ff5c5b0fb3698bfbbe28b2f93d932b71a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83079 Reviewed-by: -
Torben Hansen authored
With #103046, `encryptionKey` has been removed from `DefaultConfiguration.php`. This leads to PHP array key warnings in unit tests. The patch sets it for various tests. Resolves: #103148 Related: #103046 Releases: main, 12.4, 11.5 Change-Id: Ife279449c2db569c8d63a0cc19009f1a3ca278d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83074 Reviewed-by:
-
Stefan Bürk authored
The command dispatch for `-s phpstanGenerateBaseline` is modified to a simple command dispatch instead of the bash expansion - which is not needed in this case. Resolves: #103106 Releases: main, 12.4, 11.5 Change-Id: I771945f2a0751cbf4d350ffe0e8e8f2d78a04d86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83092 Reviewed-by:
-
