- Nov 17, 2021
-
-
Oliver Bartsch authored
The FilesProcessor previously exploded the comma separated list of file collection uids with trimExplode. However, the underlying FileCollector method expects the uids to be of type int. Therefore, the data processor now uses GU::intExplode(), like already done in FileContentObject, instead. Resolves: #93193 Releases: master Change-Id: Ib0923b1484993793e1dd50be395fac78aa61cda7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72204 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Hader authored
Resolves: #96014 Releases: master Change-Id: Ia6fea96a2af2572f5e2c0115aed99c514a168b8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72215 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Simon Gilli authored
docker on mac and windows WSL2 encapsulate a VM into the system. The current xdebug remote config does not work in those cases since the host IP can not be determined with the current solution. Switching to host.docker.internal works for macOS and WSL2, and works for linux too in combination with an extra_hosts setting. This requires linux to use at least docker 20.10, which shouldn't be a huge issue with casual developer machines. Resolves: #95999 Resolves: #94932 Releases: master, 10.4 Change-Id: I02acfeefc08f338841b4fecdb952c7da37ff65e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72194 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Christian Kuhn authored
Switching to 20.10 gives us a feature we need in runTests.sh. Resolves: #96013 Related: #94932 Related: #95999 Releases: master, 10.4 Change-Id: I7eef83c130b76cab84dff7d595b7807d34b22ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72212 Tested-by:
-
Oliver Hader authored
HtmlWorker (triggered by f:transform.html view helper) issued a PHP warning concering an empty Document Fragment when the markup to be parsed is an empty string (`''`). Resolves: #95867 Releases: master Change-Id: I9018274d9f16b20550a8ac5b740753e33737b867 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72210 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
The example for the CommaSeparatedValueProcessor was missing a value for the fieldEnclosure property. This might lead to the assumption that this property can be "unset", which is not the case as it always defaults to a quotation mark ("). This is now fixed by adding an example value. Resolves: #93190 Releases: master Change-Id: If4ee5f358f71d83d0117cf0e9c2e07c619966b9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72203 Tested-by: -
Sybille Peters authored
Fix a problem in the GUI where the previous page "depth" selector ("Show this level") was not remembered when selecting a different page in the page tree. Resolves: #95893 Releases: master Change-Id: Ifdb90ac21701dd9ad2a87a1864f24d32e6dd1f8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72197 Tested-by: -
Torben Hansen authored
Ensure the first argument passed to $this->cImage() is a string if file is not defined in conf array. Resolves: #96008 Releases: master Change-Id: Icf84fd7fad66da4f248e3216ab4b79ac995a69c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72200 Tested-by:
-
Helmut Hummel authored
Fatal error can occur, when the file variable isn't a string, which only happens, when file processing failed or the resolved file isn't an image. Nevertheless the fatal error should be avoided. Also clean up some variable usage to not change the type of variable and remove some not needed isset() check for better readability. Resolves: #91681 Releases: master, 10.4 Change-Id: Ibde8e1105fa7c0e233656b5dd49e083b6c7259ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64908 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Helmut Hummel authored
With the introduction of site settings being exposed to TypoScript with https://review.typo3.org/64128 it has become important to allow more characters as TypoScript keys. Allowing a slash in addition should cover cases where paths are exposed as keys. Additionally the above change reveals, that the ArrayUtility::flatten method does not properly handle array keys that has dots in between, as those must be escaped to produce a correct result. This change introduces a new flatten method after several failed attempts to guess what fixes might not be breaking. The new method is used in places where no TypoScript is used, as in those the weird edge case behaviour of the flatten method isn't expected anyway. The new method is marked internal until it is decided how to proceed with the flatten method. Resolves: #94646 Releases: master, 10.4 Change-Id: I4ebad8a0beece975702d8601a343aa1fdaaa285c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70115 Tested-by:
-
Daniel Goerz authored
EXT:impexp EXT:indexed_search EXT:info EXT:install Resolves: #94264 Releases: master Change-Id: I0799fce1f3f316a4b6e0925f6813738a2c53f8a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69394 Tested-by:
-
- Nov 16, 2021
-
-
Florian Rival authored
Resolves: #95993 Releases: master Change-Id: I8eb6e779ae1d0f02bf8ef0fe3fb5dd02b751cb47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72190 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Oliver Bartsch authored
In #94688, the table layout of form fields had been replaced by a grid layout. However, some places did not receive the new classes, leading to display error. This is fixed by adding the corresponding classes to those places. Resolves: #95994 Relates: #94688 Releases: master Change-Id: Iba3ea2d3f665d055864edd9c8329dac939aa2642 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72191 Tested-by:
-
Oliver Bartsch authored
Resolves: #95995 Releases: master Change-Id: I6faea581aba0ca9171a6b79c94c1371c56b60387 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72192 Tested-by:
-
Oliver Hader authored
Schedule task "Table Garbage Collection" uses inline JavaScript to declare default values for different database tables. Besides that proper prototype functions instead of closures assigned to properties are used - which require proper scoping with `bind()`. Resolves: #95989 Releases: master Change-Id: I78ff7903716b52c6d625e41237dd6c02c6b9af54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72185 Tested-by:
-
Oliver Bartsch authored
The browser notification API has been introduced in #90666. Due to various reason it had been removed again in #92988. This patch removes some leftover language labels. Resolves: #95991 Related: #92988 Releases: master Change-Id: Ib25b42c1734f5c6b19c9575e3dfe6797b6e085a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72189 Tested-by:
-
Anja Leichsenring authored
ext:irre_tutorial has two relations to tx_irretutorial_1nff_hotel from tt_content: One from native field tx_irretutorial_1nff_hotels and one from within flex for field tx_irretutorial_flexform. With two relations in place, both need a foreign_match_fields definition written to the child table to distinguish the two relations. This is missing for tx_irretutorial_1nff_hotels and leads to the situation that adding a relation to the flex field is then shown as relation for the native field, too. The patch adds a foreign_match_fields definition to the native field and adapts the .csv test cases accordingly. Resolves: #95986 Releases: master Change-Id: I19f36990f1b6a699029b56b4bf62690128a5bb67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72181 Tested-by:
-
Anja Leichsenring authored
The functionality the trait provides is never used for the SessionService, so usage declaration is removed. Resolves: #95990 Releases: master Change-Id: I916daf559b74f1dd821870183bd7f3ebdf0320ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72186 Tested-by:
-
Oliver Hader authored
Change-Id: I5796168cca0ddfd134da596d016a784bb9ab55b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72188 Tested-by:
-
Oliver Hader authored
Change-Id: I963971774750267bde8c1f4816ec9f07f2dad9f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72187 Tested-by:
-
Benni Mack authored
In recent TYPO3 v11.5.x versions, the error handling for Frontend pages did cache the external PSR-7 Response (by guzzle) in the pages cache. However, if the error page was fetched the second time, the Response object from the cache did not have a valid stream anymore, thus resulting in an array. This change now caches the body + headers for the page (still, only when a 200 response code was returned), and re-builds a clean Response object. Resolves: #95940 Related: #95586 Related: #94402 Releases: master Change-Id: I27aaffe8acda275fd3450f9479e19a3f21d22df6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72184 Tested-by:
-
- Nov 15, 2021
-
-
Oliver Hader authored
Reduces amount of `requireJsModules` and `scriptCall` invocations in AJAX response handling and migrates to new `scriptItems` which is forwarded to JavaScriptHandler.js. Resolves: #95954 Releases: master Change-Id: I258da49fef46ccc36c602e0fd7c9a14ddb3cec1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72154 Tested-by:
-
Christian Kuhn authored
Brings a patch for extension testing, so they don't inherit the composer flag for test instances anymore. composer req --dev typo3/testing-framework:^6.14.0 Change-Id: Ic0490cc888d08596cd7babfa7bd0247a885e29b9 Resolves: #95988 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72183 Tested-by:
-
André Buchmann authored
In TYPO3 v8, new page translations within pages_language_overlay were visible by default when using plain DataHandler. In TYPO3 v9, due to the merge into "pages" for translations, the default value for "hidden" is used. Every new page translation was hidden by default - this was a different behavior. Issue #88248 changed this and restored the behaviour how it was in TYPO3 v8, this translated pages where always visible. This patch consider TCA configuration 'hideAtCopy' and TSconfig setting 'TCEMAIN.table.pages.disableHideAtCopy' options for page translations if source page is not already hidden. Further datahandler tests are added to cover these cases and prevent regressions on that. As the patch for #88248 already has been stating: For future TYPO3 major versions, the hidden field could be migrated into a 'allowLanguageSynchronization' once the Context API is used throughout Core properly. Resolves: #89622 Related: #88248 Releases: master Change-Id: Iff0488c559201fa51071cb6f364edec8e148a05a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71556 Tested-by:
-
Nikita Hovratov authored
Resolves: #95987 Releases: master Change-Id: Icd868d64e0414fa295f1d03c7cbe102b388ff978 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72182 Tested-by:
-
Simon Gilli authored
Storing the package artifact in the var/build folder raised questions how this folder shall be treated in general and during deployment. Since the Package Artifact is built in a `composer install` process, it should be treated the same as other build artifacts like all files in the vendor folder. To make this more clear, the package artifact is now also stored in the vendor folder. Accessing the vendor folder during runtime is now possible with using Composer 2.1 runtime API, which is required anyway already. The path to the vendor folder is determined indirectly, by using the path to the typo3/cms-composer-installers package. This means, this package must not be replaced by another package with a different name. Since no public replacements for this package exist and there are no benefits for a private replacement of this package over having a private fork with the same package name, this should not be an impediment. To ease the required related changes in the testing framework, late static binding is used for calling SystemEnvironmentBuilder::usesComposerClassLoading Resolves: #95897 Releases: master Change-Id: I3cfc982c289b312d22f59d2704d7e7932efc8cc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72071 Tested-by:
-
Nicole Cordes authored
The ConditionMatcher tries to resolve the current page id from global variables. One of this possibilities uses the cmdMap that is sent to the DataHandler. This patch ensures that the correct target uid is used to resolve the page id. Resolves: #95967 Releases: master, 10.4 Change-Id: I0fb7968c3118f2ab78c1cbb1dda3643e9f2f450e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72163 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Benni Mack authored
Bootstrap 5 ships with "text-end" which is semantically more correct than "text-right". This change adapts the needed places in TYPO3 Core to use "text-end". Resolves: #95974 Releases: master Change-Id: I9c72b5004594ef46faba79e0ea78fe24025a93a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72172 Tested-by:
-
Christian Eßl authored
Previously, when creating a translated content element of type `shortcut`, the preview in the page module would always show the title of the reference from the original language. In case the referenced record has been translated as well, the preview now shows the translated title instead. Resolves: #92523 Releases: master Change-Id: I5dd5de3a63db916311ede94a07bb7fb3209795f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66090 Tested-by:
-
Benjamin Franzke authored
empty() returns true if a record contains 0 as value. Therefore isset() needs to be used instead. The corresponding fix that was introduced with #91145 to workaround this flaw is removed again. Resolves: #95972 Related: #91145 Releases: master, 10.4 Change-Id: Idfea91b84d8391d680900966f57b406c28a616ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72170 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Stefan Bürk authored
The big win with this patch: All core now run tests with E_ALL error handling (unit, functional, acceptance). This means, they will also fail when PHP deprecations are raised. This improves PHP compatibility and makes sure new PHP versions can be integrated more quickly since we'll find deprecated PHP code calls early. Additionally, the acceptance tests are extended to run with PHP 8.1. As a result, the entire testing is now done with PHP 8.1 and green, we can claim PHP 8.1 compatibility for core now. Resolves: #95981 Releases: master Change-Id: I1eece6d2faec6453ada9731fc4064076dc8d5d97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72151 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Anja Leichsenring authored
To further separate concerns from ext:irre_tutorial, the configuration of JsonRenderer looses all parts that only concern the 1ncsv scenario. Ext:test_irre_csv receives a dedicated JsonRenderer, that is used by related test scenarios. Resolves: #95982 Releases: master Change-Id: Id83fbbd0133b56c6d1069b385298d6db56fd7142 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72180 Tested-by:
-
Benni Mack authored
Resolves: #95973 Releases: master Change-Id: I6f0358cfdc38aff55ce8e0ef4343cd50104d93c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72171 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
Simon Gilli authored
This patch applies the current recommendations for BASH scripts see https://github.com/koalaman/shellcheck#readme. Resolves: #95964 Releases: master, 10.4 Change-Id: I21ba18cb151acc0ff8f33a2135ef289669d15bab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71981 Tested-by:
-
Christian Kuhn authored
Brings especially a series of core v11 relevant PHP 8.1 bug fixes. composer req typo3fluid/fluid:^2.7.1 composer req typo3fluid/fluid:^2.7.1 -d typo3/sysext/core/ --no-update composer req typo3fluid/fluid:^2.7.1 -d typo3/sysext/adminpanel/ --no-update composer req typo3fluid/fluid:^2.7.1 -d typo3/sysext/fluid/ --no-update composer req typo3fluid/fluid:^2.7.1 -d typo3/sysext/redirects/ --no-update Resolves: #95980 Releases: master Change-Id: I5aae8fa275d80b2322bb526a8b6a1856194ec786 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72178 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Christian Kuhn authored
Brings a series of core v11 relevant PHP 8.1 E_ALL preparations and a couple of minor details. composer req --dev typo3/testing-framework:^6.13.0 Change-Id: I140866e8fb7014efbc33b7c1f25b2f840bd19ce2 Resolves: #95979 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72176 Tested-by:
-
Nikita Hovratov authored
If extension authors don't provide a type for their extension configuration options, they will now fall back to "string" and prevent later undefined array key access warnings. Resolves: #95977 Releases: master Change-Id: Icd77c4d130d2fc7d0b4f127dbeb2926c4057b81c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72175 Tested-by:
-
Christian Kuhn authored
There was a skipped unit test due to a PHP 8.1 bug. Latest rc6 fixed the issue, the test can be activated again. Resolves: #95976 Related: #95501 Releases: master Change-Id: Ib5cebf9edd544ca1aa3b91474c6032bf5721176e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72174 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Benni Mack authored
Used commands: > yarn add "bootstrap@^5.1.3" > yarn add "@popperjs/core" > grunt build Resolves: #95975 Releases: master Change-Id: Icacbf8d51c4e3345b9c549433c5ae28ba88848d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72173 Reviewed-by:
-
Anja Leichsenring authored
For easier testing, ext:irre_tutorial "csv" setup is extracted to a dedicated extension. Tests concerning these tables can now load the smaller test extension, which reduces system load and simplifies maintenance. Resolves: #95951 Releases: master Change-Id: Ib2040107929d795dd5b2606bff170a23435e541a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72165 Tested-by:
-
