- Oct 27, 2020
-
-
Benni Mack authored
When the Admin Panel is activated, TSFE should not override the frontendpreview aspect by default, as the preview settings will never work otherwise. Resolves: #92713 Releases: master, 10.4 Change-Id: I070fe49d5196f1ae2e8cc9feed3d16926f5d9728 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66314 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Oct 26, 2020
-
-
Jonas Eberle authored
The event was split up into 2 events in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64021/17 yet the example in the changelog was forgotten. Resolves: #92702 Releases: master, 10.4 Change-Id: I2ab04d38745bb20cfcf7dd07c44ec63ccb1cf9d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66280 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Oct 25, 2020
-
-
Frank Naegler authored
This patch prevents double escaping of the src attribute by unescaping the value before handover to the AssetCollector->addJavaScript() function. Resolves: #92284 Releases: master, 10.4 Change-Id: Ia9bb22e176f8a58a8bba642599546d13aa4855d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Christian Kuhn authored
A couple of foreign_table_where TCA fields for l10n_parent do not allow setting a localized element to a different parent element located on the same page. Solution is to use the same foreign_table_where strategy as used with other tables like tt_content. Note this is only visible for sys_category since the two fal related tables do not show that field at all. Those two are still changed to streamline core code and to not deliver broken examples. Change-Id: I449ba949b555efa04138da054d6cca9a4d52372b Resolves: #69906 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66221 Tested-by:
-
Oliver Bartsch authored
Since some TCA columns like `hidden` use the `invertStateDisplay` option for display in FormEngine nowadays, the corresponding CSH labels are now adjusted to reflect this behaviour. Resolves: #92603 Releases: master, 10.4 Change-Id: I05bb667930906232947a2ebb4f1995e795e39110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66212 Tested-by:
-
Oliver Bartsch authored
The paste content buttons now have the type "button" set to not falsely behave as submit buttons, which is the default if no type is defined. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-type Note: In this case the regular submit event is prevented by JavaScript which leads to no actual functional change here. Resolves: #92668 Relates: #92653 Releases: master, 10.4 Change-Id: I22f80778eab02b9c9ada9177ae5f72cfca2f55ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66248 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Oct 23, 2020
-
-
Oliver Bartsch authored
A <button> tag is now being used instead of an <a> tag as collapsing / expanding the tables is an interaction on the same page rather than opening a new one (<a> tag had empty `href` attribute). The button now also provides a proper aria-label with a descriptive text and gets the aria-expandend state initially set. Furthermore the button now uses common styling to be directly recognized as such. Resolves: #92657 Releases: master Change-Id: I7d98720f49b549bd74af1632c1fdd9fb9accbdba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66244 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Jens Ulrich <jens.ulrich@snk.de> Tested-by:
-
Sybille Peters authored
The Introduction page is updated to reflect current master. The text are changed in a way that they also apply for previous versions 10 and 9. Screenshots are replaced. Resolves: #92691 Releases: master, 10.4, 9.5 Change-Id: I9eb633f5446dc08636f97548920a6419b1fe8359 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66263 Tested-by:
-
Alexander Schnitzler authored
This patch introduces a proper request/response handling chain. That means, that Extbase no longer creates a response object early, passes it through the request handler and dispatcher into the controller and expects it to be altered there. Instead, request handlers, the dispatcher and controllers only get passed a request object and controllers are then responsible for creating and returning a response. This change is preparatory work for the introduction of PSR-7 responses in Extbase. Those responses are immutable and can no longer passed by reference through the stack. Instead, the controller must return the desired response along with its state down the stack while remaining unaltered. This patch is considered breaking because it changes several method signatures of public classes and interfaces. Still, it is quite unlikely to be struck by this change when using the public api of Extbase and not overriding classes such as the ActionController. Releases: master Resolves: #92513 Change-Id: I3ab7846268ea68727a2f57eea69328b85be4f5e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66079 Tested-by:
-
Georg Ringer authored
- Provide a page title - Replace nowrap attribute with the nowrap class Resolves: #92676 Releases: master Change-Id: I31cb551a5807a1eea5ab3f1899d62419494c0c6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66251 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
-
- Oct 22, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92580 Change-Id: Iab991450493b13d524f4429d51a71958ad62a0e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66159 Tested-by:
-
Oliver Bartsch authored
The fluid based page module tried to return a "unique id" for each "create content element" button using the `getUniqueId` method. This id however was not unique as it was stored as class property after the first creation. This lead to all buttons got the same ID which is according to the spec https://html.spec.whatwg.org/multipage/dom.html#the-id-attribute not allowed. Therefore the `getUniqueId()` method now returns a new "unique id" on each call. Resolves: #92629 Releases: master, 10.4 Change-Id: Ie3724423e91eb11a6caf5933c651d34691da477b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66220 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Georg Ringer authored
Use the same viewport configuration as the core and as the Install Tool is not yet translated, the language can be hardcoded to english. Resolves: #92672 Releases: master Change-Id: I9aa557108dba98943710bcf2d24fede9326d09af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66249 Tested-by:
-
Benni Mack authored
The RedirectService should have a ServerRequestInterface object that can properly set up TSFE when linking to pages. Resolves: #92666 Releases: master Change-Id: I39fddb224396410bfc0bffb229ea16eaeef5adeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66140 Tested-by:
-
Benni Mack authored
This is a pre-patch as a cleanup to extract the file system related functionality and the "zip file" related functionality in separate classes, to remove further cross-dependencies between PHP classes in Extension Manager code. Resolves: #92669 Releases: master Change-Id: I55710f4d4354b1ea239738d219ca778e74306396 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66189 Tested-by:
-
Christian Kuhn authored
* Merge import .csv files and rename file to "ImportDefault.csv" * Extend assert .csv files to contain all tables in the same order as the import files. This allows to easily diff the before/after files and to get a have overview if viewing them side-by-side. Additionally, this shows unwanted side effects from patches more easily. Change-Id: I9a5c37de4492d34903f9bda1b398884e6f6ac7e4 Resolves: #92677 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66245 Tested-by:
-
Georg Ringer authored
The marker ###POSTJSMARKER### is not replaced anymore and can be removed. Resolves: #92673 Releases: master Change-Id: Iddc2d7c0ee9d0c36383c179143f06e7440e2e67d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66250 Tested-by:
-
Danilo Caccialanza authored
Consider the case you have N workspaces and some BE "advanced users" and "limited users” having access to a workspace. "Advanced users" have access to all workspace’s page tree and also LIVE workspace, in this case everything works correctly. "Limited users" have access only to a limited page tree of the workspace and cannot access to LIVE workspace. When the user logs in, the page tree doesn’t show up and the system indicate the following error: "Page tree error Got unexpected response from the server. Please check logs for details" This patch fixes the "limited user" problem. Resolves: #91918 Resolves: #91594 Releases: master, 10.4 Change-Id: I0029add1940504ad1d274eac4ab02ff2af69f96d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65755 Tested-by:
Danilo Caccialanza <supercaccia@bluewin.ch> Tested-by:
cbugada <christian.bugada@ti.ch> Tested-by:
-
Oliver Hader authored
Using view helper `f:form.select.optgroup` with argument `disabled` throws PHP type error, since array is expected, but string given. Resolves: #92656 Releases: master, 10.4, 9.5 Change-Id: I7f1fd3a1f81c7befb15e4657c9e59ff862e663e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66242 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Markus Klein authored
With #86219 the migration from sys_domain records to Sites was faulty. Formerly all known domain records were inspected in order to decide whether a domain was local or not. This was changed to an invalid check covering the current site only. This change now again validates all known sites. Resolves: #92626 Related: #86219 Releases: master, 10.4, 9.5 Change-Id: I2ce4dc0e8891ee2b438c42d20fff10428fafa7e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66227 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Georg Ringer authored
The attribute alt is not allowed for the element "textarea". Resolves: #92633 Releases: master, 10.4 Change-Id: I70790e529a270300f73d3b22cb598e2d8197e07c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66225 Tested-by:
-
- Oct 21, 2020
-
-
Oliver Bartsch authored
The paste content button in the page module was not accessible via the keyboard because of it being an anchor element without a `href` attribute (so no tabstop). The button is therefore now changed to use a button tag, allowing it to be accessed via the keyboard. Resolves: #92653 Releases: master, 10.4 Change-Id: Ied665d2899b6364046ff7920dfa9dcb006de0d87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66238 Reviewed-by:
-
Georg Ringer authored
The attribute href is not allowed on spans. Resolves: #92635 Releases: master, 10.4 Change-Id: I34079953da58784ca7384c94f1839b8941c5cd1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66226 Tested-by:
-
Oliver Bartsch authored
Since the column is using the `invertStateDisplay` the label must take this into account otherwise the display in e.g. single-table-view is wrong. Resolves: #92654 Releases: master, 10.4 Change-Id: I022efb771e0fce393f29dff86543f1ca6a8297a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66240 Tested-by:
-
Georg Ringer authored
Attribute alt is not allowed on span elements. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/span#Attributes Resolves: #92632 Releases: master, 10.4 Change-Id: If4e5762cf95535130b373d4e297a28b547686702 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66223 Tested-by:
-
Georg Ringer authored
Instead of using the shorthand ternary operator use a regular ternary operator to avoid an invalid HTML attribute '1'. Resolves: #92640 Releases: master, 10.4 Change-Id: Ibf14dfaafd34158c71d71c99ddbc70d04795f3d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66229 Tested-by:
-
Oliver Bartsch authored
All iframes must contain a description to allow screen readers to identify the content or purpose of them. Therefore all iframes are now equipped with a proper title attribute, describing their content. Resolves: #92646 Releases: master, 10.4 Change-Id: I6af29e2587f51c3800c8b7590ed91f57e4fafd20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66235 Tested-by:
-
Georg Ringer authored
The capslock information is improved by the following changes: - Change the position to avoid covering the clear icon - Add the role="status" to improve the accessibility - Clear the alt attribute as it contains the same information as the title attribute. Resolves: #92645 Releases: master Change-Id: I676dd76627d1de2b765913b239ea1d21e1d55e17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66234 Reviewed-by:
-
Georg Ringer authored
Resolves: #92642 Releases: master, 10.4 Change-Id: Ic2012c25f15ae460ec03aa78f07c190e988351f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66230 Tested-by:
-
Georg Ringer authored
A '"' is too much in the record list. Resolves: #92638 Releases: master Change-Id: I00eb74b3376d42ddf614d389d3bf9336e225d20c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66228 Tested-by:
-
Georg Ringer authored
Related: #92529 Resolves: #92617 Releases: master Change-Id: I6fed72dae3574f1350b53a7fb962dde4141d33f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66217 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Alexander Schnitzler authored
Using controller aliases, i.e. the controller name only, for plugin registration has been deprecated and is now removed. \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin() and similar methods do expect fully qualified class names instead. Controller aliases are derived from the class name. Releases: master Resolves: #92609 Change-Id: I06186760dbec8ed5c639066a4e3a835a65bf4673 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64671 Tested-by:
-
Christian Kuhn authored
Bugfix release brings a deprecation fix that is going to be removed in master. composer require --dev typo3/cms-styleguide ~11.0.1 Resolves: #92614 Related: #92609 Releases: master Change-Id: I553824de255f9c1136e96df9b28f6108feecc5c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66216 Tested-by:
-
- Oct 20, 2020
-
-
Oliver Bartsch authored
Since over a decade (according to the timestamp), GeneralUtility::uniqueList() does not allow an array as first argument and furthermore doesn't use the second parameter anymore. Since then, both have thrown an `InvalidArgumentException`. Furthermore, this method does not belong to GeneralUtility at all. Therefore this method is now deprecated and a new one, using proper type hints, a return type, no second argument and a correct PHPDoc is added to StringUtility. All usages in the core are replaced with the new method, ensuring proper types. Resolves: #92607 Releases: master Change-Id: Ibca5c2c312258dfc63c74f0ff11408d11226f7b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66190 Tested-by:
-
Georg Ringer authored
The method :php`\TYPO3\CMS\Core\Utility\GeneralUtility::validEmail` is used to validate a given email address through the core and TYPO3 extensions. The validation can now be configured by providing the used validators to be used in the LocalConfiguration.php or AdditionalConfiguration.php. Example: $GLOBALS['TYPO3_CONF_VARS']['MAIL']['validators'] = [ \Egulias\EmailValidator\Validation\RFCValidation::class, \Egulias\EmailValidator\Validation\DNSCheckValidation::class' ]; The RFCValidation validator is still be used as default. Furthermore, following validators are available: - Egulias\EmailValidator\Validation\DNSCheckValidation - Egulias\EmailValidator\Validation\SpoofCheckValidation - Egulias\EmailValidator\Validation\NoRFCWarningsValidation It is also possible to provide own validators which must implement the Egulias\EmailValidator\Validation\EmailValidation interface. If multiple validators are provided, each validator must return TRUE. Resolves: #92531 Releases: master Change-Id: I9c5a0573c2f9bff56bf869dc221a2c0ffd75417b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66179 Tested-by: -
Daniel Goerz authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92578 Change-Id: I4532bbbd9ed907fe364f56caf6f330feda7c32bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66157 Tested-by:
-
Alexander Schnitzler authored
All fluid widgets and the core widget functionality has been removed due to its complexity and the fact that fluid widgets did and do bring more trouble than benefit. The most commonly used paginate widget can be replaced with a recently introduced new core api. Examples of how to use it can be found in the core itself. Extensions be_user and extensionmanager did use the pagination widget before and do now use the core pagination api. Custom widgets and their functionality have to be reimplemented in another way. The usual way to replace a widget is to put its functionality into the controller action and move the widgets query params into the query param namespace of the plugin that formerly rendered the widget. Releases: master Resolves: #92529 Change-Id: I3342214d467a85dfcd6d684f4a7678f70fd67146 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66095 Tested-by:
-
Anja Leichsenring authored
By unsetting the PHP version in config platform.php, we ensure the highest possible packages for the currently available PHP version are installed. Resolves: #92335 Related: #92251 Releases: master, 10.4 Change-Id: Id6359014aa950bd65622e7fd8dac26313a6778c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65754 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Oct 19, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92579 Change-Id: I488edd51d9af44107969335b8f955cb69734c42b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66158 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christoph Lehmann authored
This commit adds the missing field forget_header to the upgrade wizard. The field is available in 9.5 and in 10.4 as "settings.forgot_header" and thus needs to be migrated. Resolves: #92585 Releases: master, 10.4 Change-Id: Icb55a962873042aab946cc227e2374675eb8c98e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66166 Tested-by:
-
