- Oct 13, 2017
-
-
Loek Hilgersom authored
Resolves: #82749 Releases: master, 8.7 Change-Id: I1de1157ca8e28da3a9fd3ffb3783bb73b1f8e845 Reviewed-on: https://review.typo3.org/54382 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Gianluigi Martino <gmartino27@gmail.com> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
Modernize the code base of the lowlevel ConfigurationController: * No more _GP usages * Get rid of MOD_SETTINGS and friends * Don't use BackendUtility::funcModule and other crude helpers * Get and apply changes to be_user->uc directly * Move last html pieces to view Change-Id: I24af6c53b9c55c82e0e1fc1ee79de97768fd9b2c Resolves: #82754 Releases: master Reviewed-on: https://review.typo3.org/54389 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Frank Naegler authored
Resolves: #82604 Releases: master Change-Id: I9b9ff38c635902f2713602955ad9a3d04734ec88 Reviewed-on: https://review.typo3.org/54367 Tested-by:
-
- Oct 12, 2017
-
-
Georg Ringer authored
To avoid exceptions with complex structures, the strict flag must be used in the in_array check. Resolves: #82736 Releases: master, 8.7, 7.6 Change-Id: I3ecf859e3e3cc70ab40b10ef9052d46e8b486957 Reviewed-on: https://review.typo3.org/54372 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Christian Kuhn authored
Setting / unsetting the checkbox "Use regular expression" fails with JavaScript error "jumpToUrl is not defined". Add that to the document body. Change-Id: I0a5928e008972493d070a35d1219a0acca579ce8 Resolves: #82746 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/54377 Reviewed-by:
-
Christian Kuhn authored
The two "view" classes are clearly controllers and are renamed with this patch accordingly. Change-Id: Ic1cdc405ae24b87aa6224cda79b7226ce5eeec64 Resolves: #82744 Releases: master Reviewed-on: https://review.typo3.org/54375 Tested-by:
-
Christian Kuhn authored
To further phase out BaseScriptTask "SOBE", the scheduler controller class no longer extends it and copies left over usages to itself. A general cleanup is applied along with this patch: * Hard code some general variables like "moduleName" * Remove some duplicate class attributes * Additional namespace usages Change-Id: I937b66e0b59d65591547144763026dbbd2d6c5f0 Resolves: #82727 Releases: master Reviewed-on: https://review.typo3.org/54364 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
To reduce BaseScriptClass "SOBE" usages, the lowlevel controller "ConfigurationView" no longer extends this class and inlines some of the detail methods into routing target "mainAction". Change-Id: Icc284f5a3b4f0f9d50482a9f8865b0d7d1c16f4f Resolves: #82728 Releases: master Reviewed-on: https://review.typo3.org/54365 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
To reduce BaseScriptClass "SOBE" usages, the lowlevel controller "DatabaseIntegrityView" no longer extends this class and inlines some of the detail methods into routing target "mainAction". Change-Id: I67b0bae5848607166d19988cb005c91301754413 Resolves: #82729 Releases: master Reviewed-on: https://review.typo3.org/54366 Tested-by:
-
Stanislas Rolland authored
RecordLinkHandler->canHandleLink should check record identifier, otherwise the element browser may open the wrong tab when multiple record identifiers are configured. Resolves: #82737 Releases: master, 8.7 Change-Id: Ie12c6d7484bdb51577dfe02a653e80fe1d7b63ea Reviewed-on: https://review.typo3.org/54369 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Christian Kuhn authored
The call tree of the extension manager "configuration form" ext_conf_template.txt parser is a mess: The ext:extensionmanager ConfigurationUtility calls ext:core ConfigurationForm which is a class that extends ExtendedTemplateService which extends TemplateService. The "TypoScript" a-like parsing then uses class TypoScriptParser. This compiles to a huge list of dependencies. The patch compiles this mess down to a series of methods within ConfigurationUtility directly, effectively adding needed parts of TypoScriptParser and ConfigurationForm as protected methods. The class ends up with way less direct and indirect dependencies. The various detail parsing methods are still messy and hard to follow, but rewriting the parser heart does not really make sense since the ext_conf_template.txt format will bite the dust sooner or later anyway and having all in one place is already much better than before. So putting some days of energy into rewriting these specific parts of the TypoScript parsing did not seem to be worth it, even if it in the end could probably solved with 1/4 of code. Class ConfigurationForm is deprecated but could also be removed as breaking patch later if anyone wants to refactor the remaining ExtendedTemplateService and TemplateService classes in v9. Note this patch is an intermediate step before the ConfigurationUtility class form ext:em is moved into the install tool. Change-Id: I62d9fafb6444d954e17c980358e6367a83b033b8 Resolves: #82725 Releases: master Reviewed-on: https://review.typo3.org/54362 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- Oct 11, 2017
-
-
Andreas Fernandez authored
The package `codemirror-minified` used as a drop-in replacement of `codemirror` is not maintained well and is replaced with the original package again. To still get the benefits of page loading speed, at least the JavaScript files are compressed by our own toolchain now. CSS can't get compressed now as the original copyright gets replaced by our own "banner". Resolves: #82713 Releases: master Change-Id: Ic12a7e9e70c63f2c0ae322e470453fe056c99155 Reviewed-on: https://review.typo3.org/54346 Tested-by:
-
Andreas Fernandez authored
This patch fixes a condition that fails when a CSV export in the record list is requested. The maximum limit of records is set, if `$iLimit` is larger than 0 to avoid a `LIMIT 0` query. Resolves: #82710 Related: #81651 Releases: master Change-Id: I49779e4fa4b31e44d5457f90939e6f96a41e497b Reviewed-on: https://review.typo3.org/54341 Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Oct 10, 2017
-
-
Tymoteusz Motylewski authored
Resolves: #82726 Releases: master, 8.7 Change-Id: I779dbf4cdecf931cae4f2734f561aa1c9eab4efb Reviewed-on: https://review.typo3.org/54352 Reviewed-by:
-
Markus Klein authored
If the IP of the client changes and is not within the lockIP range anymore a new session is now created. Resolves: #82490 Releases: master, 8.7 Change-Id: I7dc5033318fa9eb1efc929af126b38cc9840e964 Reviewed-on: https://review.typo3.org/54347 Tested-by:
Franz Holzinger <franz@ttproducts.de> Reviewed-by:
-
Tymoteusz Motylewski authored
Fixture data for functional tests in impexp contains correct height for one image now. Resolves: #82722 Releases: master, 8.7 Change-Id: I3fea831a5a030eb525fabe9bbb6e891a3a722fd7 Reviewed-on: https://review.typo3.org/54350 Reviewed-by:
-
Benni Mack authored
Previously, it was possible to disable the handling of references / child-parent relations in workspaces on publishing, due to legacy functionality this was an option introduced back in v4. The behaviour (option switch via TSconfig) was enabled by default on all installations. It automatically resolves dependencies (= publishing dependencies in relations automatically), having this option disabled could lead to side effects in the past. Resolves: #82701 Releases: master Change-Id: I4f152fd337e4c405eaa0f1386601629a688a05d4 Reviewed-on: https://review.typo3.org/54319 Tested-by:
-
Benni Mack authored
The FAL security checks which adds additional checks for Backend Users are currently placed within TYPO3_MODE === BE which applies to CLI as well. In order to even use the FAL API via CLI, a user has to be authenticated (just for browsing files). Therefore, the check needs to be handled via TYPO3_REQUEST_TYPE which excludes symfony commands on CLI basis. Additionally, the REQUEST TYPE checks are handled within the Slot and not when to register the hook (see other cleanup patch as well). Resolves: #82691 Releases: master, 8.7 Change-Id: I7b895a119a17ea166331eb1dbcb75e57fffbd388 Reviewed-on: https://review.typo3.org/54315 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Benni Mack authored
The TCA Inline behaviour option "localizeChildrenAtParentLocalization" is dropped. This functionality is now always enabled. A TCA migration wizard is removing the option. On a side note, the removed functional tests when removing "localizationMode=select" were re-added. Resolves: #82709 Releases: master Change-Id: Idad3443417bf08fc4c93fa6475079ac2fd779c1e Reviewed-on: https://review.typo3.org/54326 Tested-by:
-
- Oct 09, 2017
-
-
Gianluigi Martino authored
On the left side of the "Record selector" window a popup with the content element id is showing hovering the content element icon. With this patch it works also on the right lower side icons in the same window. Resolves: #82708 Releases: master, 8.7 Change-Id: Ib091f61b13923d787e94cb93e85257c39978dbb5 Reviewed-on: https://review.typo3.org/54340 Tested-by:
Raphael Graf <graf@netvertising.ch> Tested-by:
-
Benni Mack authored
The syntax is very confusing, and the second argument is not necessarily needed - most of the TYPO3 Core code uses only the first argument. In order to streamline the API the second method argument is deprecated but still works as before. Resolves: #82702 Releases: master Change-Id: Ib2238ff90edf932f9410cf87c214e23d0a1c4826 Reviewed-on: https://review.typo3.org/54323 Reviewed-by:
-
Joshua Westerheide authored
Resolves: #82697 Releases: master, 8.7, 7.6 Change-Id: I64bf51d5efd0394f4d3269965820281cbaf2de90 Reviewed-on: https://review.typo3.org/54317 Tested-by:
-
Benni Mack authored
Resolves: #81990 Releases: master, 8.7 Change-Id: Id52849587f3ad438d65f48d01a8930a646829dd4 Reviewed-on: https://review.typo3.org/54298 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- Oct 08, 2017
-
-
Benni Mack authored
This option was renamed and is set in init() of GraphicalFunctions anyway, so the call can be removed (and also, does not create a PHP notice). Resolves: #82700 Releases: master, 8.7 Change-Id: Ib2328676eaf123755b97ae09fd070f6e82250c92 Reviewed-on: https://review.typo3.org/54324 Tested-by:
-
Benni Mack authored
The document references files that do not exist anymore, also CONTRIBUTING.md is missing. * ChangeLog => gone * GPL.txt => LICENSE.txt * NEWS.txt => gone Resolves: #82698 Releases: master, 8.7 Change-Id: Idb5890f789632a342d1d640febd4ac1b9fa7497b Reviewed-on: https://review.typo3.org/54320 Reviewed-by:
-
- Oct 07, 2017
-
-
Anke Altintop authored
Add document.ready, so SelectTree is initialized even with slow internet connection. Resolves: #81891 Releases: master, 8.7 Change-Id: I5489d37821107310f99fbccffc00fd183e2e3786 Reviewed-on: https://review.typo3.org/54310 Reviewed-by:
-
- Oct 06, 2017
-
-
Jigal van Hemert authored
FileCollector::addFilesFromFolder now supports the t3://folder URN as identifier for a folder. This allows the FILES cObj and the FilesProcessor data processing to use that syntax. Resolves: #82627 Releases: master, 8.7 Change-Id: I31376169f5868c6f7c52cf2b6ca98fe41bb1e111 Reviewed-on: https://review.typo3.org/54250 Reviewed-by:
-
Christian Kuhn authored
The internal / experimental class ext:backend/Module/AbstractModule doesn't do much useful stuff: It only instantiates ModuleTemplate in it's constructor which forces all inheriting classes to call parent::__construct(). The processRequest() method with its dispatcher code is never used in core, but superseeded by routing configuration via Configuration/Backend/Routes.php. The patch removes given AbstractModule usages and markes the class as deprecated. The patch is slightly breaking in cases an extension extends AbstractWizardController and additionally uses the initialized moduleTemplate property. Change-Id: Iee36e1787a6dc2a1affb3625983ccb6450589481 Resolves: #82689 Releases: master Reviewed-on: https://review.typo3.org/54312 Reviewed-by:
-
Andreas Fernandez authored
Check if the incoming optionValue is a closure and return early in such case. Resolves: #82550 Releases: master, 8.7 Change-Id: I0f6b12b8ed777906bfe7bc6849841b246e95bbd3 Reviewed-on: https://review.typo3.org/54213 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Frank Naegler authored
The first button of type=submit is used by the browser if the user hint <enter> in a form field. A form should only contains one submit button, which is fixed now with this patch. Resolves: #82668 Releases: master, 8.7 Change-Id: I43323dd89be67d18a2818faf11359151223458f1 Reviewed-on: https://review.typo3.org/54282 Reviewed-by:
Markus Sommer <markus.sommer@typo3.org> Tested-by:
-
Andreas Fernandez authored
If the submit event of a form using RSA encryption has `cancelBubble` set to true (e.g. by jQuery's stopPropagation()), any processing is stopped to prevent submitting the form. Resolves: #82259 Releases: master, 8.7 Change-Id: Idb357dd2043cccb899ad7fa3fa325f7d3c003e40 Reviewed-on: https://review.typo3.org/53845 Tested-by:
-
Susanne Moog authored
GROUP BY statements are in general evaluated before SELECT statements. If a DBMS does not implement additional logic to resolve aliases defined in SELECTS before grouping the statement will fail. Currently both MSSQL as well as ORACLE lack these additional implementations. To be safe we should group by the non-aliased columns. Change-Id: I04698b2c31fbe2b0907fd345fbbf5e84dcebf164 Resolves: #82664 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54281 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
The `Storage` RequireJS module is split into `Storage/Client` and `Storage/Persistent`. The `Storage` module itself is marked as deprecated and any occurrence is migrated to use the new modules. Resolves: #82603 Releases: master Change-Id: Ie4bbb2ac3c1801b15531f0b71e35507c8ed03f06 Reviewed-on: https://review.typo3.org/54240 Tested-by:
-
Alexander Schnitzler authored
The size of thumbnails of the file list is hard coded to 64x64 px which might not be optimal in some cases. Thus, the size should be configurable via UserTS. Releases: master Resolves: #73357 Change-Id: Ibd3bd43e55231212a410ee56b375e9be5d4354d2 Reviewed-on: https://review.typo3.org/51306 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Simon Praetorius authored
Resolves: #82439 Related: #82319 Releases: master Change-Id: Ieabaf1e7a230ce82206ffea30efded9ba821d50f Reviewed-on: https://review.typo3.org/54099 Tested-by:
-
- Oct 05, 2017
-
-
Susanne Moog authored
As bamboo already runs pre- and past-merge tests on all configured branches we don't need travis to run tests anymore. Change-Id: I0c9fd4c6da5eb2b9ff1fa72c3ef05e91d9aeee95 Resolves: #82685 Releases: master Reviewed-on: https://review.typo3.org/54304 Tested-by:
-
Susanne Moog authored
Add sonar-project.properties as basic configuration and add travis configuration for running sonar analyis on the core. Resolves: #82685 Releases: master Change-Id: I6c2886068c81e15e92b3562cf4200f3e80ff59db Reviewed-on: https://review.typo3.org/54303 Tested-by:
-
Benni Mack authored
The global configuration "png_truecolor" which ensured that generated PNG images only have 64 colors (instead of the max colors) came from the transition 12 years ago to keep a small file size for PNG images. The option was turned on for new installations and existing installations, and if not explicitly disabled, generated true-color PNG images at any time. The option did not have any effect for FAL-related image resizing at all. In order to generate PNGs with a limited color-space, it is still possible to do so with additional "reduceColors" option, as well as adding additional parameters to ImageMagick when needed. However, having a global option for this feature seems to be not practical these days anymore. Resolves: #82680 Releases: master Change-Id: I3e00cc1c37a5ed8287dcf7cad49d2a2ab10730e6 Reviewed-on: https://review.typo3.org/54277 Reviewed-by:
-
Christian Kuhn authored
Add execution of the deprecated unit tests to bamboo. Change-Id: I5b15448250f3158fde6dad3ec2c3f2681edb0b49 Resolves: #82684 Related: #82438 Releases: master Reviewed-on: https://review.typo3.org/54302 Tested-by:
-
Christian Kuhn authored
Use chromedriver directly in acceptance tests instead of routing through selenium-server. Change-Id: I229032b1b1ec1b0e6f5e4c2eb5435e3ff0ae95df Resolves: #82683 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54300 Tested-by:
-
