- Nov 30, 2021
-
-
Helmut Hummel authored
Since branching is finished, the dev-master alias is obsolete and can be removed. Used composer command: > composer up --lock Releases: main Resolves: #96102 Change-Id: I3ef3f546bb705b2fda4040b6cb8092b46bde76a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72379 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Benni Mack authored
Resolves: #96155 Related: #95293 Related: #95257 Releases: main Change-Id: I5aa8d747b98eb75ac7938323d97e99cad477761a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72397 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Christian Kuhn authored
Resolves: #96159 Related: #92494 Releases: main Change-Id: I330165bd268f9e9eb011b6ee5bee208f446aed6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72403 Tested-by:
-
Benni Mack authored
Resolves: #96125 Related: #94058 Releases: main Change-Id: I34d9fe4c02d2a44d4cfb401e73c49c239264d9c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72347 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Bartsch authored
With #96041 the registration of toolbar items was changed. All implementations of the corresponding interface are now automatically registered. The $GLOBALS configuration does no longer have any effect. An administrator however was no longer able to get an overview of the registered toolbar items in the configuration module. Therefore, this patch improves the situation by adding a new configuration provider, which in contrast to the GlobalVariableProvider, already shows the final ordering. Resolves: #96152 Related: #96041 Releases: main Change-Id: Ieba1988e65fa777aa0c71c258c0bac9e76a10ecb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72392 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
With #95486, the UploadViewHelper got extended for a new tag attribute "accept", which can be used to limit the allowed file types for an upload field. The EXT:form UploadedResourceViewHelper, which extends the UploadViewHelper, registers the "accept" argument and if given, implodes the value and adds it as attribute to the tag. This however now led to an exception since the "accept" attribute got already added by the parent class. This is fixed by no longer extending UploadViewHelper, but implementing the required logic directly in the UploadedResourceViewHelper. This step would have been necessary in v12 anyways, see #95298. Resolves: #96146 Related: #95298 Related: #95486 Releases: main Change-Id: Idbc1e284d9a7097fd7397562e566d32debc5f030 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72383 Tested-by:
-
Oliver Bartsch authored
In #92607, GeneralUtility::uniqueList was migrated to StringUtility::uniqueList and is therefore now removed. Resolves: #96139 Related: #92607 Releases: main Change-Id: I3eceb459db75a6cb69ed93126516abc2603ba9f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72374 Tested-by:
-
Benni Mack authored
Resolves: #96122 Related: #95326 Releases: main Change-Id: I5eea8b4a0f14be9d5a6dc5a74bb28cd12f59fb86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72396 Tested-by:
-
Oliver Bartsch authored
The CategoryRegistry together with the corresponding API method "makeCategorizable()" has been superseded by the TCA type "category" and is therefore now removed. Resolves: #96153 Related: #85613 Releases: main Change-Id: I95585c02da8a2a3334ab982fe0c541092ad61854 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72393 Tested-by:
-
Wouter Wolters authored
Adapt to a patch in typo3/testing-framework. composer req --dev typo3/testing-framework:dev-main Resolves: #96121 Releases: main Change-Id: I59d6ecc92c70e75ecbb797de18110925942b8027 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72340 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
The EXT:form EmailFinisher provides the possibility to send emails via the FluidEmail component since v10. Therefore the StandaloneView alternative is now removed. Since FluidEmail is now the only possibility, the previously integrated "useFluidEmail" switch is now removed, too. Resolves: #96149 Related: #92435 Releases: main Change-Id: Ia3a3009310313eb0b2bbe3593a8a4f1626b30d55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72386 Tested-by:
-
Oliver Bartsch authored
GeneralUtility::rmFromList is unused since at least v10 and is therefore now removed. Resolves: #96142 Related: #94311 Releases: main Change-Id: Ib237bc7fb2af58877f0baef94d97853cefe396ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72377 Tested-by:
-
Oliver Bartsch authored
In order to properly handle PSR-7 response objects, methods, which directly manipulate HTTP headers, should be avoided. Therefore following methods from HttpUtility are now removed: - `redirect()` - `setResponseCode()` - `setResponseCodeAndExit()` Resolves: #96143 Related: #94316 Releases: main Change-Id: Id353bb427118d148aa251b144eb866a4bd9ff822 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72378 Tested-by:
-
Nikita Hovratov authored
The old implementation and all backwards compatibility layers for SoftReferenceIndex have been dropped. Resolves: #96145 Related: #94687 Releases: main Change-Id: Ifa3bacbf3a7dc1ffad5acca852f1a2c25ac87b40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72381 Tested-by:
-
Oliver Bartsch authored
The methods getIconFactory() and getPageRenderer() from ModuleTemplate are now removed, since they exposed internal state, while hiding dependencies. Those services have to be injected in the corresponding controllers directly. Resolves: #96151 Related: #95235 Releases: main Change-Id: I7af0f78e163b3319df1b74f922917b393da70ef7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72388 Tested-by:
-
Oliver Hader authored
Removes deprecated BackendUtility::viewOnClick, which should have been replaced with \TYPO3\CMS\Backend\Routing\PreviewUriBuilder. Resolves: #96141 Releases: main Change-Id: Iae391d10cba9880c23bf124e0905993fd315c405 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72376 Tested-by:
-
Oliver Bartsch authored
It's no longer possible to pass a records' uid to AbstractTreeView::getIcon(), since the methods first argument "$row" is now type hinted "array". Resolves: #96144 Related: #92922 Releases: main Change-Id: I0cf19bb361720905ee05140c611a7d8fafa00df5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72380 Tested-by:
-
Oliver Bartsch authored
The single field configuration "special" of TCA type "select" was mainly used in core only, and was therefore replaced by the dedicated TCA type "language" and proper itemProcFunc's. The corresponding method "addItemsFromSpecial" in AbstractItemProvider is therefore now removed, making the "special" TCA option obsolete. Resolves: #96150 Related: #93837 Releases: main Change-Id: I070773aa259e5f49131a77ddeddd27f03042b3f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72387 Tested-by:
-
Oliver Bartsch authored
GeneralUtility::stdAuthCode is unused since at least v9 and is therefore now removed. Resolves: #96140 Related: #94309 Releases: main Change-Id: Idc68fff1c946e7f2f30645a6a3510d95f8e272bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72375 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Nov 29, 2021
-
-
Oliver Hader authored
To avoid introducing new components that rely on inline JavaScript, Content-Security-Policy HTTP headers for the TYPO3 backend are enabled when executing automated tests. Resolves: #95898 Releases: main, 11.5 Change-Id: I2bbc1ce055d066381cd53449d1b37fd2cafe0168 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72137 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Resolves: #96133 Releases: main, 11.5, 10.4 Change-Id: Ic1924bbf34b746bf1891419da6cb54e547a509a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72351 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
AbstractService is not used anymore and is now removed. Resolves: #96129 Related: #94313 Releases: main Change-Id: I8a23b80f8d36b446a4ae0bcd1b2d701ec1eade20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72348 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Christian Kuhn authored
Change-Id: I13ca3c60a040c15aca8e259e7c65d33682f37c44 Resolves: #96131 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72349 Tested-by:
-
- Nov 28, 2021
-
-
Benni Mack authored
The option to use the @import syntax in TypoScript "page.includeCSS" and "page.includeCSSLibs" (.import subproperty per CSS file) will not work anymore. Resolves: #96118 Related: #95349 Releases: master Change-Id: Ibcbcf091eca00d061cc79b551f87995ddf47c1a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72338 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Benni Mack authored
The methods `PageRepository->fixVersioningPid()` and `BackendUtility::fixVersioningPid` are removed, because they are not needed anymore since TYPO3 v11.0 with the removal of various VersionState (t3ver_state). Resolves: #96120 Related: #92598 Releases: master Change-Id: I029169563e094b42a2e8a1a52d0a6533984436d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72341 Tested-by:
-
Christian Kuhn authored
Resolves: #96126 Related: #94209 Releases: master Change-Id: If2edcfdbf6ab2e206c43c634fa58ccf75c75ab38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72343 Tested-by:
-
Benni Mack authored
The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/browse_links.php']['browserRendering'] is replaced in favor of the Element Browser registry. Related: #95322 Resolves: #96123 Releases: master Change-Id: If362551cf7c4a093cde4e0742037155afedbea32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72345 Tested-by:
-
Stefan Bürk authored
CleanerTaskTest dynamically calculates the needed 'period' time to use for testing, if one page records will survive the cleaning task, as not being outside this periode grace time. This has worked quite some time, but may crash now in a quite narrow timeframe, which failed core ci tests, if they were run in this timeframe - and made it reproducible only for a night owl, as the timeframe lays between UTC '00:00-01:00'. PHP8.1.0RC6 included a regression bugfix which introduced another bug, which leads to inconsinstent calculation behaviour for using 'diff()' method of '\DateTime' or '\DateTimeImmutable', if timezone switches are needed and there are the first hour leap (or two hour in summer time). This is already fixed in PHP8.1.0 release. As we do not really need that 1 hour leap calculation here, we are able to tighten the test setup here and calculate the needed dynamic period in way to work around this bug for PHP8.1.0RC6, be backwards compatible and also being safe for 8.1.0 release. PHP regression fix introduced new bug (8.1.0RC6): https://github.com/php/php-src/commit/904933e9185664148ce54 PHP bugfix released with 8.1.0: https://github.com/php/php-src/commit/e4679ef0c2d5a0a81cb6e This patch uses '00:00:00' for the time part of both dates and further uses 'UTC' timezone enforcement to calculate the period time, which stabilizes this testcase and lets night owls do their stuff undisturbed. Resolves: #96128 Releases: master, 11.5 Change-Id: Ib1f4201ce8556ae8f22eeb4463732c62394e3c14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72346 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
Stefan Bürk authored
Creating auto redirects, if page slug is changed, has been extended to add the target with LinkHandler 't3://' uri schema with #89327, adding language argument '_language' to enforce the language for the redirect, missing that that did not worked, which was solved through adding '_language' argument handling in #96043. As languge arguments '_language' and 'L' are ignored, if the provided page uid is already the uid of the localized page, the parameter was meaning less. Further this breaks language fallback handling, if the localized page record is deleted. This patch uses now the default language page uid for creating target of auto-redirects to mitigate the issue that redirect will break if localized page is deleted but language fallback is configured. Resolves: #96103 Related: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I2ece06bf053bda4edb542910c3f51b1e6c8e052c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72327 Tested-by:
-
Christian Kuhn authored
Resolves: #96127 Related: #94654 Releases: master Change-Id: I95b1c675221ffa5b53f31757b1788cfe20652bcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72344 Tested-by:
-
Georg Ringer authored
The translations need to use the language of the current backend user and not the one of the current language of the site in the frontend. Resolves: #96004 Releases: master, 11.5, 10.4 Change-Id: Id409e759de4f0324835cc932f87719147b6e1b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72196 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Benni Mack authored
Globally configured ATagParams via config.ATagParams are now always added. Resolves: #96119 Related: #95219 Releases: master Change-Id: Id862c7790c8a509f604278bd1323ad0b262b2c83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72339 Tested-by:
-
Benni Mack authored
The hook has been replaced with the PSR-14 event "TYPO3\CMS\Core\Resource\Event\ModifyFileDumpEvent" and is thus removed. Resolves: #96117 Related: #95080 Releases: master Change-Id: I0ff076381e1629028a2ca236b23121dfdffdb05c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72337 Tested-by:
-
Christian Kuhn authored
Resolves: #96115 Related: #94665 Releases: master Change-Id: Id7702f2328a0ca848656caae8350d6facc65068a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72336 Tested-by:
-
Christian Kuhn authored
Resolves: #96114 Related: #94664 Releases: master Change-Id: I6ada8e2b4249f2f38cdab2b1074333d8ac8e03d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72335 Tested-by:
-
Christian Kuhn authored
Change-Id: I417f0f896e07b05d4577c865195724955fa7bc45 Resolves: #96113 Related: #92080 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72334 Tested-by:
-
Sybille Peters authored
This patch handles problems which occured with a large number of pages and also for a large number of records to be checked for broken links. The problems previously resulted in "Prepared statement contains too many placeholders" exceptions and consumption of too much RAM and (possibly) out of memory errors. Technical details about the implementation follows because this is handled slightly differently than in other areas of the core. LinkValidator used named placeholders to build database queries, and the EditableRestriction class also used a number of placeholder. Technically 'doctrine/dbal' explodes named placeholders for array values with quote type 'PARAM_INT_ARRAY' or 'PARAM_STR_ARRAY' to single unnamed placeholders for each value, using one placeholder for each array value. If multiple array value placeholder are used with a large number of values this could quickly emit the "Prepared statement contains too many placeholders" error as the limit is reached. The limit differs beetween the various database systems. One way to work around this issue is to do database operations in chunks, but it could become quite difficult to calculate the chunk size beforehand. Array values are mainly used for 'in()' or 'notIn()' query expressions, which naturally do not not have direct limits for the value count in it through all supported dbms systems. This opens the possibility to use direct value lists for these expressions. There are other dbms limitations depending on the used dbms (for example on mariadb/mysql 'max_allowed_packets', max query size setting for SQLite), which may be adjusted in some cases. However we could not safely expect that these values are monitored and adjusted, so we still need to do database operations in chunks, but make it a little easier for 'chunksize' calculations. During testing on an instance with a large number of pages, it was found that LinkValidator used up a lot of memory, reaching the configured memory limit of 2G on that system, which itself was very high already (and far beyond the recommended 256MB limit). Instead of collecting unlimited results in an array before checking links against this array, doing this for each record directly avoids excessive memory consumption during link checking. It was decided to do this in this patch directly instead of a separate patch, as this patch otherwise would not be testable in real instances. This patch does the following: * introduce two method to implode value arrays in QueryHelper * replace placeholder in EditableRestriction with quoted values * replace placeholder in BrokenLinksRepository with quoted values * introduce chunk database operations in BrokenLinkRepository * introduce chunk database operations in LinkAnalyzer * move $results array and call checkLinks() on it to the inner loop to process this for each record (instead of accumulating the results in a huge array. In the future we need to investigate and find a more generic way to handle such scenarios for larger instances. This may take some time and investigation to do this properly and in a reusable way. To not stall the bugfix further, we are doing the workarounds in this patch to solve these issues in the meantime. Resolves: #92493 Releases: master, 11.5 Change-Id: I9a596df6749d07afee9c5ac37266b876ddc6e297 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66896 Tested-by:
-
Nikita Hovratov authored
The JavaScript method "scrollIntoView" does not work for elements inside a modal or similar. It only scrolls the main page. A quick and easy alternative is to set "scrollTop" to a very high value. Resolves: #96070 Releases: master, 11.5 Change-Id: Ic5cea96177442acc57ea78cfa66b698c0dfd0f81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72280 Tested-by:
-
Stefan Bürk authored
The json_response functional test extension will soon avoid returning json encoded responses. This will make the functional frontend test suite fully transparent regarding responses. This patch prepares a couple of frontend functional tests towards this change. Resolves: #96112 Releases: master, 11.5 Change-Id: I8116caf08e4b8b76ad5d23b49954d9cb78d1c4de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72319 Tested-by:
-
Torben Hansen authored
When performing a search in the configuration module, a JavaScript error will occur, if a possible expanded tree node is not part of the search result. This patch adds checks for existence of the scrollElement variable. Resolves: #96097 Releases: master, 11.5 Change-Id: I5977dd48487563ae30407f8cf126724acc9bcb0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72320 Tested-by:
-
