- Jun 18, 2019
-
-
Manuel Selbach authored
doctrine/dbal 2.8.x ran into unmaintained mode: https://www.doctrine-project.org/projects/dbal.html We should upgrade to at least 2.9: composer req doctrine/dbal:^2.9 Resolves: #88579 Releases: master Change-Id: I18962bd313018abec8e52bada6df9aca6aa4143f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61080 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Sybille Peters authored
Resolves: #88578 Releases: master, 9.5 Change-Id: I5fc57a9c61d5f02838f3afd3c305ae0b7b037dfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61079 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Joerg Kummer <typo3@enobe.de> Reviewed-by:
-
Benjamin Franzke authored
As it produced a warning: 1) TYPO3\CMS\Frontend\Tests\Unit\DataProcessing\SiteProcessorTest:: nullIsProvidedIfSiteCouldNotBeRetrieved Trying to configure method "getSiteFinder" which cannot be configured because it does not exist, has not been specified, is final, or is static Resolves: #88576 Related: #88568 Releases: master Change-Id: Icf72100282ce24c87b6bb9f49fc978b6187a817e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61074 Tested-by:
-
- Jun 17, 2019
-
-
Jonas Eberle authored
Rephrases button title and success message for user preference reset. Resolves: #88520 Releases: master, 9.5 Change-Id: Ib2d3180a417366249df8fa9c1faa47c74cca022a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61040 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Manuel Selbach authored
doctrine/dbal 2.8.x ran into unmaintained mode: https://www.doctrine-project.org/projects/dbal.html We should upgrade to at least 2.9: composer req doctrine/dbal:^2.8.1 which installs 2.9.2 Resolves: #88553 Releases: master, 9.5 Change-Id: Id0c20cbb3102b5086e1c4d9dcef1b32fed67db7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60994 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
Benni Mack authored
Locales resolves the user-defined TYPO3-languages and its dependencies via TYPO3_CONF_VARS, which are only finally available when all extensions' ext_localconf.php is included. For this reason, Locales::initialize() can be deprecated and moved into the regular constructor, but then the Bootstrap should not do the initialization anymore, which happens at the point now, when Locales first gets initialized (which happens in Frontend within TSFE and PageRenderer and in Backend within $LANG). For this reason, it is removed from Bootstrap, where it was first placed in TYPO3 4.6 when no proper bootstrap set up was given. Resolves: #88569 Releases: master Change-Id: Ife2e248412c1b206abffcdd21df0d01e44834cea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61046 Tested-by:
-
Benni Mack authored
SiteMatcher is a container around SiteFinder now as PseudoSite handling was removed, so SiteFinder can be used directly. Resolves: #88568 Releases: master Change-Id: Ib0f5a42351ed5c11c25458b74074b80f5c574bbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61043 Tested-by:
-
Alexander Schnitzler authored
This patch removes the automatical registration of two types of validators. - model validators - type validators Model validators are those validators that follow a specific namespace and class naming derived from domain models. Given a model \Vendor\Extension\Domain\Model\Foo, extbase searched for a valiator \Vendor\Extension\Domain\Validator\FooValidator. If it existed, it had been registered automatically and could not be disabled at all. Type validators are similiar to model validators. Given a non model action parameter or model property like int, string, float, DateTime and such, extbase searched for validators in the namespace TYPO3\CMS\Extbase\Validation\Validator. There is a TYPO3\CMS\Extbase\Validation\Validator\StringValidator for example which had been registered for string type params and properties. Said validators could not be disabled at all. There are several reasons why the automatic registration has been removed: - First of all, this behaviour led to an unknown amount of actual registered validators. Developers that are new or simply not familiar with the concept of validation magic could easily become frustrated. - Then there is the problem that validation takes place, no matter if it was needed or wanted. A domain validator, which looked quite handy in the first place, had to be reduced to the validation logic that would fit all cases where according objects had been passed into methods. No matter the context. The context however matters a lot. One might want to have different validation rules depending on if objects are created, updated or deleted. This distinction was impossible and therefore model validators could be a burden. - Last but not least, the automatic registration is a problem when introducing validation groups. Validation groups cover the context aspect mentioned earlier. By grouping validations one can create and register different validators and apply them given by contexts like create, update, delete and such. Releases: master Resolves: #87957 Change-Id: If8f590a1bedb428c8884cd61828d8cc671ee92e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60298 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Susanne Moog authored
Some unit tests still have problems on Windows. - setlocale will not error even if the locale is not found - file permissions don't work the same as the unix style version - absolute paths do not start with a slash - files from finder may contain mixed slashes - generating different hash values when used as key Tests have either been adjusted to accomodate the differing behaviour or skipped if appropriate. Resolves: #88552 Releases: master Change-Id: I32344c2a0a0797db087a3ccad45d3b626715ab77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60945 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
When parsing TypoScript, PageTSconfig and UserTSconfig is taking into account for evaluting if "TSFE.constants" is set in PageTSconfig. If this is used, this acts as a default constant. However, this feature has various drawbacks, and has been superseded by actually having constants globally (FE/BE) and via Conditions available. For frontend calls with empty pagesection caches, this improves performance greatly, especially in pages on a deeper level (recursion). This also reduces the footprint to have the TypoScriptParser (incl. condition matching) being called too often. Resolves: #88564 Releases: master Change-Id: Icbdfa9918a9a79510a87198bf033c4de96d71107 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61034 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jun 14, 2019
-
-
Georg Ringer authored
The following methods of `\TYPO3\CMS\Core\Utility\VersionNumberUtility` are unused and can be deprecated: - `splitVersionRange` - `raiseVersionNumber` - `convertIntegerToVersionNumber` Resolves: #88554 Releases: master Change-Id: I28378a39d7cae4d2ae09cfb6a85c5d294565a2f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60997 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
There are a lot of places where AbstractUserAuthentication and the dependents (BE/FE user auth) set various settings, both in the constructor and the start() method. All possible settings are now moved to the constructor, or to dependent properties in subclasses. Some changes are now in place: - UserAuth->loginType must be set now (which was previously in start()). This is now checked in the constructor. - Most of the variables (sessionTimeout/sessionDateLifetime) are now set and evaluated inside the constructor, making start() much simpler to understand and read. Resolves: #88527 Releases: master Change-Id: Ie03b8b93f869f5bafae8f660d6c983bec308f2fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60875 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #88262 Resolves: #85346 Releases: master, 9.5 Change-Id: Ia72ef1b670841d90ec0251c99b7f4d3dc1e7770a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60900 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Sven Juergens <typo3@blue-side.de> Tested-by:
-
Benni Mack authored
Introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895 cHash's that are used within the URL but not needed anymore, should rather create a redirect instead of silently unsetting the cHash argument. Related: #41033 Resolves: #88531 Releases: master, 9.5 Change-Id: Iaae3e72160c055f8848942d506f7cc3e25d31af4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60905 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Jun 13, 2019
-
-
Benni Mack authored
The two TypoScript options * config.htmlTag_langKey * config.htmlTag_dir have been removed, as they have no effect anymore in TYPO3 v10, which only works with Site Handling. Site Handlings "direction" and "twoLetterIsoCode" are already in place and used when Site Handling is active. Resolves: #88560 Releases: master Change-Id: I8ef2a8b8ccd9c790fd7db940e908e8a362ec4ca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61003 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
Various documentation in TSFE is updated, in addition to having $TSFE->setAbsRefPrefix() to be set within the postProcessing to overcome issues when the call is forgotten in custom TSFE instances. Resolves: #88555 Releases: master Change-Id: Ib3ce22db1e6ce7b0985d486d584c26f25755efa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60998 Tested-by:
-
Dmytro Nozdrin authored
Conditions with `tree.rootLineIds` if matched caused page cache regeneration on each request. Resolves: #88374 Releases: master, 9.5 Change-Id: I5a9a2a429a80575b654a6894a3515c8ca8ec8db4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60771 Tested-by:
-
Benni Mack authored
For further TSFE-related changes, the frontend request workflow now stores user-/session-related information in the middleware. This is a first step in order to reduce the dependencies of TSFE + FrontendUserAuthentication. This patch is breaking as certain hooks (like EOFE) do not have session data stored anymore. Related: #88540 Resolves: #88541 Releases: master Change-Id: I1e9a66b759d6edfd4c0e5a8ede02aa7a73b65b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60939 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
The only occurrence for 'loginSecurityLevel' checks for empty and falls back to 'normal' (also defined in #81852 this must be set to normal). Single usage in AbstractUserAuthentication: trim($GLOBALS['TYPO3_CONF_VARS'][$this->loginType]['loginSecurityLevel']) ?: 'normal'; Instead of having this set to "factory configuration", (= writing to LocalConfiguration.php on new installation), this can be set to 'normal' in DefaultConfiguration directly. EXT:rsaauth can be configured to set this to "rsa" in an instance with RSA enabled (and has already done so before). The main benefit is that this option (if set to "normal") can be removed from LocalConfiguration if set to "normal" as it is then taken from DefaultConfiguration.php Resolves: #88549 Releases: master Change-Id: I2f8c088230b334a03c5acf9d09721dd42e67c059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60972 Tested-by:
-
- Jun 12, 2019
-
-
Gianluigi Martino authored
Add title to the two topbar buttons on the left: - Minimize/maximize module menu - Collapse page tree Resolves: #88385 Releases: master, 9.5 Change-Id: I9641bdf5454f1f50e6c4ab67c96f663b8b5d8c73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60862 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Benni Mack authored
Extensions should make use of TYPO3's native functionality for using FAL-based folders, or the Environment API and TYPO3's File APIs to create folders when needed. The ext_emconf.php option "createDirs" option is removed, and not evaluted anymore. The public method `ensureConfiguredDirectoriesExist` in FileHandling Utility is removed, however the class is marked as internal. This change is a pre-work for the CLI Initiative where there are currently workarounds in using this functionality for "activating" an extension. Resolves: #88525 Releases: master Change-Id: I52ec31da541d3740977068981944bd5a1dd0d2f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60485 Tested-by:
-
Benni Mack authored
With the introduction of CKEditor in TYPO3 v8, the support for images in RTEs is dropped, however functionality was kept for compatibility with RTEHtmlArea, which was still available in TYPO3 v8 as separate extension. The functionality to handle images in CKEditor is possible to be applied again, however, as this cannot be managed properly via FAL in its current state, the previous functionality is remvoed from Core. Separate CKEditor extensions as already published, are able to manage the image handling in CKEditor directly already. Dropped * setting TYPO3_CONF_VARS[BE][RTE_imageStorageDir] * transformation setting "ts_images". * softref "images" logic * ImportExport->getRTEoriginalFilename() * RteHtmlParser->TS_images_rte() * CLI Command: cleanup:rteimages and Class RteImagesCommand Resolves: #88500 Releases: master Change-Id: Ie564b19a7d0f9b7d46398094c8d7ecd845e31a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60886 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Jonas Eberle authored
Fix two issues in the extension configuration tool if more than one extension is using the same configuration key: * Remove duplicate HTML IDs in extension configuration tool * Correctly add hidden fields with value=0 for checkboxes within every sub-<form>, not only on first occurence (first extension) of any given configuration key Resolves: #88426 Releases: master, 9.5 Change-Id: Ifbdb3b495443aa5521a4b5265ae3c29c2bc222b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60831 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Jun 11, 2019
-
-
Anja Leichsenring authored
Switching from accessibleMock to prophecy resolves a lot of failures. Also, using a concrete instance instead accessibleMockForAbstractClass reduces issues. Resolves: #88530 Releases: master, 9.5 Change-Id: I102597f74a98443fe139a76b8f168abf61349e3d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60903 Tested-by:
-
- Jun 10, 2019
-
-
Stephan Großberndt authored
Releases: master Resolves: #88535 Change-Id: Ibeb645965840c8c4e78f5e4d13272db32e9fc308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60933 Tested-by:
-
- Jun 09, 2019
-
-
Andreas Fernandez authored
If a backend usergroup has no permission to edit page properties, the wizard for content element creation is not rendered properly. This is due to a missing import of the `PageActions` module. This patch now always loads the module and makes its callback depending on proper permissions. Resolves: #88532 Related: #87687 Releases: master, 9.5 Change-Id: Ie3acaf8fbf9bdeee425eae4b4d35cb2eb80b4d1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60907 Tested-by:
-
- Jun 08, 2019
-
-
Benni Mack authored
If a cHash GET parameter is given, but there are no GET parameters that are relevant, a hash_calc() call against an empty string is done. However, the change now allows an invalid cHash if no check is necessary. This could happen when upgrading from older instances where a cHash is not needed anymore. Bots would not then fill up the error log but get the new page (with a valid 200 result) Resolves: #41033 Releases: master, 9.5 Change-Id: Id02701fcbece371a6b9ce0f92fe0be55dd972325 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895 Tested-by:
-
Benni Mack authored
This patch removes unused variables: $GLOBALS['TYPO3_MISC']['microtime_BE_USER_start'] $GLOBALS['TYPO3_MISC']['microtime_BE_USER_end'] $GLOBALS['TYPO3_MISC']['microtime_end'] $GLOBALS['TYPO3_MISC']['microtime_start'] are replaced by properly using - TimeTracker->start() - TimeTracker->finish() (new method) to encapsulate the logic into the main method. Resolves: #88498 Releases: master Change-Id: I158e4b3aed002f688f117488cb0300c6523e791f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60769 Tested-by:
-
- Jun 07, 2019
-
-
Andreas Fernandez authored
With #88459, the closing tag `</property>` was accidentally not removed, leaving a broken XML structure. This patch removes the closing tag. Resolves: #88526 Related: #88459 Releases: master Change-Id: Iee6ca5f11f12d3f84f5bc0ef4afeefcb3b37bf73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60901 Tested-by:
-
Benni Mack authored
The fat BE User object needs a haircut, and the obvious logic for sending out an email is moved out. Resolves: #88454 Releases: master Change-Id: Id009a975c1d4b75d17c8f5ec2ce06f384dda6e12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60838 Tested-by:
-
Benni Mack authored
Due to incomplete handling of "0" and casting, the fallback is always "0" which is wrong. The patch fixes the behavior and adds tests to all use-cases mentioned in the ticket. Resolves: #88490 Releases: master, 9.5 Change-Id: Ie685b96a94213104729261daa0e3be6e8ef29c35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60879 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
- Jun 06, 2019
-
-
Alexander Stehlik authored
Initialize the d3-drag clickDistance setting to prevent clicks where the mouse slightly moves from being detected as drag attempts. See also: https://github.com/d3/d3-drag#drag_clickDistance Resolves: #88160 Releases: master, 9.5 Change-Id: I646591327e1688258e5d2d6ec3ca54000219f97a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60488 Reviewed-by:
Paweł Rogowicz <rogowicz.pawel@gmail.com> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Oliver Hader authored
This reverts commit 55f7beae. Unfortunately it's not possible to get rid of t3_origuid completely without introducing new side-effects. Remaining test adjustments for #88494 have shown that non-translatable entities used as reference would rather be deleted & re-created instead of synchronized. t3_origuid did a good job there - dropping it would introduce the mentioned regression. Misusing l10n_source for a non-translatable table sounds as stupid as introducing a new field like sync_origuid. Related: #88494 Reverts: #88495 Resolves: #88501 Releases: master Change-Id: I4de8a0cbac1b7c9825991794830efaa53f270709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60888 Tested-by:
-
Georg Ringer authored
The usage of no_cache should be avoided. If still required it can be added by using the setting additionalGetParameters. As the functionality goes into the PageRouter (effectively adds cHash), and it's possible that "no_cache" is completely disabled, it is not necessary to be set. This was not the case in v9 as Site Handling was not available everywhere. On top, if an editor is actually previewing the content on the page (via EditDocumentController "save + view") DataHandler is actually flushing the cache of the page/record associated (e.g. cacheTags for records), which is much more recommended. Resolves: #87347 Releases: master Change-Id: I2bcedb4f92231329234684c9daae2843d08ec29d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59362 Tested-by:
-
- Jun 05, 2019
-
-
Claus Due authored
Prevents multiple division by zero errors when scaling images, by checking that the input image size is valid (meaning non-zero) before attempting to calculate the ratio for scaling - because the ratio is based on the input size parameters that must not be zero. Change-Id: I33fd3e49a1b3dcdc319309af736a9d785130af94 Releases: master, 9.5, 8.7 Resolves: #87954 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60299 Tested-by:
-
c.essl authored
If an admin user switches to another be_user account via the "Switch User" action in the "Backend users" module, the action is now logged to the sys_log. Resolves: #78432 Releases: master Change-Id: I0a9cb35e2d8734eb86ff475afeeac821a2f2a78a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60824 Tested-by:
-
Stefan Frömken authored
- Show how to use messageArguments - messageCode is mandatory (Don't know why, but yes it is) --> As it is mandatory, it does not make sense to write `if needed` - remove `Default value` from mandatory options --> As all calls in TYPO3 Core are strict types, a value like `null` will throw an Exception Releases: master Resolves: #88247 Change-Id: Ibf101a7c35ae01c975dbcaf162ff38f4eef27221 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60631 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Andreas Fernandez authored
The LinkBrowser used in FormEngine is now opened in a modal window instead of a popup. Resolves: #88471 Releases: master Change-Id: I59992b2fc8a9fbf6b01aa2213c024fd0c13de009 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60860 Tested-by:
-
Oliver Hader authored
In order to drop t3_origuid semantics (see issue #88494) according usages should be purged from functional tests. This way functional changes are easier to spot having to dedicated change-sets. Resolves: #88495 Releases: master Change-Id: Ic54efe30bb112b179a176681a3bb067de1791d44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60880 Tested-by:
-
Benni Mack authored
When no constant is given (due to old OS), a PHP warning is now triggered due to PHP 7.2. This is overcome to use the polyfill functionality instead then. Resolves: #88443 Releases: master, 9.5 Change-Id: I5ac673f10bc1421e543b8f969a0111e9bbc9c11e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60844 Tested-by:
Michael Waack <m.waack@i-d.de> Tested-by:
Thomas Anders <me@naderio.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
