[!!!][TASK] Re-organize variable initialization for User Authentication
There are a lot of places where AbstractUserAuthentication and the dependents (BE/FE user auth) set various settings, both in the constructor and the start() method. All possible settings are now moved to the constructor, or to dependent properties in subclasses. Some changes are now in place: - UserAuth->loginType must be set now (which was previously in start()). This is now checked in the constructor. - Most of the variables (sessionTimeout/sessionDateLifetime) are now set and evaluated inside the constructor, making start() much simpler to understand and read. Resolves: #88527 Releases: master Change-Id: Ie03b8b93f869f5bafae8f660d6c983bec308f2fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60875 Reviewed-by:Markus Klein <markus.klein@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
Showing
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php 22 additions, 26 deletions...ore/Classes/Authentication/AbstractUserAuthentication.php
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php 7 additions, 2 deletions...core/Classes/Authentication/BackendUserAuthentication.php
- typo3/sysext/core/Classes/Authentication/CommandLineUserAuthentication.php 3 additions, 4 deletions.../Classes/Authentication/CommandLineUserAuthentication.php
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88527-OverridingCustomValuesInUserAuthenticationDerivatives.rst 48 additions, 0 deletions...OverridingCustomValuesInUserAuthenticationDerivatives.rst
- typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php 5 additions, 2 deletions...ts/Unit/Authentication/AbstractUserAuthenticationTest.php
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php 86 additions, 41 deletions...end/Classes/Authentication/FrontendUserAuthentication.php
Please register or sign in to comment