- Dec 06, 2019
-
-
Andreas Fernandez authored
Executed commands: yarn upgrade jquery grunt build Resolves: #89881 Releases: master Change-Id: I48c48de69f977e949563957d59789156bd5989fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62564 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
Executed commands: yarn add @claviska/jquery-minicolors@^2.3.4 --dev grunt build Also, since the mentioned issues have been solved meanwhile, the library is copied by grunt again. Resolves: #89880 Related: #77317 Releases: master Change-Id: I0d08fec8777b2e6090a98a85115deeb761c20e92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62562 Tested-by:
-
Oliver Bartsch authored
This (re)adds various tooltips through the backend to further increase the accessibility. Especially for buttons that have a different meaning than normal in a particular context. In most cases, they were simply missed but some of them referenced to not longer existing locallang keys or to locallang keys of another sysext which is no dependency of the one where it is referenced. The tooltips are (re)added at following places: - Creating new content element in ext:core new record view - Multiple buttons in ext:core element information modal - Multiple buttons in ext:beuser listing and compare view - Multiple buttons in ext:form form management and form editor view - Multiple buttons in ext:info pagetree overview - New content element record button in ext:recordlist listing view - View redirect button in ext:redirect listing view Resolves: #89566 Releases: master Change-Id: I66cd16413b0e4f188627df06f233a0bba73c3056 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62175 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Oliver Bartsch authored
The update all button in the table head of the extensionMatrix is now disabled by default and only gets enabled if at least one active language pack is installed. This prevents interoperability of the entire card when entering the language pack update process. Resolves: #89561 Releases: master, 9.5 Change-Id: I8f04e0266d45b1257314ec937cc55a2fea603f83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62171 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Alexander Schnitzler authored
The usage of switchable controller actions, both via flexforms and typoscript, is deprecated and will be removed in one the next major versions of TYPO3, probably version 11.0 or 12.0. Switchable controller actions allowed to override the php plugin configuration and to create god plugins, i.e. plugins that can be set into multiple different modes and therefore take care of all possible use cases. Every plugin should serve a single purpose, therefore the usage of switchable controller actions is an anti pattern which will be removed. The switchable controller action mechanic will be removed without replacement which means, that there is no migration path to a similar feature. Instead, extension authors need to create multiple, dedicated plugins for different use cases. Releases: master Resolves: #89463 Change-Id: I41afac9303205f97f390f208803908177e00cda5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Andreas Fernandez authored
All frontend stack related packages get updated to their latest version and a full build is generated. Executed commands: yarn add \ @typescript-eslint/eslint-plugin@^2.10.0 \ @typescript-eslint/parser@^2.10.0 \ @typescript-eslint/typescript-estree@^2.10.0 \ autoprefixer@^9.7.3 \ eslint@^6.7.2 \ grunt-stylelint@^0.12.0 \ grunt-terser@^1.0.0 \ karma@^4.4.1 \ node-sass@^4.13.0 \ typescript@^3.7.2 --dev yarn build Resolves: #89804 Releases: master Change-Id: I48f00a01fb4191b39e76e0859d1f1476644ad07b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62486 Tested-by: -
Benjamin Franzke authored
This reverts commit 26c9a8e3. The schedulers *primary* task is to *schedule* tasks, not to execute them from the backend. The backend-execution is only an additional functionality, which is available because it's sometime handy for manual tasks/testing. We shouldn't mark commands as non-schedulable when scheduling them is a perectly valid usecase. Usecases for scheduling backend locks are: * Planned maintenance locks: schedule a backend lock for a planned update or migration where you agreed to stop editing as of a certain date. * Regular edit-locks, e.g.: schedule a backend lock for let's say every friday as of 8pm schedule backend unlock on mondays at 8am. The reverted patch tried to fix the situation where the lock task was executed from the backend scheduler overview. If we'd want to fix that, the proper fix would be to add another property which states that this command must not be executed from the backend. Releases: master, 9.5 Resolves: #89873 Reverts: #89387 Change-Id: I782809ff065c05adba0653aa208d37e1241eb41a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62551 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Andreas Fernandez authored
The LanguagePackService now uses the RequestFactory to download the mirrors.xml.gz file, since it throws proper exceptions on failures. In case of e.g. a timeout, the thrown exception is properly caught and the designed fallback kicks in. Resolves: #89810 Releases: master, 9.5 Change-Id: Ie4e8bcf02c33eb18e58f505f1a791c1233d6f593 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Michael Telgkamp authored
- Do not toggle node with canToggle!==true - Check if node has parent before trying to go to parent node Resolves: #89847 Resolves: #89864 Releases: master Change-Id: I49f112c15e64103e707481cecb7f61bd58fa8182 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62544 Tested-by:
-
Frank Naegler authored
Resolves: #89834 Releases: master, 9.5 Change-Id: I914c6e8a0739c4380be4fa1c1d165f3eb4f1aecd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62520 Tested-by:
-
Susanne Moog authored
Avoid a TypeError exception in NewContentElementController in newer PHP versions because of an undefined array access. Resolves: #89860 Releases: master, 9.5 Change-Id: I5728638a3f5800588f17bef202fe5814e79d7f2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62540 Tested-by:
Tobias D. <tobias.doll@snk.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Dec 05, 2019
-
-
Anja Leichsenring authored
The rearranged stages structure will prevent the host machines and also gerrit from being overwhelmed with a high amount of running jobs all at once. Instead, the equal size of each stage keeps the load on an average height, but it will increase the total runtime of a plan. We prefer stability over quick runs in nightlies. Resolves: #89865 Releases: master, 9.5, 8.7 Change-Id: Ib915053e83d087007242c05886619faf8d7cee0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62546 Tested-by:
-
Oliver Hader authored
Resolves: #89854 Releases: master, 9.5 Change-Id: I07aaab48ae504ee2b9e0fa5e37b725c6bb873e67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62535 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Dec 04, 2019
-
-
Oliver Hader authored
Resolves: #89849 Releases: master Change-Id: I0780f857cd058c38692344106af3f6fef9f7d549 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62533 Tested-by:
-
Anja Leichsenring authored
At least one functional and one acceptance tests run on pre-merge tests should use PHP 7.4. There are three (with tree DB systems), so each one uses now one of the supported PHP versions and one of the supported DBMS. A complete test run is done during nightly runs due to time constraints. Resolves: #89841 Releases: master, 9.5, 8.7 Change-Id: Ie0bbe7309b63142f425bd2ff45c247e70d58fd06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62530 Tested-by:
-
- Dec 03, 2019
-
-
Anja Leichsenring authored
Resolves: #89668 Releases: master, 9.5, 8.7 Change-Id: I098c573aaa13846f45c1f1904f46db5cdecf4db1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62316 Tested-by:
-
Benni Mack authored
Change-Id: I0e8abdb62a45326896fc75d9872eead478615dce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62525 Tested-by:
-
Benni Mack authored
Change-Id: I09bb29716abb1a7b1f4c8010c1d98c15ae90d808 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62523 Tested-by:
-
Andreas Fernandez authored
Resolves: #89837 Related: #89813 Releases: master Change-Id: Idfb9274c7a5415e6bef7dee61a6ca65728d96674 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62522 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Benni Mack authored
Some changes were made: - Upgrade Wizard works - Visibility on RedirectHandler is sorted out - TreeUidListProvider is removed - cObject does everything already, less dependencies - PasswordChangeEvent is actually executed now (and works!) - RedirectConfiguration now has a factory - Do not use ConnectionPool as dependency as it contains state - Most "final" and "private" were put back to "protected" (as the rest of core) - except events - Additional hmac check in Repository - Add lifetime validation of hash in changePassword action as well Resolves: #89828 Related: #84262 Releases: master Change-Id: I813a2fc86c8e4f61fd923467aa761246187af901 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62516 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Building reflection cache in ClassSchema on static class properties will lead to side-effects. For instance when ConnectionPool is analyzed for being used with Extbase dependency injection and has been used already during runtime - which is very likely - static property $connections is going to hold all runtime connections. https://www.php.net/manual/en/reflectionclass.getdefaultproperties.php: > This method only works for static properties when used on internal > classes. The default value of a static class property can not be > tracked when using this method on user defined classes. That's why default values of static properties are not resolved anymore. Resolves: #89830 Releases: master Change-Id: I0040c3e4327d084b3192017874154ab5d8466508 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62518 Tested-by:
-
Susanne Moog authored
composer require --dev typo3/testing-framework:~6.1.0 Also reverts changes to tests for phpunit 8.3 only. Resolves: #89833 Releases: master Change-Id: I834f70452775ea18960da162bb2affe459b8556a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62519 Tested-by:
-
Georg Ringer authored
Simplify the UI of the toolbar by hiding the select field if there is only one option to choose from which doesn't make sense. Resolves: #89829 Releases: master Change-Id: I6e58aae1bab25777bca21f058524e447f569d73a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62517 Tested-by:
Joerg Kummer <typo3@enobe.de> Reviewed-by:
-
Susanne Moog authored
The testing framework has been reworked and slimmed down. To make use of it, tests had to be adjusted. composer require --dev typo3/testing-framework:"~6.0.0" Resolves: #89815 Releases: master Change-Id: Ib0a8d7436070ef17be96a5f4011f796dd15b09fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62502 Tested-by:
-
- Dec 02, 2019
-
-
Andreas Fernandez authored
In case an old installation still has empty values stored in `EXTCONF/lang/availableLanguages` (which has been fixed in #63546), e.g. the language matrix in the "Manage Language Packs" is unusable. This patch therefore removes empty values from the mentioned configuration, as similar solved in the old issue. Resolves: #89772 Related: #63546 Releases: master, 9.5 Change-Id: Id7473e5f17878d84914fec4df629ac6617256b55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62497 Tested-by:
-
Michael Telgkamp authored
- Pagetree is focusable via tab key - Keyboard navigation with arrow keys inside pagetree is enabled - Implement accessible tree structure for tree nodes (role=tree) Resolves: #86818 Releases: master Change-Id: Ic948fb0de8461a8c5b4b5297b94e5cb94465ec42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62051 Tested-by:
-
Susanne Moog authored
Some change log entries should be documented in extension manuals or in ViewHelpers. The missing docs have been added. Resolves: #89827 Releases: master Change-Id: I6c76dc2d532b151275c60e85feb44f227ca80919 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62515 Tested-by:
-
Daniel Siepmann authored
There were some minor syntax issues within changelog that are now fixed. They prevented: * Rendering of lists * Rendering of code blocks * Rendering of inline code Resolves: #89825 Releases: master Change-Id: Ic272e989e7841eac8c6f04f4819354b0926cd6df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62510 Reviewed-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Benni Mack authored
Extbase's old signal slot dispatcher / core should not use classes that are not explicitly required for the miminum packages. Resolves: #89823 Releases: master Change-Id: I41f7e378ed3d99e62daebfdd5631ef0234761772 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62508 Tested-by:
-
Andreas Fernandez authored
The issue #89687 introduced a smaller response for page tree nodes by moving sane default attributes to JavaScript and overriding with the actual result. However, this is also done if a new page is created via drag&drop, the attribute get in a mixed state and page tree hurts itself in confusion. The default attributes are now applied only if no DataHandler command is invoked. Additionally, some variables in TreeController were wrongly used, which has been fixed as well. Resolves: #89822 Related: #89687 Releases: master, 9.5 Change-Id: Ia91b02eaf534cb1ce65a09e1c78fa6343630bdcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507 Tested-by:
Claus Due <claus@phpmind.net> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
docker-compose is updated to use the latest cumulative update (cu) of MSSQL 2017. Since mssql is probably still eager to fail, its stages are executed at last in the nightly builds now. Resolves: #89826 Releases: master, 9.5, 8.7 Change-Id: Ic1e8195f9b4f90747b5843d03630fd453ebe0bc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62511 Tested-by:
-
Benni Mack authored
There are numereous places where reflection is used in our test cases to inject dependencies, however there are methods available doing so, so the tests can be adapted, which will speed up tests. In addition, the $callInaccessibleMethod() function is also replaced by the accessible mock functionality, resulting in faster results than reflection. Resolves: #89824 Releases: master Change-Id: Ia2fc8a8ee4d3b5fc7b0d2de8759a7e5e9ceb7b87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62503 Tested-by:
-
Benni Mack authored
Using the freshly released version 2.6.8 in our packages adds PHP 7.4 support for Fluid Standalone. composer req "typo3fluid/fluid:^2.6.8" Resolves: #89819 Releases: master, 9.5, 8.7 Change-Id: I986b3f8e73e3114af3aef9f65b42c3bf109f9f39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62504 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #89820 Related: #89813 Change-Id: I165dbb813079fbb0f25ac7b1c8ab57f292f73b16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62506 Tested-by:
-
Benni Mack authored
The following new PSR-14 events are added: TYPO3\CMS\Core\Configuration\Event\ModifyLoadedPageTsConfigEvent TYPO3\CMS\Backend\Authentication\Event\SwitchUserEvent TYPO3\CMS\Backend\Controller\Event\BeforeFormEnginePageInitializedEvent TYPO3\CMS\Backend\Controller\Event\AfterFormEnginePageInitializedEvent TYPO3\CMS\Backend\LoginProvider\Event\ModifyPageLayoutOnLoginProviderSelectionEvent TYPO3\CMS\Impexp\Event\BeforeImportEvent TYPO3\CMS\Install\Service\Event\ModifyLanguagePackRemoteBaseUrlEvent TYPO3\CMS\Linkvalidator\Event\BeforeRecordIsAnalyzedEvent TYPO3\CMS\Seo\Event\ModifyUrlForCanonicalTagEvent TYPO3\CMS\Workspaces\Event\AfterCompiledCacheableDataForWorkspaceEvent TYPO3\CMS\Workspaces\Event\AfterDataGeneratedForWorkspaceEvent TYPO3\CMS\Workspaces\Event\GetVersionedDataEvent TYPO3\CMS\Workspaces\Event\SortVersionedDataEvent They replace the following "old" signals with a deprecation layer: TYPO3\CMS\Backend\LoginProvider\UsernamePasswordLoginProvider::getPageRenderer TYPO3\CMS\Backend\Controller\EditDocumentController::preInitAfter TYPO3\CMS\Backend\Controller\EditDocumentController::initAfter TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfigPreInclude TYPO3\CMS\Beuser\Controller\BackendUserController::switchUser TYPO3\CMS\Impexp\Utility\ImportExportUtility::afterImportExportInitialisation TYPO3\CMS\Lang\Service\TranslationService::postProcessMirrorUrl TYPO3\CMS\Linkvalidator\LinkAnalyzer::beforeAnalyzeRecord TYPO3\CMS\Seo\Canonical\CanonicalGenerator::beforeGeneratingCanonical TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_BeforeCaching TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_PostProcesss TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GetDataArray_PostProcesss TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_SortDataArray_PostProcesss Relates: #89733 Resolves: #89813 Releases: master Change-Id: I13f2454fd8f4efb5f4c5248d0b839634b77578db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62422 Tested-by:
-
Jo Hasenau authored
Due to deprecations (in v9) and marking properties from public to protected, some hooks are not as powerful anymore, so special getter methods are provided to overcome this issue. Resolves: #87064 Releases: master, 9.5 Change-Id: I5a05bb8b31c2a9df2801092bd9ead60061bbd15f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62480 Tested-by:
-
Benni Mack authored
Tests should be consistent and reflect the way we do things in Core. However, testing framework offers too many different ways to do things, and "_callRef" is one of that. Resolves: #89817 Releases: master Change-Id: I44759df255365d0f90e0928f3f5726b66ecf9f3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62493 Tested-by:
-
- Nov 29, 2019
-
-
Patrick Broens authored
In some versions of PHP there is a PCRE bug, which will be triggered when using an unquoted array syntax in Fluid templates, leading to an error and possibly not able to display the rendered template. This is solved by using the quoted array syntax where it is not used yet. Resolves: #87970 Releases: master, 9.5 Change-Id: I36f4ee86765fae24f7daa0e7e59ff9fc6741144f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62450 Reviewed-by:
Rens Admiraal <rens@simplyadmire.com> Reviewed-by:
-
Benni Mack authored
TYPO3 Core now requires at least doctrine/annotations 1.7, effectively helping to upgrade to PHP 7.4. Resolves: #89812 Releases: master, 9.5 Change-Id: I8ca951711bbcb19d935baad67ff69705d8e51aa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62498 Tested-by:
-
Benni Mack authored
The normalizedparams middleware is not executed in the install tool anymore, which is added by the NormalizedParamsAttribute middleware. In addition, the NormalizedParams class now contains factory methods for building up NormalizedParams based on $_SERVER or a PSR-7 request object. Resolves: #89808 Releases: master Change-Id: I1b3713ba22f100f652d746ae15f58f9024808ef1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62494 Reviewed-by:
-
