- Apr 19, 2020
-
-
Oliver Hader authored
Module TYPO3/CMS/Core/DocumentService provides native JavaScript functions to detect DOM ready-state returning a Promise<Document>. `$(document).ready(() => {...});` can be replaced by `documentService.ready().then(() => {...});` Resolves: #91122 Releases: master Change-Id: Id812f786430f1ced6265493dd0bae472b8144588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64241 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Josef Glatz authored
This patch takes the changes of the new documentation theme into account. Releases: master, 9.5 Resolves: #91102 Change-Id: I3308819227dc4a66f0571e4b5afdc49939f19026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64223 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Andreas Fernandez authored
When the MultiStepWizard is used with additional click events bound to the next or prev button, those event got stacked as the buttons don't change per step. To fix this issue, all click events are removed after switching a step and the original click event to switch the step is bound again. Furthermore the 'savePath' for duplication of a form is now correctly set if there is only one folder available and therefore no select element present in the modal. Resolves: #91094 Releases: master Change-Id: Ic95d2222441c8e1e8cf9fb46e5e7437d4e4ed85e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64214 Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
- Apr 18, 2020
-
-
Richard Haeser authored
No additional classes are needed anymore to initialise the graphs in Dashboard Widgets. If a graphConfig is given the chart will be initialised. Resolves: #91100 Releases: master Change-Id: Id25d272e4287a0248d982b600f792e5e32e76445 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64220 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benjamin Franzke authored
The installtool sends a mail when a login happens when TYPO3_CONF_VARS.BE.warning_email_addr is set. When TYPO3_CONF_VARS.EXTENSIONS.backend.loginLogo is set to provide a custom backend logo, that logo is used by the FluidEmail template via f:image viewhelper. Therefore we need to provide MetaDataRepository, as the f:image viewhelper will use that service. The (implicit) dependency chain is: <f:image> -> Resource\File -> MetaDataAspect -> MetaDataRepository Releases: master Resolves: #91107 Related: #89892 Change-Id: If4e73d607d2a6e21646ea91bd8f0a39742f133d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64236 Tested-by:Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Superfluous inline events have been removed or replaced with native HTML functionality (location.href -> anchor). Resolves: #91110 Releases: master Change-Id: I594fe2df3c71234de096e437b5662867469ffbb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64229 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Eßl authored
Resolves: #91103 Releases: master Change-Id: If342b9bf69574b54d598e342c3bb2773dba582cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64224 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #91112 Releases: master Change-Id: I6fef3f196afd44a11fbd5d688bec45457a28aad6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64231 Reviewed-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Richard Haeser authored
Corrected way of accessing the AJAX urls by using the dot notation. Resolves: #91113 Releases: master Change-Id: I6c3fd48707f3d45c5432ac1e11f77b0c33d577ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64232 Tested-by:
-
Benni Mack authored
Made sure EXT:dashboard follows the guidelines for usage of ext_localconf and ext_tables and some other changed to make the code more consistent with other system extensions. Resolves: #91108 Releases: master Change-Id: I82d957a9e13aee8504b6bf8df6a3145b8fb6a5db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64221 Tested-by:
-
Anja Leichsenring authored
The changelog files for the version 10.4 must leave the master folder now and move to their final home in 10.4. Resolves: #91106 Releases: master Change-Id: Ia2a97ef805653c2179426da9c228b052b6801472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64226 Tested-by:
-
Oliver Hader authored
Using HTML form elements without actually making use of typical consumers (input, textarea, select, ...) seems to be superfluous. Resolves: #91101 Releases: master Change-Id: I37a6647f162a8b1f3f8394ad04458830abca0e26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64222 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
-
Benni Mack authored
YAML configuration set in a site configuration under the main key "settings:" are now available as TypoScript constants in templates and as constants in page TSconfig. This feature is a replacement for the former page TSconfig functionality "TSFE.constants", which has been removed. A former replacement approach had to be reverted in v10.1. Resolves: #91080 Resolves: #91081 Releases: master Change-Id: Ia5cd4e94049a359a23418c1fdb122a0d5f8c7311 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64128 Tested-by:
-
Tobi Kretschmann authored
Resolves: #90729 Resolves: #90578 Releases: master Change-Id: I9ce6b678addcc9e65e7e4e7b70e3187d91b7456a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63886 Reviewed-by:
-
Benni Mack authored
Resolves: #91091 Releases: master Change-Id: I88c8c7c7119d7dae485eb6013ce05aaee42145d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64213 Tested-by:
-
- Apr 17, 2020
-
-
Andreas Fernandez authored
Resolves: #91099 Releases: master, 9.5 Change-Id: I08ea8ecfc7096a21b0ffddee0b4e3976363fffd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64219 Tested-by:
-
Benni Mack authored
In order to build a stronger Permission Handling system and a stronger API for TCA resolving in TYPO3 v11, several methods and public properties have been marked as "internal". These continue to be working as is for TYPO3 v10 LTS, but are now marked as internal - most of the code has been coming from PHP4 where no visibility restrictions have been available back then. Resolves: #91095 Releases: master Change-Id: Ibb47739a0cdec5eae19fafa2e376eeb609aa6c53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64162 Tested-by:
-
Helmut Hummel authored
All commands that are added via Configuration/Commands.php are instantiated and prepared when the "scheduler:run" command is executed. This preparation includes setting the Application object. If this Application object is present in an Command object, calling the run method of the command will cause a merge of the application's arguments with command arguments. Since command objects in symfony/console and TYPO3 are more or less singletons, these merged arguments will stay merged on a second "instantiation" of the command through when scheduler executes the second task with the same command. Therefore we must SKIP the validation of the new Input object we create and pass to the command's run method, so that this validation does not fail due to the missing command argument. It also does not matter that we skip validation, because validation happens implicitly when calling the run method on the command object. Only Symfony code is "smart" enough to set the command argument, when it was not present before. Resolves: #87312 Releases: master,9.5 Change-Id: I75677493216961fd7559a923e94e7831e07921bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63964 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
Andreas Fernandez authored
The page module now doesn't try to update the flag icon of a dragged record if the page module is not in "language" mode as the required information is not available. Resolves: #91096 Related: #90693 Releases: master Change-Id: I1c796a6f4b00761f3310335cf45256d75a7e3bc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64218 Tested-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer Releases: master Resolves: #91092 Change-Id: I80956bc210237169034acd86ef26c1e8f9725ddb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64212 Tested-by:
-
Helmut Hummel authored
It is now possible to limit restrictions to a given set of table aliases by using the introduced \TYPO3\CMS\Core\Database\Query\Restriction\LimitToTablesRestrictionContainer. Example: $queryBuilder->getRestrictions() ->removeByType(HiddenRestriction::class) ->add( GeneralUtility::makeInstance(LimitToTablesRestrictionContainer::class) ->addForTables( GeneralUtility::makeInstance(HiddenRestriction::class), ['sys_language'] ); Resolves: #87776 Releases: master Change-Id: I7fc7108ccac93d50cfab6fa8a74809f1dfe2bd89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60781 Tested-by: -
Richard Haeser authored
Most classes used in EXT:dashboard are internal classes and are now marked as internal and therefor not part of the public API. Resolves: #91093 Releases: master Change-Id: Idd9ccf423b6330908487fd1278163f51b64f50d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64216 Tested-by:
-
Benni Mack authored
Some code related to templating / cached TypoScript, inclusion of CSS/JS and internals like "indexedDocTitle" which has now a proper PageTitle API, is marked as internal now, so further refactorings can happen in the next major release. As all replacements are in place for this functionality, extension authors can and should already use new APIs instead of relying on TSFE for this logic. Resolves: #91079 Releases: master Change-Id: Ic24c607dd620d1cfe7966484d5272491aa5f429a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64199 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Oliver Hader authored
Change https://review.typo3.org/c/Packages/TYPO3.CMS/+/61223 (v10 only) modified Extbase referring argument handling. This change reintroduces `$internalArguments['__referrer']['arguments']` to be used when redirecting back to original request action in case some validation errors occurred - otherwise those arguments are lost. This basically reverts commit 19b5ee0f (adjusted for code clean up and refactorings that happened in between) Resolves: #89434 Releases: master Change-Id: Id83f38d20ecd482b517c37c4244d871a40ff0a89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63152 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Benjamin Franzke authored
This will allow both, dependency injection for these services (manually wired in service providers), and usage in install/maintenance tool (where we do not use the caching symfony container for basic tasks). The move to DI is possible thanks to the failsafe container and the service providers which can fed the failsafe container with service factories. These factories are used to wire services manually. Notes: * The definition in a service provider means we are required to use manual wiring and are forced to define the dependencies in the service provider when we add new depenencies to services that are being used by the install.. With that approach we can assure that we do not accidentally add new dependencies to services which would become available in symfony DI due to autowiring, but would be unavailable in the install tool. * The install tool has operations that require a booted symfony container which is provided by the LateBootService. Services that are used in that mode do not need to be listed in service providers. Therefore we do only add core services to service providers if they are used in a context without a fully booted symfony DI container. * GLOBALS['LANG'] mocks in Core\Tests\Unit\DataHandling\DataHandlerTest have been removed as the code under test does no longer use $GLOBALS['LANG']->csConvObj->substr() but mb_substr. The test had been introduced with #68602 but the tested code was adapted in #78670. * We got a bit ugly constructs now, where a unit(!) test previously used $GLOBALS['LANG'] = new LanguageService(); …we now have to encode the dependency structure: $GLOBALS['LANG'] = new LanguageService(new Locales, new LocalizationFactory( new LanguageStore, $cacheManagerProphecy->reveal() ) ); This isn't nice, but this change reveals that the affected unit tests should either be adapted, removed or be moved to a functional test. Such adaption are out of scope for this change. * loadExtLocalconfDatabaseAndExtTables() is removed from the EXT:install AbstractController, as it hides the implicit dependency to LateBootService * Nullable constructor arguments have been changed to be non-nullable whenever possible. That results in some more test adaptions, but reveals, where unit tests rely on implicit dependencies and offers better readability and less possible codepaths. Releases: master Resolves: #89892 Resolves: #89891 Change-Id: Ib72d6440f81b2c0d05279e8768697c3b48aecfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62575 Tested-by: -
Richard Haeser authored
For proper animations during drag / drop of the widgets at the Dashboard, we need a Web Animations API polyfill for some browsers. This patch replaces the current polyfill with a lightweight MIT-licensed library. Resolves: #91072 Releases: master Change-Id: Ic04d97ab1d1a16a99aa92522552b4b060ced31e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64206 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Hader authored
Arrow functions keep using their own `thisArg` on invocation. To be able to avoid unscoped `function()` call and still retrieving `targetElement` it is passed explicitly as 2nd callback argument. Resolves: #91084 Releases: master Change-Id: I3f1087713827605ac8b59f18eb4a59becd67e460 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64209 Tested-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/backend/Classes bin/rector process --set=php53 typo3/sysext/backend/Tests Releases: master Resolves: #91064 Change-Id: I9e91882ab233b0e34bc991fd348fceba197a91ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64187 Tested-by: -
Christian Eßl authored
The changes made in #90135 introduced a regression, that made the PageContentErrorHandler ignore the enabled flag of the requested language. Resolves: #91013 Related: #90135 Related: #87865 Releases: master, 9.5 Change-Id: I23504caab2f060c49f112d7bc529e71d02939486 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64131 Tested-by:
-
Benjamin Franzke authored
PackageManager can not have DI tags assigned as it is a early container instance (injected from core Bootstrap). That caused the 'packagesMayHaveChanged' event to never be executed. We rather need to hookup the event listener using a service provider that extends the ListenerProvider. (That's pretty much the same, what the DI tags do in the background as well.) Notes: 1) To avoid similar future mistakes we also remove the unneeded `autoconfigure: false` from Configuration.yaml 2) This restriction (no DI tag configuration) does only apply to early instance services, which is a static list of core TYPO3 services. 3) We additionally drop the currently unused event callback PackageManager::beforeInstallationEventListener. It was not fully migrated to a PSR-14 event callback in #90249, which revealed that it is actually unneeded. The signal callback was introduced with #52766 in EXT:extensionmanager/ext_localconf.php, but became obsolete with later fixes: #71071 and #71455 ExtensionManagementService now calls (through Install/ListUtility) directly into packageManager instead of (mis-)using a signal/event. Resolves: #90955 Related: #90249 Releases: master Change-Id: I8943e6149743d527c9e1157e425eed3afa98b0d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64156 Tested-by:Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Daniel Siepmann authored
Initial documentation covering basic editor, integrator and developer tasks. Resolves: #90340 Releases: master Change-Id: Ib4917b8f618062ec2f6566415bee7fdf611a2dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63754 Tested-by:
-
Tymoteusz Motylewski authored
Do not calculate permissions for every page, as we're limiting the pages through SQL query constraints. Fetch sys_language_uid and l10n_parent from db as they are required for isInWebMount to prevent it from fetching row from db again. Pass full row to isInWebMount in calcPerms instead of just uid. isInWebMount has logic to handle translated records. Resolves: #91037 Related: #90105 Releases: 9.5, master Change-Id: I56dbaf3daa15aa8b6f0fc5e09b212aa34203a0b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64175 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Christian Eßl authored
Add checks to use proper permissions in the DataHandler class, as in some cases, where the record is not a page, the PAGE_DELETE permissions were used instead of CONTENT_EDIT. Resolves: #90878 Related: #90019 Releases: master Change-Id: Ic10dc132391044ae0c98b93316d877053a091b70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63999 Reviewed-by:
-
Benjamin Franzke authored
A booted symfony container is needed as ext_localconf.php is loaded since #89713 for the "Check TCA" action. ext_localconf.php files may depend on a fully-booted symfony container, therefore we need to provide it in this case as well – or ext_localconf.php loading may fail. Adapt the LateBootService to allow to reset to a previously backuped container (even if it has been reset in the meantime by another method). Currently affected extensions were EXT:news before commit ac0cb20c (which added a workaround for this case). Thus the bugfix can be verified against the parent of that commit: georgringer/news:205cb3e Releases: master Resolves: #91073 Related: #89713 Change-Id: Iaceb5efae26c1ae2e08e0db31ff2c223cc803ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64190 Tested-by:
-
- Apr 16, 2020
-
-
Susanne Moog authored
The interfaces of the dashboard have been moved out of the interfaces folder to be consistent with the overall TYPO3 structure. Additionally, the superfluous button utility has been removed. Releases: master Resolves: #91066 Change-Id: Iaad0c1d8d046b467ee44d8cbbe32f8803c737fae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64201 Tested-by:
-
Benjamin Franzke authored
Since #90266 install tool E-Mails are templated and custom logos, viewhelpers or services may be loaded. A custom backend login logo caused the usage of the f:image ViewHelper which triggered the FileIndexRepository which wasn't configured for the install tool context. Therefore we need to provide a fully booted symfony container in order for dependency injection to work for all core and third party extensions, especially when using a customized SystemEmail template. Resolves: #91067 Releases: master Change-Id: Ia2cb06dfecd7bb9bd757b37849c1345e538dfffc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64205 Tested-by:
Martin Hotmann <martinhotmann@gmail.com> Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` events. * extracts inline JavaScript from templates * introduces `TYPO3/CMS/Backend/GlobalEventHandler` module * adjusts PHP type-hints to their correct & actual values Resolves: #91052 Releases: master Change-Id: If92391bd48f89df57fbb0ed6f8b0936da0e1a49d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191 Tested-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/frontend/Classes bin/rector process --set=php53 typo3/sysext/frontend/Tests Releases: master Resolves: #91063 Change-Id: Ia6a547ec40c1da2c80cabb8a3e0581d628f51c92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64200 Tested-by: -
Alexander Schnitzler authored
Releases: master Resolves: #90910 Change-Id: If03889ee330e96c5ca82b31ae0604fb1d1d0afc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64031 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Chris Müller authored
In the dependency injection examples for defining a console command a colon is missing after the class name. Resolves: #91068 Related: #89139 Releases: master Change-Id: Ieea67cfb3f906037a4fad7da49d3d91613a12855 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64202 Tested-by:
-
