- Feb 03, 2020
-
-
Benni Mack authored
This change updates fluid standalone to 2.6.9, which solves some PCRE-related issues with recent PHP versions. Composer command used: composer update typo3fluid/fluid Resolves: #90308 Releases: master, 9.5, 8.7 Change-Id: I6ba96f4ab1f46a2b8af58a1b2836397dc9493c40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63163 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
If a MountPoint page was overlaid with the Mounted page, a redirect was triggered. This happened because the slugs were not identical, so the Mounted Page was not in the list of the slug candidates. The behaviour is now resolved, as the Mounted Page is now added to the candidates and its slug is replaced by the original slug of the MountPoint page. Resolves: #90307 Releases: master, 9.5 Change-Id: I0a5bcc320b92e8a2e99ace49f2f84d56cd0b620b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63162 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Simon Gilli authored
This patch converts the $mailSettings['transport_smtp_encrypt'] explicit to a bool as expected by Symfony/Mailer. Additionally this setting is corrected in the admin tool which was not adapted correctly with the introduction of the Symfony/Mailer. Resolves: #90295 Releases: master Change-Id: Ia5f48eec810bfda7936d462c098f5d5eba4332c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63146 Tested-by:
Martin Hotmann <martinhotmann@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
A lot of code within PageLayoutView is not properly applicable anymore. The next step in this area is to: - Extract Logic for PageInformationController into a separate class - Extract Helper logic for custom content element previews into a separate class Resolves: #90272 Releases: master Change-Id: Ied94677c3a957eb81d18f281afab658c55214b48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63097 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
The main entry point for the TYPO3 backend is the BackendController. Some changes are made: - Only instantiate necessary code - Use $uriBuilder as property - Use ModuleTemplate's view to not instantiate a Fluid view multiple times This eases the way to lower the usage of DocumentTemplate again. Resolves: #90282 Releases: master Change-Id: I7ebc0f564f898f7451a5821ec357d05bda5bbda4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63109 Tested-by:
-
Elias Häußler authored
If slugs are generated within Backend forms, the visual output (= label below slug field) of the generated slug proposal might be broken if no slash is prepended to the generated slug. This might be the case in custom database tables where custom slug fields are defined with the configuration "prependSlash" set to "false" (which is the default value). It can also be the case if the configuration "prefixParentPageSlug" is set to "false". In order to ensure a clean visual output for those labels, the slug proposalwithin them will now always be prepended by a slash. This makes sure that the resulting url which is shown within those labels is always valid. Note that this only effects visual output and is not meant to modify any slug proposal generated by the SlugHelper class. Resolves: #90222 Releases: master, 9.5 Change-Id: I93587cfec0db6c3d889fdce60a4515ef47decc82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63051 Tested-by: TYPO3com <noreply...
-
Stefan Horst authored
The REPORT HTTP method is specified in RFC 3253. Releases: master, 9.5 Resolves: #90297 Change-Id: Ia78f602266bede3a8cf9d31e320bea7fe385aa08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63147 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
-
Benni Mack authored
The FileList class was originally a derivative of DatabaseRecordList, which was decoupled in TYPO3 v9 and and marked as internal. It is responsible for showing the actual "FileList" in the TYPO3 Backend module. A lot of this code has grown historically, and can be removed and simplified, as it is not directly connected to the abstract record list anymore. This patch removes unused public properties like $JScode as this is part of a "multi-table" setup as is possible in the database listings. Some methods are split into smaller parts to make the methods themselves smaller. This is however just the first step, next to separating the curation and the output (and moving this into a fluid template), also using proper pagination for fetching files and folders, or building DI for the class now is much easier to do. Resolves: #90242 Releases: master Change-Id: Ie66964d9df355a9d74dbe9d0a8a17f9cecdf7c83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63067 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Feb 02, 2020
-
-
Andreas Fernandez authored
The payload sent with the AJAX API is now automatically converted to a JSON-encoded string, if the request's Content-Type header is set to `application/json` or any variant of this. Resolves: #90291 Releases: master Change-Id: Ia81c74d9314fb56de99f4a74e073af7a671b472b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63140 Tested-by:
-
Oliver Hader authored
https://github.com/TYPO3/testing-framework/commit/2111db60e8e1391fabdac4f2253af553f291d460 Resolves: #90294 Releases: master, 9.5 Change-Id: I21d8ad233b753c4a56c2227b4d2fec6944340c81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63144 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Resolves: #90269 Releases: master, 9.5 Change-Id: I7366c213d5d417575b9c85c18728a4fdf4273520 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63142 Tested-by:
-
Oliver Hader authored
Resolves: #90278 Releases: master, 9.5 Change-Id: I158a7ea2c27b0081b3cdf5ee9452f2394cc31593 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63104 Tested-by:
-
Andreas Fernandez authored
The AJAX API doesn't expose the AbortController anymore as it has no benefit for a developer, besides aborting a request. For this reason, the AJAX API removes the `getAbort()` method and replaces it with an `abort()` method, which utilizes the controller directly. Resolves: #90292 Releases: master Change-Id: Id6355663bc00bbb763692ca3b7fab145cb8cc55e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63141 Tested-by:
-
- Feb 01, 2020
-
-
Oliver Hader authored
Resolves: #90229 Releases: master, 9.5 Change-Id: Iec8baa5dbe23d78dd4bfae460b501c2da5cb6bd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63056 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Jan 31, 2020
-
-
Benni Mack authored
The RteHtmlParser has two public methods: ->init() ->RTE_transform() init() was introduced in early PHP4 times when there was no constructor in PHP. RTE_transform() contained a lot of parsing of properties, which is not needed anymore since TYPO3 v8. init() itself is not needed anymore. Since TYPO3 v8, RteHtmlParser is much cleaner towards the developer, and the last step for this PHP class is to clearly separate the logic for the transformations in each direction, making two new entrypoints: ->transformTextForRichTextEditor($content, $configuration) ->transformTextForPersistence($content, $configuration) This way, all logic is separated in these two methods, and the existing RTE_transform() method is just a shell, which is not needed anymore. Resolves: #90258 Releases: master Change-Id: Iba140d71c5cd954dab4cf1fe4bfaca2233527e50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63070 Tested-by:
-
Benni Mack authored
The first PSR-14 event received a custom Compatibility slot. All further "old" slots have been moved to "SlotReplacement" classes, which is now done with this first PSR-14 event (AfterMailerInitializationEvent) as well, and moved to a more generic MailerInterface API, now that symfony/mailer is stable. Resolves: #90273 Releases: master Change-Id: I989a941031987733d694335d7e235cf1e2392235 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63098 Tested-by:
-
Oliver Hader authored
Resolves: #90270 Releases: master, 9.5 Change-Id: Idbc51d012b49f3214d163878611d2107010242aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63095 Tested-by:
-
Claus Due authored
Followup for https://review.typo3.org/c/Packages/TYPO3.CMS/+/63069 The original patch changed both public and non-internal method signatures and constitutes a breaking change, but was not committed and documented as a breaking change. This patch restores the method signatures in accordance with the non-breaking nature of the original patch. Resolves: #90246 Releases: master Change-Id: Icc832f80aad0466e3bd1555ff32369ef3949b04b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63094 Tested-by:
-
Oliver Hader authored
Use createFieldConstraints instead of createRouteFieldConstraints (as it has been in PersistedPatternMapper). Resolves: #90269 Releases: master, 9.5 Change-Id: Ia4b70079291fc72527a2846d73b16b9e61c81dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63093 Tested-by:
-
Frank Naegler authored
Show error messages in TypoScript Object Browser and Template Analyzer for any invalid condition line. Resolves: #77714 Releases: master, 9.5 Change-Id: I8ad24455a61467c47a1b8b28e465022c467d21d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63092 Tested-by:
-
Benni Mack authored
This change migrates all left-over signals in TYPO3 Core to PSR-14-compatible events. Package manager - related events have been moved to EXT:core to decouple ExtensionManager functionality from PackageManager. The following signals have been moved to events: PackageManagement::packagesMayHaveChanged => PackagesMayHaveChangedEvent InstallUtility::afterExtensionInstall => AfterPackageActivationEvent InstallUtility::afterExtensionUninstall => AfterPackageDeactivationEvent InstallUtility::afterExtensionT3DImport => AfterExtensionStaticDatabaseContentHasBeenImportedEvent InstallUtility::afterExtensionStaticSqlImport => AfterExtensionStaticDatabaseContentHasBeenImportedEvent InstallUtility::afterExtensionFileImport => AfterExtensionFilesHaveBeenImportedEvent ExtensionManagementService::willInstallExtensions => BeforePackageActivationEvent ProcessAvailableActionsViewHelper::processActions => AvailableActionsForExtensionEvent Next up: Deprecate signal slot dispatcher. Resolves: #90249 Releases: master Change-Id: If688265c50c4200983c34f408b1cfd063f72546b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63045 Tested-by:
-
Georg Ringer authored
If the state property inside `ext_emconf.php` is set to `excludeFromUpdates`, the extension will be skipped while updating the language files in the Install Tool. Resolves: master Releases: #90236 Change-Id: I741216e7fac18aeb3e1144033495c2f2943d496f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63065 Tested-by:
-
Benni Mack authored
The page module search bar now redirects to the list module, where all functionality is given, and all records on this page (not just tt_content) are found, streamlining it with the list module logic. Editors without permission for the list module do not see the search in the page module (similar behaviour to LiveSearch). All code of the page layout classes related to search is removed. As this is non-public API, the removal is done without any deprecations necessary. Resolves: #90235 Releases: master Change-Id: Ia23c931c5a009e8ffe9a1a56219fb922d63e44bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63063 Tested-by:
-
Oliver Hader authored
Use [:xdigit:] (a-f0-9/i) instead of [:alnum:] (a-z0-9/i) for parsing hexadecimal values in sequences. Resolves: #90263 Releases: master Change-Id: I26d575c381a17c409abcd5ed04876696587a3886 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63078 Tested-by:
-
Oliver Hader authored
Settings for $GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash'] are modelled in CacheHashConfiguration which takes care of validating configuration. It also determines whether corresponding aspects apply to a given URL parameter. Besides exact matches (equals) it is possible to apply partial matches at the beginning of a parameter (startsWith) or inline occurrences (contains). URL parameter names are prefixed with the following indicators: + = (equals): exact match, default behavior if not given + ^ (startsWith): matching the beginning of a parameter name + ~ (contains): matching any inline occurrence in a parameter name These indicators can be used for all previously existing sub-properties 'cachedParametersWhiteList', 'excludedParameters', 'excludedParametersIfEmpty' and 'requireCacheHashPresenceParameters'. Example: $GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash'] = [ 'excludedParameters' => [ 'utm_source', 'utm_medium', '^utm_', // making previous two obsolete ], 'excludedParametersIfEmpty' => [ '^tx_my_plugin[aspects]', 'tx_my_plugin[filter]', ], ]; Resolves: #90234 Releases: master Change-Id: I16d316e463b7c94c5eb75069f8c24ffde135d080 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63062 Tested-by: -
Benjamin Franzke authored
All Routes.php information for Backend routes are now collected via Dependency Injection. That means Bootstrap::initializeBackendRouter() doesn't need to be called explicitly from a middleware anymore. The Router class will always have the routes populated whenever it is initialized / needed. We use DI factories to collect and add the backend routes. The routes from the extension configuration files are still cached, but the cache is managed by a service provider. We adapt the ServiceProviderCompilationPass to keep track of the return type of extended services where the extension may not have a return type declaration (because of the dynamic closures in PseudoServiceProvider). We do that to properly notify symfony DI that the routes are stored as ArrayObject. Change-Id: Ie589825408bf9e51782800a1b8370f57d81d5178 Releases: master Resolves: #90247 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62531 Tested-by:
-
Oliver Hader authored
The intention of PersistenceDelegate was to provide a generic API to resolve or generate route components. However the implementation did not provide any additional behavior. It just was used as structural pattern which did not provide any further advantages. That's the reason why PersistenceDelegate gets dissolved and its database connection invocation is moved to its corresponding callers PersistedAliasMapper and PersistedPatternMapper. For backward-compatibility reasons previous (protected) implementation is still kept in legacy layer for those two route aspects. Resolves: #90218 Releases: master, 9.5 Change-Id: I49eb58372c139c9b8274593efa2892a43eb81508 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63049 Tested-by:
-
Sebastian Michaelsen authored
In template tree view the property path is now shown in the title attribute of each node to help the user orient and navigate through a deeply nested tree. Resolves: #90237 Releases: master, 9.5 Change-Id: I175c38eda3168c04e9d5f5b6d96a7bdc74121799 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63064 Tested-by:
-
- Jan 30, 2020
-
-
Benni Mack authored
Within all refactorings, fetching the correct backend layout and relevant colPos information was still called via callUserFunction which is not needed at all, as it is a static information (class + method name) so a regular method call via PHP works just fine. Resolves: #90254 Releases: master Change-Id: I712e86b3a5d343bad3b4752a21dac9cbdc510f46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63073 Tested-by:
-
Benni Mack authored
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
-
Daniel Siepmann authored
As `rowCount()` is not supported across all DBMS (e.g. sqlite). The logic is kept, but instead of relying on row count, the list of items is built first, and checked afterwards. Resolves: #90231 Releases: master Change-Id: Iad0dc46c507d300708c9bc9d53aad6d6840a3446 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63061 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
mehrlich authored
Resolves: #90252 Releases: master, 9.5 Change-Id: Ibacf2dab8a246bcb09f02be65765aa0760ba041b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63072 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
-
Benni Mack authored
Until TYPO3 v9, PageLayoutView was a subclass of AbstractDatabaseRecordList, so it inherited a lot of logic, which was never used in this class. The code can safely be removed, as PageLayoutView is only used in Page Module (web_layout) and Info Module ("Page Information"). Resolves: #90246 Releases: master Change-Id: Ie1fbd1fb2131d1b7d6dee9342a82f54c4dd5e563 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63069 Tested-by:
-
- Jan 29, 2020
-
-
Benni Mack authored
When commenting out the line SystemEnvironmentBuilder::initializeBasicErrorReporting() then Unit Tests run with notices, showing notices as errors. This happened due to recent updates of the TYPO3 testing framework v6. The fix to overcome this is https://review.typo3.org/c/Packages/TYPO3.CMS/+/62926 but the preferred clean ups are done beforehand. Resolves: #90245 Releases: master Change-Id: Ieb43f2f9524fb18c221b9c690de7116c994f5260 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63068 Tested-by:
-
Alexander Schnitzler authored
- Add phpdoc for variables to let phpstan know their type - Do not use ::class syntax for PHP 7.4 classes (yet) - Add missing class properties - Do not unset non-existing variables Releases: master Resolves: #90207 Change-Id: I01ae756c03f7dfc286bedd2577979e0d79ca3d9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Daniel Siepmann authored
Children of $array in ArrayUtility::getValueByPath() may contain other datatypes than array, therefore check the datatype by is_array() before calling array_key_exists() in order to avoid a PHP warning. Resolves: #90241 Releases: master, 9.5, 8.7 Change-Id: Ibde8f854a28a0aef68ed33ed172299cb4e1ff2ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63066 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Jan 28, 2020
-
-
Elias Häußler authored
Resolves: #90227 Releases: master, 9.5, 8.7 Change-Id: If905b071639844b9080e1ffd903a15cb211ed7f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63055 Tested-by:
-
Daniel Siepmann authored
Resolves: #90232 Releases: master Change-Id: If9b030c8f984914d41482d0ab5fd7f94e1385b58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63060 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Oliver Hader authored
Injects configuration to constructor directly, avoids using MockBuilder to define internal values (part of configuration). Resolves: #90230 Releases: master, 9.5 Change-Id: I7759b071192ed09572f3a7ed7e7779e51a4eb9f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63058 Tested-by:
-
Manuel Selbach authored
With this change the wrong introduced type hint will be changed and enriched with some detail information. Resolves: #90223 Releases: master Change-Id: I3437889fb355571c88f1902b217faf11d56dd158 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63052 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
