- Feb 05, 2018
-
-
Frank Naegler authored
This is the first step for introduce CGL for JavaScript files. The settings of the .editorconfig file is now applied to all JavaScript files. This will prevent merge conflicts for the next patches. Resolves: #83752 Releases: master, 8.7 Change-Id: Ie84691e7f7f3a3974f3c62133895a62377b22f67 Reviewed-on: https://review.typo3.org/55521 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Fernandez authored
This patch adjusts the drag and drop handling on the page module. Localized content element can't get moved anymore when they are in connected mode. Languages without a `l18n_parent` may be freely moved. Resolves: #83470 Related: #66540 Releases: master, 8.7 Change-Id: I7dcb61279d4bfeb094dcb0e2fbffd416da9c787b Reviewed-on: https://review.typo3.org/55453 Tested-by:
Armin Vieweg <armin@v.ieweg.de> Tested-by:
Reiner Teubner <rteubner@me.com> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Christian Kuhn authored
Fixes various issues, brings PHP 7.2 compatibility to v8 core branch of standalone fluid. composer command used: composer update typo3fluid/fluid Change-Id: I52c3a97e7dc8dafd7b0dee1e07df5105f29cdbde Resolves: #83774 Resolves: #82227 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55560 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
-
- Feb 04, 2018
-
-
Nicole Cordes authored
This patch moves the execution of configured initCommands to the end of connect function. This prevents a database connection from being opened by default due to the execution of commands right after class initialization and still ensures a connection is configured properly before first command execution. Furthermore this patch adds a new functional test for the ErrorHandler. The test uses some predefined initCommands to enforce the strict mode of MySQL database to be set. Due to the predefined initCommands the test failed before as the connection was forced to be opened. For further information see the referenced forge ticket. Resolves: #83770 Releases: master, 8.7 Change-Id: I2287600959b3ec06d338e26373562850307ce0b1 Reviewed-on: https://review.typo3.org/55548 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Wolfgang Klinger authored
Bring back the possibility to access FE session data in TypoScript conditions: [globalVar = TSFE:fe_user|sesData|some_key > 10] Resolves: #83506 Releases: master, 8.7 Change-Id: I77f6bc73a6d9160b7074d39a948e94a59b51e521 Reviewed-on: https://review.typo3.org/55408 Tested-by:
Timo Pfeffer <pfeffer.timo+typo3@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Stefan Neufeind authored
When using filters the colorspace is not always applied. A quickfix is to add the colorspace-setting again before writing the output-image. Multiple colorspace-settings on the commandline will be executed in order. For example the grayscale-filter uses "-colorspace GRAY". The final output-image can then be converted to "-colorspace sRGB" again so the brightness appears correct (not too dark) again. Resolves: #78816 Releases: master, 8.7 Change-Id: I3fcabf8fdbb8d43f15662532b881501ebb43b1dd Reviewed-on: https://review.typo3.org/50791 Reviewed-by:
-
Mathias Schreiber authored
In order to give FormEngine a fresher look we add the following renderTypes to type=checkbox * checkboxToggle * checkboxLabeledToggle Furthermore, checkboxes are now displayed with icons provided via the IconFactory and can be changed. Resolves: #83556 Release: master Change-Id: I24570dc4ee8cb672a5f961399b709fe7da05e2f0 Reviewed-on: https://review.typo3.org/55351 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Mathias Schreiber authored
The central InsufficientFolderReadPermissionsException now displays the name of the folder in question to ease tracing down errors. Resolves: #82342 Releases: master Change-Id: I968c74e6b2e210b07964f7ebb141155525c26ee5 Reviewed-on: https://review.typo3.org/55541 Tested-by:
-
Mathias Schreiber authored
Editing faulty FileStorages is possible again due to catching the respective exception and piping it into a FlashMessage Resolves: #83762 Releases: master, 8.7 Change-Id: I5081d86fd73076359b1d9eba954ba07c50bcb7b2 Reviewed-on: https://review.typo3.org/55551 Reviewed-by:
-
Andreas Fernandez authored
When the element browser is opened in a popup window, the parent element (=popup) is now accessed properly. This patch also fixes the case for `list_frame` which didn't work in Firefox. Resolves: #83693 Releases: master Change-Id: I2436942a239b868cd1e3e269c6161a9df92e05ff Reviewed-on: https://review.typo3.org/55511 Tested-by:
-
Mathias Schreiber authored
The Suggest Wizard now allows to search for multiple terms in field by splitting the searchterm by +. This allows to search for a combination of values which is helpful when dealing with large data sets. Resolves: #61981 Releases: master Change-Id: I764039a575ca5d9ccbd97dd3dc57f3947906a5c3 Reviewed-on: https://review.typo3.org/55546 Reviewed-by:
-
Mathias Schreiber authored
The SuggestWizard no longer returns translated pages. For the sake of database relations, relating directly to a translated page makes no sense and will most likely result in unintended behavior. Resolves: #83771 Releases: master Change-Id: Ibfa8dfa3082245726e0a519e77f26849507e421b Reviewed-on: https://review.typo3.org/55550 Reviewed-by:
-
Christian Kuhn authored
Sets the typo3 database cache backend "content" field from mediumblob to longblob. Mediumblob on mysql equals 16MB max storage, which can be too small for cache entries. Switching to longblob increases single cache row size to 4GB and costs only one additional byte per row. Change-Id: I1ab5b84b6845280e77e339cbe4a59e0043f84cc2 Resolves: #83772 Releases: master Reviewed-on: https://review.typo3.org/55549 Tested-by:
-
- Feb 03, 2018
-
-
Benni Mack authored
This reverts commit f22792ec reviewed on https://review.typo3.org/#/c/55528/ due to a fault of mine removing the original ownership of the commit. Change-Id: Idd8b09754ec124047bd620c7529b0937c823e6b1 Resolves: #83767 Reverts: #83725 Releases: master Reviewed-on: https://review.typo3.org/55543 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
This reverts commit a1f5a232 due to author conflicts. https://review.typo3.org/#/c/55537/ Change-Id: Ie6003a41e75d395a1214904ecce8994ec63ac798 Resolves: #83766 Reverts: #83785 Releases: master Reviewed-on: https://review.typo3.org/55542 Tested-by:
-
Benni Mack authored
This patch moves logic out of the RequestHandlers into PSR-15 compatible middleware classes to call a hook and initialize the time tracker. Resolves: #83765 Releases: master Change-Id: Ibe2435833a8cbf0fb19cfe1fddd519d47147707e Reviewed-on: https://review.typo3.org/55537 Tested-by:
-
Benni Mack authored
PSR-15 middlewares are hooks on steroids for HTTP requests. Due to chaining middlewares and the core request handler(s), middlewares can execute code before and after the application. Middlewares may return early, that means they can prevent consecutive middleware and the core application from being executed at all. A full middleware coverage for *all* requests will need a lot of changes to the core and extensions. We'll eventually need to stop using header()/exit()/die() or HttpUtility::{redirect,sendRespose}(). Those method calls need to be replaced by manipulation of PSR-7 message objects. Change-Id: I075639835115f7cf28f18c3814ef6dd190fdf29b Releases: master Resolves: #83725 Reviewed-on: https://review.typo3.org/55528 Reviewed-by: -
Benni Mack authored
The Browseable Trees (Element Browser) show pages with language > 0 (page translations), due to a missing fix during the pages_language_overlay refactoring. The patch adds the restriction on deleted pages and sys_language_uid=0 pages, just like PageTreeView and the new page tree do it. Resolves: #83764 Releases: master Change-Id: I90d76a37a0ee146ea549adcbb3aeff027fe42d26 Reviewed-on: https://review.typo3.org/55536 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Tymoteusz Motylewski authored
Chrome 64 changed the behaviour regarding xhr.open() calls when passing null values as password and username. The d3.js file is manually patched. Once PR https://github.com/d3/d3-request/pull/34/files is merged we can use official d3.js version again. Resolves: #83741 Releases: master, 8.7 Change-Id: I9b83d953ecd19afb9fa5039e1782d094111b0125 Reviewed-on: https://review.typo3.org/55534 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Thomas Löffler authored
When requiring fluid_styled_content in an extension by composer, the extension fluid should be required and installed, too. Releases: master Resolves: #83756 Change-Id: I1cdd00e842e4b0918db0746ccdf58bb871b8790c Reviewed-on: https://review.typo3.org/55531 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
- Feb 02, 2018
-
-
Mathias Schreiber authored
The modal “OK” button of the BE layout column assignment now sports the correct color for the button. Resolves: #83662 Releases: master Change-Id: I13587241f5f79a555ef7edab6071d1d3f0265ad0 Reviewed-on: https://review.typo3.org/55532 Tested-by:
Jan Delius <me@jandelius.eu> Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
Rico Drexler <rico.drexler@gmx.de> Reviewed-by:
-
- Feb 01, 2018
-
-
Benjamin Franzke authored
This is in preparation for PSR-15 middleware support which will require PSR-7 RespnseInterface return type declarations for request handlers. As TSFE powers a concept of outputting nothing [see isOutputting()] we need to add NullResponse (which implements the PSR-7 ResponseInterface) which Core/Bootstrap can detect, to stop invoking header() and echo. Change-Id: Ie3169a4365a85d0472523138cc73bb47cbbcb70f Releases: master Resolves: #83724 Reviewed-on: https://review.typo3.org/55498 Tested-by:
-
Armin Vieweg authored
Fix regular expression in escapeCssSelector method, to convert e.g. "." to "\.". Resolves: #83747 Branches: master, 8.7 Change-Id: I0fe19fb3590e28cafce6e2fd0cbf9a63f4375954 Reviewed-on: https://review.typo3.org/55516 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Frank Naegler authored
This patch removes the uglify task of jquery-ui/sortable.js. With https://review.typo3.org/#/c/55389/ the lib was patched and already uglified. This patch prevents a double uglify of the file. Resolves: #83593 Releases: master, 8.7 Change-Id: I16edd94fc8d3165159b4dc0a47ac7365ff34e37f Reviewed-on: https://review.typo3.org/55517 Reviewed-by:
-
- Jan 30, 2018
-
-
Oliver Hader authored
Change-Id: I221d472b3bd9ac035221cb804601740cf77847b0 Reviewed-on: https://review.typo3.org/55505 Tested-by:
-
Oliver Hader authored
Change-Id: I8ebeca67eb5524682846a2fb7d55ee8bbde1a318 Reviewed-on: https://review.typo3.org/55504 Reviewed-by:
-
Stephan Großberndt authored
By casting the JavaScript variable to string this patch avoids an error if 'eval' => 'int,nospace' is used in a TCA column definition. Resolves: #83731 Releases: master, 8.7 Change-Id: I5be79bf6cd748ac184505f0aa4bd97c7d934eebd Reviewed-on: https://review.typo3.org/55500 Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Stephan Großberndt authored
Resolves: #83732 Releases: master, 8.7 Change-Id: I7dccb42445dba584ed1c9a814f62525335d26ab1 Reviewed-on: https://review.typo3.org/55501 Reviewed-by:
-
Michael Oehlhof authored
When renaming a file with the name of an existing file a modal is shown. Pressing the cancel button no longer renames the file with an unique name. Resolves: #83624 Releases: master Change-Id: I9963f6ce0b476f63043056d74e38af251ea0cd3e Reviewed-on: https://review.typo3.org/55418 Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
-
Mathias Schreiber authored
Proofread documentation for CMS 9.1. Two rst snippets remain in Changelog/master in order to ease a scheduled revert by @helhum. Resolves: #83700 Releases: master Change-Id: Iebf3db03bd95a6f20b0b786e9776fc84b77d6e3b Reviewed-on: https://review.typo3.org/55465 Reviewed-by:
-
Helmut Hummel authored
While the intended feature is great (having the possiblity to extract and re-use parts of the form definition), implementation wise it needs some rework. To be able to release 9.1 as stable as possible, we now revert this implementation for now and bring it in for 9.2 again. This reverts commit a52a9922. Reverts: #82089 Resolves: #83729 Releases: master Change-Id: I850401d232b642e712801613d3780816f873966a Reviewed-on: https://review.typo3.org/55422 Tested-by:
-
- Jan 29, 2018
-
-
Susanne Moog authored
Most websites probably use custom analytics for page hit statistics or are not interested in the count of hits on a redirect. Therefor the redirect hit count has been disabled by default. The option to enable the hit count globally via LocalConfiguration has been added. Change-Id: I71c57784d8c6e0f17c81b1f899aa43e91d37cd76 Resolves: #83677 Releases: master Reviewed-on: https://review.typo3.org/55497 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Christian Kuhn authored
The patch implements feedback from the new ExtensionConfiguration API. get() now falls back to a parsing of ext_conf_template, so the parser is moved from the install tool to the ext:core class. This prevents a chicken-egg issue in early setup phases. The move of the synchronize* methods forces a raise of the testing-framework: composer require --dev typo3/testing-framework ^2.0.3 Change-Id: I9a6700fc66fe78d9df09038a89ea95f8dba81031 Resolves: #83666 Releases: master Reviewed-on: https://review.typo3.org/55434 Reviewed-by:
-
Oliver Hader authored
NewContentElementWizardController, which has been introduced for TYPO3 v9 to render the new content element process in a dedicated modal was just a duplicate of the existing NewContentElementController class with some minor adjustments and code flow enhancements (names, empty checks). However, there have been several side effects like: * hook implementing NewContentElementWizardHookInterface would have been called by both object instances, having different public properties - the most common access to $parentObject->id or ~->sys_language would have failed to to property visibility and change names * the JavaScript closure callback to adjust the URL when interacting in the browser was hard-coded to modal rendering, with still having the possibility to render the old behavior e.g. in the web>list view To overcome these flaws both mentioned classes have been merged since the functionality was not that much different anyway. Besides that different JavaScript client scopes ('window' or 'list_frame') are forwarded to the according object instances. Resolves: #83705 Releases: master Change-Id: I472a7ec8a5d06c05e6c7053bf98b5cfacb69f9d9 Reviewed-on: https://review.typo3.org/55479 Tested-by:Nicole Cordes <typo3@cordes.co> Tested-by:
-
Oliver Hader authored
When creating a new content element in the frontend using the according button in the "editing" section of the admin panel, the request to the TYPO3 backend is rejected due to an invalid XSRF session token: Validating the security token of this form has failed. Please reload the form and submit it again. The reason is, that the URL after issue #70055 looks like the following "token=<hash>id=<id>" instead of "token=<hash>&id=<id>" - the id became part of the XSRF session token. Resolves: #83719 Releases: master, 8.7, 7.6 Change-Id: Ibdd252b2e59d9e8de78bb0be14a95e0789dc0d17 Reviewed-on: https://review.typo3.org/55488 Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Benjamin Kott authored
Resolves: #83723 Releases: master Change-Id: I010796bd056e6c70d21010ef649f127c4d006a21 Reviewed-on: https://review.typo3.org/55491 Reviewed-by:
-
Georg Ringer authored
To avoid warnings with PHP 7.2, `serialized_executions` must be checked for being not an empty value. Resolves: #83691 Releases: master, 8.7, 7.6 Change-Id: I5855a03d6669ec0e82931cfc0110c2b7ca134ad4 Reviewed-on: https://review.typo3.org/55474 Tested-by:
-
Michael Oehlhof authored
The exception does not occur with the LocalDriver. For testing use the driver mentioned in the forge issue. Resolves: #83627 Releases: master, 8.7 Change-Id: Iae5fef2cc1ca704998975aba4fb6f5e48aeec4b1 Reviewed-on: https://review.typo3.org/55419 Tested-by:
-
Susanne Moog authored
The order of the options given is irrelevant as they will always be rendered in the same order. The documentation was updated to reflect that fact. Change-Id: I409e8a26a3b1186a12761cbb84a4f6afe94b464b Resolves: #82431 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55478 Tested-by:
-
Frank Naegler authored
In the overview table of the redirects module the source path now links to edit record view (like everywhere in the backend) and a new preview icon is now available in case the source path is not a RegExp. Resolves: #83709 Related: #83708 Releases: master Change-Id: Ie92e434f675a5f66e5e779e0d739d75a0a774caa Reviewed-on: https://review.typo3.org/55481 Tested-by:
-
