- Sep 23, 2021
-
-
Wouter Wolters authored
Replace static:: with self:: in final classes. Resolves: #95319 Releases: master Change-Id: If375daf637c31f94c86f24d9189e85f8bae32581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71190 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
There was a time when new code for TYPO3 Core was introduced by using "MyClass::getInstance()" to act as a factory for this class, which _would_ be OK if these classes are actually prototypes and not services (or singleton services), as GeneralUtility::makeInstance() or DI via Services.yaml works as well. This change deprecates all getInstance methods around such code with GeneralUtility::makeInstance() calls. At a later point, proper DI can be introduced in these cases. * TYPO3\CMS\Core\Resource\Index\ExtractorRegistry::getInstance() * TYPO3\CMS\Core\Resource\Index\FileIndexRepository::getInstance() * TYPO3\CMS\Core\Resource\Index\MetaDataRepository::getInstance() * TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\OnlineMediaHelperRegistry::getInstance() * TYPO3\CMS\Core\Resource\Rendering\RendererRegistry::getInstance() * TYPO3\CMS\Core\Resource\TextExtraction\TextExtractorRegistry::getInstance() * TYPO3\CMS\Form\Service\TranslationService::getInstance() * TYPO3\CMS\T3editor\Registry\AddonRegistry::getInstance() * TYPO3\CMS\T3editor\Registry\ModeRegistry::getInstance() Resolves: #95326 Releases: master Change-Id: Ie3160c67792e115cf5488dc800bd717c0b913ab9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71178 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/browse_links.php']['browserRendering'] is deprecated in favor of the ElementBrowser API implemented in TYPO3 v7.6 via https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/7.6/Feature-66369-AddedLinkBrowserAPIs.html Also, calling "wizard_element_browser" with mode=wizard or "mode=rte" is deprecated, instead extensions should link to "wizard_link", which also exists since TYPO3 v8. Resolves: #95322 Releases: master Change-Id: I4ad30fa0b0c0684767e1060d99cebc11b7db9710 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71180 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
Revert a style change, added in #95325, which led to disabled checkboxes are being shown, while only their label should be visible. Those checkbox classes hide the actual checkbox, while the label acts as one. This allows extended styling, e.g. "icon checkboxes" or "toggle checkboxes". Instead add the disabled style to the correct checkbox component, which is acutally using the checkbox element and no label. Resolves: #95325 Releases: master Change-Id: I0842c184e629a3c4327c18db92affde58c32924d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71213 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 22, 2021
-
-
Robert Kärner authored
On PHP 8.0, renaming a folder in the backend might fail with a "PHP Warning: Uninitialized string offset 0". This is fixed by utilizing the substr() function instead. Resolves: #95273 Releases: master Change-Id: Ib642a25492c933b6fae857206c4535b7a861cc3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71123 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Simon Gilli authored
The import was removed shortly before https://review.typo3.org/c/Packages/TYPO3.CMS/+/71032 was merged so it's added again. Resolves: #95321 Related: #95189 Related: #95190 Releases: master Change-Id: If44ba57ab6a390fac07c1ee12bbd8f36d2e7539f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71191 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Stefan Bürk authored
Core has been working with id and type as query parameter to display FE pages and switch between defined TypoScript page definitions. Speaking url has been integrated for v9 through the new routing feature to do it in a more determistic way as in comparision to ext:realurl. As there might be instances using id/type query parameters for ajax call switches (and eventelly for eid scrips) in the frontend, normalization has been implemented to keep this option alive (#88028). Recently there has been a try to fix a bug for so some use cases, which broke this support (#94537). For future it should be considered if it is possible to drop this option in the future to free id/type query arguments for instances in the frontend. There a several issues in this area, for example broken subfolder installation support and id/type query parameter on a full speaking url overrule it with selected id, which is not expected. To validate that the test fails if support is broken change in PageRouter following line (150): $urlPath = str_replace($scriptName, '', $urlPath); to $urlPath = str_replace( '/' . $scriptName, '', $urlPath); Build/Scripts/runTests.sh -s functional \ typo3/sysext/frontend/Tests/Functional/SiteHandling/\ SiteRequestTest.php This patch acts as pre-patche to fix these. Resolves: #95096 Related: #95096 Releases: master, 10.4 Change-Id: Iff97f04d7bf7e7b2462425d830e0451a8d7a8686 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70880 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Christoph Schwob authored
Replace '.input-group-addon' with '.input-group-text' Resolves: #95148 Releases: master Change-Id: I3d855d93da79e8edd39d77ead46fe4637639decd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70966 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Dennis Prinse <dennis.prinse@maxserv.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Dennis Prinse <dennis.prinse@maxserv.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Simon Gilli authored
With the change #82000 the DistributionWelcome image was removed by accident. This patch adds the image again with a proper fallback to the Distribution image. Resolves: #95313 Releases: master Change-Id: I1bfb281af43e80fa83c72e43aff95dc35fb56f7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71187 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
To further improve the recordlist UI, the "Localize to" column is not longer shown, in case there are no more records to localize. Resolves: #94794 Releases: master Change-Id: Ib08508a25a6eac677d92b3b4f539d7ee4e84c1c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70403 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
With TYPO3 v7.6 the internal DataHandler command to "inlineLocalizeSynchronize" was migrated to an array-based syntax, and TYPO3 Core uses this ever since. With TYPO3 v11 it is time to deprecate the old behavior. Resolves: #95317 Releases: master Change-Id: I325f54d3cf3ab318a7528a393bf0d848e8b5e3b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71184 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
Various methods within TypoScripFrontendController are now "protected" as they are marked as internal. Resolves: #95315 Releases: master Change-Id: Iae9691457b250305c617b11fa5f558ac4e55c2b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71179 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Oliver Bartsch authored
In case a site in the TYPO3 page tree only features the default language, the module menu of the page module does no longer add "All languages" as option, since this led to misbehaviour, e.g. empty views in some cases. Resolves: #95308 Releases: master Change-Id: I54f72c99ff5c8511fd119e024493153408be33c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71173 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Sybille Peters authored
A new function StringUtility::multibyteStringPad() is introduced to handle multibyte strings instead of str_pad() which will not pad strings with multibyte characters correctly. The new function is now used for: - Fluid ViewHelper format.padding - TypoScript stdWrap.strPad Resolves: #95189 Resolves: #95190 Releases: master Change-Id: I4b8bf4b42e049b17754b260003ac064fbbb6246a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71032 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
The parseFunc.sword functionality wraps HTML (usually a span tag) around RTE-based content if: * GET parameter ?sword[]=search-word is set * no_cache=1 is set via GET parameter or TypoScript This feature only works in non-cached environments due to the actual problem that the search term should never be cached. This happens if a result page in indexed search is clicked, which then receives a no_cache=1 argument. This feature is highly discouraged due to the possible server load that is created, and thus removed. The existing solution is far from optimal and should rather be handled in third-party extensions (such as EXT:solr does it via a HighlightViewHelper). Resolves: #95318 Releases: master Change-Id: If74247bad14a87c55d092322f0a609c3663f2e67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71176 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Alexander Opitz authored
In web_layout we show for every language the content if defLangBinding is set. Resolves: #94568 Releases: master, 10.4 Change-Id: Ic48f141ac45e2d2e32b3e2d53b70c4e156dfc551 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71073 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Eric Chavaillaz <eric.chavaillaz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Eric Chavaillaz <eric.chavaillaz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
With #93526, multi-factor authentication was introduced to TYPO3. This came with several configuration options, such as the possibility to require MFA for specific users and user groups. Previously, the only result of this option was a warning, displayed in the MFA configuration module. Obviously, this did not really help administrators, trying to enforce MFA in their system. Therefore, this patch adds the missing endpoint, which is automatically called for all users, required to set up MFA, as soon as they have successfully passed the first authentication step (e.g. username + password). While it's a new endpoint, the actions still call the MFA providers the same way, the MFA configuration module does. Therefore, no changes to the API. Resolves: #95287 Releases: master Change-Id: Ib82ae53cbd5bd0782418d81d166c1f3d7e9a7ab1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71132 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
A couple of patches changed the amount of columns, shown in the filelist module listing. For example, since column selector component. Also multi record selection, introduced in #94906, adds an additional column, providing the checkbox. This patch therefore adjusts the DragUploader component to take this into account while dynamically adding rows for uploaded files. Resolves: #95300 Related: #84184 Related: #94906 Releases: master Change-Id: I0fcadc1c38da94a3365f6524c5407fe487fc4e21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71166 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Christian Kuhn authored
Ever wondered the icons of the main core extensions that use the TYPO3 logo all look subtly different, for instance in EM? The patch aligns them to the 'white logo with orange background' svg version. Resolves: #95310 Releases: master Change-Id: Ifd04c8bbe03e7988c44b0db34a15aa0a11b31eb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71175 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Benni Mack authored
ext_localconf.php still references "localconf.php" even though it is called "LocalConfiguration.php" since TYPO3 v6.0. Resolves: #95314 Releases: master, 10.4 Change-Id: Idd8f85bbc9351959b0be35e353f8237cf33b54e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71183 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benjamin Franzke authored
This change allows module URLs to be automatically framed by the TYPO3 main controller whenever they are directly opened in the browser address bar in a secure environment (e.g. https:// or .localhost TLD) (In this case the Sec-Fetch-Dest=document is sent by browsers). See: https://w3c.github.io/webappsec-fetch-metadata/#sec-fetch-dest-header Note: This header is already supported by Chrome, Edge and Firefox nightly, only Safari does not deliver this header yet. Non supporting browsers or unsafe http connections will gracefully fallback to showing the module contents without the TYPO3 main frame being added. This fallback behaviour is only triggered when a link is opened in a new tab. Regular clicks are intercepted and directly dispatched via module-router/iframe, as before. This change allows to render the module menu with anchor tags instead of buttons which lets users decide how and where a module should be opened. Long term goal is to improve accessibility by using real links not only in module menu (as we had in TYPO3 v7), but actually everywhere (for example in the database record list), in order for the user to decide whether to open a link in the current or a new tab. This will require enhancing FormEngine routes with module information and is therefore out of scope for this change. Resolves: #94084 Releases: master Change-Id: Iaad8fe62644ec6c9cb1aaa4c92ce2e8e3eeab7bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69058 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Benni Mack authored
Resolves: #95299 Releases: master Change-Id: I4882a9ca07948718afdeb1a5fb5b3a518eb86c38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71163 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
Commands executed: cd Build/ yarn upgrade lit@^2.0.0 lit-html@^2.0.0 lit-element@^3.0.0 @lit/reactive-element@^1.0.0 grunt rollup Releases: master Resolves: #95303 Change-Id: I7e67815cdc0d7e055c6974af4889d51cea76a45d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71168 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Susanne Moog authored
Fixes both admin panel and time tracker array access warnings with PHP8. Resolves: #95309 Releases: master Change-Id: I528c7dcb0f0daa1bd898dc342b5047120e27932d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71174 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Wouter Wolters authored
Resolves: #95234 Releases: master Change-Id: Ic6e8326d0e9f97429a727ac1ceae6aab2ff976d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71078 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 21, 2021
-
-
Wouter Wolters authored
The variable $this->arguments['selected'] is not always set. Resolves: #95283 Releases: master Change-Id: I24ac026300c04bd9bf2e5f2bab580cdf847df5ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71169 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
Resolves: #95306 Releases: master Change-Id: I9dfeef91bc22eb4abf67759f1eb9286061c9b42c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71172 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Wouter Wolters authored
Update the following packages from TYPO3 itself to their latest version: typo3/cms-cli typo3/cms-composer-installers typo3/symfony-psr-event-dispatcher-adapter Composer commands used: composer req typo3/cms-cli:^3.1 composer req typo3/cms-cli:^3.1 -d typo3/sysext/core --no-update composer u typo3/cms-composer-installers composer u typo3/symfony-psr-event-dispatcher-adapter Resolves: #95304 Releases: master Change-Id: Icf3d4f3d8a577e01fbdbe1402170349282149aed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71170 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The clipboard component still suffers a lot of problems, due to its static integration in the list modules. For example, when clearing the clipboard, it's no longer possible to copy / cut a record via context menu, since the the previous GET parameters are included in the return URL, directly reverting the operation. The list modules should therefore not longer handle any clipboard logic directly, especially not via GET. This patch does the first step towards this goal and introduces a dedicated endpoint, only available via POST. The clipboard panel, used in recordlist and filelist is furthermore now integrated as a web component, making any form submit in the main module superfluous. Additionally some related bugs are fixed: * Elements moved to clipboard via context menu can now be remvoed from clipboard again * Non related elements are now always properly styled * File elements now correctly link to their parent folder in filelist * Buttons are only shown for the clipboard they influence Resolves: #95268 Resolves: #95267 Releases: master Change-Id: I7b1050c9b0f11a1e495ef09df4d0560dd84df882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70978 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Helmut Hummel authored
Environment::getFrameworkBasePath() API was created under the assumption that TYPO3 core extensions are always installed in a dedicated but fixed folder (typo3/sysext). Additionally this folder is assumed to be publicly accessible through a web server. Therefore this API is used in two contexts. 1. To resolve and check file system paths 2. To create URLs to public resources To at some point achieve the goal to allow all TYPO3 extensions to be installed in arbitrary locations (a configurable vendor folder), usage of such API must be removed. As a first step all usages are removed, that reference files within the boundaries of one extensions. Relative paths (relative to the file that references) are used instead, or, where possible EXT: syntax Releases: master Resolves: #95250 Change-Id: Ie7291b71d5d85d75add9bc5b352a4bd1cf065499 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71102 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
Benni Mack authored
With PHP 8.0 and symfony/polyfill-php80 it is possible to use native str_starts_with() and str_ends_with() methods. This way, the methods * StringUtility::beginsWith() * StringUtility::endsWith() are marked as deprecated. Resolves: #95293 Releases: master Change-Id: I46d15c2f8b93c5f8b487966b2015ebefb1711348 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71135 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
Communication patch for an upcoming v12 change. We've had the situation a couple of times that core changed Fluid Viewhelpers to adapt them to current needs, keeping the template arguments, but changing internal handling and method signatures. It happened that developers then stepped up with "This broke my own Viewhelper!" and we had to act upon. The ImageViewHelper for instance has been a victim of this. From a framework point of view, Viewhelpers are specific implementations tailored for specific use. In most cases, they're small codewise. Extending these classes and changing their scope should not be supported. Developers should extend a matching abstract instead of extending specific VH's. The patch brings an Important.rst to pitch an upcoming v12 change that will declare all Viewhelpers final. The core currently of course also extends a couple of VH's itself, but this is too late for v11 now to change and adapt. Instead, we'll take the time in v12 to resolve these cases and will have a look at the abstract classes as well to see which VH functionality should be included in abstracts to simplify re-use and transition for extension authors and to sharpen core API. Resolves: #95298 Releases: master Change-Id: Ia3312829fad94e7429c0989f3aa3554c3cf944ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71164 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
This change removes the language title and flag from each CE, and instead adds only the flag if the content element is set to "All Languages" (-1). In addition, the header is now based on flex-box instead of floats. Resolves: #95302 Releases: master Change-Id: I6d1a180915fba9f2ccf8df3979a2256134d18379 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71116 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Rachel Foucard <rfoucard@w-seils.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Francois Suter authored
In the workspaces module, hide the mass action selector when no actions are available. In particular, this is the case when options.workspaces.enableMassActions = 0 has been set in User TSconfig. Releases: master Resolves: #95295 Change-Id: I81b5aa62ec5496b37dc70f042e4e3d779d84f874 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71165 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Jochen Roth authored
Links without a target are actually buttons. Previously, the "Update extension" link in the reports module was furthermore removed while parsing, due to the missing target. Therefore this patch transforms the "link", which is using the ActionDispatcher, to be a button. Resolves: #95169 Releases: master Change-Id: I89847e1e1ec45fb7f5c797b2c25646f113905508 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70985 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Francois Suter authored
The setting options.workspaces.enableMassActions is described in the extension manual as being a Page TSconfig option, whereas it is a User TSconfig option. Releases: master Resolves: #95296 Change-Id: Id0fc6a1c47323fddff018676bc52934f01cf2f13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71162 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Robert Kärner authored
Fix PHP8 related "undefined array key" warnings which occur in the backend by adding the required fallbacks. Resolves: #95239 Releases: master Change-Id: Id1477c95ac00e90b9d449271fb461f2b4dc34235 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71100 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
When publishing workspace records with connected "true" MM relations (uid_local / uid_foreign columns and no TCA for that table), DataHandler triggers bugs: * It updates uid_local or uid_foreign rows to negative uids during the process as intermediate DB state. * It leaves "dangling" MM rows of the workspace record that has been pushed live. The involved code is relatively well encapsulated, it only kicks in for this "publish MM relations" scenario, the impact of this patch is limited to this area. The patch rewrites MM workspace publish handling: * Avoid parking state in a DataHandler class property only used in this scenario. * Avoid moving a list of stateful RelationHandler instances around and dynamically calling methods on those instances. * Avoid recursive flex form MM publish handling with indirect callback methods that change class state. * Obsolete a RelationHandler method used only in this scenario. * Reduce number of queries. The result is a simplified, better encapsulated and well commented solution. On a testing side, the patch brings a scenario to verify flex form MM relation handling. An according styleguide example is pending, too. This patch allows us to change auto created MM table definitions to unsigned uid_local and uid_foreign columns, which is of course the right way to go. Change-Id: I0d24f31cbd356f19937c2f8c18d432424e127b97 Resolves: #95275 Resolves: #81718 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71097 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
A functional test has been disabled for postgres execution due duplicate key issues using `setupFrontendRootPage` in functional testcases. As setUpFrontendRootPage has been fixed in the testing framework, this test is enabled again. Commands to test: $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 9.6 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 10 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 11 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 12 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 13 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 9.6 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 10 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 11 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 12 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 13 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php Resolves: #95114 Releases: master Change-Id: I85d74f05e7ef347cd217843c0384d460194fac24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70897 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
https://github.com/TYPO3/html-sanitizer/releases/tag/v2.0.11 composer req typo3/html-sanitizer:^2.0.11; \ composer req typo3/html-sanitizer:^2.0.11 \ -d typo3/sysext/core --no-update Resolves: #95289 Releases: master, 10.4, 9.5 Change-Id: I3a294c788f25ca5a1068f9eb79c924f65e21244d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71152 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-