- Mar 21, 2020
-
-
Alexander Schnitzler authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/59514/ all possibilities have been taken to define which view class to use based on the format query param. As those format query params are still api and in use, the core must reintegrate the former behaviour: Instantiating a JsonView object for requests with a format query param set to 'json'. The implementation is marked as internal as the overall idea is to remove the format param in the long run. Releases: master Resolves: #90788 Change-Id: I62aaa8f44126edbe1238a5a972044f239f3362eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63438 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Eglseder authored
useDefaultLanguageRecord is documented to use the default record uid by default. The actual behaviour is the opposite. This change introduces a test and the change, that fixes the evaluation of useDefaultLanguageRecord in the code. Resolves: #87948 Releases: master, 9.5 Change-Id: I9633092089cc74e8a837bf0bfe27e6b3b8d0d229 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60297 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Mar 20, 2020
-
-
Alexander Schnitzler authored
The extbase container provides a method isSingleton that checks if a class implements the SingletonInterface interface. It did so by creating a ClassSchema instance for the given class name which is not needed as there are more efficient ways to check for implemented interfaces that don't require the creation of a ClassSchema instance. Releases: master Resolves: #90798 Change-Id: I62a3290c2d3c100a967f5a98b3d901cd61ca0db6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63820 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Alexander Schnitzler authored
As there are a lot of rules that do not raise any errors with our code base, those rules up to level 8 are enabled with this patch resulting in more pre merge tests being executed as of now. Releases: master Resolves: #90795 Change-Id: I3628569c90e1e7bbf2ffde81abbef37065bd45e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63812 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Susanne Moog authored
The title property of IRRE file relations (sys_file_reference) were doubly escaped - once is enough. Resolves: #88514 Releases: master, 9.5 Change-Id: I50f5f9db70cdd1af8fb6f7e9e2de1d3eb3f3cc0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63814 Tested-by:
-
Benni Mack authored
If somebody calls www.example.com?AMDCMD_prev=abcbenni the output should never throw an exception (also if the preview entry or the cookie has expired). The cookie itself is a session-based cookie nowadays, so the expiration of the cookie is not relevant. The change lets outsiders just fall back silently to the Live version. Resolves: #18761 Releases: master, 9.5 Change-Id: I1ca1dce2a01ce01daddc6945a45960b3e9e1f4ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63818 Tested-by:
-
Andreas Fernandez authored
With `DragDrop.ajaxAction()` returning a promise now, the flag icon can get updated after dropping a content element into another language. Resolves: #90693 Releases: master Change-Id: Iff0a819e69194f0302ea97ce096500e0144704c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63799 Tested-by:
-
Andreas Fernandez authored
If PageRenderer->addRequireJsConfiguration() is consecutively called, the configuration is now properly merged by using array_merge_recursive(). The previously used ArrayUtility::mergeRecursiveWithOverrule() overrode any previously set keys of the numeric array which broke the configuration. Resolves: #89431 Releases: master, 9.5 Change-Id: I1e654c27a095db5ec88182aed1b8fe1011b37134 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63816 Tested-by:
-
Andreas Fernandez authored
The event listener for collapsing and expanding IRRE nodes is now less greedy and ignores the div containing all control buttons which makes the buttons without click event (e.g. "Edit metadata") functional again. Resolves: #90796 Releases: master Change-Id: Ie19547bc5fbf21124f4a658ffc3a28b157242d51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63817 Tested-by:
-
Alexander Schnitzler authored
This patch simply pulls out the level 2 rules into a separate configuration file which is a copy of the original level 2 configuration file of phpstan with some rules, services and parameters disabled. Also, additional configuration files are put into the Build folder and phpstan.neon has been added to the .gitattributes file. Releases: master Resolves: #90789 Change-Id: Ia3b3c30cfa57227c0607904df38add31f36be0e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63802 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Christian Bülter authored
Releases: master Resolves: #90793 Change-Id: I087f38e04d8e96c66610c1bc293d6bceb7fc1e51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63809 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Susanne Moog authored
Files that are not readable by the web server should not be returned by FAL LocalDriver as we cannot do anything with them and even the basic subsequent steps (fileinfo, indexing) will fail. Resolves: #57457 Releases: master, 9.5 Change-Id: I5314cc9ba9e49bf142b4c388feea4495b8f8e5a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63807 Reviewed-by:
-
Jacob Dreesen authored
Releases: master, 9.5 Resolves: #90779 Change-Id: If6931385b288456dc6e1d5d0e289b1132886bc77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63766 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Andreas Fernandez authored
Define the `hideDropzone` event listener via assignment to keep the binding of `this` to the DragUploader class. Resolves: #90792 Releases: master, 9.5 Change-Id: I21c52da477349e77a52f2c6701fd75abc3b5b074 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63805 Tested-by:
-
Guido Schmechel authored
Deferred files should not be concatenated. They are now output as a single script. Resolves: #90208 Releases: master, 9.5 Change-Id: I17c84b41acd445db6ee261bade69fddd32ca7380 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63040 Tested-by:
Ghanshyam Bhava <ghanshyambhava@yahoo.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Georg Ringer authored
Partly revert #89956 to reallow category titles in extension settings which contain a space. Resolves: #90776 Releases: master Change-Id: I93358e1c10e502ba9c48402a78927e34c240215a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63764 Tested-by:
-
Andreas Fernandez authored
The "Check TCA in ext_tables.php" module in the Install Tool now loads the ext_localconf.php per checked extension as well. Resolves: #89713 Releases: master, 9.5 Change-Id: I55bc23611554cfb0270e1f10a7787dae058609ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63801 Tested-by:
-
Benni Mack authored
The fields * be_groups.workspace_perms * be_users.workspace_perms * be_users.disableIPlock Are now only shown if the requirements are met (e.g. EXT:workspaces is installed, or the IPlock options are enabled Resolves: #40867 Releases: master Change-Id: Id6310bdbfbd187c2d0190118476a1b3fe729aa77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63761 Tested-by:
-
Frank Naegler authored
Since Firefox 72 a user interaction is required to prompt the user for native browser notification permissions. This should prevent the user for notification SPAM. This patch introduces a modal confirmation, to get this user interaction. The user is asked only once (as before), this is possible because the modal is triggered only if a UC setting is not present. Resolves: #90666 Releases: master, 9.5 Change-Id: I031a2addee9894db7e345f46d1e5e5d0d62316d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63567 Tested-by:
-
- Mar 19, 2020
-
-
Susanne Moog authored
If TYPO3 is configured to use multiple database connections, the system information toolbar should display information about each. However, errors occuring when connecting to the non-essential databases should not directly result in an exception. Instead, these exceptions are now caught and the database status displayed as offline. Resolves: #89831 Releases: master Change-Id: I52fa2df01b23ac005b63b21bc8d7b11a294ec46f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63796 Tested-by:
-
Benni Mack authored
Resolves: #76218 Releases: master, 9.5 Change-Id: I1597d4482c2536266b6fc2fed31dd9ca67ebb60a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63800 Tested-by:
-
Susanne Moog authored
While number_format does an internal cast to float, it does not cast things like empty strings to 0 - instead a PHP warning is emitted. To catch that edge case, we are now casting to float before calling number_format. Resolves: #90786 Releases: master, 9.5 Change-Id: Ibfbacd2606dabd926adc140960e1116076bbdb5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63798 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Georg Ringer authored
If a field is used in `foreign_table_where` configuration which points to a field using `group` as type, the uid needs to be fetched differently from the processed row. Resolves: #17073 Releases: master, 9.5 Change-Id: I8ec9c7cd0dd166a0c4e87a61adb2f87b7c1c8cf5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63595 Tested-by:
-
Benni Mack authored
* TSFE->contentStrReplace only calls a hook, which is now moved to the callers code (which only contains another hook as well) * TSFE->clearPageCacheContent_pidList() is not used anymore (protected) * cObj->decryptEmail() is not used anymore (protected). * BE_USER->getRealUserId() is not used anymore (protected) * DataHandler->recUpdateAccessCache is not used anymore (protected) * LiveSearch (internal) -> getRecordTitlePrep() is not used anymore Resolves: #90785 Releases: master Change-Id: Idf14c9185a9356091ec0400faecfc8bbe5861c3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63795 Tested-by:
-
Benni Mack authored
This change modifies "->expectExceptionMessageRegExp" which is not available anymore in PHPunit v9. In addition, expectException(Warning::class) is deprecated in PHPUnit v9, which is modified as well, to make Core a small step towards PHPUnit v10 compat. Resolves: #90787 Releases: master, 9.5 Change-Id: Ie8aedc3cf95b5fac84791cb2d7cedba642d481c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63797 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90766 Change-Id: I59823ed9b573344a96823d3308b253edcc765a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63682 Tested-by:
-
Benni Mack authored
Resolves: #42111 Releases: master Change-Id: Ie9b35fb8a32f18f3be6ccd62b87e93e71d6cdea9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63770 Tested-by:
-
Benni Mack authored
* t3o has fileadmin/l10n since 2 years (currently it's a redirect). * new translation server just took the path as previously on t3o This is now consolidated: * t3o is replacing fileadmin/ter with fileadmin/l10n (saving t3o some redirects) * localize is using xliff/ Both changes are in place already on the remote servers so this change can be used directly. Resolves: #84025 Releases: master, 9.5 Change-Id: I6362f6f0f8dbc6739f007deb82edb54de608d21c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63533 Tested-by:
-
Markus Klein authored
Resolves: #89124 Resolves: #90689 Resolves: #88184 Releases: master, 9.5 Change-Id: I41b6c9d73346974cffb029551be5f987f9a09a79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63714 Tested-by:
-
Oliver Hader authored
Avoid calling GeneralUtility::makeInstance() in UriBuilder multiple time, but add class member instead. Resolves: #90781 Releases: master, 9.5 Change-Id: I0d1341e9fcbd54ca30d3be791f927219b030f841 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63767 Tested-by:
-
Benni Mack authored
When fetching a page from cache, the information which cache tags were used are not available anymore for any hooks in extensions (e.g. static_filecache). Resolves: #90775 Releases: master, 9.5 Change-Id: Ib1ca0f256411a2d979113ddbb0ef128bc79a0197 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63768 Tested-by:
-
Christian Eßl authored
Hide the module menu, if it doesn't contain any modules (If the editor has no access to any module, that is placed in the module container). Also disable the toggle icons for module menu / list module in this case. Resolves: #67725 Releases: master Change-Id: I680ef0bd1d4de8c7b71d393ea14429d55f740de8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63697 Reviewed-by:
-
Benni Mack authored
When adding a new main module, the "position" is now taken into account, allowing TYPO3 Core also to use the addModule API everywhere. Resolves: #47663 Releases: master Change-Id: I733ee92eada88f09fd247fa818c018dc6bee62d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63724 Tested-by:
-
- Mar 18, 2020
-
-
Christian Eßl authored
If an editor has "view" permissions set for a table, but no "modify" permissions, the record list would still show many buttons related to modifying records, to the user: "Add", "Edit", "Copy", "Cut" actions. Trying to click one of these buttons would lead the editor to a broken page that just shows an infinite loading spinner. This patch now adds "tables_modify" permission checks to many places in the code. The following adjustments were made: - Check modify permissions on "copy" in RecordProvider (context menu) - Check table modify permissions in DatabaseRecordList Resolves: #83008 Resolves: #89307 Resolves: #23598 Releases: master, 9.5 Change-Id: Ia3140ba887573a314191ebba5672c85d93fe885c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63696 Tested-by:
-
Georg Ringer authored
Use the FluidEmail service for sending the test task of EXT:scheduler. Resolves: #90725 Releases: master Change-Id: I7edb46c1e449acdb6979982c016658de95043807 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63678 Tested-by:
-
Georg Ringer authored
With #86629 the link type "telephone" has been added but it was forgotten to add support for it in the InputLinkElement. Add the support and show a nice icon next to the number. Resolves: #90771 Releases: master Change-Id: Ib2ea37ab07b0ae2fa9a429dc683c6021a8691aae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63760 Reviewed-by:
-
Susanne Moog authored
As system news are sorted by crdate, the user had no way to influence the order in which news appeared. While it makes sense to sort by creation, users should have an option to influence that. Changing to tstamp would not be a solution, as tstamp changes on every edit (for example correcting a spelling mistake should not change the order). Adding an explicit sorting field seems like overkill (and would need upgrade wizards and DB changes). Therefor TCA has been changed to allow editing of the creation date for these kinds of records. Resolves: #90774 Releases: master, 9.5 Change-Id: I1268cbe7be6ed6a241e608b4a8800e19eeb58515 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63762 Tested-by:
Stefan P <spo@snk.de> Tested-by:
-
Susanne Moog authored
Resolves: #86943 Releases: master, 9.5 Change-Id: I1092442a963d7ba6e2282ed8d4c4bce360be8afc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63614 Tested-by:
-
- Mar 17, 2020
-
-
Christian Eßl authored
In some cases, the "dirty" field checks were still not working for both ckeditor and flexform fields. The following changes were made: - Flexform elements can use dots for html id attributes, which are not officially supported by the W3C CSS specification. So escape the corresponding element selectors to work with the validation. - When maximizing an RTE, ckeditor4 automatically removes all the classes from the connected html elements (and reapplies them once leaving the fullscreen mode), so the markFieldAsChanged() validation won't work here. In this case, apply an event for remembering the changes, once the user leaves fullscreen again. Resolves: #88978 Resolves: #88776 Releases: master, 9.5 Change-Id: Ib21d415766b67be8d6c6e9aae8b8e937d03850bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63730 Tested-by:
-
Guido Schmechel authored
Improve the privacy of users by using the no-cookie setting by default and set the do not track parameter to 1. Resolves: #89381 Releases: master, 9.5 Change-Id: I81d1a6aae802126f66765702417b7ffd350d8fb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61948 Reviewed-by:
-
